lex-apollo 0.4.25 → 0.4.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 96a0b3d72ad8895d264315b2da3710c323d31280cf08fe615f8db74c9c762e82
-  data.tar.gz: a6d938a7409cfd0f1b5f3a0dc6c7f1f3c0399dc93a8b7ba8ffcfff0c82536bc3
+  metadata.gz: fe40d4ba4efef56b2bd1cec166f525ca3c165989453e455bdacc14a2a5377d16
+  data.tar.gz: e4f7f0daabec002d031c00a6936308df68d75dd2200b1f49f7264de6f2833153
 SHA512:
-  metadata.gz: efd4519deb1935da01026f3149460fafd110be233f7cdaf522c1980c4cab70a2debcb4ca4ba8a7e3b5b8be0b409d94fdf566fdba6cc8bcdcc1a3ebef879ef6fe
-  data.tar.gz: b0b446a0af1010dde65247cff125c17d086ebba9cf9bd0269575fc7d94fed6eab06a2d836ee6419d742b4fe150aa7b055deefb11e6160b30bde83f79b5c63d71
+  metadata.gz: 7d0995197fb2c7191a81a91bba476792570baaf5e750df8b0464de096beabc82a4fbec8fabb8b09fda967d5c834c7bf682041d8775ce24c602d1790e332692c7
+  data.tar.gz: 6c0277a64242c3c37795dde7229db4d2f0c27d191a7ad5d252266db1c4b433538ec5741f57624a3e262d1ad1b38ca9abf9c0ec1b2463a7bd69b9fac2126cb190

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [0.4.26] - 2026-05-11
+
+### Fixed
+- Handle `Sequel::UniqueConstraintViolation` in `create_candidate_entry` gracefully — a race condition during concurrent knowledge ingestion can cause two threads to pass the content_hash dedup check simultaneously and both attempt to insert the same row. On collision, the rescue block now looks up the existing winner row by content_hash (excluding archived) and returns its ID so the caller continues normally (access log, contradiction detection, etc.) instead of propagating a database error.
+- Added `Sequel::UniqueConstraintViolation` stub to the test-only Sequel shim so the race-condition rescue path is exercisable in unit tests without a live database.
+
 ## [0.4.25] - 2026-05-08
 
 ### Fixed

data/lib/legion/extensions/apollo/runners/knowledge.rb

@@ -469,6 +469,22 @@ module Legion
             )
             log.info("Apollo Knowledge.handle_ingest created entry_id=#{new_entry.id} status=candidate domain=#{metadata[:domain]} source_agent=#{metadata[:source_agent]}") # rubocop:disable Layout/LineLength
             new_entry.id
+          rescue Sequel::UniqueConstraintViolation => e
+            # Race condition: another thread/process inserted the same content_hash between our
+            # dedup check and this insert. Fetch and return the winner's id so the caller can
+            # continue normally (access log, contradiction detection, etc.).
+            winner = Helpers::DataModels.apollo_entry
+                                        .where(content_hash: content_hash)
+                                        .exclude(status: 'archived')
+                                        .first
+            if winner
+              log.warn("Apollo Knowledge.create_candidate_entry race_dedup entry_id=#{winner.id} content_hash=#{content_hash} source_agent=#{metadata[:source_agent]}") # rubocop:disable Layout/LineLength
+              winner.id
+            else
+              handle_exception(e, level: :warn, handled: true, operation: 'apollo.knowledge.create_candidate_entry',
+                                  content_hash: content_hash)
+              nil
+            end
           end
 
           def browse_query?(query)

data/lib/legion/extensions/apollo/version.rb

@@ -3,7 +3,7 @@
 module Legion
   module Extensions
     module Apollo
-      VERSION = '0.4.25'
+      VERSION = '0.4.26'
     end
   end
 end

data/spec/legion/extensions/apollo/runners/knowledge_spec.rb

@@ -321,6 +321,30 @@ RSpec.describe Legion::Extensions::Apollo::Runners::Knowledge do
           expect(result[:deduped]).to be true
           expect(result[:entry_id]).to eq('uuid-existing')
         end
+
+        it 'recovers gracefully when a concurrent ingest wins the content_hash unique constraint race' do
+          # Simulate: dedup check passes (nil — no existing entry yet), then .create
+          # raises UniqueConstraintViolation (another thread inserted between check and insert).
+          # create_candidate_entry must rescue and return the existing entry's id so the
+          # caller succeeds rather than propagating a database error.
+          race_entry = double('race_entry', id: 'uuid-race-winner')
+
+          allow(mock_entry_class).to receive(:create)
+            .and_raise(Sequel::UniqueConstraintViolation, 'duplicate key value violates unique constraint "idx_apollo_content_hash"')
+
+          collision_dataset = double('collision_dataset')
+          allow(mock_entry_class).to receive(:where).with(content_hash: anything).and_return(collision_dataset)
+          allow(collision_dataset).to receive(:exclude).with(status: 'archived').and_return(collision_dataset)
+          # First call: dedup pre-check returns nil (not yet in DB).
+          # Second call: post-collision lookup returns the winner inserted by the other thread.
+          allow(collision_dataset).to receive(:first).and_return(nil, race_entry)
+
+          result = host.handle_ingest(content: 'concurrent content', content_type: 'fact',
+                                      source_agent: 'agent-1',
+                                      content_hash: 'd3861b2862454c5a6a9e480829333841')
+          expect(result[:success]).to be true
+          expect(result[:entry_id]).to eq('uuid-race-winner')
+        end
       end
     end
 

data/spec/spec_helper.rb

@@ -13,6 +13,7 @@ require 'legion/transport'
 unless defined?(Sequel)
   module Sequel
     class Error < StandardError; end
+    class UniqueConstraintViolation < Error; end
 
     def self.pg_array(arr) = arr
     def self.lit(str, *) = str

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-apollo
 version: !ruby/object:Gem::Version
-  version: 0.4.25
+  version: 0.4.26
 platform: ruby
 authors:
 - Esity