lex-apollo 0.4.9 → 0.4.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 59e9aac7402ce0e7ecf6c11f6fd65ca9fbe0f23c89583b724db0a8502c290201
-  data.tar.gz: 210cc5d0b6ef7e466f0783e354dc24181be86c01c473399c18602c2729b14796
+  metadata.gz: 5a299ad72e6776724cf5ee9c94d394618adcc130a4af35e205d4966d6f4079f0
+  data.tar.gz: 6cf9bee4d6a7a38dcc223442871c5760c4c62076bde2a7d1d5f4af674aa33f33
 SHA512:
-  metadata.gz: 330d8e9902f715f934c343b83ecf44da34e01d5e93176d846fa155cad954bb8b7d8d7f2b0f817a9fc2a83fe476b18b9601114c16932b2351d8bd89a9a0b1ce10
-  data.tar.gz: 6178bfd570b0ac4e5bcf5b3e1e9dc45db26f80423487fe55ce01e96cbbfa89f857611c264a80d429cb6475c24b8649b40015c96f989531cf2404e836da0dcd75
+  metadata.gz: 708fed8ac6cae84b333ddf1f4c0fe3a8889be2271f678e49017d590ffb6bb61593c9e286e6999ef521257a9a0e7aa0d7e54ed70b6bcb8b8064ddfddb85ffd1fb
+  data.tar.gz: 3c4cd4423c4a58f213b30e3709bbe6bf078a709faeb526f829f1b1b0e960d12c1d215b3be04309b714978e72b011a93f76f3ceee3fd7279c03397612dc13726e

data/CHANGELOG.md

@@ -1,5 +1,32 @@
 # Changelog
 
+## [0.4.14] - 2026-03-27
+
+### Fixed
+- Replace `Legion::JSON.load` calls in `Runners::Gas` with `json_load` helper to satisfy CI Helper Migration lint
+
+## [0.4.13] - 2026-03-27
+
+### Changed
+- Replace all `Legion::Logging.xxx(...)` calls in `lib/` with `log.xxx(...)` to satisfy CI Helper Migration lint check
+- Add `log` module-function/class-method to `Runners::Gas`, `Helpers::Similarity`, `Helpers::Capability`, `Helpers::Confidence`, `Helpers::Writeback`, and `Helpers::EntityWatchdog`
+- Instance methods in `Runners::Knowledge` use `log` via existing `Helpers::Lex` include
+
+## [0.4.12] - 2026-03-27
+
+### Fixed
+- All bare `rescue` blocks in `lib/` now capture the exception as `=> e` and log `e.message` to satisfy the Rescue Logging lint rule
+
+## [0.4.11] - 2026-03-27
+
+### Fixed
+- `handle_ingest`: made `content:` and `content_type:` optional with nil defaults, added `skip:` parameter for GAIA dream cycle phase wiring compatibility
+
+## [0.4.10] - 2026-03-26
+
+### Changed
+- set remote_invocable? false for local dispatch
+
 ## [0.4.9] - 2026-03-25
 
 ### Changed

data/lib/legion/extensions/apollo/actors/entity_watchdog.rb

@@ -27,7 +27,8 @@ module Legion
           def enabled?
             defined?(Legion::Extensions::Apollo::Runners::EntityExtractor) &&
               defined?(Legion::Transport)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("EntityWatchdog enabled? check failed: #{e.message}")
             false
           end
 
@@ -71,7 +72,8 @@ module Legion
                    .limit(log_limit)
                    .select_map(:message)
             logs.map(&:to_s).reject(&:empty?).uniq
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("EntityWatchdog recent_task_log_texts failed: #{e.message}")
             []
           end
 
@@ -87,7 +89,8 @@ module Legion
             closest = result[:entries].first
             distance = closest[:distance].to_f
             distance <= (1.0 - dedup_similarity_threshold)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("EntityWatchdog entity_exists_in_apollo? failed: #{e.message}")
             false
           end
 

data/lib/legion/extensions/apollo/actors/gas_subscriber.rb

@@ -16,7 +16,8 @@ module Legion
           def enabled?
             defined?(Legion::Extensions::Apollo::Runners::Gas) &&
               defined?(Legion::Transport)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GasSubscriber enabled? check failed: #{e.message}")
             false
           end
 

data/lib/legion/extensions/apollo/actors/ingest.rb

@@ -15,7 +15,8 @@ module Legion
           def enabled?
             defined?(Legion::Extensions::Apollo::Runners::Knowledge) &&
               defined?(Legion::Transport)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Ingest enabled? check failed: #{e.message}")
             false
           end
         end

data/lib/legion/extensions/apollo/actors/query_responder.rb

@@ -15,7 +15,8 @@ module Legion
           def enabled?
             defined?(Legion::Extensions::Apollo::Runners::Knowledge) &&
               defined?(Legion::Transport)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("QueryResponder enabled? check failed: #{e.message}")
             false
           end
         end

data/lib/legion/extensions/apollo/actors/writeback_store.rb

@@ -16,7 +16,8 @@ module Legion
             defined?(Legion::Extensions::Apollo::Runners::Knowledge) &&
               defined?(Legion::Transport) &&
               Helpers::Capability.apollo_write_enabled?
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("WritebackStore enabled? check failed: #{e.message}")
             false
           end
         end

data/lib/legion/extensions/apollo/actors/writeback_vectorize.rb

@@ -34,7 +34,8 @@ module Legion
 
           def enabled?
             defined?(Legion::Transport) && Helpers::Capability.can_embed?
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("WritebackVectorize enabled? check failed: #{e.message}")
             false
           end
 

data/lib/legion/extensions/apollo/api.rb

@@ -19,8 +19,8 @@ module Legion
             return {} if body.empty?
 
             ::JSON.parse(body, symbolize_names: true)
-          rescue ::JSON::ParserError
-            halt 400, { error: 'invalid JSON' }.to_json
+          rescue ::JSON::ParserError => e
+            halt 400, { error: "invalid JSON: #{e.message}" }.to_json
           end
 
           def runner

data/lib/legion/extensions/apollo/helpers/capability.rb

@@ -9,11 +9,20 @@ module Legion
 
           module_function
 
+          def log
+            return Legion::Logging if defined?(Legion::Logging)
+
+            @log ||= Object.new.tap do |nl|
+              %i[debug info warn error fatal].each { |m| nl.define_singleton_method(m) { |*| nil } }
+            end
+          end
+
           def can_embed?
             return false unless defined?(Legion::LLM) && Legion::LLM.started?
 
             ollama_embedding_available? || cloud_embedding_configured?
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Capability.can_embed? failed: #{e.message}")
             false
           end
 
@@ -22,13 +31,15 @@ module Legion
             return false unless defined?(Legion::Data) && Legion::Data.connected?
 
             check_db_write_privilege
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Capability.can_write? failed: #{e.message}")
             false
           end
 
           def apollo_write_enabled?
             Legion::Settings.dig(:data, :apollo_write) == true
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Capability.apollo_write_enabled? failed: #{e.message}")
             false
           end
 
@@ -36,7 +47,8 @@ module Legion
             return false unless defined?(Legion::LLM::Discovery::Ollama)
 
             EMBEDDING_MODELS.any? { |m| Legion::LLM::Discovery::Ollama.model_available?(m) }
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Capability.ollama_embedding_available? failed: #{e.message}")
             false
           end
 
@@ -44,7 +56,8 @@ module Legion
             provider = Legion::Settings.dig(:apollo, :embedding, :provider)
             model = Legion::Settings.dig(:apollo, :embedding, :model)
             !provider.nil? && !model.nil?
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Capability.cloud_embedding_configured? failed: #{e.message}")
             false
           end
 
@@ -54,7 +67,8 @@ module Legion
             @apollo_write_privilege = Legion::Data.connection
                                                   .fetch("SELECT has_table_privilege(current_user, 'apollo_entries', 'INSERT') AS can_insert")
                                                   .first[:can_insert] == true
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Capability.check_db_write_privilege failed: #{e.message}")
             @apollo_write_privilege = false
           end
 

data/lib/legion/extensions/apollo/helpers/confidence.rb

@@ -20,11 +20,20 @@ module Legion
 
           module_function
 
+          def log
+            return Legion::Logging if defined?(Legion::Logging)
+
+            @log ||= Object.new.tap do |nl|
+              %i[debug info warn error fatal].each { |m| nl.define_singleton_method(m) { |*| nil } }
+            end
+          end
+
           def apollo_setting(*keys, default:)
             return default unless defined?(Legion::Settings) && !Legion::Settings[:apollo].nil?
 
             Legion::Settings[:apollo].dig(*keys) || default
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Confidence.apollo_setting failed: #{e.message}")
             default
           end
 

data/lib/legion/extensions/apollo/helpers/entity_watchdog.rb

@@ -12,6 +12,14 @@ module Legion
           }.freeze
 
           class << self
+            def log
+              return Legion::Logging if defined?(Legion::Logging)
+
+              @log ||= Object.new.tap do |nl|
+                %i[debug info warn error fatal].each { |m| nl.define_singleton_method(m) { |*| nil } }
+              end
+            end
+
             def detect_entities(text:, types: nil)
               return [] if text.nil? || text.empty?
 
@@ -84,7 +92,7 @@ module Legion
             def create_candidate(entity, _source_context)
               return unless defined?(Runners::Knowledge)
 
-              Legion::Logging.debug "[entity_watchdog] candidate: #{entity[:type]}=#{entity[:value]}" if defined?(Legion::Logging)
+              log.debug "[entity_watchdog] candidate: #{entity[:type]}=#{entity[:value]}"
             end
           end
         end

data/lib/legion/extensions/apollo/helpers/similarity.rb

@@ -9,6 +9,14 @@ module Legion
         module Similarity
           module_function
 
+          def log
+            return Legion::Logging if defined?(Legion::Logging)
+
+            @log ||= Object.new.tap do |nl|
+              %i[debug info warn error fatal].each { |m| nl.define_singleton_method(m) { |*| nil } }
+            end
+          end
+
           def cosine_similarity(vec_a:, vec_b:, **)
             vec_a = parse_vector(vec_a)
             vec_b = parse_vector(vec_b)
@@ -27,7 +35,8 @@ module Legion
             return nil unless vec.is_a?(String)
 
             ::JSON.parse(vec)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Similarity.parse_vector failed: #{e.message}")
             nil
           end
 

data/lib/legion/extensions/apollo/helpers/writeback.rb

@@ -14,6 +14,14 @@ module Legion
 
           module_function
 
+          def log
+            return Legion::Logging if defined?(Legion::Logging)
+
+            @log ||= Object.new.tap do |nl|
+              %i[debug info warn error fatal].each { |m| nl.define_singleton_method(m) { |*| nil } }
+            end
+          end
+
           def evaluate_and_route(request:, response:, enrichments: {})
             return unless writeback_enabled?
             return unless should_capture?(request, response, enrichments)
@@ -21,7 +29,7 @@ module Legion
             payload = build_payload(request: request, response: response)
             route_payload(payload)
           rescue StandardError => e
-            Legion::Logging.warn("apollo writeback failed: #{e.message}") if defined?(Legion::Logging)
+            log.warn("apollo writeback failed: #{e.message}")
           end
 
           def should_capture?(_request, response, enrichments)
@@ -83,7 +91,7 @@ module Legion
               Runners::Knowledge.handle_ingest(**payload)
             end
           rescue StandardError => e
-            Legion::Logging.warn("apollo direct write failed, falling back to transport: #{e.message}") if defined?(Legion::Logging)
+            log.warn("apollo direct write failed, falling back to transport: #{e.message}")
             publish_to_transport(payload, has_embedding: !payload[:embedding].nil?)
           end
 
@@ -94,18 +102,20 @@ module Legion
               **payload, has_embedding: has_embedding
             ).publish
           rescue StandardError => e
-            Legion::Logging.warn("apollo writeback publish failed: #{e.message}") if defined?(Legion::Logging)
+            log.warn("apollo writeback publish failed: #{e.message}")
           end
 
           def writeback_enabled?
             Legion::Settings.dig(:apollo, :writeback, :enabled) != false
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Writeback.writeback_enabled? failed: #{e.message}")
             true
           end
 
           def min_content_length
             Legion::Settings.dig(:apollo, :writeback, :min_content_length) || MIN_CONTENT_LENGTH
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Writeback.min_content_length failed: #{e.message}")
             MIN_CONTENT_LENGTH
           end
 
@@ -125,7 +135,8 @@ module Legion
             return 'unknown' unless request.respond_to?(:caller) && request.caller.is_a?(Hash)
 
             request.caller.dig(:requested_by, :identity) || 'unknown'
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Writeback.extract_identity failed: #{e.message}")
             'unknown'
           end
 
@@ -134,7 +145,8 @@ module Legion
 
             user_msgs = Array(request.messages).select { |m| m[:role] == 'user' || m['role'] == 'user' }
             (user_msgs.last || {})[:content] || ''
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Writeback.extract_user_query failed: #{e.message}")
             ''
           end
 

data/lib/legion/extensions/apollo/runners/gas.rb

@@ -16,6 +16,18 @@ module Legion
 
           module_function
 
+          def log
+            return Legion::Logging if defined?(Legion::Logging)
+
+            @log ||= Object.new.tap do |nl|
+              %i[debug info warn error fatal].each { |m| nl.define_singleton_method(m) { |*| nil } }
+            end
+          end
+
+          def json_load(str)
+            ::JSON.parse(str, symbolize_names: true)
+          end
+
           def relate_confidence_gate = Helpers::Confidence.apollo_setting(:gas, :relate_confidence_gate, default: RELATE_CONFIDENCE_GATE)
           def synthesis_confidence_cap = Helpers::Confidence.apollo_setting(:gas, :synthesis_confidence_cap, default: SYNTHESIS_CONFIDENCE_CAP)
           def max_anticipations       = Helpers::Confidence.apollo_setting(:gas, :max_anticipations, default: MAX_ANTICIPATIONS)
@@ -42,7 +54,7 @@ module Legion
               anticipations:    anticipations.length
             }
           rescue StandardError => e
-            Legion::Logging.warn("GAS pipeline error: #{e.message}") if defined?(Legion::Logging)
+            log.warn("GAS pipeline error: #{e.message}")
             { phases_completed: 0, error: e.message }
           end
 
@@ -68,7 +80,8 @@ module Legion
 
             result = Runners::EntityExtractor.extract_entities(text: audit_event[:response_content])
             result[:success] ? (result[:entities] || []) : []
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS phase_extract failed: #{e.message}")
             []
           end
 
@@ -95,7 +108,8 @@ module Legion
             return [] unless llm_available?
 
             llm_synthesize(facts)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS phase_synthesize failed: #{e.message}")
             []
           end
 
@@ -116,7 +130,7 @@ module Legion
               )
               deposited += 1
             rescue StandardError => e
-              Legion::Logging.warn("GAS deposit error: #{e.message}") if defined?(Legion::Logging)
+              log.warn("GAS deposit error: #{e.message}")
             end
             { deposited: deposited }
           end
@@ -127,7 +141,8 @@ module Legion
             return [] unless llm_available?
 
             llm_anticipate(facts)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS phase_anticipate failed: #{e.message}")
             []
           end
 
@@ -138,7 +153,8 @@ module Legion
             facts.each do |fact|
               result = Runners::Knowledge.retrieve_relevant(query: fact[:content], limit: lim, min_confidence: min_conf)
               entries.concat(result[:entries]) if result[:success] && result[:entries]&.any?
-            rescue StandardError
+            rescue StandardError => e
+              log.warn("GAS fetch_similar_entries failed for fact: #{e.message}")
               next
             end
             entries.uniq { |e| e[:id] }
@@ -151,8 +167,9 @@ module Legion
             else
               { from_content: fact[:content], to_id: entry[:id], relation_type: 'similar_to', confidence: fb_conf }
             end
-          rescue StandardError
-            { from_content: fact[:content], to_id: entry[:id], relation_type: 'similar_to', confidence: fb_conf }
+          rescue StandardError => e
+            log.warn("GAS classify_relation failed: #{e.message}")
+            { from_content: fact[:content], to_id: entry[:id], relation_type: 'similar_to', confidence: fallback_confidence }
           end
 
           def llm_classify_relation(fact, entry)
@@ -189,7 +206,7 @@ module Legion
             )
 
             content = result.respond_to?(:message) ? result.message[:content] : result.to_s
-            parsed = Legion::JSON.load(content)
+            parsed = json_load(content)
             rels = parsed.is_a?(Hash) ? (parsed[:relations] || parsed['relations'] || []) : []
             best = rels.max_by { |r| r[:confidence] || r['confidence'] || 0 }
 
@@ -200,7 +217,8 @@ module Legion
             return fallback_relation(fact, entry) if conf < relate_confidence_gate || !RELATION_TYPES.include?(rtype)
 
             { from_content: fact[:content], to_id: entry[:id], relation_type: rtype, confidence: conf }
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS llm_classify_relation failed: #{e.message}")
             fallback_relation(fact, entry)
           end
 
@@ -245,11 +263,12 @@ module Legion
             )
 
             content = result.respond_to?(:message) ? result.message[:content] : result.to_s
-            parsed = Legion::JSON.load(content)
+            parsed = json_load(content)
             items = parsed.is_a?(Hash) ? (parsed[:synthesis] || parsed['synthesis'] || []) : []
 
             items.map { |item| build_synthesis_entry(item, facts) }
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS llm_synthesize failed: #{e.message}")
             []
           end
 
@@ -300,7 +319,7 @@ module Legion
             )
 
             content = result.respond_to?(:message) ? result.message[:content] : result.to_s
-            parsed = Legion::JSON.load(content)
+            parsed = json_load(content)
             questions = parsed.is_a?(Hash) ? (parsed[:questions] || parsed['questions'] || []) : []
             questions = questions.first(max_anticipations)
 
@@ -308,7 +327,8 @@ module Legion
               promote_to_pattern_store(question: q, facts: facts)
               { question: q }
             end
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS llm_anticipate failed: #{e.message}")
             []
           end
 
@@ -320,13 +340,15 @@ module Legion
               resolution: { source: 'gas_anticipate', facts: facts.map { |f| f[:content] } },
               confidence: fallback_confidence
             )
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS promote_to_pattern_store failed: #{e.message}")
             nil
           end
 
           def llm_available?
             defined?(Legion::LLM::Pipeline::GaiaCaller)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS llm_available? check failed: #{e.message}")
             false
           end
 
@@ -365,7 +387,7 @@ module Legion
             )
 
             content = result.respond_to?(:message) ? result.message[:content] : result.to_s
-            parsed = Legion::JSON.load(content)
+            parsed = json_load(content)
             facts_array = parsed.is_a?(Hash) ? (parsed[:facts] || parsed['facts'] || []) : Array(parsed)
             facts_array.map do |f|
               {
@@ -373,7 +395,8 @@ module Legion
                 content_type: (f[:content_type] || f['content_type'] || 'fact').to_sym
               }
             end
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("GAS llm_comprehend failed: #{e.message}")
             mechanical_comprehend(messages, response)
           end
         end

data/lib/legion/extensions/apollo/runners/knowledge.rb

@@ -58,7 +58,10 @@ module Legion
             }
           end
 
-          def handle_ingest(content:, content_type:, tags: [], source_agent: 'unknown', source_provider: nil, source_channel: nil, knowledge_domain: nil, submitted_by: nil, submitted_from: nil, content_hash: nil, context: {}, **) # rubocop:disable Metrics/ParameterLists, Layout/LineLength
+          def handle_ingest(content: nil, content_type: nil, tags: [], source_agent: 'unknown', source_provider: nil, source_channel: nil, knowledge_domain: nil, submitted_by: nil, submitted_from: nil, content_hash: nil, context: {}, skip: false, **) # rubocop:disable Metrics/ParameterLists, Layout/LineLength, Metrics/PerceivedComplexity, Metrics/CyclomaticComplexity
+            return { status: :skipped } if skip
+            return { success: false, error: 'content is required' } if content.nil? || content.to_s.strip.empty?
+            return { success: false, error: 'content_type is required' } if content_type.nil?
             return { success: false, error: 'apollo_data_not_available' } unless defined?(Legion::Data::Model::ApolloEntry)
 
             # Content hash dedup
@@ -214,7 +217,7 @@ module Legion
               redistributed += 1
             end
 
-            Legion::Logging.info("[apollo] redistributed #{redistributed} entries from departing agent=#{agent_id}") if defined?(Legion::Logging)
+            log.info("[apollo] redistributed #{redistributed} entries from departing agent=#{agent_id}")
             { success: true, redistributed: redistributed, agent_id: agent_id }
           rescue Sequel::Error => e
             { success: false, error: e.message }
@@ -313,7 +316,8 @@ module Legion
             result = Legion::LLM::Embeddings.generate(text: text)
             vector = result.is_a?(Hash) ? result[:vector] : result
             vector.is_a?(Array) && vector.any? ? vector : Array.new(1024, 0.0)
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Knowledge.embed_text failed: #{e.message}")
             Array.new(1024, 0.0)
           end
 
@@ -363,7 +367,8 @@ module Legion
               contradictions << existing[:id]
             end
             contradictions
-          rescue Sequel::Error
+          rescue Sequel::Error => e
+            log.warn("Apollo Knowledge.detect_contradictions failed: #{e.message}")
             []
           end
 
@@ -379,7 +384,8 @@ module Legion
               caller:   { extension: 'lex-apollo', runner: 'knowledge' }
             )
             result[:data]&.dig(:contradicts) == true
-          rescue StandardError
+          rescue StandardError => e
+            log.warn("Apollo Knowledge.llm_detects_conflict? failed: #{e.message}")
             false
           end
 

data/lib/legion/extensions/apollo/version.rb

@@ -3,7 +3,7 @@
 module Legion
   module Extensions
     module Apollo
-      VERSION = '0.4.9'
+      VERSION = '0.4.14'
     end
   end
 end

data/lib/legion/extensions/apollo.rb

@@ -33,6 +33,10 @@ module Legion
   module Extensions
     module Apollo
       extend Legion::Extensions::Core if Legion::Extensions.const_defined? :Core
+
+      def self.remote_invocable?
+        false
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-apollo
 version: !ruby/object:Gem::Version
-  version: 0.4.9
+  version: 0.4.14
 platform: ruby
 authors:
 - Esity