lex-agentic-self 0.1.10 → 0.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '081b534c7eaf4efbc0265eada2d3b8f11b37b93a3fb34be77068d0ce4f0e842d'
-  data.tar.gz: ce8a3839f617dc41d904ccf54a98a208037178cd89eefb39cd031fce8a89e315
+  metadata.gz: aa196a32fb12a9051c899a77c904db1b019bcf20fa722522f4560aa06325c1c5
+  data.tar.gz: 21ea04fbbd1a0bb7ccbaf1baeb93c062c036818cecd316f907d82ba4607fc640
 SHA512:
-  metadata.gz: 49409e3e358267476770c66db88a4eff2f7968857c130e547cc3170a3c3e891b27358d7b28ac77e81e5733d480ab65480b38c10c908ef9323738b4159bab527e
-  data.tar.gz: fd913ef78cfa8b14ccb5bdadbd95e3133e5bcf67d21a40332ba360ba6393ebd1b34e7db0ccebe3a4bf177aea506d1fc666dcb0efc89820e26853e0574888998d
+  metadata.gz: 2e5f6191d0093ad34c915a5368d71b1457f9774e393fff5f9d0424784ca38c250ce3c3ae3c3be6c0fc4c9b4a43ac8b2148bd3917b3ed37e102181aa2beae1e1a
+  data.tar.gz: 2bc178f3bfc1001ccc64af277a3e9fac685fea350964107883b6d001a4fe8da31fd3287b18e3a4b6838bd293798737c1c8eeb9fac3c77d44010be734e97279d0

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [0.1.11] - 2026-03-31
+
+### Fixed
+- `ArcEngine#to_h` now returns the last computed `relationship_health` score instead of always nil; `relationship_health()` caches result in `@last_health`
+- `ArcEngine#arc_state_hash` now includes `milestones_today` key (milestones with `created_at` matching today in local time)
+- `SelfTalk::Runners::SelfTalk#stub_turn_content` replaced by `mechanical_turn_content` backed by `VOICE_BANK` — produces real, meaningful content for critic/advocate/explorer/pragmatist voices; unknown types fall back to `VOICE_BANK_GENERIC`
+- `SelfTalk::Runners::SelfTalk#generate_summary_for_dialogue` replaces static "Dialogue concluded" fallback with `mechanical_summary` — includes turn count, voices, and dominant position
+- `Identity::Runners::Entra#rotate_client_secret` now emits a `Legion::Logging.warn` when `rotation_enabled: true` but Graph API rotation is not yet implemented, and returns `action_required` with instructions instead of a silent error
+
 ## [0.1.10] - 2026-03-31
 
 ### Added

data/Gemfile

@@ -3,3 +3,5 @@
 source 'https://rubygems.org'
 
 gemspec
+
+gem 'rubocop-legion'

data/lex-agentic-self.gemspec

@@ -34,7 +34,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'faraday', '~> 2.0'
   spec.add_development_dependency 'rspec', '~> 3.13'
-  spec.add_development_dependency 'rubocop', '~> 1.60'
-  spec.add_development_dependency 'rubocop-legion', '~> 0.1'
-  spec.add_development_dependency 'rubocop-rspec', '~> 2.26'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-legion'
+  spec.add_development_dependency 'rubocop-rspec'
 end

data/lib/legion/extensions/agentic/self/identity/runners/entra.rb

@@ -293,8 +293,11 @@ module Legion
 
                 return { rotated: false, worker_id: worker_id, dry_run: true, would_rotate: true } if dry_run
 
-                # Graph API rotation would go here when permission is granted
-                { rotated: false, worker_id: worker_id, error: 'graph_api_rotation_not_implemented' }
+                # Graph API rotation is blocked on Azure Application.ReadWrite.All permission.
+                # Emit a loud warning so callers are never silently misled.
+                Legion::Logging.warn "[identity:entra] Client secret rotation is enabled but Graph API rotation is not yet implemented. Worker: #{worker_id}"
+                { rotated: false, worker_id: worker_id, error: 'graph_api_rotation_not_implemented',
+                  action_required: 'Manual rotation needed — Graph API write permission not yet granted' }
               end
 
               def credential_refresh_cycle(**)

data/lib/legion/extensions/agentic/self/relationship_arc/helpers/arc_engine.rb

@@ -41,7 +41,7 @@ module Legion
                 score = (attachment_strength.to_f * w[:attachment_strength]) +
                         (reciprocity_balance.to_f * w[:reciprocity_balance]) +
                         (communication_consistency.to_f * w[:communication_consistency])
-                score.clamp(0.0, 1.0)
+                @last_health = score.clamp(0.0, 1.0)
               end
 
               def dirty?
@@ -77,14 +77,27 @@ module Legion
               def to_h
                 { agent_id: @agent_id, current_chapter: @current_chapter,
                   milestones: @milestones.map(&:to_h),
-                  relationship_health: nil, milestone_count: @milestones.size }
+                  relationship_health: @last_health, milestone_count: @milestones.size }
               end
 
               private
 
               def arc_state_hash
                 { agent_id: @agent_id, current_chapter: @current_chapter,
-                  milestones: @milestones.map(&:to_h) }
+                  milestones: @milestones.map(&:to_h),
+                  milestones_today: @milestones.select { |m| milestone_today?(m) }.map(&:to_h) }
+              end
+
+              def milestone_today?(milestone)
+                ts = milestone.respond_to?(:created_at) ? milestone.created_at : milestone[:created_at]
+                return false unless ts
+
+                today = ::Time.now
+                t = ts.is_a?(::Time) ? ts.localtime : ::Time.parse(ts.to_s)
+                t.year == today.year && t.mon == today.mon && t.mday == today.mday
+              rescue StandardError => e
+                warn "[arc_engine] milestone_today? error: #{e.message}"
+                false
               end
 
               def derive_chapter(bond_stage)

data/lib/legion/extensions/agentic/self/self_talk/runners/self_talk.rb

@@ -104,6 +104,35 @@ module Legion
                 { decayed: decayed, voices: voice_list }
               end
 
+              VOICE_BANK = {
+                critic:     [
+                  { content: 'What could go wrong with this approach?', position: :challenge },
+                  { content: 'Are we overlooking any risks here?', position: :challenge },
+                  { content: 'This needs more careful consideration.', position: :caution }
+                ],
+                advocate:   [
+                  { content: 'This aligns with our core values.', position: :support },
+                  { content: 'The potential benefits outweigh the risks.', position: :support },
+                  { content: 'We should move forward with this.', position: :affirm }
+                ],
+                explorer:   [
+                  { content: 'What alternatives have we not considered?', position: :explore },
+                  { content: 'There may be an unconventional approach here.', position: :explore },
+                  { content: 'Let us examine this from another angle.', position: :clarify }
+                ],
+                pragmatist: [
+                  { content: 'What is the simplest path forward?', position: :simplify },
+                  { content: 'Focus on what is actionable now.', position: :prioritize },
+                  { content: 'We need concrete next steps.', position: :clarify }
+                ]
+              }.freeze
+
+              VOICE_BANK_GENERIC = [
+                { content: 'Let us think this through carefully.', position: :clarify },
+                { content: 'More reflection is needed on this topic.', position: :clarify },
+                { content: 'What do we know for certain here?', position: :clarify }
+              ].freeze
+
               private
 
               def engine
@@ -124,7 +153,7 @@ module Legion
                   )
                   return [llm_result, :llm] if llm_result
                 end
-                [stub_turn_content(voice_data.voice_type, dialogue_data.topic), :mechanical]
+                [mechanical_turn_content(voice_data.voice_type, dialogue_data.topic), :mechanical]
               end
 
               def build_prior_turns(dialogue_data)
@@ -135,13 +164,14 @@ module Legion
                 end
               end
 
-              def stub_turn_content(voice_type, topic)
-                { content: "[#{voice_type} perspective on #{topic}]", position: :clarify }
+              def mechanical_turn_content(voice_type, _topic)
+                bank = VOICE_BANK.fetch(voice_type.to_sym, VOICE_BANK_GENERIC)
+                bank.sample
               end
 
               def generate_summary_for_dialogue(dialogue_id)
                 dialogue_data = engine.dialogues[dialogue_id]
-                return 'Dialogue concluded' unless dialogue_data
+                return mechanical_summary(nil) unless dialogue_data
 
                 if Helpers::LlmEnhancer.available?
                   turns = dialogue_data.turns.map do |t|
@@ -161,7 +191,15 @@ module Legion
                   return llm_result[:summary] if llm_result
                 end
 
-                'Dialogue concluded'
+                mechanical_summary(dialogue_data)
+              end
+
+              def mechanical_summary(dialogue_data)
+                turns = dialogue_data&.turns || []
+                voices = turns.filter_map { |t| t.respond_to?(:voice_id) ? engine.voices[t.voice_id]&.name || t.voice_id : t[:voice_id] }.uniq
+                positions = turns.filter_map { |t| t.respond_to?(:position) ? t.position : t[:position] }.tally
+                dominant = positions.max_by { |_, count| count }&.first
+                "#{turns.size} turns across #{voices.join(', ')} voices. Dominant position: #{dominant || 'none'}."
               end
             end
           end

data/lib/legion/extensions/agentic/self/version.rb

@@ -4,7 +4,7 @@ module Legion
   module Extensions
     module Agentic
       module Self
-        VERSION = '0.1.10'
+        VERSION = '0.1.11'
       end
     end
   end

data/spec/legion/extensions/agentic/self/identity/runners/entra_spec.rb

@@ -338,6 +338,59 @@ RSpec.describe Legion::Extensions::Agentic::Self::Identity::Runners::Entra do
       expect(result[:action_required]).to be false
       expect(result[:days_remaining]).to be > 30
     end
+
+    context 'when rotation_enabled is true and secret is expiring (fix 5)' do
+      before do
+        stub_const('Legion::Settings', Class.new do
+          def self.dig(*keys)
+            map = {
+              %i[identity entra rotation_enabled]     => true,
+              %i[identity entra rotation_buffer_days] => 30
+            }
+            map[keys]
+          end
+
+          def self.[](_key) = {}
+        end)
+      end
+
+      it 'emits a warning log when graph api rotation is not implemented' do
+        vault_mod = Module.new do
+          def self.read_client_secret(**)
+            { client_secret: 'val', client_secret_expires_at: (Time.now + (86_400 * 10)).iso8601 }
+          end
+        end
+        stub_const('Legion::Extensions::Agentic::Self::Identity::Helpers::VaultSecrets', vault_mod)
+
+        warned = false
+        allow(Legion::Logging).to receive(:warn) do |msg|
+          warned = true if msg.include?('graph_api_rotation_not_implemented') ||
+                           msg.include?('Graph API rotation is not yet implemented')
+        end
+
+        result = client.rotate_client_secret(worker_id: 'w1')
+
+        expect(warned).to be true
+        expect(result[:rotated]).to be false
+        expect(result[:error]).to eq('graph_api_rotation_not_implemented')
+        expect(result[:action_required]).to include('Manual rotation needed')
+      end
+
+      it 'returns dry_run result without warning when dry_run: true' do
+        vault_mod = Module.new do
+          def self.read_client_secret(**)
+            { client_secret: 'val', client_secret_expires_at: (Time.now + (86_400 * 10)).iso8601 }
+          end
+        end
+        stub_const('Legion::Extensions::Agentic::Self::Identity::Helpers::VaultSecrets', vault_mod)
+
+        expect(Legion::Logging).not_to receive(:warn).with(a_string_including('not yet implemented'))
+
+        result = client.rotate_client_secret(worker_id: 'w1', dry_run: true)
+        expect(result[:dry_run]).to be true
+        expect(result[:would_rotate]).to be true
+      end
+    end
   end
 
   # ---------------------------------------------------------------------------

data/spec/legion/extensions/agentic/self/relationship_arc/helpers/arc_engine_spec.rb

@@ -120,5 +120,46 @@ RSpec.describe Legion::Extensions::Agentic::Self::RelationshipArc::Helpers::ArcE
       h = engine.to_h
       expect(h).to include(:agent_id, :current_chapter, :milestones, :relationship_health)
     end
+
+    it 'relationship_health is nil before relationship_health() is called' do
+      expect(engine.to_h[:relationship_health]).to be_nil
+    end
+
+    it 'relationship_health reflects the last computed value' do
+      engine.relationship_health(
+        attachment_strength:       0.8,
+        reciprocity_balance:       0.6,
+        communication_consistency: 0.7
+      )
+      h = engine.to_h
+      expected = (0.8 * 0.4) + (0.6 * 0.3) + (0.7 * 0.3)
+      expect(h[:relationship_health]).to be_within(0.01).of(expected)
+    end
+
+    it 'includes milestone_count' do
+      engine.add_milestone(type: :first_interaction, description: 'x', significance: 0.5)
+      expect(engine.to_h[:milestone_count]).to eq(1)
+    end
+  end
+
+  describe '#arc_state_hash (via to_apollo_entries)' do
+    it 'includes milestones_today for milestones added today' do
+      engine.add_milestone(type: :first_interaction, description: 'today', significance: 0.9)
+      entries = engine.to_apollo_entries
+      parsed = JSON.parse(entries.first[:content], symbolize_names: true)
+      expect(parsed).to have_key(:milestones_today)
+      expect(parsed[:milestones_today].size).to eq(1)
+    end
+
+    it 'milestones_today is empty when milestones have old timestamps' do
+      ms = Legion::Extensions::Agentic::Self::RelationshipArc::Helpers::Milestone.new(
+        type: :first_interaction, description: 'old', significance: 0.5,
+        created_at: Time.now.utc - (2 * 86_400)
+      )
+      engine.instance_variable_get(:@milestones) << ms
+      entries = engine.to_apollo_entries
+      parsed = JSON.parse(entries.first[:content], symbolize_names: true)
+      expect(parsed[:milestones_today]).to eq([])
+    end
   end
 end

data/spec/legion/extensions/agentic/self/self_talk/runners/self_talk_llm_spec.rb

@@ -137,7 +137,7 @@ RSpec.describe Legion::Extensions::Agentic::Self::SelfTalk::Runners::SelfTalk, '
         result = client.conclude_dialogue(dialogue_id: did)
         expect(result[:concluded]).to be true
         report = client.dialogue_report(dialogue_id: did)
-        expect(report[:dialogue][:conclusion]).to eq('Dialogue concluded')
+        expect(report[:dialogue][:conclusion]).to match(/turns across .* voices\. Dominant position:/)
       end
     end
 
@@ -151,7 +151,7 @@ RSpec.describe Legion::Extensions::Agentic::Self::SelfTalk::Runners::SelfTalk, '
         result = client.conclude_dialogue(dialogue_id: did)
         expect(result[:concluded]).to be true
         report = client.dialogue_report(dialogue_id: did)
-        expect(report[:dialogue][:conclusion]).to eq('Dialogue concluded')
+        expect(report[:dialogue][:conclusion]).to match(/turns across .* voices\. Dominant position:/)
       end
     end
 

data/spec/legion/extensions/agentic/self/self_talk/runners/self_talk_spec.rb

@@ -193,4 +193,64 @@ RSpec.describe Legion::Extensions::Agentic::Self::SelfTalk::Runners::SelfTalk do
       expect(voice[:name]).to eq('Critic')
     end
   end
+
+  describe 'mechanical voice bank (fix 3)' do
+    let(:runner_class) do
+      Class.new do
+        include Legion::Extensions::Agentic::Self::SelfTalk::Runners::SelfTalk
+      end
+    end
+    let(:runner) { runner_class.new }
+
+    it 'produces real content for known voice types' do
+      %i[critic advocate explorer pragmatist].each do |type|
+        result = runner.send(:mechanical_turn_content, type, 'test topic')
+        expect(result[:content]).not_to be_empty
+        expect(result[:content]).not_to match(/\A\[/)
+        expect(result[:position]).not_to be_nil
+      end
+    end
+
+    it 'falls back to generic bank for unknown voice types' do
+      result = runner.send(:mechanical_turn_content, :unknown_voice, 'some topic')
+      expect(result[:content]).not_to be_empty
+      expect(result[:position]).not_to be_nil
+    end
+
+    it 'VOICE_BANK covers critic, advocate, explorer, pragmatist' do
+      bank = Legion::Extensions::Agentic::Self::SelfTalk::Runners::SelfTalk::VOICE_BANK
+      expect(bank.keys).to include(:critic, :advocate, :explorer, :pragmatist)
+    end
+  end
+
+  describe 'mechanical summary (fix 4)' do
+    let(:runner_class) do
+      Class.new do
+        include Legion::Extensions::Agentic::Self::SelfTalk::Runners::SelfTalk
+      end
+    end
+    let(:runner) { runner_class.new }
+
+    it 'produces a non-empty summary when dialogue_data is nil' do
+      summary = runner.send(:mechanical_summary, nil)
+      expect(summary).to be_a(String)
+      expect(summary).not_to be_empty
+    end
+
+    it 'includes turn count in summary' do
+      did = start_dialogue(topic: 'summary test')
+      vid = register_voice(name: 'Critic', type: :critic)
+      client.add_turn(dialogue_id: did, voice_id: vid, content: 'Point one', position: :challenge)
+      client.add_turn(dialogue_id: did, voice_id: vid, content: 'Point two', position: :challenge)
+
+      result = client.conclude_dialogue(dialogue_id: did)
+      expect(result[:concluded]).to be true
+    end
+
+    it 'conclude_dialogue without summary uses mechanical_summary' do
+      did = start_dialogue(topic: 'no summary')
+      result = client.conclude_dialogue(dialogue_id: did)
+      expect(result[:concluded]).to be true
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-agentic-self
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.11
 platform: ruby
 authors:
 - Esity
@@ -139,44 +139,44 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.60'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.60'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-legion
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.26'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.26'
+        version: '0'
 description: 'LEX agentic self domain: identity, metacognition, self-model'
 email:
 - matthewdiverson@gmail.com