lex-agentic-affect 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 304db292215662c9a10acb7c604d279ff263a747ffa410d4306020a03f2d1d69
-  data.tar.gz: dc50e3bcecccdd41ce18855d375576cbd52747634a8d93bd161e00ffb9c3622e
+  metadata.gz: a5768d527e95204ef16c40ce69b64e6fea209640636223b405804e4dfccc6cf3
+  data.tar.gz: 13e3b630d0c1434e716d85cf149949ac2a9848005bb97bba80733ffa61ab74f0
 SHA512:
-  metadata.gz: f4f56f2da0be9254ca01595c8d891e8b1f8a846ccc16fa8df485c818fd2ba37fb5e888e5391085c5539fdf10f342c601963ff6a5d37e22749d986e2f16a89401
-  data.tar.gz: f8d3e0b229ba3b01749c1a5e5773ffe64ef3f5ac3cb67bdfea1046a2fd7ce984554d4d1af6c4dee729d25b67c14b00e5912678e7245b03c00d6b5212371a255b
+  metadata.gz: 0e967fd97104da2eea612ac0373635c249925263855cf1966fbb7c4d93291dc9f8896f7305554bda4700c888296fb96f48c2c41015356df9f0f489746faf0d3a
+  data.tar.gz: 749e3642b5b7418f519fe660be924ba97db8ccc213bdf185373bf6ee90408f1aebec2832accc6c38a7b5fb9a1d651f8cc8ceb322448b5d8ac80a41bcae7f93b0

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.1.9] - 2026-03-31
+
+### Fixed
+- Reappraisal: `ReappraisalEngine.mechanical_appraisal` replaces the meaningless `"auto-reappraised via #{strategy}"` placeholder with strategy- and valence-bracket-specific text drawn from `MECHANICAL_REAPPRAISALS` (7 strategies × 3 valence brackets: `highly_negative`, `negative`, `neutral`)
+- Reappraisal: `auto_reappraise` (engine) and `auto_reappraise_event` (runner) now use `mechanical_appraisal` as the LLM-unavailable fallback
+- Flow spec: replaced non-asserting `consecutive_flow_ticks >= 0` assertion with meaningful checks — after 50 balanced ticks the state must be `:flow`, `deep_flow` must be `true`, and `consecutive_flow_ticks` must exceed `DEEP_FLOW_THRESHOLD` (20)
+
 ## [0.1.8] - 2026-03-31
 
 ### Added

data/lex-agentic-affect.gemspec

@@ -33,6 +33,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'legion-transport', '>= 1.3.9'
 
   spec.add_development_dependency 'rspec', '~> 3.13'
-  spec.add_development_dependency 'rubocop', '~> 1.60'
-  spec.add_development_dependency 'rubocop-rspec', '~> 2.26'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-rspec'
 end

data/lib/legion/extensions/agentic/affect/reappraisal/helpers/reappraisal_engine.rb

@@ -9,6 +9,44 @@ module Legion
             class ReappraisalEngine
               include Constants
 
+              MECHANICAL_REAPPRAISALS = {
+                reinterpretation:    {
+                  negative:        'This situation may have aspects that are not immediately apparent. Consider alternative explanations.',
+                  highly_negative: 'Strong negative reactions often signal something important. Examine what underlying need is unmet.',
+                  neutral:         'A balanced perspective reveals both challenges and opportunities in this situation.'
+                },
+                distancing:          {
+                  negative:        'Viewed from a broader timeline, this event occupies a small portion of overall experience.',
+                  highly_negative: 'In the larger context of ongoing goals and relationships, this moment will pass.',
+                  neutral:         'Stepping back reveals this is one event among many.'
+                },
+                benefit_finding:     {
+                  negative:        'Difficult experiences often contain lessons that become apparent with reflection.',
+                  highly_negative: 'Even significant setbacks can reveal strengths and areas for growth.',
+                  neutral:         'There may be unexpected value in examining this experience closely.'
+                },
+                acceptance:          {
+                  negative:        'Acknowledging this experience as it is, without resistance, creates space for response.',
+                  highly_negative: 'Some experiences cannot be changed, only accepted and integrated.',
+                  neutral:         'This experience is acknowledged and integrated without judgment.'
+                },
+                normalizing:         {
+                  negative:        'Many others have faced similar situations. This reaction is a common and understandable response.',
+                  highly_negative: 'Intense responses to difficult events are a natural part of experience, not a sign of weakness.',
+                  neutral:         'This situation falls within the normal range of experience.'
+                },
+                perspective_taking:  {
+                  negative:        'Considering this from another vantage point reveals aspects that were not initially visible.',
+                  highly_negative: 'Seeing through a different lens can transform how a significant event is understood.',
+                  neutral:         'Multiple perspectives offer a fuller picture of what is happening.'
+                },
+                temporal_distancing: {
+                  negative:        'Looking back from the future, this moment is likely to appear smaller and more manageable.',
+                  highly_negative: 'Even the most difficult moments recede with time. This too will become part of a larger story.',
+                  neutral:         'In the fullness of time, the significance of this event will become clearer.'
+                }
+              }.freeze
+
               attr_reader :events, :reappraisal_log
 
               def initialize
@@ -65,7 +103,7 @@ module Legion
                 return { success: false, reason: :event_not_found } unless event
 
                 strategy = select_strategy(event)
-                new_appraisal = "auto-reappraised via #{strategy}"
+                new_appraisal = self.class.mechanical_appraisal(strategy, event.current_valence)
                 reappraise(event_id: event_id, strategy: strategy, new_appraisal: new_appraisal)
               end
 
@@ -131,6 +169,25 @@ module Legion
                 }
               end
 
+              def self.valence_bracket(valence)
+                if valence < -0.6
+                  :highly_negative
+                elsif valence < 0.0
+                  :negative
+                else
+                  :neutral
+                end
+              end
+
+              def self.mechanical_appraisal(strategy, valence)
+                bracket  = valence_bracket(valence)
+                strategy = strategy.to_sym
+                brackets = MECHANICAL_REAPPRAISALS[strategy]
+                return "Reappraised via #{strategy}" unless brackets
+
+                brackets[bracket] || brackets.values.first || "Reappraised via #{strategy}"
+              end
+
               private
 
               def select_strategy(event)

data/lib/legion/extensions/agentic/affect/reappraisal/runners/cognitive_reappraisal.rb

@@ -52,7 +52,8 @@ module Legion
                 return { success: false, reason: :event_not_found } unless event
 
                 strategy  = select_strategy_for(event)
-                appraisal = llm_appraisal_for(event, strategy) || "auto-reappraised via #{strategy}"
+                appraisal = llm_appraisal_for(event, strategy) ||
+                            Helpers::ReappraisalEngine.mechanical_appraisal(strategy, event.current_valence)
                 result    = eng.reappraise(event_id: event_id, strategy: strategy, new_appraisal: appraisal)
 
                 if result[:success]

data/lib/legion/extensions/agentic/affect/version.rb

@@ -4,7 +4,7 @@ module Legion
   module Extensions
     module Agentic
       module Affect
-        VERSION = '0.1.8'
+        VERSION = '0.1.9'
       end
     end
   end

data/spec/legion/extensions/agentic/affect/flow/runners/flow_spec.rb

@@ -215,8 +215,12 @@ RSpec.describe Legion::Extensions::Agentic::Affect::Flow::Runners::Flow do
     it 'reaches deep flow after threshold' do
       50.times { client.update_flow(tick_results: balanced_tick) }
       status = client.flow_status
-      # May or may not reach deep flow depending on exact EMA convergence
-      expect(status[:consecutive_flow_ticks]).to be >= 0
+      # After 50 balanced ticks the agent is in :flow (confirmed by the prior example).
+      # DEEP_FLOW_THRESHOLD is 20 consecutive flow ticks, so consecutive_flow_ticks must
+      # exceed that threshold, and deep_flow? must be true.
+      expect(status[:in_flow]).to be true
+      expect(status[:consecutive_flow_ticks]).to be > Legion::Extensions::Agentic::Affect::Flow::Helpers::Constants::DEEP_FLOW_THRESHOLD
+      expect(status[:deep_flow]).to be true
     end
   end
 end

data/spec/legion/extensions/agentic/affect/reappraisal/helpers/reappraisal_engine_spec.rb

@@ -208,4 +208,107 @@ RSpec.describe Legion::Extensions::Agentic::Affect::Reappraisal::Helpers::Reappr
                            :overall_regulation_ability, :strategy_effectiveness)
     end
   end
+
+  describe '.mechanical_appraisal' do
+    subject(:appraisal) { described_class.mechanical_appraisal(strategy, valence) }
+
+    context 'with a known strategy and highly negative valence' do
+      let(:strategy) { :reinterpretation }
+      let(:valence)  { -0.8 }
+
+      it 'returns meaningful text (not a template stub)' do
+        expect(appraisal).not_to match(/auto-reappraised via/)
+        expect(appraisal).not_to match(/Reappraised via/)
+        expect(appraisal.length).to be > 20
+      end
+
+      it 'returns the highly_negative bracket text' do
+        expect(appraisal).to eq(
+          described_class::MECHANICAL_REAPPRAISALS[:reinterpretation][:highly_negative]
+        )
+      end
+    end
+
+    context 'with a known strategy and mildly negative valence' do
+      let(:strategy) { :distancing }
+      let(:valence)  { -0.3 }
+
+      it 'returns the negative bracket text' do
+        expect(appraisal).to eq(
+          described_class::MECHANICAL_REAPPRAISALS[:distancing][:negative]
+        )
+      end
+
+      it 'does not return a template stub' do
+        expect(appraisal).not_to match(/auto-reappraised via/)
+      end
+    end
+
+    context 'with a known strategy and neutral/positive valence' do
+      let(:strategy) { :benefit_finding }
+      let(:valence)  { 0.1 }
+
+      it 'returns the neutral bracket text' do
+        expect(appraisal).to eq(
+          described_class::MECHANICAL_REAPPRAISALS[:benefit_finding][:neutral]
+        )
+      end
+    end
+
+    context 'with normalizing strategy' do
+      let(:strategy) { :normalizing }
+      let(:valence)  { -0.4 }
+
+      it 'returns meaningful normalizing text' do
+        expect(appraisal).to include('common')
+      end
+    end
+
+    context 'with perspective_taking strategy' do
+      let(:strategy) { :perspective_taking }
+      let(:valence)  { -0.7 }
+
+      it 'returns meaningful perspective text' do
+        expect(appraisal).not_to match(/auto-reappraised via/)
+        expect(appraisal.length).to be > 20
+      end
+    end
+
+    context 'with temporal_distancing strategy' do
+      let(:strategy) { :temporal_distancing }
+      let(:valence)  { -0.7 }
+
+      it 'returns meaningful temporal text' do
+        expect(appraisal).not_to match(/auto-reappraised via/)
+        expect(appraisal).to include('time')
+      end
+    end
+
+    context 'with an unknown strategy' do
+      let(:strategy) { :unknown_strategy }
+      let(:valence)  { -0.5 }
+
+      it 'falls back to "Reappraised via <strategy>"' do
+        expect(appraisal).to eq('Reappraised via unknown_strategy')
+      end
+    end
+  end
+
+  describe '#auto_reappraise mechanical path' do
+    it 'produces meaningful appraisal text when called' do
+      event_id = engine.register_event(content: 'failure', valence: -0.7, intensity: 0.4, appraisal: 'terrible').id
+      engine.auto_reappraise(event_id: event_id)
+      appraisal = engine.events[event_id].appraisal
+      expect(appraisal).not_to match(/auto-reappraised via/)
+      expect(appraisal.length).to be > 20
+    end
+
+    it 'produces highly_negative bracket text for very negative events' do
+      event_id = engine.register_event(content: 'crisis', valence: -0.9, intensity: 0.9, appraisal: 'worst').id
+      engine.auto_reappraise(event_id: event_id)
+      # intense + negative → :distancing, valence -0.9 → :highly_negative
+      expected = described_class.mechanical_appraisal(:distancing, -0.9)
+      expect(engine.events[event_id].appraisal).to eq(expected)
+    end
+  end
 end

data/spec/legion/extensions/agentic/affect/reappraisal/runners/cognitive_reappraisal_spec.rb

@@ -137,10 +137,16 @@ RSpec.describe Legion::Extensions::Agentic::Affect::Reappraisal::Runners::Cognit
         allow(enhancer).to receive(:available?).and_return(false)
       end
 
-      it 'falls back to mechanical appraisal stub' do
+      it 'falls back to a meaningful mechanical appraisal (not a template stub)' do
         result = client.auto_reappraise_event(event_id: registered[:event_id], engine: engine)
+        appraisal = engine.events[registered[:event_id]].appraisal
         expect(result[:success]).to be true
-        expect(engine.events[registered[:event_id]].appraisal).to match(/auto-reappraised via/)
+        # Valence -0.7 (highly_negative) with non-intense event → :reinterpretation strategy
+        expect(appraisal).to eq(
+          Legion::Extensions::Agentic::Affect::Reappraisal::Helpers::ReappraisalEngine
+            .mechanical_appraisal(:reinterpretation, -0.7)
+        )
+        expect(appraisal).not_to match(/auto-reappraised via/)
       end
     end
 
@@ -150,10 +156,15 @@ RSpec.describe Legion::Extensions::Agentic::Affect::Reappraisal::Runners::Cognit
         allow(enhancer).to receive(:generate_reappraisal).and_return(nil)
       end
 
-      it 'falls back to mechanical appraisal stub' do
+      it 'falls back to a meaningful mechanical appraisal (not a template stub)' do
         result = client.auto_reappraise_event(event_id: registered[:event_id], engine: engine)
+        appraisal = engine.events[registered[:event_id]].appraisal
         expect(result[:success]).to be true
-        expect(engine.events[registered[:event_id]].appraisal).to match(/auto-reappraised via/)
+        expect(appraisal).to eq(
+          Legion::Extensions::Agentic::Affect::Reappraisal::Helpers::ReappraisalEngine
+            .mechanical_appraisal(:reinterpretation, -0.7)
+        )
+        expect(appraisal).not_to match(/auto-reappraised via/)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-agentic-affect
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - Esity
@@ -125,30 +125,30 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.60'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.60'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.26'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.26'
+        version: '0'
 description: 'LEX agentic affect domain: emotions, valence, mood regulation'
 email:
 - matthewdiverson@gmail.com