lev 4.2.0 → 4.3.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MTgxYzgyOGI5NmQwYzE2MWM0NGI2NjZiMTIzM2U5NDk5ZGZiZjZkYw==
+    ZGMxZTI5ZTEzM2M2Yzc0OWFhMzRmMDg0MDdjZDI3ZmRlNDhmZjM0Mg==
   data.tar.gz: !binary |-
-    ZGIyNGMyNDdmZGY1NjM0NmZmY2E5NTMwODU2MDJmMTU1YTYwYjM4OQ==
+    NjkwYjg3YTJjOWEyMThlMjk1YjdiY2RmMDI1YmJhNmQ4ZjUyOGQ2Ng==
 SHA512:
   metadata.gz: !binary |-
-    N2FhODUwZmE3ZTM3NDJlMGM2N2JlM2YxNWExNDIxMDI0MzdlNmZlZGFmODFj
-    ZmM3NjY3ZWQ2M2FkMjFkMjI4NWY3MDFkNzJmYzc1MWY3YTMyN2VjZWZlYzky
-    MWIyZDlhMTA1MjY5YTQ2MDc1ZjhjMGM1OGU0ZGQyZThhZWJiMzc=
+    YmM3ZDY1MzdlMWQxMjhjMjFjNDhiYTBjOWY0ZjA1YjVjYTlhMzVjODZjNjg3
+    NGYxOWIwNGQ2OWVmNWE0MjViYTgwYTYxMTZiY2QxYzk4Njg3NWUwZDNkYTk3
+    MmZhMWY1YWEwMjM1ZWFhZGIwZjU5MTY4ZDAyMDFmNWY5MTk2ZGQ=
   data.tar.gz: !binary |-
-    MmJkMjMwZDhhNjk1ZjRiYThiMzkzYjBkMmFlZmVjZGU1NGYyYjNlOGJhYjM4
-    MDU2YzI4NTg2OTQ0ZjdhYmM3OTkzZTU2Y2FjZTc0ZWRmYWVmZmMyZjdmNWNl
-    MTI0ODYwMDE1YzI0NWIzZGQzYTkxNDMzOTkzNGU3ZWZkOTdmMWQ=
+    ZWJhZTc3NjFlNDc2MTI2MWZiNjg2YjAyNGFkYmE3ZjRhY2QzZWEyZWE1MDEw
+    NDg4ZjMwNGI3NDQ2ZGE0NGI3Mjg0YjFkZDgxZGFlNzA2ZDMxM2NiNjAxNWJk
+    NzMxM2Y2ODJiYzVlNDMxNzQ1ZDk0OWVkZWQyMzYyNTFhZmRiODc=

data/README.md

@@ -73,6 +73,31 @@ end
 
 So if you `fatal_error(name: :is_blank)` it will raise `StandardError: "name is blank"`, or `fatal_error(thing: :is_broken, and: :messed_up)` it will raise `StandardError: "thing is broken - and messed up"`
 
+You can override the global setting in your routine, which also overrides nested routine settings:
+
+```ruby
+# initializer
+Lev.configure do |config|
+  config.raise_fatal_errors = false
+end
+
+# app/routines/my_routine.rb
+class MyRoutine
+  lev_routine raise_fatal_errors: true
+
+  uses_routine Tasks::MyTaskRoutine # Still raises despite its setting
+end
+
+
+# app/subroutines/tasks/my_task_routine.rb
+module Tasks
+  class MyTaskRoutine
+    lev_routine raise_fatal_errors: false
+  end
+end
+```
+
+
 Additionally, see below for a discussion on how to transfer errors from ActiveRecord models.
 
 Any `StandardError` raised within a routine will be caught and transformed into a fatal error with `:kind` set to `:exception`.  The caller of this routine can choose to reraise this exception by calling `reraise_exception!` on the returned errors object:
@@ -408,6 +433,14 @@ class MyRoutine
 end
 ```
 
+By default also, jobs use ActiveJob::Base as the class, but you can configure this:
+
+```ruby
+Lev.configure do |config|
+  config.active_job_class = TrackableJob
+end
+```
+
 ## Handlers
 
 Handlers are specialized routines that take user input (e.g. form data) and then take an action based on that input.  Because all Handlers are Routines, everything discussed above applies to them.

data/lib/lev.rb

@@ -55,12 +55,14 @@ module Lev
       attr_accessor :security_transgression_error
       attr_accessor :illegal_argument_error
       attr_accessor :raise_fatal_errors
+      attr_accessor :active_job_class
 
       def initialize
         @form_error_class = 'error'
         @security_transgression_error = Lev::SecurityTransgression
         @illegal_argument_error = Lev::IllegalArgument
         @raise_fatal_errors = false
+        @active_job_class = defined?(ActiveJob) ? ActiveJob::Base : nil
         super
       end
     end

data/lib/lev/routine.rb

@@ -209,7 +209,7 @@ module Lev
       if defined?(ActiveJob)
         def active_job_class
           @active_job_class ||= const_set("ActiveJob",
-            Class.new(ActiveJob::Base) do
+            Class.new(Lev.configuration.active_job_class) do
               queue_as do
                 parent_routine.active_job_queue
               end

data/lib/lev/version.rb

@@ -1,3 +1,3 @@
 module Lev
-  VERSION = "4.2.0"
+  VERSION = "4.3.0"
 end

data/spec/active_job_routines_spec.rb

@@ -4,24 +4,54 @@ require 'spec_helper'
 ActiveJob::Base.queue_adapter = :test
 ActiveJob::Base.logger = ::Logger.new(nil)
 
-class LaterRoutine
-  lev_routine active_job_queue: :something_else
+RSpec.describe 'ActiveJob routines' do
+  context 'default configuration' do
+    before do
+      Lev.configure { |c| c.active_job_class = ActiveJob::Base } # default
+    end
 
-  protected
-  def exec
-  end
-end
+    class LaterRoutine
+      lev_routine active_job_queue: :something_else
 
-RSpec.describe 'ActiveJob routines' do
-  it 'can perform routines later' do
-    expect {
+      protected
+      def exec; end
+    end
+
+    it 'can perform routines later' do
+      expect {
+        LaterRoutine.perform_later
+      }.to change { ActiveJob::Base.queue_adapter.enqueued_jobs.count }.by(1)
+    end
+
+    it 'can have the default queue overridden' do
       LaterRoutine.perform_later
-    }.to change { ActiveJob::Base.queue_adapter.enqueued_jobs.count }.by(1)
+      queue_name = ActiveJob::Base.queue_adapter.enqueued_jobs.first[:queue]
+      expect(queue_name).to eq('something_else')
+    end
   end
 
-  it 'can have the default queue overridden' do
-    LaterRoutine.perform_later
-    queue_name = ActiveJob::Base.queue_adapter.enqueued_jobs.first[:queue]
-    expect(queue_name).to eq('something_else')
+  context 'specialized configuration' do
+    before do
+      Lev.configure { |c| c.active_job_class = SomeOtherJobBase }
+    end
+
+    class SomeOtherJobBase
+      def self.queue_as(*args); end
+      def self.perform_later; end
+    end
+
+    class NewLaterRoutine
+      lev_routine
+      protected
+      def exec; end
+    end
+
+    it 'allows configuration of the class' do
+      allow(SomeOtherJobBase).to receive(:perform_later)
+
+      expect(Lev.configuration.active_job_class).to eq(SomeOtherJobBase)
+      NewLaterRoutine.perform_later
+      expect(SomeOtherJobBase).to have_received(:perform_later)
+    end
   end
 end

data/spec/routine_spec.rb

@@ -35,7 +35,7 @@ describe Lev::Routine do
   it 'allows not raising fatal errors to be overridden' do
     stub_const 'NestedFatalError', Class.new
     NestedFatalError.class_eval {
-      lev_routine
+      lev_routine raise_fatal_errors: false # testing that parent overrides
 
       def exec
         fatal_error(code: :its_broken)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lev
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.3.0
 platform: ruby
 authors:
 - JP Slavinsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-04 00:00:00.000000000 Z
+date: 2015-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel