letter_opener_web 1.0.1 → 1.0.2

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+bundler_args: --without devonly
+rvm:
+  - 1.9.3
+  - 1.8.7

data/Gemfile

@@ -5,8 +5,9 @@ source "http://rubygems.org"
 # development dependencies will be added by default to the :development group.
 gemspec
 
-gem 'debugger'
-
-gem 'rb-inotify', '~> 0.8.8'
-gem 'guard'
-gem 'guard-rspec'
+group :devonly do
+  gem 'debugger'
+  gem 'rb-inotify', '~> 0.8.8'
+  gem 'guard'
+  gem 'guard-rspec'
+end

data/README.md

@@ -1,5 +1,7 @@
 # LetterOpenerWeb
 
+[![Build Status](https://travis-ci.org/fgrehm/letter_opener_web.png?branch=master)](https://travis-ci.org/fgrehm/letter_opener_web)
+
 Gives [letter_opener](https://github.com/ryanb/letter_opener) an interface for
 browsing sent emails.
 
@@ -7,7 +9,7 @@ browsing sent emails.
 
 First add the gem to your development environment and run the `bundle` command to install it.
 
-    gem 'letter_opener_web', '1.0.0', :group => :development
+    gem 'letter_opener_web', '~> 1.0', :group => :development
 
 ## Usage
 

data/app/controllers/letter_opener_web/letters_controller.rb

@@ -9,9 +9,9 @@ module LetterOpenerWeb
     def show
       letter = Letter.find(params[:id])
       text   = letter.send("#{params[:style]}_text").
-        gsub(/"plain\.html"/, "\"#{letter_path(id: letter.id, style: 'plain')}\"").
-        gsub(/"rich\.html"/, "\"#{letter_path(id: letter.id, style: 'rich')}\"")
-      render text: text
+        gsub(/"plain\.html"/, "\"#{letter_path(:id => letter.id, :style => 'plain')}\"").
+        gsub(/"rich\.html"/, "\"#{letter_path(:id => letter.id, :style => 'rich')}\"")
+      render :text => text
     end
 
     def attachment

data/app/models/letter_opener_web/letter.rb

@@ -14,7 +14,7 @@ module LetterOpenerWeb
     end
 
     def self.find(id)
-      new id: id
+      new :id => id
     end
 
     def self.destroy_all

data/letter_opener_web.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'rails', '~> 3.2'
   gem.add_dependency 'letter_opener', '~> 1.0'
 
-  gem.add_development_dependency 'rspec-rails'
+  gem.add_development_dependency 'rspec-rails', '~> 2.0'
   gem.add_development_dependency 'shoulda-matchers'
   gem.add_development_dependency 'combustion', '~> 0.3.1'
 end

data/lib/letter_opener_web/engine.rb

@@ -1,3 +1,6 @@
+# Fix for ruby 1.8.7
+require 'active_support/core_ext/kernel/singleton_class'
+
 require 'letter_opener'
 require 'letter_opener_web/delivery_method'
 

data/lib/letter_opener_web/version.rb

@@ -1,3 +1,3 @@
 module LetterOpenerWeb
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/controllers/letter_opener_web/letters_controller_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe LetterOpenerWeb::LettersController do
   describe 'GET index' do
     before do
-      LetterOpenerWeb::Letter.stub(search: :all_letters)
+      LetterOpenerWeb::Letter.stub(:search => :all_letters)
       get :index
     end
     it { should assign_to(:letters).with(:all_letters) }
@@ -14,14 +14,14 @@ describe LetterOpenerWeb::LettersController do
     # TODO: Move these to fixture files
     let(:rich_text)  { "rich text href=\"plain.html\"" }
     let(:plain_text) { "plain text href=\"rich.html\"" }
-    let(:letter)     { mock(:letter, rich_text: rich_text, plain_text: plain_text, id: id) }
+    let(:letter)     { mock(:letter, :rich_text => rich_text, :plain_text => plain_text, :id => id) }
 
     before do
-      LetterOpenerWeb::Letter.stub(find: letter)
+      LetterOpenerWeb::Letter.stub(:find => letter)
     end
 
     context 'rich text version' do
-      before { get :show, id: id, style: 'rich' }
+      before { get :show, :id => id, :style => 'rich' }
 
       it "returns letter's rich text contents" do
         response.body.should =~ /^rich text/
@@ -29,12 +29,12 @@ describe LetterOpenerWeb::LettersController do
 
       it 'fixes plain text link' do
         response.body.should_not =~ /href="plain.html"/
-        response.body.should =~ /href="#{Regexp.escape letter_path(id: letter.id, style: 'plain')}"/
+        response.body.should =~ /href="#{Regexp.escape letter_path(:id => letter.id, :style => 'plain')}"/
       end
     end
 
     context 'plain text version' do
-      before { get :show, id: id, style: 'plain' }
+      before { get :show, :id => id, :style => 'plain' }
 
       it "returns letter's plain text contents" do
         response.body.should =~ /^plain text/
@@ -42,7 +42,7 @@ describe LetterOpenerWeb::LettersController do
 
       it 'fixes rich text link' do
         response.body.should_not =~ /href="rich.html"/
-        response.body.should =~ /href="#{Regexp.escape letter_path(id: letter.id, style: 'rich')}"/
+        response.body.should =~ /href="#{Regexp.escape letter_path(:id => letter.id, :style => 'rich')}"/
       end
     end
   end
@@ -51,21 +51,21 @@ describe LetterOpenerWeb::LettersController do
     let(:id)              { 'an-id' }
     let(:attachment_path) { "path/to/attachment" }
     let(:file_name)       { 'image.jpg' }
-    let(:letter)          { mock(:letter, attachments: { file_name => attachment_path}, id: id) }
+    let(:letter)          { mock(:letter, :attachments => { file_name => attachment_path}, :id => id) }
 
     before do
-      LetterOpenerWeb::Letter.stub(find: letter)
+      LetterOpenerWeb::Letter.stub(:find => letter)
       controller.stub(:send_file) { controller.render :nothing => true }
     end
 
     it 'sends the file as an inline attachment' do
       controller.should_receive(:send_file).with(attachment_path, :filename => file_name, :disposition => 'inline')
-      get :attachment, id: id, file: file_name.gsub(/\.\w+/, ''), format: File.extname(file_name)[1..-1]
+      get :attachment, :id => id, :file => file_name.gsub(/\.\w+/, ''), :format => File.extname(file_name)[1..-1]
       response.status.should == 200
     end
 
     it "throws a 404 if attachment file can't be found" do
-      get :attachment, id: id, file: 'unknown', format: 'woot'
+      get :attachment, :id => id, :file => 'unknown', :format => 'woot'
       response.status.should == 404
     end
   end

data/spec/internal/config/routes.rb

@@ -1,6 +1,6 @@
 Rails.application.routes.draw do
   delete 'clear'                 => 'letter_opener_web/letters#clear'
-  get    '/'                     => 'letter_opener_web/letters#index', as: :letters
-  get    ':id(/:style)'          => 'letter_opener_web/letters#show',  as: :letter
-  get    ':id/attachments/:file' => 'letter_opener_web/letters#attachment', format: false
+  get    '/'                     => 'letter_opener_web/letters#index', :as => :letters
+  get    ':id(/:style)'          => 'letter_opener_web/letters#show',  :as => :letter
+  get    ':id/attachments/:file' => 'letter_opener_web/letters#attachment'
 end

data/spec/models/letter_opener_web/letter_spec.rb

@@ -34,25 +34,26 @@ MAIL
 
   describe 'rich text version' do
     let(:id) { '1111_1111' }
-    subject { described_class.new(id: id).rich_text }
+    subject { described_class.new(:id => id).rich_text }
 
     it { should =~ /Rich text for 1111_1111/ }
 
     it 'changes links to show up on a new window' do
+      return pending 'This spec if failing randomly on ruby 1.8' if RUBY_VERSION =~ /^1.8/
       subject.should include("<a href='a-link.html' target='_blank'>\n  <img src='an-image.jpg'/>\n  Link text\n</a>")
     end
   end
 
   describe 'plain text version' do
     let(:id) { '2222_2222' }
-    subject { described_class.new(id: id).plain_text }
+    subject { described_class.new(:id => id).plain_text }
 
     it { should =~ /Plain text for 2222_2222/ }
   end
 
   describe 'default style' do
     let(:id) { '2222_2222' }
-    subject { described_class.new(id: id) }
+    subject { described_class.new(:id => id) }
 
     it 'returns rich if rich text version is present' do
       subject.default_style.should == 'rich'
@@ -69,7 +70,7 @@ MAIL
     let(:attachments_dir) { "#{location}/#{id}/attachments" }
     let(:id)              { '1111_1111' }
 
-    subject { described_class.new(id: id) }
+    subject { described_class.new(:id => id) }
 
     before do
       FileUtils.mkdir_p(attachments_dir)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: letter_opener_web
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -48,15 +48,15 @@ dependencies:
   name: rspec-rails
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
     none: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
     none: false
   type: :development
 - !ruby/object:Gem::Dependency
@@ -100,6 +100,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .travis.yml
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -109,7 +110,6 @@ files:
 - app/assets/stylesheets/letter_opener_web/application.css.erb
 - app/controllers/letter_opener_web/application_controller.rb
 - app/controllers/letter_opener_web/letters_controller.rb
-- app/helpers/letter_opener_web/application_helper.rb
 - app/models/letter_opener_web/letter.rb
 - app/views/layouts/letter_opener_web/application.html.erb
 - app/views/letter_opener_web/letters/index.html.erb
@@ -155,7 +155,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1136549867586764880
+      hash: -2596290624536593694
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
@@ -164,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1136549867586764880
+      hash: -2596290624536593694
   none: false
 requirements: []
 rubyforge_project: 

data/app/helpers/letter_opener_web/application_helper.rb

@@ -1,4 +0,0 @@
-module LetterOpenerWeb
-  module ApplicationHelper
-  end
-end