letter_opener 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2df464fe5809a855caf4522381a27fb4513aafbe1d25541d40e094af74d22b54
-  data.tar.gz: 3d6f55250c61a5c6997635543330166fad5f01427cf769b9736c5aba196edc04
+  metadata.gz: 0ef387f446fe58d7fbe039333d493cc644dbb388323e098f2b4a0a48dfad93ac
+  data.tar.gz: 3d6da1bcc7fa1d575e00d361677e36a73dfd26ea331416cfbb31c14cdd8f87ac
 SHA512:
-  metadata.gz: b95a304e86c9285ce73702cef85911a3664d4e51399b248ced6fa3db1e6e7ccaa214253e3970393aeeb327b55b690195774655a0797c3e900c6a4df53e71d639
-  data.tar.gz: 4ab881435c6a00604afb16fb1aeeb6a8b3244049c094ab144576bbf2a2be2bf8c39d098f657a300d06153049416439cd284eb2a71ceaeaf69aed2b5dad22d4e1
+  metadata.gz: 62fc742943f4904086cfdddcd0908c7bb67fd602530e340852eb213644bce32e664e6da00058767fd80cfc8f13735e757e2d4fa32cb4459be74df8bdf7348030
+  data.tar.gz: 827cb033ed7805de3399f2c32427e69190a15420314d2f4ad6b4f3856a8209d6cbf0b0d5701ea6e47dd996fd919ef5e9185389df3b151ce24b3ad67a693492a6

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## master ##
+ * Use default configuration in `Message::rendered_messages` (thanks [Krystan HuffMenne
+](https://github.com/gitKrystan))
+ * Do not use `Rails.root` path if LetterOpener is used outside of Rails (thanks [centrevillage](https://github.com/centrevillage))
+ * Allow to set only `Mail#cc`/`Mail#bcc` without `Mail#to`.
+
 ## 1.6.0 ##
  * Do not depend on Mail gem to check delivery params.
  * Do not parse and escape url before passing it to Launchy.

data/README.rdoc

@@ -12,6 +12,7 @@ First add the gem to your development environment and run the +bundle+ command t
 Then set the delivery method in <tt>config/environments/development.rb</tt>
 
   config.action_mailer.delivery_method = :letter_opener
+  config.action_mailer.perform_deliveries = true
 
 Now any email will pop up in your browser instead of being sent. The messages are stored in <tt>tmp/letter_opener</tt>.
 If you want to change application that will be used to open your emails you should override <tt>LAUNCHY_APPLICATION</tt> environment variable or set <tt>Launchy.application</tt> in the initializer.

data/lib/letter_opener.rb

@@ -4,7 +4,7 @@ module LetterOpener
   autoload :Configuration, "letter_opener/configuration"
 
   def self.configuration
-    @configration ||= Configuration.new
+    @configuration ||= Configuration.new
   end
 
   def self.configure

data/lib/letter_opener/configuration.rb

@@ -3,7 +3,7 @@ module LetterOpener
     attr_accessor :location, :message_template
 
     def initialize
-      @location = Rails.root.join('tmp', 'letter_opener') if defined?(Rails)
+      @location = Rails.root.join('tmp', 'letter_opener') if defined?(Rails) && Rails.respond_to?(:root)
       @message_template = 'default'
     end
   end

data/lib/letter_opener/delivery_method.rb

@@ -27,11 +27,11 @@ module LetterOpener
     private
 
     def validate_mail!(mail)
-      if !mail.from || mail.from.empty?
+      if !mail.smtp_envelope_from || mail.smtp_envelope_from.empty?
         raise ArgumentError, "SMTP From address may not be blank"
       end
 
-      if !mail.to || mail.to.empty?
+      if !mail.smtp_envelope_to || mail.smtp_envelope_to.empty?
         raise ArgumentError, "SMTP To address may not be blank"
       end
     end

data/lib/letter_opener/message.rb

@@ -16,12 +16,17 @@ module LetterOpener
       messages.sort
     end
 
+    ERROR_MSG = '%s or default configuration must be given'.freeze
+
     def initialize(mail, options = {})
       @mail = mail
-      @location = options[:location]
+      @location = options[:location] || LetterOpener.configuration.location
       @part = options[:part]
-      @template = options[:message_template]
+      @template = options[:message_template] || LetterOpener.configuration.message_template
       @attachments = []
+
+      raise ArgumentError, ERROR_MSG % 'options[:location]' unless @location
+      raise ArgumentError, ERROR_MSG % 'options[:message_template]' unless @template
     end
 
     def render
@@ -114,7 +119,7 @@ module LetterOpener
     end
 
     def attachment_filename(attachment)
-      attachment.filename.gsub(/[^\w\-_.]/, '_')
+      attachment.filename.gsub(/[^\w\-.]/, '_')
     end
 
     def <=>(other)

data/spec/letter_opener/delivery_method_spec.rb

@@ -316,7 +316,7 @@ describe LetterOpener::DeliveryMethod do
   end
 
   context 'delivery params' do
-    it 'raises an exception if delivery params are not valid' do
+    it 'raises an exception if there is no SMTP Envelope To value' do
       expect(Launchy).not_to receive(:open)
 
       expect {
@@ -327,6 +327,19 @@ describe LetterOpener::DeliveryMethod do
         end
       }.to raise_exception(ArgumentError)
     end
+
+    it 'does not raise an exception if there is at least one SMTP Envelope To value' do
+      expect(Launchy).to receive(:open)
+
+      expect {
+        Mail.deliver do
+          from     'Foo foo@example.com'
+          cc       'Bar bar@example.com'
+          reply_to 'No Reply no-reply@example.com'
+          body     'World! http://example.com'
+        end
+      }.not_to raise_exception
+    end
   end
 
   context 'light template' do

data/spec/letter_opener/message_spec.rb

@@ -201,4 +201,22 @@ describe LetterOpener::Message do
       expect(message.body.encoding.name).to eq('UTF-8')
     end
   end
+
+  describe '.rendered_messages' do
+    it 'uses configured default template if options not given' do
+      allow(LetterOpener.configuration).to receive(:location) { location }
+      messages = described_class.rendered_messages(mail)
+      expect(messages.first.template).not_to be_nil
+    end
+
+    it 'fails if necessary defaults are not provided' do
+      allow(LetterOpener.configuration).to receive(:location) { nil }
+      expect { described_class.rendered_messages(mail) }.to raise_error(ArgumentError)
+    end
+
+    it 'fails if necessary defaults are not provided' do
+      allow(LetterOpener.configuration).to receive(:message_template) { nil }
+      expect { described_class.rendered_messages(mail) }.to raise_error(ArgumentError)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: letter_opener
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Ryan Bates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-10 00:00:00.000000000 Z
+date: 2018-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: launchy
@@ -94,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.4
 requirements: []
 rubyforge_project: letter_opener
-rubygems_version: 2.6.14
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Preview mail in browser instead of sending.