letter_opener 1.5.0 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 01b0762b4aecc2dab14ff7cd85a99f5983185a528429b80a34daf75b53003b01
-  data.tar.gz: 00ceedf63ed4a2a18b0ef2f6571ad7338e9ab6154b41f870cf61a3caf4d58dcc
+  metadata.gz: 2df464fe5809a855caf4522381a27fb4513aafbe1d25541d40e094af74d22b54
+  data.tar.gz: 3d6f55250c61a5c6997635543330166fad5f01427cf769b9736c5aba196edc04
 SHA512:
-  metadata.gz: b0b6fe51bf7aca4604c7fcc8bdce55c4ae88530015fb34638fe7f97f5ef50321b059d36c1101b6405a37513ba32db346e8984532495ba152382b178c561824a2
-  data.tar.gz: 9f7ea030c5a857720d3f01548d5174c8d172914b4223396c9bbe50704ca8db4cb523ff7b0a070b12658c51065ca8e6dc5b963fd30e1418dcebcefdfbf8394cbb
+  metadata.gz: b95a304e86c9285ce73702cef85911a3664d4e51399b248ced6fa3db1e6e7ccaa214253e3970393aeeb327b55b690195774655a0797c3e900c6a4df53e71d639
+  data.tar.gz: 4ab881435c6a00604afb16fb1aeeb6a8b3244049c094ab144576bbf2a2be2bf8c39d098f657a300d06153049416439cd284eb2a71ceaeaf69aed2b5dad22d4e1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.6.0 ##
+ * Do not depend on Mail gem to check delivery params.
+ * Do not parse and escape url before passing it to Launchy.
+
 ## 1.5.0 ##
  * Use proper check for `Rails::Railties` (thanks [Florian Weingarten](https://github.com/fw42))
  * Add a shim for the iFrame "srcdoc" attribute (make it work with IE).

data/lib/letter_opener/delivery_method.rb

@@ -1,15 +1,8 @@
 require "digest/sha1"
 require "launchy"
-begin
-  require "mail"
-  require "mail/check_delivery_params"
-rescue LoadError
-end
 
 module LetterOpener
   class DeliveryMethod
-    include Mail::CheckDeliveryParams if defined?(Mail::CheckDeliveryParams)
-
     class InvalidOption < StandardError; end
 
     attr_accessor :settings
@@ -24,11 +17,23 @@ module LetterOpener
     end
 
     def deliver!(mail)
-      check_delivery_params(mail) if respond_to?(:check_delivery_params)
+      validate_mail!(mail)
       location = File.join(settings[:location], "#{Time.now.to_f.to_s.tr('.', '_')}_#{Digest::SHA1.hexdigest(mail.encoded)[0..6]}")
 
       messages = Message.rendered_messages(mail, location: location, message_template: settings[:message_template])
-      Launchy.open("file:///#{URI.parse(CGI.escape(messages.first.filepath))}")
+      Launchy.open("file:///#{messages.first.filepath}")
+    end
+
+    private
+
+    def validate_mail!(mail)
+      if !mail.from || mail.from.empty?
+        raise ArgumentError, "SMTP From address may not be blank"
+      end
+
+      if !mail.to || mail.to.empty?
+        raise ArgumentError, "SMTP To address may not be blank"
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: letter_opener
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - Ryan Bates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-02 00:00:00.000000000 Z
+date: 2018-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: launchy