letsencrypt_webfaction 2.2.2 → 2.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 70cdf0bbd92fee6c754762d779ad9637d851fb6d
-  data.tar.gz: 500669496025c30fdfe9d6e61071d1bbce4559c1
+  metadata.gz: 4b883c5a06ee4a755c4a926a4bb975191b7d975c
+  data.tar.gz: 21a1981e3cec9caf86c53d1823b78f72dbcbb259
 SHA512:
-  metadata.gz: cd47d7ec3b7158705d045ee282985d50687a1338ee068a696814327cb95e545481a9700fb6b82dee0a98c21608ddbf4c8caf88b2c260ab67e93a8f24604c4afd
-  data.tar.gz: 5ea1ca661317976e585fc974d732225c15b2b359495065e5772b6125a6dcea7ad6ef118149adc772d678575661eec7e5c8a5d111308adc12b3bee289a35093b8
+  metadata.gz: bcd3f8322875e3a8e3350ff0ba7ebdba8c1edca79c77b8cfb2f4f4ceb18a9fe8f7ac76567e55abf049fdf3e027d540766c21de663e64ba6b25e137f436de0177
+  data.tar.gz: 949201a7be7d429f95fd6808d2df4de4fd397e2c39644eec78029593088afcc8282c36f39a5802ea81466923193feb5967dfeb7439b39f20818e5f0519635bff

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+v2.2.3
+
+* Fix issue where Acme::Client v0.5.0 changed API. Require newer version and use differently. Fixes #120
+* Fix timing issue where it always took 10 seconds to fail.
+* Upgrade required Acme::Client to v0.6.0.
+
 v2.2.2
 
 * Removes `output_dir` from configuration as it hasn't been used since 1..

data/letsencrypt_webfaction.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.1.0'
 
-  spec.add_runtime_dependency 'acme-client', '~> 0.5.5'
+  spec.add_runtime_dependency 'acme-client', '~> 0.6.0'
 
   # This will be required for Ruby 2.4. But it is incompatible for Ruby <2.3. Unsupporting Ruby 2.4 for the moment.
   # spec.add_runtime_dependency 'xmlrpc', '~> 0.3.0'

data/lib/letsencrypt_webfaction.rb

@@ -1,3 +1,3 @@
 module LetsencryptWebfaction
-  VERSION = '2.2.2'.freeze
+  VERSION = '2.2.3'.freeze
 end

data/lib/letsencrypt_webfaction/domain_validator.rb

@@ -14,10 +14,12 @@ module LetsencryptWebfaction
       challenges.each(&:request_verification)
 
       10.times do
-        return true if all_challenges_valid?
+        break if no_challenges_pending?
         sleep(1)
       end
 
+      return true if all_challenges_valid?
+
       print_errors
       false
     end
@@ -32,8 +34,12 @@ module LetsencryptWebfaction
       @challenges ||= authorizations.map(&:http01)
     end
 
+    def no_challenges_pending?
+      challenges.none? { |challenge| challenge.authorization.verify_status == 'pending' }
+    end
+
     def all_challenges_valid?
-      challenges.reject { |challenge| challenge.verify_status == 'valid' }.empty?
+      challenges.reject { |challenge| challenge.authorization.verify_status == 'valid' }.empty?
     end
 
     def write_files!
@@ -61,11 +67,16 @@ module LetsencryptWebfaction
       end
 
       def print_error
-        if @challenge.verify_status == 'valid'
+        case @challenge.authorization.verify_status
+        when 'valid'
           $stderr.puts "#{@domain}: Success"
-        else
+        when 'invalid'
           $stderr.puts "#{@domain}: #{@challenge.error['detail']}"
           $stderr.puts "Make sure that you can access #{url}"
+        when 'pending'
+          $stderr.puts "#{@domain}: Still pending, but timed out"
+        else
+          $stderr.puts "#{@domain}: Unexpected authorization status #{@challenge.authorization.verify_status}"
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: letsencrypt_webfaction
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.2.3
 platform: ruby
 authors:
 - William Johnston
@@ -30,7 +30,7 @@ cert_chain:
   Bgn1/q+P8H+/qkt6w5h8UzWYyXRlEjWvSJEjkNU0C05GQ0w0GFiqd62CgQty5xpa
   7M3NhWEjOZHE18Ro4Vy9CQCJxUasYC4JUMMQ9tQBW+vYIgHfBn0+xlw=
   -----END CERTIFICATE-----
-date: 2018-03-25 00:00:00.000000000 Z
+date: 2018-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: acme-client
@@ -38,14 +38,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.5
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.5
+        version: 0.6.0
 description: A tool to simplify the manual process of using LetsEncrypt on Webfaction
   hosts. It can be added to cron where it will validate your domains automatically,
   place the generated certs in a common folder, and then email the WebFaction support