lets_shard 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7ad5ad3bc12b55db4816cd5b729704a502f6365ee135f0bc8b789d9e0aed18b
-  data.tar.gz: 7d08482f4ee12152db3ae2d09ac33400fd748844a34a44fc8aae088e13d63a41
+  metadata.gz: 5bf3cd5a20aaac93d6dda2fbba8f687b2329df22686d4beff2e0e4a2d77e4fa6
+  data.tar.gz: a3fd4bbd36b608a9b4f7ca804efe6b73a39fdce95637cc4b34a167d34b227efb
 SHA512:
-  metadata.gz: 1b15660bfda65b7d4637c7c1a27f4cdf706318a1228e8693c1fc93c770b5ab84728835c86286e8a645be061eea147120482e87ce777ad9b021d60bdf23112242
-  data.tar.gz: 214e8d1f9b116f9b0fa7305e398ceb384db071692d6da170242fb2278b4735697075f762f870c6909c9473fcc7bdec30f5851c8b164ab5fb03c6b3c9f4b254d8
+  metadata.gz: 31398727fda887d14c046b617400e23d71900fb18f47fd52589029dbaa3e2b6cb15522c1d39394029f4880a8ca29b80b7d1f83714de590464719ba9bd812888e
+  data.tar.gz: 63d6183bb1982df8c23fed7206fd42e9cf0a9111e973e8f54ed542e58fc487c9b04a1fdcb0d1e5dba97d510f50f855764ecc48aa1686b5032ef9a935d83bfd00

data/lib/lets_shard.rb

@@ -12,7 +12,7 @@ class LetsShard
 
     @objects = objects
     @weights = weights.any? ? weights : Array.new(@objects.size, 1)
-    @slots = @objects.size < DEFAULT_SLOTS ? DEFAULT_SLOTS : @objects.size
+    @slots = [DEFAULT_SLOTS, weights.sum].max
 
     set_unit_weight!
     set_remainder_slots!
@@ -41,8 +41,9 @@ class LetsShard
       end_slot = start_slot + (@weights[index] * @unit_weight) - 1
 
       if @remainder_slots > 0
-        end_slot += 1
-        @remainder_slots -= 1
+        slots_to_add = [@weights[index], @remainder_slots].min
+        end_slot += slots_to_add
+        @remainder_slots -= slots_to_add
       end
 
       @shards << Shard.new(object, start_slot, end_slot)
@@ -51,12 +52,16 @@ class LetsShard
     end
   end
 
+  def weights_sum
+    @weights.inject(0, :+)
+  end
+
   def set_unit_weight!
-    @unit_weight = @slots / @weights.inject(0, :+)
+    @unit_weight = @slots / weights_sum
   end
 
   def set_remainder_slots!
-    @remainder_slots = @slots - (@unit_weight * @objects.size)
+    @remainder_slots = @slots - (@unit_weight * weights_sum)
   end
 
   def get_hkey(key)

data/lib/lets_shard/version.rb

@@ -1,3 +1,3 @@
 class LetsShard
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lets_shard
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - oshboul