leptris 1.9.49-x86_64-linux → 1.9.50-x86_64-linux

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db5d7a945b1ae54ad6f41071e065ac76e281b5046c57c1cb287622cf56e5cfaa
-  data.tar.gz: 26d1656cd92f748b696d5be108161f5a1d7cafe459cf1582ad223eb674df8ee3
+  metadata.gz: 82771f3b1186801c18c35e8a120077fb00b699848e3e1f416abb8745c7cba9eb
+  data.tar.gz: 2e5e709e74ec8e0b4885138f2566ac74559d855213917a5908d65e3f2bb5a104
 SHA512:
-  metadata.gz: 3b7efbacf1d493e46a74ea0dca00fb38bc0930a15265f2c2806dc2021b6fd482a74181a5174d37f8bc2789f8975b3edc36367ebfaa49ed5219b467469c07f97f
-  data.tar.gz: 43e35c6719b7d81e63e9ccb845792be27168c9ec98a4ae15ee11206b78c525ed67ea718c5f3dc066b84ca0166f65cdc09656128ba36fd16aa25945f7dde39b61
+  metadata.gz: ee78523e4b6a4226d6411b438a4170fcdcf4706699815cdbfa1a6c5a5f288fbd2c9f5580b3958853e07fa61927b9f0c84ae4b1ae20453fe179838f3d113760e7
+  data.tar.gz: 77d47c27d3b3a946c4d12cded1dd533a65cab50fa7f981de9c4743c2c2aa47d17a79a42b2f2f2a53b8fb3fcc74aaee07259e07928f30a5bf9878176aabb31741

data/CHANGELOG.md

@@ -5,6 +5,22 @@ All notable changes to Leptris will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.9.50] - 2026-09-01
+
+### Fixed
+
+- **Copies keep comment and PI children (leptris-ruby#115)**:
+  `leptris_element_copy` silently drops COMMENT and PI children —
+  the C child-copy loop reads `/* Skip COMMENT and PI nodes for
+  now */` (engine-side, filed as leptris/leptris#696 with the
+  line). Blast radius in the binding: `Element#dup/#clone` and the
+  element indent-unit path both composed through the C copy. Both
+  now round through serialization instead — the serializer
+  preserves every child kind, prefixed names, and namespace
+  declarations, and re-parsing rebuilds them all; `dup` returns a
+  tree in a NEW document (unchanged contract), detached from the
+  original (spec-pinned).
+
 ## [1.9.49] - 2026-09-01
 
 ### Added

data/lib/leptris/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Leptris
-  VERSION = "1.9.49"
+  VERSION = "1.9.50"
 end

data/lib/leptris/xml/element.rb

@@ -251,10 +251,14 @@ class Leptris::XML::Element < Leptris::XML::Node
     self
   end
 
+  # Deep copy in a NEW document, via serialization round-trip:
+  # leptris_element_copy silently drops COMMENT and PI children
+  # (leptris/leptris#696, leptris-ruby#115) — the serializer
+  # preserves every child kind, prefixed names, and namespace
+  # declarations, and re-parsing rebuilds them all.
   def dup
-    copy_ptr = Leptris::XML::FFI.leptris_element_copy(@c_ptr, @document.c_ptr)
-    raise Leptris::XML::Error, "leptris_element_copy failed" if copy_ptr.null?
-    Leptris::XML::Node.wrap(copy_ptr, @document)
+    ensure_alive!
+    Leptris::XML::Document.parse(to_xml).root
   end
   alias_method :clone, :dup
 

data/lib/leptris/xml/node.rb

@@ -369,13 +369,16 @@ class Leptris::XML::Node
     result
   end
 
+  # Deep copy in a NEW document. Rounds through serialization
+  # rather than leptris_element_copy: the C copy silently drops
+  # COMMENT and PI children (leptris/leptris#696, leptris-ruby#115)
+  # — the serializer preserves every child kind, prefixed names,
+  # and namespace declarations, and re-parsing rebuilds them all.
   def dup
     ensure_alive!
     elem_ptr = Leptris::XML::FFI.leptris_node_as_element(@c_ptr)
     raise Leptris::XML::Error, "dup is only supported for element nodes" if elem_ptr.null?
-    copy_ptr = Leptris::XML::FFI.leptris_element_copy(elem_ptr, @document.c_ptr)
-    raise Leptris::XML::Error, "leptris_element_copy failed" if copy_ptr.null?
-    Leptris::XML::Node.wrap(copy_ptr, @document)
+    Leptris::XML::Document.parse(to_xml).root
   end
   alias_method :clone, :dup
 

data/lib/leptris/xml/serialization.rb

@@ -97,19 +97,15 @@ module Leptris::XML::Serialization
 
   # Element-face indent unit (leptris-ruby#109 residual 2): no
   # element-level ext-serialize entry exists yet, so the unit path
-  # copies the element into a fresh document (C-side copy, one
-  # pool allocation), serializes that document without a
-  # declaration, and returns the subtree — identical output to the
-  # element serializer for the standard layout, with the unit.
+  # rounds the subtree through serialization into a fresh document
+  # (leptris_element_copy drops COMMENT/PI children —
+  # leptris/leptris#696, leptris-ruby#115) and serializes that
+  # document without a declaration — identical output to the
+  # element serializer for the standard layout, with the unit and
+  # every child kind intact.
   def self.to_xml_element_unit(element, unit, indent: 0)
-    document = Leptris::XML::Document.create
+    document = Leptris::XML::Document.parse(element.to_xml)
     begin
-      copy_ptr = Leptris::XML::FFI.leptris_element_copy(
-        element.c_ptr, document.c_ptr)
-      if copy_ptr.null?
-        raise Leptris::XML::Error, "leptris_element_copy failed"
-      end
-      document.root = Leptris::XML::Node.wrap(copy_ptr, document)
       to_xml_indent_unit(document.c_ptr, unit,
                          indent: indent, no_decl: true)
     ensure

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: leptris
 version: !ruby/object:Gem::Version
-  version: 1.9.49
+  version: 1.9.50
 platform: x86_64-linux
 authors:
 - Ribose Inc.