leptris 1.9.222.1-x86_64-linux → 1.9.222.2-x86_64-linux

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dca333815547515d8eca3e154d3b78f22343c8e61772d1b238f35bb9f5a89593
-  data.tar.gz: cb9570da32327971d7ec4ff45ba9fd9f9b1aac00d08ef57849579e22a312a752
+  metadata.gz: 1a2572ad1d071c50c78534599f7fd5085eb10440ee977adfcde86fdeb54124e5
+  data.tar.gz: 8de31d649e8716712d6b323d5424cb95963a8360fad615a401da1b607fa6d993
 SHA512:
-  metadata.gz: b68930a9057d620c4ddeb5380d9e2740d0c712144f6d68f0b2e5718edf8131b1c5acb56ab1414aa09ef670439e2a92f0f730957bd1cb26d2456f65538acb23fd
-  data.tar.gz: a67c1b617d6517986843ae3fb550b15c6141b6e4c4e553b994d08531a334e3258eae7d0529863674164c30ae9a74c77561b223300fe19b1b3e2c54f09e925bb6
+  metadata.gz: '0209e0b311b3811bea6948f8d36dfa0053b63efd117fe76b3eb471c3182dca8acead4de51a679a7273900ebd8ed3a0c81189abe3849c2896b9885ecba12c6aea'
+  data.tar.gz: 61ae26f2a6e027e7cb2eec1326a24b1f722e158ead86db7496f6e27f28cdb1e7083105906e418f358ba04a4c13e07b154b872c2ac7f1055cb7087e36c220cb25

data/ext/leptris/native/native.c

@@ -2150,6 +2150,34 @@ static VALUE nf_plan_structs_typed_p(VALUE self)
     return Qtrue;
 }
 
+/* ---- Bulk attribute rows (leptris-ruby#278) ----------------------
+ * One C crossing per element: walks the attribute chain and
+ * returns a flat [name, value, address, ...] array. Names
+ * interned (they repeat), values fresh UTF-8 strings, addresses
+ * as Integers for Attr c_handle reconstruction. Identical data
+ * to the per-attribute FFI chain (first/next/get_name/get_value,
+ * 4 crossings each) — the win amplifies with attribute density
+ * (40-attr elements: ~7x on the listing). */
+static VALUE nf_attribute_rows(VALUE self, VALUE document, VALUE addr)
+{
+    (void)self;
+    (void)document;
+    void *node = (void *)(uintptr_t)NUM2ULL(addr);
+    VALUE out = rb_ary_new();
+    if (f_node_type(node) != WS_NODE_ELEMENT) return out;
+
+    for (void *a = f_attr_first(node); a; a = f_attr_next(a)) {
+        const char *an = f_attr_name(a);
+        const char *av = f_attr_value(node, a);
+        rb_ary_push(out, an ? rb_enc_interned_str(an, strlen(an),
+                                                  rb_utf8_encoding())
+                            : Qnil);
+        rb_ary_push(out, av ? rb_utf8_str_new_cstr(av) : Qnil);
+        rb_ary_push(out, ULL2NUM((uintptr_t)a));
+    }
+    return out;
+}
+
 static VALUE nf_plan_structs(VALUE self, VALUE document, VALUE addr,
                              VALUE spec)
 {
@@ -2732,6 +2760,8 @@ LEPTRIS_INIT_EXPORT void Init_native(void)
                               nf_attribute_pairs, 2);
     rb_define_module_function(m_native, "plan_structs",
                               nf_plan_structs, 3);
+    rb_define_module_function(m_native, "attribute_rows",
+                              nf_attribute_rows, 2);
     rb_define_module_function(m_native, "plan_structs_typed?",
                               nf_plan_structs_typed_p, 0);
     rb_define_module_function(m_native, "doc_handle_attach",

data/lib/leptris/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Leptris
-  VERSION = "1.9.222.1"
+  VERSION = "1.9.222.2"
 end

data/lib/leptris/xml/element.rb

@@ -311,7 +311,11 @@ class Leptris::XML::Element < Leptris::XML::Node
 
   def attribute_nodes
     return @attribute_nodes if memo_hit?(@attribute_nodes_version)
-    result = each_attribute.to_a
+    result = if NATIVE_ATTR_ROWS && @c_address && @document
+               attribute_rows_native
+             else
+               each_attribute.to_a
+             end
     if @document
       @attribute_nodes = result
       @attribute_nodes_version = @document.version
@@ -319,6 +323,26 @@ class Leptris::XML::Element < Leptris::XML::Node
     result
   end
 
+  # One C crossing per element (leptris-ruby#278): the native face
+  # walks the attribute chain and returns flat [name, value,
+  # address] triples; the Attr value objects are minted from them
+  # with zero further engine crossings — identical objects to
+  # each_attribute. The win amplifies with attribute density
+  # (40-attr elements list ~7x faster than the chain).
+  def attribute_rows_native
+    ::Leptris::XML::Native.attribute_rows(@document, @c_address)
+      .each_slice(3)
+      .map do |name, value, handle|
+        ::Leptris::XML::Attr.new(name, value, self,
+                                 c_handle: ::FFI::Pointer.new(handle))
+      end
+  end
+
+  NATIVE_ATTR_ROWS =
+    defined?(::Leptris::XML::Native) &&
+    ::Leptris::XML::Native.respond_to?(:attribute_rows)
+  private_constant :NATIVE_ATTR_ROWS
+
   # The element's own namespace prefix (e.g. "foo" for <foo:child/>),
   # or nil when the element has none.
   def prefix

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: leptris
 version: !ruby/object:Gem::Version
-  version: 1.9.222.1
+  version: 1.9.222.2
 platform: x86_64-linux
 authors:
 - Ribose Inc.