legion-transport 1.4.25 → 1.4.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3257739440ff409750a6b555beeda06961106a34550640aba80d25047a89682
-  data.tar.gz: 205dd2249629c4ded7831cd2e3c46b461deb26dc58ee23e6ca0b0d404c08e19b
+  metadata.gz: 3ef4fe3fdbefc12a9efd791c71b41422435c5ad5401e5ba0c51040649360f0b0
+  data.tar.gz: 8162f75c0d55ec521e8e1f3e2eaa1ff367b16bd0479a5c4f46471d9a6a92f8db
 SHA512:
-  metadata.gz: 597ab35e69a59cf40b8d99f4d2cd17234f60104140cf83fa37594e2894002b30ae4f04a9beaa5873f56db4258d671ee4241e81dd4158455363f6b2f0189a4b8d
-  data.tar.gz: f5552c15fe1463f572c960823bf9e02cec9605048909c1ba5c33c4dba384cd11369fbf3b3018dff2d8289e5a47a10ee3ba8564b921e2bd30992a04356ce5a297
+  metadata.gz: 577f95777048496f3155dc4e22a9fd865df45fe1869c076e7297dcd2390352d3929952b0fa849e5864974ad84b2595a28d3788f8bdfe50a9a3f55084f3fb535c
+  data.tar.gz: 96cda6bf47f5bfa71ef6e3684b1ea68ebe91573159d42e00adba7f6f664d9f1bc0a587a185abfd5108dbe60f77bbe6e598c61a7a4929b971aca24c7ccf128707

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## [Unreleased]
 
+## [1.4.26] - 2026-05-16
+
+### Fixed
+- Fixed channel leak caused by concurrent-ruby's IO-pool thread lifecycle: `TimerTask` (used by `Every` actors) dispatches onto `global_io_executor` threads that idle-timeout after 60s; thread-local Bunny channels were never closed when those threads died, eventually exhausting RabbitMQ's `channel_max` (1024). Added a `@channel_registry` that tracks publisher channels by owning thread and sweeps orphaned channels from dead threads before creating new ones.
+- `Connection.shutdown` now explicitly closes all tracked publisher channels before tearing down the session.
+- `Connection.force_reconnect` resets the channel registry to prevent stale references after reconnection.
+
 ## [1.4.25] - 2026-05-15
 
 ### Added

data/lib/legion/transport/connection.rb

@@ -11,6 +11,7 @@ module Legion
     module Connection
       RECOVERY_WINDOW = 60
       MAX_RECOVERIES_PER_WINDOW = 5
+      MAX_PUBLISHER_CHANNELS = 128
 
       class << self
         include Legion::Logging::Helper
@@ -36,6 +37,7 @@ module Legion
         def reconnect(connection_name: 'Legion', **)
           @session = nil
           @channel_thread = Concurrent::ThreadLocalVar.new(nil)
+          @channel_registry = Concurrent::Hash.new
           setup(connection_name: connection_name)
         end
 
@@ -83,9 +85,18 @@ module Legion
           s = session
           raise IOError, 'transport session unavailable (recovery in progress)' unless s&.open?
 
+          sweep_dead_thread_channels
+
+          current_size = channel_registry_size
+          if current_size >= MAX_PUBLISHER_CHANNELS
+            log.warn "Channel registry at capacity (size=#{current_size}, max=#{MAX_PUBLISHER_CHANNELS}); " \
+                     'RabbitMQ channel_max exhaustion risk — investigate thread lifecycle'
+          end
+
           @channel_thread.value = s.create_channel(nil, settings[:channel][:default_worker_pool_size], false, 10)
           @channel_thread.value.prefetch(settings[:prefetch])
-          log.debug "Channel created for thread #{Thread.current.object_id}"
+          track_channel(Thread.current, @channel_thread.value)
+          log.debug "Channel created for thread #{Thread.current.object_id} (tracked=#{channel_registry_size})"
           @channel_thread.value
         end
 
@@ -127,6 +138,7 @@ module Legion
           @shutting_down = true
           pre_mark_sessions_closing
           close_build_session
+          close_all_tracked_channels
 
           if @pool
             @pool.shutdown
@@ -150,6 +162,7 @@ module Legion
         ensure
           @log_channel = nil
           @session = nil
+          @channel_registry = Concurrent::Hash.new
           @shutting_down = false
         end
 
@@ -163,6 +176,7 @@ module Legion
           reset_pool if pool_mode
           @session = nil
           @channel_thread = Concurrent::ThreadLocalVar.new(nil)
+          @channel_registry = Concurrent::Hash.new
           @recovery_timestamps = []
 
           tear_down_session(old) if old && !pool_mode
@@ -272,8 +286,50 @@ module Legion
           sess
         end
 
+        def channel_registry_size
+          (@channel_registry ||= Concurrent::Hash.new).size
+        end
+
         private
 
+        def track_channel(thread, channel)
+          @channel_registry ||= Concurrent::Hash.new
+          @channel_registry[thread] = channel
+        end
+
+        def close_all_tracked_channels
+          @channel_registry ||= Concurrent::Hash.new
+          return if @channel_registry.empty?
+
+          @channel_registry.each_value do |channel|
+            channel.close if channel&.open?
+          rescue StandardError => e
+            handle_exception(e, level: :warn, handled: true, operation: 'transport.connection.close_tracked_channel')
+          end
+          @channel_registry.clear
+        end
+
+        def sweep_dead_thread_channels
+          @channel_registry ||= Concurrent::Hash.new
+          return if @channel_registry.empty?
+
+          swept = 0
+          @channel_registry.each do |thread, channel|
+            next if thread&.alive?
+
+            if channel&.open?
+              channel.close
+              swept += 1
+            end
+            @channel_registry.delete(thread)
+          rescue StandardError => e
+            @channel_registry.delete(thread)
+            handle_exception(e, level: :warn, handled: true, operation: 'transport.connection.sweep_channel')
+          end
+
+          log.info "Swept #{swept} orphaned channel(s) from dead threads (remaining=#{@channel_registry.size})" if swept.positive?
+        end
+
         def pre_mark_sessions_closing
           candidates = [
             session,
@@ -493,6 +549,7 @@ module Legion
           @log_channel = nil
           @session = Concurrent::AtomicReference.new(create_session_with_failover(connection_name: connection_name))
           @channel_thread = Concurrent::ThreadLocalVar.new(nil)
+          @channel_registry = Concurrent::Hash.new
           start_session(session)
           qos_channel = session.create_channel(nil, settings[:channel][:session_worker_pool_size])
           apply_qos_and_close(qos_channel)

data/lib/legion/transport/version.rb

@@ -2,6 +2,6 @@
 
 module Legion
   module Transport
-    VERSION = '1.4.25'
+    VERSION = '1.4.26'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: legion-transport
 version: !ruby/object:Gem::Version
-  version: 1.4.25
+  version: 1.4.26
 platform: ruby
 authors:
 - Esity