legion-settings 1.3.5 → 1.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 220738db670fe9bbda99acc5d64d903de88268afdc83bb0ef6c482f550b7b769
-  data.tar.gz: b46f3ff6ed58a9a7a0269230814ea2a9204953970c93877747c5d28c23410c8b
+  metadata.gz: 226a1ae2303f64b96fc48bd42101545a9d06b73aefab19278f27007c406c39d2
+  data.tar.gz: 4cbf2414166794436869ed44646f86c2860e7bdad4a07feebbd2536fe0e15276
 SHA512:
-  metadata.gz: 2e8a71bf3705c3f2a809b454c1bc676f7ab1f7c2e3c2dd1b3d6b317f5126ba84bde201b75a1f65e5111d31f1b67408e173eef8da3683d4d19ee48af83c69bdc0
-  data.tar.gz: a537874627f4d55ee13bb3ec4cbce0e869337a15c0f6c1bfd012a16f081c79f8bb7a56f39d7431c7eb6c1e6e525cda8a98155f534bfac32177a135b1aa96e7cd
+  metadata.gz: 0b719320bd415ffbf14d68c5a43122dddf8182a0cfddca05915ba8f36490ede658abcb74fa499f320711a20fb5ec67d4f108c17fa4a1b35ee6a51dac801d0402
+  data.tar.gz: 88220500e2cc7a8542ce32b26c94b8ccf143d6b90d7ef0054a32f8d4507d175534dd8ac4ddae724ac8cfaa1fb4e88ac099200ca7d028fe4e258fe945398d939a

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Legion::Settings Changelog
 
+## [1.3.6] - 2026-03-20
+
+### Fixed
+- Guard all `Legion::Logging` calls in loader with `defined?` check to prevent `NameError` when legion-logging is not loaded (fixes CI for downstream gems like legion-transport)
+
 ## [1.3.5] - 2026-03-19
 
 ### Added

data/CLAUDE.md

@@ -8,7 +8,7 @@
 Hash-like configuration store for the LegionIO framework. Loads settings from JSON files, directories, and environment variables. Provides a unified `Legion::Settings[:key]` accessor used by all other Legion gems. Includes schema-based validation with type inference, enum constraints, and cross-module checks.
 
 **GitHub**: https://github.com/LegionIO/legion-settings
-**Version**: 1.3.4
+**Version**: 1.3.5
 **License**: Apache-2.0
 
 ## Architecture
@@ -27,11 +27,19 @@ Legion::Settings (singleton module)
 │
 ├── Loader               # Core: loads env vars, files, directories, merges settings
 │   ├── .load_env        # Load environment variables (LEGION_API_PORT)
+│   ├── .load_dns_bootstrap  # DNS-based corporate config discovery (baseline defaults)
 │   ├── .load_file       # Load single JSON file
 │   ├── .load_directory  # Load all JSON files from directory
 │   ├── .load_module_settings    # Merge with module priority
 │   └── .load_module_default     # Merge with default priority
 │
+├── DnsBootstrap         # DNS-based corporate config auto-discovery
+│   ├── .resolve?        # Check if legion-bootstrap.<domain> resolves
+│   ├── .fetch           # HTTPS GET /legion/bootstrap.json
+│   ├── .write_cache     # Atomic write to ~/.legionio/settings/_dns_bootstrap.json
+│   ├── .read_cache      # Read + strip metadata, delete if corrupted
+│   └── .cache_exists?   # Check for cached config
+│
 ├── Schema               # Type inference, validation, unknown key detection
 │   ├── .register        # Infer types from defaults
 │   ├── .define_override # Add enum/required/type constraints
@@ -46,7 +54,9 @@ Legion::Settings (singleton module)
 ### Key Design Patterns
 
 - **Auto-Load on Access**: `Legion::Settings[:key]` auto-loads if not initialized
+- **DNS Bootstrap Discovery**: On load, resolves `legion-bootstrap.<search-domain>` to fetch corporate baseline config. First boot blocks; subsequent boots use cache + async refresh. Disabled via `LEGION_DNS_BOOTSTRAP=false`
 - **Directory-Based Config**: Loads all `.json` files from config directories (default paths: `/etc/legionio`, `~/legionio`, `./settings`)
+- **Load Priority** (lowest to highest): hardcoded defaults < DNS bootstrap < local JSON files < CLI flags < secret resolution
 - **Module Merging**: Each Legion module registers its defaults via `merge_settings` during startup
 - **Schema Inference**: Types are inferred from default values — no manual schema definitions needed
 - **Two-Pass Validation**: Per-module on merge (catches type mismatches immediately) + cross-module on `validate!` (catches dependency conflicts)
@@ -70,13 +80,15 @@ Legion::Settings (singleton module)
 | `lib/legion/settings/validation_error.rb` | Error collection and formatted reporting |
 | `lib/legion/settings/os.rb` | OS detection helpers |
 | `lib/legion/settings/resolver.rb` | Secret resolution: `vault://` and `env://` URI references, fallback chains |
+| `lib/legion/settings/dns_bootstrap.rb` | DNS-based corporate config discovery, caching, background refresh |
 | `lib/legion/settings/version.rb` | VERSION constant |
 | `spec/legion/settings_spec.rb` | Core settings module tests |
 | `spec/legion/settings_module_spec.rb` | Module-level accessor and merge tests |
 | `spec/legion/loader_spec.rb` | Loader: env/file/directory loading tests |
 | `spec/legion/settings/schema_spec.rb` | Schema validation tests |
 | `spec/legion/settings/validation_error_spec.rb` | Error formatting tests |
-| `spec/legion/settings/integration_spec.rb` | End-to-end validation tests |
+| `spec/legion/settings/integration_spec.rb` | End-to-end validation + DNS bootstrap override tests |
+| `spec/legion/settings/dns_bootstrap_spec.rb` | DnsBootstrap class tests (resolve, fetch, cache) |
 | `spec/legion/settings/role_defaults_spec.rb` | Role profile default settings tests |
 | `spec/legion/settings/resolver_spec.rb` | Secret resolver tests (env://, vault://, lease://, fallback chains) |
 

data/README.md

@@ -2,7 +2,7 @@
 
 Configuration management module for the [LegionIO](https://github.com/LegionIO/LegionIO) framework. Loads settings from JSON files, directories, and environment variables. Provides a unified `Legion::Settings[:key]` accessor used by all other Legion gems.
 
-**Version**: 1.3.4
+**Version**: 1.3.5
 
 ## Installation
 

data/lib/legion/settings/loader.rb

@@ -162,7 +162,7 @@ module Legion
       end
 
       def load_file(file)
-        Legion::Logging.debug("Trying to load file #{file}")
+        log_debug("Trying to load file #{file}")
         if File.file?(file) && File.readable?(file)
           begin
             contents = read_config_file(file)
@@ -173,11 +173,11 @@ module Legion
             # @indifferent_access = false
             @loaded_files << file
           rescue Legion::JSON::ParseError => e
-            Legion::Logging.error("config file must be valid json: #{file}")
-            Legion::Logging.error("  parse error: #{e.message}")
+            log_error("config file must be valid json: #{file}")
+            log_error("  parse error: #{e.message}")
           end
         else
-          Legion::Logging.warn("Config file does not exist or is not readable file:#{file}")
+          log_warn("Config file does not exist or is not readable file:#{file}")
         end
       end
 
@@ -199,7 +199,7 @@ module Legion
           @settings[:client][:subscriptions].uniq!
           @indifferent_access = false
         else
-          Legion::Logging.warn('unable to apply legion client overrides, reason: client subscriptions is not an array')
+          log_warn('unable to apply legion client overrides, reason: client subscriptions is not an array')
         end
       end
 
@@ -226,7 +226,7 @@ module Legion
       end
 
       def load_dns_first_boot(bootstrap)
-        Legion::Logging.debug("DNS bootstrap: first boot, fetching from #{bootstrap.url}")
+        log_debug("DNS bootstrap: first boot, fetching from #{bootstrap.url}")
         config = bootstrap.fetch
         bootstrap.write_cache(config) if config
         config
@@ -285,7 +285,7 @@ module Legion
 
         @settings[:api] ||= {}
         @settings[:api][:port] = ENV['LEGION_API_PORT'].to_i
-        Legion::Logging.warn("using api port environment variable, api: #{@settings[:api]}")
+        log_warn("using api port environment variable, api: #{@settings[:api]}")
         @indifferent_access = false
       end
 
@@ -355,18 +355,30 @@ module Legion
         'unknown'
       end
 
+      def log_debug(message)
+        Legion::Logging.debug(message) if defined?(Legion::Logging)
+      end
+
+      def log_warn(message)
+        defined?(Legion::Logging) ? Legion::Logging.warn(message) : warn(message)
+      end
+
+      def log_error(message)
+        defined?(Legion::Logging) ? Legion::Logging.error(message) : warn(message)
+      end
+
       def warning(message, data = {})
         @warnings << {
           message: message
         }.merge(data)
-        Legion::Logging.warn(message)
+        log_warn(message)
       end
 
       def load_error(message, data = {})
         @errors << {
           message: message
         }.merge(data)
-        Legion::Logging.error(message)
+        log_error(message)
         raise(Error, message)
       end
 

data/lib/legion/settings/version.rb

@@ -2,6 +2,6 @@
 
 module Legion
   module Settings
-    VERSION = '1.3.5'
+    VERSION = '1.3.6'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: legion-settings
 version: !ruby/object:Gem::Version
-  version: 1.3.5
+  version: 1.3.6
 platform: ruby
 authors:
 - Esity