legion-settings 1.3.2 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 905fefabffcdb64f2d654827742feb7c2651a3603625eb7f4e2eb71930416c8e
-  data.tar.gz: e19c105841be33b885565d5dac97d2549ee9813897ea4286bf68977e35e95e63
+  metadata.gz: f66aca7decaa9e60f84abf3d4b2538f42a90978289916f535395991161bb8e24
+  data.tar.gz: 41c5f1bac7ec1e12d0034ad872816405588d880542efbe7c420ec958697f1991
 SHA512:
-  metadata.gz: 71a352c5cd2a45145619ae24d31f9b9f3280c33c0d2f864c21c9549f7a78a4a48b45f06d4172bc6ed30d314a355ab1548bc141efa63638917734816b1c66c0ba
-  data.tar.gz: 6a7a29a655bc77c13352631a62763bc20c8cf9d2a7e84efeaa43b92cc70301425081aa8ed82e6d34a2c77aac9944500ff241ce404f09d0af76bb4de9aaf68baf
+  metadata.gz: 967b78c6ca4e9e2bee7a2ac1e53c6198a0b0606985e16fca8734c061be6b5b5b4f30e7ed882c387af00554f3323e9008269e036eaec09e9b7ee12d1e1c8ad349
+  data.tar.gz: 2451834575d97a57f1f11c41556f48cf581358624c793d8ac011158b174df2072988d1135af0b9fc3656d1fd608734ab155a2f5b7419d71f77a613e5d8677994

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Legion::Settings Changelog
 
+## [1.3.4] - 2026-03-18
+
+### Fixed
+- Added `logger` gem to test dependencies for Ruby 4.0 compatibility
+
+## [1.3.3] - 2026-03-17
+
+### Fixed
+- Config JSON parse error now includes the filename at ERROR level instead of burying it in DEBUG
+
 ## [1.3.2] - 2026-03-17
 
 ### Added

data/Gemfile

@@ -5,6 +5,7 @@ source 'https://rubygems.org'
 gemspec
 group :test do
   gem 'legion-logging'
+  gem 'logger'
   gem 'rake'
   gem 'rspec'
   gem 'rspec_junit_formatter'

data/docs/plans/2026-03-17-config-error-filename-design.md

@@ -0,0 +1,56 @@
+# Design: Include Filename in JSON Parse Error Messages
+
+## Problem
+
+When a user edits a config file and introduces a JSON syntax error, the settings loader logs:
+
+```
+ERROR config file must be valid json
+```
+
+The filename is only logged at DEBUG level on the next line:
+
+```ruby
+Legion::Logging.error('config file must be valid json')
+Legion::Logging.debug("file:#{file}, error: #{e}")
+```
+
+This makes it nearly impossible for users to identify which file is broken, especially when multiple config files exist in `~/.legionio/settings/`. The settings loader silently skips the broken file, and downstream code fails with confusing errors (e.g., RubyLLM complaining about missing API keys because `llm.json` wasn't loaded).
+
+## Proposed Solution
+
+Change `load_file` in `loader.rb` to include the filename and parse error in the ERROR message:
+
+```ruby
+rescue Legion::JSON::ParseError => e
+  Legion::Logging.error("config file must be valid json: #{file}")
+  Legion::Logging.error("  parse error: #{e.message}")
+end
+```
+
+This is a one-line change (plus one added line) in `loader.rb:140-142`.
+
+### Before
+
+```
+[2026-03-17 18:27:27 -0500] ERROR config file must be valid json
+```
+
+### After
+
+```
+[2026-03-17 18:27:27 -0500] ERROR config file must be valid json: /Users/matt/.legionio/settings/llm.json
+[2026-03-17 18:27:27 -0500] ERROR   parse error: unexpected token at '{ "llm": { ... '
+```
+
+## Alternatives Considered
+
+1. **Raise instead of logging** — rejected; the current behavior of skipping broken files and continuing is correct for resilience. But the user needs to know what happened.
+2. **Add a `config validate` pre-check** — already exists (`legion config validate`), but users won't run it proactively. The error message at load time is the first line of defense.
+3. **Return the broken files in `loaded_files`** — would require API changes for minimal benefit.
+
+## Constraints
+
+- Do not change the error-handling behavior (continue loading other files)
+- Do not change method signatures
+- The debug line can be removed since the info is now in the error message

data/docs/plans/2026-03-17-config-error-filename-implementation.md

@@ -0,0 +1,34 @@
+# Implementation: Include Filename in JSON Parse Error Messages
+
+## Phase 1: Update Error Logging
+
+### Files to Modify
+
+- `lib/legion/settings/loader.rb` — lines 140-142
+
+### Changes
+
+Replace:
+
+```ruby
+rescue Legion::JSON::ParseError => e
+  Legion::Logging.error('config file must be valid json')
+  Legion::Logging.debug("file:#{file}, error: #{e}")
+```
+
+With:
+
+```ruby
+rescue Legion::JSON::ParseError => e
+  Legion::Logging.error("config file must be valid json: #{file}")
+  Legion::Logging.error("  parse error: #{e.message}")
+```
+
+### Spec Coverage
+
+- Add spec in `spec/legion/loader_spec.rb` that writes invalid JSON to a temp file, calls `load_file`, and asserts the error was logged with the filename
+
+### Version Bump
+
+- Bump patch version in `lib/legion/settings/version.rb`
+- Update CHANGELOG.md

data/lib/legion/settings/loader.rb

@@ -38,7 +38,25 @@ module Legion
             vault:                  { connected: false }
           },
           cache:                      { enabled: true, connected: false, driver: 'dalli' },
-          extensions:                 {},
+          extensions:                 {
+            core:              %w[
+              lex-node lex-tasker lex-scheduler lex-health lex-ping
+              lex-telemetry lex-metering lex-log lex-audit
+              lex-conditioner lex-transformer lex-exec lex-lex lex-codegen
+            ],
+            ai:                %w[lex-claude lex-openai lex-gemini],
+            gaia:              %w[lex-tick lex-mesh lex-apollo lex-cortex],
+            categories:        {
+              core:    { type: :list, tier: 1 },
+              ai:      { type: :list, tier: 2 },
+              gaia:    { type: :list, tier: 3 },
+              agentic: { type: :prefix, tier: 4 }
+            },
+            blocked:           [],
+            reserved_prefixes: %w[core ai agentic gaia],
+            reserved_words:    %w[transport cache crypt data settings json logging llm rbac legion],
+            agentic:           { allowed: nil, blocked: [] }
+          },
           reload:                     false,
           reloading:                  false,
           auto_install_missing_lex:   true,
@@ -120,8 +138,8 @@ module Legion
             # @indifferent_access = false
             @loaded_files << file
           rescue Legion::JSON::ParseError => e
-            Legion::Logging.error('config file must be valid json')
-            Legion::Logging.debug("file:#{file}, error: #{e}")
+            Legion::Logging.error("config file must be valid json: #{file}")
+            Legion::Logging.error("  parse error: #{e.message}")
           end
         else
           Legion::Logging.warn("Config file does not exist or is not readable file:#{file}")

data/lib/legion/settings/version.rb

@@ -2,6 +2,6 @@
 
 module Legion
   module Settings
-    VERSION = '1.3.2'
+    VERSION = '1.3.4'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: legion-settings
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.4
 platform: ruby
 authors:
 - Esity
@@ -42,6 +42,8 @@ files:
 - Gemfile
 - LICENSE
 - README.md
+- docs/plans/2026-03-17-config-error-filename-design.md
+- docs/plans/2026-03-17-config-error-filename-implementation.md
 - legion-settings.gemspec
 - lib/legion/settings.rb
 - lib/legion/settings/loader.rb