legato 0.1.0 → 0.2.0

data/.gitignore

@@ -3,4 +3,5 @@
 Gemfile.lock
 pkg/*
 lib/demo.rb
-.rvmrc
+.rvmrc
+coverage

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## Legato 0.2.0 ##
+
+*   Changed Query API for #metrics & #dimensions
+
+      If you add metrics and dimensions to a query, it will not modify the
+      parent (of the query) class's dimensions or metrics. Resolves issue #40.
+
+    *Tony Pitale*
+
+## Legato 0.1.0 ##
+
+*   Added dynamic segment support from @etiennebarrie
+*   Fixed some readme typos from PR by @juuso
+
 ## Legato 0.0.3 ##
 
 *   Merged branch oauth-1-support

data/legato.gemspec

@@ -28,6 +28,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "vcr", "2.0.0.beta2"
   s.add_development_dependency "fakeweb"
   s.add_development_dependency "oauth2"
+  s.add_development_dependency "simplecov"
 
   s.add_runtime_dependency "multi_json"
 end

data/lib/legato/list_parameter.rb

@@ -25,5 +25,9 @@ module Legato
     def ==(other)
       name == other.name && elements == other.elements
     end
+
+    def include?(element)
+      @elements.include?(element)
+    end
   end
 end

data/lib/legato/query.rb

@@ -172,11 +172,11 @@ module Legato
     # end
 
     def metrics
-      parent_klass.metrics
+      @metrics ||= parent_klass.metrics.dup
     end
 
     def dimensions
-      parent_klass.dimensions
+      @dimensions ||= parent_klass.dimensions.dup
     end
 
     def sort=(arr)

data/lib/legato/version.rb

@@ -1,3 +1,3 @@
 module Legato
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/lib/legato/query_spec.rb

@@ -18,6 +18,7 @@ describe Legato::Query do
   context "a query" do
     before :each do
       @klass = Class.new
+      @klass.extend(Legato::Model)
       @block = lambda {eql(:key, 1000)}
       @klass.stubs(:filters).returns({:high => @block})
       @klass.stubs(:segments).returns([])
@@ -131,6 +132,34 @@ describe Legato::Query do
       @query.should have_received(:apply_options).with({:sort => [:city]})
     end
 
+    context "when modifying dimensions" do
+      it 'changes the query dimensions' do
+        @query.dimensions << :city
+        @query.dimensions.include?(:city).should be_true
+      end
+
+      it 'does not change the parent class dimensions' do
+        empty_dimensions = Legato::ListParameter.new(:dimensions, [])
+
+        @query.dimensions << :city
+        @klass.dimensions.should eq(empty_dimensions)
+      end
+    end
+
+    context "when modifying metrics" do
+      it 'changes the query metrics' do
+        @query.metrics << :pageviews
+        @query.metrics.include?(:pageviews).should be_true
+      end
+
+      it 'does not change the parent class metrics' do
+        empty_metrics = Legato::ListParameter.new(:metrics, [])
+
+        @query.metrics << :pageviews
+        @klass.metrics.should eq(empty_metrics)
+      end
+    end
+
     context 'when applying filters' do
       before :each do
         @filter = Legato::Filter.new(:key, :eql, 1000, nil)

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
+require 'simplecov'
+SimpleCov.start
+
 require 'bundler/setup'
 
 require 'rspec'
@@ -19,4 +22,6 @@ RSpec.configure do |config|
 
   config.extend VCR::RSpec::Macros
   config.include Support::Macros::OAuth
+
+  config.order = 'random'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: legato
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-19 00:00:00.000000000 Z
+date: 2013-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -123,6 +123,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement