leftovers 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b87286f8934cc673a0c9ccea260ac5bee0117230cf21917d244eb6988b70aede
-  data.tar.gz: c2daf36aaec3ffe393e4adab37bc80ba8bb5a5ffed2f1c94977a3138bbecde05
+  metadata.gz: b371d523daccdf78bc7c31a0b17256299029e95aa6d9d14a3578ac42929ee08d
+  data.tar.gz: 6798582ea10ea250ea68fc0325564e116fa2d317416d0df0b02a7d2e8235849a
 SHA512:
-  metadata.gz: aca4a439cdbf92fbf6589bf2b9459d209e8ea3affd75bf432648110b58845870f06f80b9815bd1a5404e995a1f4a576885291cffbd1390d45c38f3ff658b9185
-  data.tar.gz: 464a65edd31f10324be77be82b5d28c3632b7b0f691e6268903d9b00190bed3e7c553f6301760c9222dceda12d62e4dba7e927d7dd717300b6effac3e57c790c
+  metadata.gz: b38f49be63e8d7ba2e63a3c5a7bbddd8d61692dc603da0d2f0b936fdb02f421b357a8b2a089100e8dd3e21b50b6acc21668dd7aa1f472b721d25fe6d4655b4fe
+  data.tar.gz: f015305d13562b66a33b4f4effc680784bf8a8d24b3d7e143a2a6d2c20285ae47377867ea22cad995e9dd467b5d86064afbc78becd6d55424b0ee96c4a54737b

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+# v0.2.1
+
+- Fix route arguments with '/' handling (e.g get `'/admin', to: 'admin/dashboard#index'`)
+- Fix route arguments for `root to: "whatever#index"`
+- Add some more rails exceptions (`APP_ROOT`, `APP_PATH`, Mailer Previews)
+- add more ruby object methods that are called by various bits of ruby
+- correct output of unused definitions using `linked_transforms:`
+- add `audited` gem
+
 # v0.2.0
 
 Play nice with rubocop

data/lib/config/audited.yml

@@ -0,0 +1,4 @@
+rules:
+  name: current_user_method=
+  calls:
+    argument: 1

data/lib/config/rails.yml

@@ -18,10 +18,16 @@ rules:
       - validate_each # ActiveModel::EachValidator
       - format_message # ActiveSupport::Logger
       - ssl_configured? # ApplicationController
+      - APP_PATH
+      - APP_ROOT
   - skip: true
     names:
       has_suffix: Helper
     path: /app/helpers
+  - skip: true
+    names:
+      has_suffix: Preview
+    path: '**/mailers/previews/**/*_preview.rb'
   - names:
       - after_initialize
       - after_find
@@ -227,6 +233,7 @@ rules:
       - patch
       - post
       - put
+      - root
     calls:
       - arguments: [1, action]
       - argument: '**'

data/lib/config/ruby.yml

@@ -17,12 +17,18 @@ rules:
   - skip: true
     name:
       - initialize # called by new
-      - inspect # called by repl
+      - inspect # called by repl, to_s
       - respond_to_missing? # called by respond_to?
       - method_missing # called by method dispatch
-      - to_s # called by #{}
-      - to_ary
-      - to_str
+      - coerce # called by Numeric
+      - to_s # called by "#{}"
+      - to_ary # called by Array(), []+
+      - to_a # called by Array(), *splat
+      - to_str # called by String(), ""+
+      - to_hash # called by Hash(), **splat, {}.merge
+      - to_int # called by Integer()
+      - to_i # called by Integer()
+      - to_f # called by Float()
       - <=> # called by Comparable
       - each # called by Enumerable
       - marshal_dump # called by Marshal.dump
@@ -33,6 +39,10 @@ rules:
       - extended # called by extend Module
       - included # called by include Module
       - $VERBOSE # called by whatever is outputting warnings i guess
+      - === # called by when
+      - == # called by Array value, Hash value equality, ===
+      - hash # called by Hash key equality
+      - eql? # called by Hash key equality
   - name:
       - send
       - public_send

data/lib/leftovers/argument_rule.rb

@@ -176,7 +176,8 @@ module Leftovers
 
     SPLIT = /[.:]+/.freeze
     def symbol_values(symbol_node, method_node) # rubocop:disable Metrics/MethodLength
-      subnodes = symbol_node.to_s.split(SPLIT).flat_map { |s| transform(s, method_node) }
+      subnodes = Array(transform(symbol_node.to_s, method_node))
+        .flat_map { |s| s.to_s.split(SPLIT).map(&:to_sym) }
 
       return subnodes unless @definer
 
@@ -199,7 +200,7 @@ module Leftovers
     end
 
     def transform(string, method_node)
-      return string.to_sym unless @transform || @transforms
+      return string unless @transform || @transforms
       return @transform.transform(string, method_node) if @transform
 
       @transforms.map do |transform|

data/lib/leftovers/definition_set.rb

@@ -21,6 +21,10 @@ module Leftovers
       freeze
     end
 
+    def full_name
+      names.join(', ')
+    end
+
     def names
       @definitions.map(&:names)
     end

data/lib/leftovers/file_collector.rb

@@ -2,14 +2,11 @@
 
 require 'fast_ignore'
 require 'set'
-require 'parser'
-require 'parser/current'
-require_relative 'ast/builder'
-require_relative 'ast/node'
+require_relative 'parser'
 require_relative 'definition'
 
 module Leftovers
-  class FileCollector < Parser::AST::Processor # rubocop:disable Metrics/ClassLength
+  class FileCollector < ::Parser::AST::Processor # rubocop:disable Metrics/ClassLength
     attr_reader :calls
     attr_reader :definitions
 
@@ -34,33 +31,8 @@ module Leftovers
       }
     end
 
-    # mostly copied from https://github.com/whitequark/parser/blob/master/lib/parser/base.rb
-    # but with our builder
-    def self.parser # rubocop:disable Metrics/MethodLength
-      p = ::Parser::CurrentRuby.new(Leftovers::AST::Builder.new)
-      p.diagnostics.all_errors_are_fatal = true
-      p.diagnostics.ignore_warnings = true
-
-      p.diagnostics.consumer = lambda do |diagnostic|
-        warn(diagnostic.render)
-      end
-
-      p
-    end
-    PARSER = parser
-
-    # mostly copied from https://github.com/whitequark/parser/blob/master/lib/parser/base.rb
-    # but with our parser
-    def parse_with_comments(string, file = '(string)', line = 1)
-      PARSER.reset
-      source_buffer = ::Parser::CurrentRuby.send(
-        :setup_source_buffer, file, line, string, PARSER.default_encoding
-      )
-      PARSER.parse_with_comments(source_buffer)
-    end
-
     def collect
-      ast, comments = parse_with_comments(@ruby, @file)
+      ast, comments = Leftovers::Parser.parse_with_comments(@ruby, @file)
       process_comments(comments)
       process(ast)
     rescue Parser::SyntaxError => e

data/lib/leftovers/parser.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require 'parser'
+require 'parser/current'
+
+require_relative 'ast/builder'
+require_relative 'ast/node'
+
+module Leftovers
+  module Parser
+    class << self
+      # mostly copied from https://github.com/whitequark/parser/blob/master/lib/parser/base.rb
+      # but with our parser
+      def parse_with_comments(string, file = '(string)', line = 1)
+        PARSER.reset
+        source_buffer = ::Parser::CurrentRuby.send(
+          :setup_source_buffer, file, line, string, PARSER.default_encoding
+        )
+        PARSER.parse_with_comments(source_buffer)
+      end
+
+      private
+
+      # mostly copied from https://github.com/whitequark/parser/blob/master/lib/parser/base.rb
+      # but with our builder
+      def parser # rubocop:disable Metrics/MethodLength
+        p = ::Parser::CurrentRuby.new(Leftovers::AST::Builder.new)
+        p.diagnostics.all_errors_are_fatal = true
+        p.diagnostics.ignore_warnings = true
+
+        p.diagnostics.consumer = lambda do |diagnostic|
+          warn(diagnostic.render)
+        end
+
+        p
+      end
+    end
+    PARSER = parser
+  end
+end

data/lib/leftovers/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Leftovers
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: leftovers
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Dana Sherson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-19 00:00:00.000000000 Z
+date: 2020-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -207,6 +207,7 @@ files:
 - exe/leftovers
 - leftovers.gemspec
 - lib/config/attr_encrypted.yml
+- lib/config/audited.yml
 - lib/config/builder.yml
 - lib/config/capistrano.yml
 - lib/config/datagrid.yml
@@ -247,6 +248,7 @@ files:
 - lib/leftovers/hash_rule.rb
 - lib/leftovers/merged_config.rb
 - lib/leftovers/name_rule.rb
+- lib/leftovers/parser.rb
 - lib/leftovers/rake_task.rb
 - lib/leftovers/reporter.rb
 - lib/leftovers/rule.rb