left_joins 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: df7ca5a2313f0d5b956fa812dcf528646ffd79b60d28421d6abfd9cebafdb891
-  data.tar.gz: 48265e1cd3b79d43e0c399fe6a1420126fe14d71b0f7a028344e6d739fc53e6c
+  metadata.gz: 96d6f9767a640b7ba9ce3b37443298771f1744dd74b77df7cf309996bf9fd52d
+  data.tar.gz: c2275de76d3c6355673cb09c41ea2adc5bfb6f91bf2b3c189eb9d464a337c416
 SHA512:
-  metadata.gz: 7b81a965effac0c35447cbc05e4a28e9ba70a4db17899516e15af7933d8565e02f082a1dd59c7f44165127c176b33fed08866576b48d09b638fb1c82fa530984
-  data.tar.gz: 9b1a1901c4c9e2b8b79698932394801e42de7839950140c36d0c684ab77967313684561d7db87f7ec65d330bedc63d32432d2b8f60de05c108dbb720ecafa248
+  metadata.gz: ad73bace7c184fabcecc0a05752ffff2393c08c82c8b3cfacb3d8b5407e6eab5bb9c5e329eece38c3194881c88576e9ca543638ff7cf638e0c944f2a8acda3a1
+  data.tar.gz: 93a6300e3b775b706320700ab87fbe4172ed818e06b5fd3eb7e958b22886fd105625410a22a720de6ce622ceefd26384caf242c5298a0ad9aad8ae1e08e2db35

data/.travis.yml

@@ -4,9 +4,9 @@ rvm:
   - 2.3
 sudo: required
 dist: trusty
-before_install: 
-  - gem install bundler
-  - gem update --system
+before_install:
+  - gem i rubygems-update -v '<3' && update_rubygems
+  - gem install bundler -v 1.17.3
   - gem --version
 gemfile:
   - gemfiles/3.2.gemfile

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 ## Change Log
 
+### [v1.0.4](https://github.com/khiav223577/left_joins/compare/v1.0.3...v1.0.4) 2018/07/18
+- [#7](https://github.com/khiav223577/left_joins/pull/7) Fix: eager_load is broken (@khiav223577)
+
 ### [v1.0.3](https://github.com/khiav223577/left_joins/compare/v1.0.2...v1.0.3) 2018/06/30
 - [#5](https://github.com/khiav223577/left_joins/pull/5) Fix: JoinDependency#make_constraints is not defined in Rails 4.0 (@khiav223577)
 

data/gemfiles/3.2.gemfile

@@ -5,6 +5,7 @@ gem "activerecord", "~> 3.2.0"
 group :test do
   gem "simplecov"
   gem "codeclimate-test-reporter", "~> 1.0.0"
+  gem "sqlite3", "~> 1.3.6"
 end
 
 gemspec :path => "../"

data/gemfiles/4.0.gemfile

@@ -5,6 +5,7 @@ gem "activerecord", "~> 4.0.0"
 group :test do
   gem "simplecov"
   gem "codeclimate-test-reporter", "~> 1.0.0"
+  gem "sqlite3", "~> 1.3.6"
 end
 
 gemspec :path => "../"

data/gemfiles/4.2.gemfile

@@ -5,6 +5,7 @@ gem "activerecord", "~> 4.2.0"
 group :test do
   gem "simplecov"
   gem "codeclimate-test-reporter", "~> 1.0.0"
+  gem "sqlite3", "~> 1.3.6"
 end
 
 gemspec :path => "../"

data/gemfiles/5.0.gemfile

@@ -5,6 +5,7 @@ gem "activerecord", "~> 5.0.0"
 group :test do
   gem "simplecov"
   gem "codeclimate-test-reporter", "~> 1.0.0"
+  gem "sqlite3", "~> 1.3.6"
 end
 
 gemspec :path => "../"

data/gemfiles/5.1.gemfile

@@ -5,6 +5,7 @@ gem "activerecord", "~> 5.1.0"
 group :test do
   gem "simplecov"
   gem "codeclimate-test-reporter", "~> 1.0.0"
+  gem "sqlite3", "~> 1.3.6"
 end
 
 gemspec :path => "../"

data/gemfiles/5.2.gemfile

@@ -5,6 +5,7 @@ gem "activerecord", "~> 5.2.0"
 group :test do
   gem "simplecov"
   gem "codeclimate-test-reporter", "~> 1.0.0"
+  gem "sqlite3", "~> 1.3.6"
 end
 
 gemspec :path => "../"

data/left_joins.gemspec

@@ -26,8 +26,11 @@ Gem::Specification.new do |spec|
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
+  spec.metadata = {
+    'changelog_uri' => 'https://github.com/khiav223577/left_joins/blob/master/CHANGELOG.md',
+  }
 
-  spec.add_development_dependency "bundler", "~> 1.11"
+  spec.add_development_dependency 'bundler', '>= 1.17', '< 3.x'
   spec.add_development_dependency "rake", "~> 12.0"
   spec.add_development_dependency "sqlite3", "~> 1.3"
   spec.add_development_dependency "minitest", ">= 4.2"

data/lib/left_joins.rb

@@ -12,7 +12,11 @@ module ActiveRecord::QueryMethods
     # ----------------------------------------------------------------
     # ● Storing left joins values into @left_outer_joins_values
     # ----------------------------------------------------------------
-    attr_accessor :left_outer_joins_values
+    attr_writer :left_outer_joins_values
+    def left_outer_joins_values
+      @left_outer_joins_values ||= []
+    end
+
     def left_outer_joins(*args)
       check_if_method_has_arguments!(:left_outer_joins, args)
 
@@ -24,7 +28,7 @@ module ActiveRecord::QueryMethods
     end
 
     def left_outer_joins!(*args)
-      (@left_outer_joins_values ||= []) << args
+      left_outer_joins_values.concat(args)
       self
     end
 
@@ -35,7 +39,7 @@ module ActiveRecord::QueryMethods
     alias_method :build_arel_without_outer_joins, :build_arel
     def build_arel(*args)
       arel = build_arel_without_outer_joins(*args)
-      build_left_outer_joins(arel, @left_outer_joins_values.flatten) if @left_outer_joins_values
+      build_left_outer_joins(arel, @left_outer_joins_values) if @left_outer_joins_values
       return arel
     end
 

data/lib/left_joins/version.rb

@@ -1,3 +1,3 @@
 module LeftJoins
-  VERSION = "1.0.4"
+  VERSION = "1.0.5"
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: left_joins
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - khiav reoy
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-18 00:00:00.000000000 Z
+date: 2019-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.17'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: 3.x
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.17'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: 3.x
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -124,7 +130,8 @@ files:
 homepage: https://github.com/khiav223577/left_joins
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/khiav223577/left_joins/blob/master/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths: