ledger_sync 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8aeb1fb1722b3457692a3a513ecd3dc419a3a489d00a24aa2839dfae6e5f203f
-  data.tar.gz: 66e5e8415a1c2bfb6c1c04f8210e046f3510390a0bf0768932d6120a1453bf8b
+  metadata.gz: 05667fe1a37dc8edfcb33121d2eb5f08ad076b8b635ecaaf33809b663c830f68
+  data.tar.gz: 3b3a6c68af8ecf2ce04a8f789854fb1002b3d90d5e747e71d398aa1b1b8b4c9f
 SHA512:
-  metadata.gz: 87bc80cc850ac858e3d448098d2acd8b1f7a502ec7e51126c1d9a52560aedc02dcd968069fbf9a9de0a86ebbc7b6c52f64ccf0a6c3cdc4fbe5bf390fdd4373af
-  data.tar.gz: 3b5e0d36361a0910acd74c4ae3de805c09ad14838cfc02eb458c8fc93069190f0633f4738fb549d1e3de0f92e1f6dd74110317f20d36c718d1352e3c1ba5f861
+  metadata.gz: 14cdebe2e5342838d44202fbe9b11c28e09a6e18ccbb4827145d0b098833c1549c9e922bd8760555708358058df74ff5574a46b91aa67d48f347a99d2e5a0129
+  data.tar.gz: 8a48a4251273a4aa7a2cca65cc1eaed38c87d385caa2aeb1c3eaf63c76f0d67bf5af3099dcb16a1c4df82517e79c3bd35c8b41584a1a5197a584bce5c951ca5f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ledger_sync (1.3.1)
+    ledger_sync (1.3.2)
       activemodel
       colorize
       coveralls

data/lib/ledger_sync/adaptors/ledger_serializer.rb

@@ -12,9 +12,9 @@ module LedgerSync
 
       attr_reader :resource
 
-      def initialize(resource:)
+      def initialize(ensure_inferred_resource_class: true, resource:)
         @resource = resource
-        ensure_inferred_resource_class!
+        ensure_inferred_resource_class! if ensure_inferred_resource_class
       end
 
       def attribute_value_from_ledger(hash:, ledger_serializer_attribute:, resource:)
@@ -28,7 +28,7 @@ module LedgerSync
         deserialize_into = resource.dup # Do not overwrite values in the resource
         hash = Util::HashHelpers.deep_stringify_keys(hash)
 
-        self.class.attributes.each do |ledger_serializer_attribute|
+        self.class.attributes.deserializable_attributes.each do |ledger_serializer_attribute|
           next unless ledger_serializer_attribute.resource_attribute?
 
           value = attribute_value_from_ledger(
@@ -49,7 +49,7 @@ module LedgerSync
       def to_ledger_hash(only_changes: false)
         ret = {}
 
-        self.class.attributes.each do |ledger_serializer_attribute|
+        self.class.attributes.serializable_attributes.each do |ledger_serializer_attribute|
           next if only_changes && !resource.attribute_changed?(ledger_serializer_attribute.resource_attribute)
 
           ret = Util::HashHelpers.deep_merge(
@@ -61,11 +61,20 @@ module LedgerSync
         ret
       end
 
-      def self.attribute(ledger_attribute:, resource_attribute: nil, type: LedgerSerializerType::ValueType, &block)
+      def self.attribute(
+        deserialize: true,
+        ledger_attribute:,
+        resource_attribute: nil,
+        serialize: true,
+        type: LedgerSerializerType::ValueType,
+        &block
+      )
         _attribute(
           block: (block if block_given?),
+          deserialize: deserialize,
           ledger_attribute: ledger_attribute,
           resource_attribute: resource_attribute,
+          serialize: serialize,
           type: type
         )
       end
@@ -83,6 +92,15 @@ module LedgerSync
         )
       end
 
+      def self.references_one(ledger_attribute:, resource_attribute:, serializer:)
+        _attribute(
+          ledger_attribute: ledger_attribute,
+          resource_attribute: resource_attribute,
+          serializer: serializer,
+          type: LedgerSerializerType::ReferencesOneType
+        )
+      end
+
       def self.id(ledger_attribute:, resource_attribute:, &block)
         @id ||= _attribute(
           block: (block if block_given?),
@@ -98,13 +116,25 @@ module LedgerSync
         )
       end
 
-      private_class_method def self._build_attribute(block: nil, id: false, ledger_attribute:, resource_attribute: nil, resource_class: nil, serializer: nil, type: LedgerSerializerType::ValueType)
+      private_class_method def self._build_attribute(
+        block: nil,
+        deserialize: true,
+        id: false,
+        ledger_attribute:,
+        resource_attribute: nil,
+        resource_class: nil,
+        serialize: true,
+        serializer: nil,
+        type: LedgerSerializerType::ValueType
+      )
         LedgerSerializerAttribute.new(
           id: id,
           block: block,
+          deserialize: deserialize,
           ledger_attribute: ledger_attribute,
           resource_attribute: resource_attribute,
           resource_class: resource_class,
+          serialize: serialize,
           serializer: serializer,
           type: type
         )

data/lib/ledger_sync/adaptors/ledger_serializer_attribute.rb

@@ -7,21 +7,35 @@ module LedgerSync
   module Adaptors
     class LedgerSerializerAttribute
       attr_reader :block,
+                  :deserialize,
                   :id,
                   :ledger_attribute,
                   :resource_attribute,
                   :resource_class,
+                  :serialize,
                   :serializer,
                   :type
 
-      def initialize(block: nil, id: false, ledger_attribute:, resource_attribute: nil, resource_class: nil, serializer: nil, type: LedgerSerializerType::ValueType)
+      def initialize(
+        block: nil,
+        deserialize: true,
+        id: false,
+        ledger_attribute:,
+        resource_attribute: nil,
+        resource_class: nil,
+        serialize: true,
+        serializer: nil,
+        type: LedgerSerializerType::ValueType
+      )
         raise 'block and resource_attribute cannot both be present' unless block.nil? || resource_attribute.nil?
 
         @block = block
+        @deserialize = deserialize
         @id = id
         @ledger_attribute = ledger_attribute.to_s
         @resource_attribute = resource_attribute.to_s
         @resource_class = resource_class
+        @serialize = serialize
         @serializer = serializer
         @type = type.new
       end
@@ -30,6 +44,10 @@ module LedgerSync
         block.call(resource)
       end
 
+      def deserialize?
+        deserialize
+      end
+
       # Make nested/dot calls (e.g. `vendor.ledger_id`)
       def dot_value_for(resource:)
         resource_attribute_dot_parts.inject(resource) { |r, dot_method| r&.send(dot_method) }
@@ -59,10 +77,18 @@ module LedgerSync
         ledger_attribute_dot_parts.reverse.inject(value) { |a, n| { n => a } }
       end
 
+      def reference?
+        references_many? || references_one?
+      end
+
       def references_many?
         type.is_a?(LedgerSerializerType::ReferencesManyType)
       end
 
+      def references_one?
+        type.is_a?(LedgerSerializerType::ReferencesOneType)
+      end
+
       def resource_attribute?
         resource_attribute.present?
       end
@@ -71,6 +97,10 @@ module LedgerSync
         @resource_attribute_dot_parts ||= resource_attribute.split('.')
       end
 
+      def serialize?
+        serialize
+      end
+
       def value_from_local(resource:)
         value = if block.nil?
                   dot_value_for(resource: resource)
@@ -78,7 +108,7 @@ module LedgerSync
                   block_value_for(resource: resource)
                 end
 
-        if references_many?
+        if reference?
           type.convert_from_local(
             serializer: serializer,
             value: value
@@ -93,7 +123,7 @@ module LedgerSync
       def value_from_ledger(hash:, resource:)
         value = hash.dig(*ledger_attribute_dot_parts)
 
-        value = if references_many?
+        value = if reference?
                   type.convert_from_ledger(
                     resource_class: resource_class,
                     serializer: serializer,

data/lib/ledger_sync/adaptors/ledger_serializer_attribute_set.rb

@@ -4,9 +4,11 @@ module LedgerSync
   module Adaptors
     class LedgerSerializerAttributeSet
       attr_reader :attributes,
+                  :deserializable_attributes,
                   :id_attribute,
                   :ledger_attribute_keyed_hash,
                   :resource_attribute_keyed_hash,
+                  :serializable_attributes,
                   :serializer_class
 
       delegate  :[],
@@ -17,8 +19,10 @@ module LedgerSync
 
       def initialize(serializer_class:)
         @attributes = []
+        @deserializable_attributes = []
         @ledger_attribute_keyed_hash = {}
         @resource_attribute_keyed_hash = {}
+        @serializable_attributes = []
         @serializer_class = serializer_class
       end
 
@@ -37,6 +41,9 @@ module LedgerSync
           resource_attribute_keyed_hash[attribute.resource_attribute.to_s] = attribute
         end
 
+        serializable_attributes << attribute if attribute.serialize?
+        deserializable_attributes << attribute if attribute.deserialize?
+
         # TODO: Can make this validate something like `expense.vendor.id`
         # raise "#{resource_attribute} is not an attribute of the resource #{_inferred_resource_class}" if !resource_attribute.nil? && !_inferred_resource_class.serialize_attribute?(resource_attribute)
 

data/lib/ledger_sync/adaptors/ledger_serializer_type/references_one_type.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module LedgerSync
+  module Adaptors
+    module LedgerSerializerType
+      class ReferencesOneType < ValueType
+        def convert_from_ledger(resource_class: nil, serializer:, value:)
+          return if value.nil?
+
+          resource_class ||= serializer.inferred_resource_class
+          serializer.new(resource: resource_class.new).deserialize(hash: value)
+        end
+
+        def convert_from_local(serializer:, value:)
+          return if value.nil?
+
+          serializer.new(resource: value).to_ledger_hash
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/adaptors/mixins/infer_ledger_serializer_mixin.rb

@@ -6,7 +6,7 @@ module LedgerSync
       module InferLedgerSerializerMixin
         module ClassMethods
           def inferred_ledger_serializer(resource:)
-            @inferred_ledger_serializer ||= inferred_ledger_serializer_class.new(
+            inferred_ledger_serializer_class.new(
               resource: resource
             )
           end

data/lib/ledger_sync/adaptors/netsuite/account/operations/create.rb

@@ -15,7 +15,7 @@ module LedgerSync
                 required(:account_type).maybe(:string)
                 required(:account_sub_type).maybe(:string)
                 required(:number).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/netsuite/account/operations/find.rb

@@ -15,7 +15,7 @@ module LedgerSync
                 required(:account_type).maybe(:string)
                 required(:account_sub_type).maybe(:string)
                 required(:number).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/quickbooks_online/account/ledger_serializer.rb

@@ -1,19 +1,35 @@
 # frozen_string_literal: true
 
+require_relative '../currency/ledger_serializer'
+
 module LedgerSync
   module Adaptors
     module QuickBooksOnline
       module Account
         class LedgerSerializer < QuickBooksOnline::LedgerSerializer
-          attribute ledger_attribute: 'Id', resource_attribute: :ledger_id
-          attribute ledger_attribute: 'Name', resource_attribute: :name
-          attribute ledger_attribute: 'AccountType', resource_attribute: :account_type, type: LedgerSerializerType::AccountType
-          attribute ledger_attribute: 'AccountSubType', resource_attribute: :account_sub_type, type: LedgerSerializerType::AccountSubType
-          attribute ledger_attribute: 'AcctNum', resource_attribute: :number
-          attribute ledger_attribute: 'CurrencyRef.value', resource_attribute: :currency
-          attribute ledger_attribute: 'Classification', resource_attribute: :classification, type: LedgerSerializerType::ClassificationType
-          attribute ledger_attribute: 'Description', resource_attribute: :description
-          attribute ledger_attribute: 'Active', resource_attribute: :active
+          attribute ledger_attribute: 'Id',
+                    resource_attribute: :ledger_id
+          attribute ledger_attribute: 'Name',
+                    resource_attribute: :name
+          attribute ledger_attribute: 'AccountType',
+                    resource_attribute: :account_type,
+                    type: LedgerSerializerType::AccountType
+          attribute ledger_attribute: 'AccountSubType',
+                    resource_attribute: :account_sub_type,
+                    type: LedgerSerializerType::AccountSubType
+          attribute ledger_attribute: 'AcctNum',
+                    resource_attribute: :number
+          attribute ledger_attribute: 'Classification',
+                    resource_attribute: :classification,
+                    type: LedgerSerializerType::ClassificationType
+          attribute ledger_attribute: 'Description',
+                    resource_attribute: :description
+          attribute ledger_attribute: 'Active',
+                    resource_attribute: :active
+
+          references_one ledger_attribute: :CurrencyRef,
+                         resource_attribute: :currency,
+                         serializer: Currency::LedgerSerializer
         end
       end
     end

data/lib/ledger_sync/adaptors/quickbooks_online/account/operations/create.rb

@@ -11,7 +11,7 @@ module LedgerSync
                 required(:account_type).filled(:string)
                 required(:active).maybe(:bool)
                 required(:classification).filled(:string)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:ledger_id).value(:nil)
                 required(:name).filled(:string)

data/lib/ledger_sync/adaptors/quickbooks_online/account/operations/find.rb

@@ -13,7 +13,7 @@ module LedgerSync
                 required(:account_type).maybe(:string)
                 required(:account_sub_type).maybe(:string)
                 required(:number).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/quickbooks_online/account/operations/update.rb

@@ -17,7 +17,7 @@ module LedgerSync
                 required(:account_type).filled(:string)
                 required(:account_sub_type).filled(:string)
                 required(:number).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/quickbooks_online/adaptor.rb

@@ -90,7 +90,7 @@ module LedgerSync
           request(
             headers: OAUTH_HEADERS.dup,
             method: :post,
-            body: payload.to_json,
+            body: payload,
             url: url
           )
         end

data/lib/ledger_sync/adaptors/quickbooks_online/bill/ledger_serializer.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../bill_line_item/ledger_serializer'
+require_relative '../currency/ledger_serializer'
 
 module LedgerSync
   module Adaptors
@@ -9,7 +10,9 @@ module LedgerSync
         class LedgerSerializer < QuickBooksOnline::LedgerSerializer
           id
 
-          attribute ledger_attribute: 'CurrencyRef.value', resource_attribute: :currency
+          references_one ledger_attribute: :CurrencyRef,
+                         resource_attribute: :currency,
+                         serializer: Currency::LedgerSerializer
 
           attribute ledger_attribute: 'DueDate',
                     resource_attribute: :due_date,

data/lib/ledger_sync/adaptors/quickbooks_online/bill/operations/create.rb

@@ -8,7 +8,7 @@ module LedgerSync
               params do
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
-                optional(:currency).filled(:string)
+                optional(:currency).hash(Types::Reference)
                 optional(:due_date).maybe(:date?)
                 optional(:ledger_id).value(:nil)
                 required(:line_items).array(Types::Reference)

data/lib/ledger_sync/adaptors/quickbooks_online/bill/operations/find.rb

@@ -8,7 +8,7 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
-                optional(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 optional(:due_date).maybe(:date?)
                 optional(:line_items).array(Types::Reference)
                 required(:ledger_id).filled(:string)

data/lib/ledger_sync/adaptors/quickbooks_online/bill/operations/update.rb

@@ -8,7 +8,7 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
-                optional(:currency).filled(:string)
+                optional(:currency).hash(Types::Reference)
                 optional(:due_date).maybe(:date?)
                 required(:line_items).array(Types::Reference)
                 required(:ledger_id).filled(:string)

data/lib/ledger_sync/adaptors/quickbooks_online/currency/ledger_serializer.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module LedgerSync
+  module Adaptors
+    module QuickBooksOnline
+      module Currency
+        class LedgerSerializer < QuickBooksOnline::LedgerSerializer
+          attribute ledger_attribute: :value,
+                    resource_attribute: :symbol
+
+          attribute ledger_attribute: :name,
+                    resource_attribute: :name
+        end
+      end
+    end
+  end
+end

data/lib/ledger_sync/adaptors/quickbooks_online/deposit/ledger_serializer.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../deposit_line_item/ledger_serializer'
+require_relative '../currency/ledger_serializer'
 
 module LedgerSync
   module Adaptors
@@ -9,8 +10,9 @@ module LedgerSync
         class LedgerSerializer < QuickBooksOnline::LedgerSerializer
           id
 
-          attribute ledger_attribute: 'CurrencyRef.value',
-                    resource_attribute: :currency
+          references_one ledger_attribute: :CurrencyRef,
+                         resource_attribute: :currency,
+                         serializer: Currency::LedgerSerializer
 
           attribute ledger_attribute: 'TxnDate',
                     resource_attribute: :transaction_date,

data/lib/ledger_sync/adaptors/quickbooks_online/deposit/operations/create.rb

@@ -9,7 +9,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 required(:ledger_id).value(:nil)
                 required(:account).hash(Types::Reference)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:department).hash(Types::Reference)
                 required(:memo).filled(:string)
                 required(:transaction_date).filled(:date?)

data/lib/ledger_sync/adaptors/quickbooks_online/deposit/operations/find.rb

@@ -9,7 +9,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:account).hash(Types::Reference)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:department).hash(Types::Reference)
                 required(:memo).maybe(:string)
                 required(:transaction_date).filled(:date?)

data/lib/ledger_sync/adaptors/quickbooks_online/deposit/operations/update.rb

@@ -11,7 +11,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 required(:ledger_id).filled(:string)
                 required(:account).hash(Types::Reference)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:department).hash(Types::Reference)
                 required(:memo).filled(:string)
                 required(:transaction_date).filled(:date?)

data/lib/ledger_sync/adaptors/quickbooks_online/expense/ledger_serializer.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../expense_line_item/ledger_serializer'
+require_relative '../currency/ledger_serializer'
 
 module LedgerSync
   module Adaptors
@@ -10,8 +11,9 @@ module LedgerSync
           id  ledger_attribute: 'Id',
               resource_attribute: :ledger_id
 
-          attribute ledger_attribute: 'CurrencyRef.value',
-                    resource_attribute: :currency
+          references_one ledger_attribute: :CurrencyRef,
+                          resource_attribute: :currency,
+                          serializer: Currency::LedgerSerializer
 
           attribute ledger_attribute: 'PaymentType',
                     resource_attribute: :payment_type,

data/lib/ledger_sync/adaptors/quickbooks_online/expense/operations/create.rb

@@ -8,7 +8,7 @@ module LedgerSync
               params do
                 required(:external_id).maybe(:string)
                 required(:account).hash(Types::Reference)
-                optional(:currency).filled(:string)
+                optional(:currency).hash(Types::Reference)
                 optional(:exchange_rate).maybe(:float)
                 optional(:ledger_id).value(:nil)
                 required(:line_items).array(Types::Reference)

data/lib/ledger_sync/adaptors/quickbooks_online/expense/operations/find.rb

@@ -8,7 +8,7 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
-                optional(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 optional(:exchange_rate).maybe(:float)
                 required(:ledger_id).filled(:string)
                 optional(:line_items).array(Types::Reference)

data/lib/ledger_sync/adaptors/quickbooks_online/expense/operations/update.rb

@@ -8,7 +8,7 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 required(:account).hash(Types::Reference)
-                optional(:currency).filled(:string)
+                optional(:currency).hash(Types::Reference)
                 optional(:exchange_rate).maybe(:float)
                 required(:ledger_id).filled(:string)
                 required(:line_items).array(Types::Reference)

data/lib/ledger_sync/adaptors/quickbooks_online/invoice/ledger_serializer.rb

@@ -9,8 +9,9 @@ module LedgerSync
         class LedgerSerializer < QuickBooksOnline::LedgerSerializer
           id
 
-          attribute ledger_attribute: 'CurrencyRef.value',
-                    resource_attribute: :currency
+          references_one ledger_attribute: :CurrencyRef,
+                         resource_attribute: :currency,
+                         serializer: Currency::LedgerSerializer
 
           attribute ledger_attribute: 'TxnDate',
                     resource_attribute: :transaction_date,

data/lib/ledger_sync/adaptors/quickbooks_online/invoice/operations/create.rb

@@ -10,7 +10,7 @@ module LedgerSync
               params do
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:customer).hash(Types::Reference)
                 optional(:deposit).maybe(:integer)
                 required(:ledger_id).value(:nil)

data/lib/ledger_sync/adaptors/quickbooks_online/invoice/operations/find.rb

@@ -8,7 +8,7 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
-                optional(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 optional(:customer).hash(Types::Reference)
                 optional(:deposit).maybe(:integer)
                 required(:ledger_id).filled(:string)

data/lib/ledger_sync/adaptors/quickbooks_online/invoice/operations/update.rb

@@ -8,7 +8,7 @@ module LedgerSync
               schema do
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:customer).hash(Types::Reference)
                 optional(:deposit).maybe(:integer)
                 required(:ledger_id).filled(:string)

data/lib/ledger_sync/adaptors/quickbooks_online/journal_entry/ledger_serializer.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative '../currency/ledger_serializer'
 require_relative '../journal_entry_line_item/ledger_serializer'
 
 module LedgerSync
@@ -9,8 +10,9 @@ module LedgerSync
         class LedgerSerializer < QuickBooksOnline::LedgerSerializer
           id
 
-          attribute ledger_attribute: 'CurrencyRef.value',
-                    resource_attribute: :currency
+          references_one ledger_attribute: :CurrencyRef,
+                         resource_attribute: :currency,
+                         serializer: Currency::LedgerSerializer
 
           attribute ledger_attribute: 'TxnDate',
                     resource_attribute: :transaction_date,

data/lib/ledger_sync/adaptors/quickbooks_online/journal_entry/operations/create.rb

@@ -7,7 +7,7 @@ module LedgerSync
             class Contract < LedgerSync::Adaptors::Contract
               params do
                 required(:external_id).maybe(:string)
-                optional(:currency).filled(:string)
+                optional(:currency).hash(Types::Reference)
                 required(:ledger_id).value(:nil)
                 optional(:line_items).array(Types::Reference)
                 optional(:memo).filled(:string)

data/lib/ledger_sync/adaptors/quickbooks_online/journal_entry/operations/find.rb

@@ -7,7 +7,7 @@ module LedgerSync
             class Contract < LedgerSync::Adaptors::Contract
               schema do
                 required(:external_id).maybe(:string)
-                optional(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:ledger_id).filled(:string)
                 optional(:line_items).array(Types::Reference)
                 optional(:memo).maybe(:string)

data/lib/ledger_sync/adaptors/quickbooks_online/journal_entry/operations/update.rb

@@ -7,7 +7,7 @@ module LedgerSync
             class Contract < LedgerSync::Adaptors::Contract
               schema do
                 required(:external_id).maybe(:string)
-                optional(:currency).filled(:string)
+                optional(:currency).hash(Types::Reference)
                 required(:ledger_id).filled(:string)
                 optional(:line_items).array(Types::Reference)
                 optional(:memo).filled(:string)

data/lib/ledger_sync/adaptors/quickbooks_online/ledger_serializer.rb

@@ -25,7 +25,7 @@ module LedgerSync
         def merge_resources_for_full_update(hash:, ledger_resource:)
           merged_resource = resource.dup
 
-          self.class.attributes.each do |ledger_serializer_attribute|
+          self.class.attributes.deserializable_attributes.each do |ledger_serializer_attribute|
             next unless ledger_serializer_attribute.references_many?
 
             resources_from_ledger = attribute_value_from_ledger(

data/lib/ledger_sync/adaptors/quickbooks_online/payment/ledger_serializer.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative '../currency/ledger_serializer'
 require_relative '../payment_line_item/ledger_serializer'
 
 module LedgerSync
@@ -13,8 +14,9 @@ module LedgerSync
                     resource_attribute: :amount,
                     type: LedgerSerializerType::AmountType
 
-          attribute ledger_attribute: 'CurrencyRef.value',
-                    resource_attribute: :currency
+          references_one ledger_attribute: :CurrencyRef,
+                         resource_attribute: :currency,
+                         serializer: Currency::LedgerSerializer
 
           attribute ledger_attribute: 'CustomerRef.value',
                     resource_attribute: 'customer.ledger_id'
@@ -39,8 +41,8 @@ module LedgerSync
                     type: LedgerSerializerType::DateType
 
           references_many ledger_attribute: 'Line',
-                    resource_attribute: :line_items,
-                    serializer: PaymentLineItem::LedgerSerializer
+                          resource_attribute: :line_items,
+                          serializer: PaymentLineItem::LedgerSerializer
         end
       end
     end

data/lib/ledger_sync/adaptors/quickbooks_online/payment/operations/create.rb

@@ -11,7 +11,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
                 required(:amount).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:customer).hash(Types::Reference)
                 optional(:deposit_account).hash(Types::Reference)
                 optional(:exchange_rate).maybe(:float)

data/lib/ledger_sync/adaptors/quickbooks_online/payment/operations/find.rb

@@ -9,7 +9,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
                 optional(:amount).maybe(:integer)
-                optional(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 optional(:customer).hash(Types::Reference)
                 optional(:deposit_account).hash(Types::Reference)
                 optional(:exchange_rate).maybe(:float)

data/lib/ledger_sync/adaptors/quickbooks_online/payment/operations/update.rb

@@ -9,7 +9,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
                 required(:amount).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:customer).hash(Types::Reference)
                 optional(:deposit_account).hash(Types::Reference)
                 optional(:exchange_rate).maybe(:float)

data/lib/ledger_sync/adaptors/quickbooks_online/request.rb

@@ -53,7 +53,7 @@ module LedgerSync
           oauth_response = oauth.send(
             method,
             url,
-            body: body,
+            body: (body.to_json unless body.nil?),
             headers: headers
           )
           ret = Response.new_from_oauth_response(

data/lib/ledger_sync/adaptors/quickbooks_online/transfer/ledger_serializer.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../currency/ledger_serializer'
+
 module LedgerSync
   module Adaptors
     module QuickBooksOnline
@@ -24,8 +26,9 @@ module LedgerSync
                     resource_attribute: :transaction_date,
                     type: LedgerSerializerType::DateType
 
-          attribute ledger_attribute: 'CurrencyRef.value',
-                    resource_attribute: 'currency'
+          references_one ledger_attribute: :CurrencyRef,
+                         resource_attribute: :currency,
+                         serializer: Currency::LedgerSerializer
         end
       end
     end

data/lib/ledger_sync/adaptors/quickbooks_online/transfer/operations/create.rb

@@ -11,7 +11,7 @@ module LedgerSync
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
                 required(:amount).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:memo).filled(:string)
                 required(:transaction_date).filled(:date?)
               end

data/lib/ledger_sync/adaptors/quickbooks_online/transfer/operations/find.rb

@@ -11,7 +11,7 @@ module LedgerSync
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
                 required(:amount).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:memo).maybe(:string)
                 required(:transaction_date).maybe(:date?)
               end

data/lib/ledger_sync/adaptors/quickbooks_online/transfer/operations/update.rb

@@ -13,7 +13,7 @@ module LedgerSync
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
                 required(:amount).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:memo).filled(:string)
                 required(:transaction_date).filled(:date?)
               end

data/lib/ledger_sync/adaptors/test/account/operations/create.rb

@@ -13,7 +13,7 @@ module LedgerSync
                 required(:account_type).filled(:string)
                 required(:account_sub_type).filled(:string)
                 required(:number).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/test/account/operations/find.rb

@@ -13,7 +13,7 @@ module LedgerSync
                 required(:account_type).maybe(:string)
                 required(:account_sub_type).maybe(:string)
                 required(:number).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/test/account/operations/invalid.rb

@@ -13,7 +13,7 @@ module LedgerSync
                 required(:account_type).maybe(:string)
                 required(:account_sub_type).maybe(:string)
                 required(:number).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/test/account/operations/update.rb

@@ -13,7 +13,7 @@ module LedgerSync
                 required(:account_type).filled(:string)
                 required(:account_sub_type).filled(:string)
                 required(:number).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/test/account/operations/valid.rb

@@ -13,7 +13,7 @@ module LedgerSync
                 required(:account_type).filled(:string)
                 required(:account_sub_type).filled(:string)
                 required(:number).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:description).maybe(:string)
                 required(:active).maybe(:bool)
               end

data/lib/ledger_sync/adaptors/test/expense/operations/create.rb

@@ -12,7 +12,7 @@ module LedgerSync
                 required(:ledger_id).value(:nil)
                 required(:account).hash(Types::Reference)
                 required(:entity).hash(Types::Reference)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:memo).filled(:string)
                 required(:payment_type).filled(:string)
                 required(:transaction_date).filled(:date?)

data/lib/ledger_sync/adaptors/test/expense/operations/find.rb

@@ -12,7 +12,7 @@ module LedgerSync
                 required(:ledger_id).filled(:string)
                 required(:account).hash(Types::Reference)
                 required(:entity).hash(Types::Reference)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:memo).maybe(:string)
                 required(:payment_type).maybe(:string)
                 required(:transaction_date).maybe(:date?)

data/lib/ledger_sync/adaptors/test/expense/operations/update.rb

@@ -10,7 +10,7 @@ module LedgerSync
                 required(:ledger_id).filled(:string)
                 required(:account).hash(Types::Reference)
                 required(:entity).hash(Types::Reference)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:memo).filled(:string)
                 required(:payment_type).filled(:string)
                 required(:transaction_date).filled(:date?)

data/lib/ledger_sync/adaptors/test/payment/operations/create.rb

@@ -9,7 +9,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
                 required(:amount).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:customer).hash(Types::Reference)
                 optional(:deposit_account).hash(Types::Reference)
                 optional(:exchange_rate).maybe(:float)

data/lib/ledger_sync/adaptors/test/payment/operations/find.rb

@@ -9,7 +9,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
                 optional(:amount).maybe(:integer)
-                optional(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 optional(:customer).hash(Types::Reference)
                 optional(:deposit_account).hash(Types::Reference)
                 optional(:exchange_rate).maybe(:float)

data/lib/ledger_sync/adaptors/test/payment/operations/update.rb

@@ -9,7 +9,7 @@ module LedgerSync
                 required(:external_id).maybe(:string)
                 optional(:account).hash(Types::Reference)
                 required(:amount).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:customer).hash(Types::Reference)
                 optional(:deposit_account).hash(Types::Reference)
                 optional(:exchange_rate).maybe(:float)

data/lib/ledger_sync/adaptors/test/transfer/operations/create.rb

@@ -11,7 +11,7 @@ module LedgerSync
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
                 required(:amount).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:memo).filled(:string)
                 required(:transaction_date).filled(:date?)
               end

data/lib/ledger_sync/adaptors/test/transfer/operations/find.rb

@@ -11,7 +11,7 @@ module LedgerSync
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
                 required(:amount).maybe(:integer)
-                required(:currency).maybe(:string)
+                required(:currency).maybe(:hash, Types::Reference)
                 required(:memo).maybe(:string)
                 required(:transaction_date).maybe(:date?)
               end

data/lib/ledger_sync/adaptors/test/transfer/operations/update.rb

@@ -11,7 +11,7 @@ module LedgerSync
                 required(:from_account).hash(Types::Reference)
                 required(:to_account).hash(Types::Reference)
                 required(:amount).filled(:integer)
-                required(:currency).filled(:string)
+                required(:currency).filled(:hash, Types::Reference)
                 required(:memo).filled(:string)
                 required(:transaction_date).filled(:date?)
               end

data/lib/ledger_sync/resources/account.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative 'currency'
+
 module LedgerSync
   class Account < LedgerSync::Resource
     attribute :name, type: Type::String
@@ -7,8 +9,9 @@ module LedgerSync
     attribute :account_type, type: Type::String
     attribute :account_sub_type, type: Type::String
     attribute :number, type: Type::String
-    attribute :currency, type: Type::String
     attribute :description, type: Type::String
     attribute :active, type: Type::Boolean
+
+    references_one :currency, to: Currency
   end
 end

data/lib/ledger_sync/resources/bill.rb

@@ -2,11 +2,11 @@
 
 require_relative 'account'
 require_relative 'bill_line_item'
+require_relative 'currency'
 require_relative 'vendor'
 
 module LedgerSync
   class Bill < LedgerSync::Resource
-    attribute :currency, type: Type::String
     attribute :memo, type: Type::String
     attribute :transaction_date, type: Type::Date
     attribute :due_date, type: Type::Date
@@ -14,6 +14,7 @@ module LedgerSync
 
     references_one :vendor, to: Vendor
     references_one :account, to: Account
+    references_one :currency, to: Currency
 
     references_many :line_items, to: BillLineItem
 

data/lib/ledger_sync/resources/deposit.rb

@@ -1,18 +1,19 @@
 # frozen_string_literal: true
 
 require_relative 'account'
+require_relative 'currency'
 require_relative 'department'
 require_relative 'deposit_line_item'
 
 module LedgerSync
   class Deposit < LedgerSync::Resource
-    attribute :currency, type: Type::String
     attribute :memo, type: Type::String
     attribute :transaction_date, type: Type::Date
     attribute :exchange_rate, type: Type::Float
 
     references_one :account, to: Account
     references_one :department, to: Department
+    references_one :currency, to: Currency
 
     references_many :line_items, to: DepositLineItem
 

data/lib/ledger_sync/resources/expense.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
 require_relative 'account'
+require_relative 'currency'
 require_relative 'customer'
 require_relative 'expense_line_item'
 require_relative 'vendor'
 
 module LedgerSync
   class Expense < LedgerSync::Resource
-    attribute :currency, type: Type::String
     attribute :memo, type: Type::String
     attribute :payment_type, type: Type::String
     attribute :transaction_date, type: Type::Date
@@ -16,6 +16,7 @@ module LedgerSync
 
     references_one :entity, to: [Customer, Vendor]
     references_one :account, to: Account
+    references_one :currency, to: Currency
 
     references_many :line_items, to: ExpenseLineItem
 
@@ -24,7 +25,7 @@ module LedgerSync
     end
 
     def name
-      "Purchase: #{amount} #{currency}"
+      "Purchase: #{amount} #{currency.try(:symbol)}"
     end
   end
 end

data/lib/ledger_sync/resources/invoice.rb

@@ -1,18 +1,19 @@
 # frozen_string_literal: true
 
 require_relative 'account'
+require_relative 'currency'
 require_relative 'customer'
 require_relative 'invoice_sales_line_item'
 
 module LedgerSync
   class Invoice < LedgerSync::Resource
-    attribute :currency, type: Type::String
     attribute :memo, type: Type::String
     attribute :transaction_date, type: Type::Date
     attribute :deposit, type: Type::Integer
 
     references_one :customer, to: Customer
     references_one :account, to: Account
+    references_one :currency, to: Currency
 
     references_many :line_items, to: InvoiceSalesLineItem
 

data/lib/ledger_sync/resources/journal_entry.rb

@@ -1,14 +1,16 @@
 # frozen_string_literal: true
 
+require_relative 'currency'
 require_relative 'journal_entry_line_item'
 
 module LedgerSync
   class JournalEntry < LedgerSync::Resource
-    attribute :currency, type: Type::String
     attribute :memo, type: Type::String
     attribute :transaction_date, type: Type::Date
     attribute :reference_number, type: Type::String
 
+    references_one :currency, to: Currency
+
     references_many :line_items, to: JournalEntryLineItem
 
     def name

data/lib/ledger_sync/resources/payment.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
 require_relative 'account'
+require_relative 'currency'
 require_relative 'customer'
 require_relative 'payment_line_item'
 
 module LedgerSync
   class Payment < LedgerSync::Resource
     attribute :amount, type: Type::Integer
-    attribute :currency, type: Type::String
     attribute :memo, type: Type::String
     attribute :transaction_date, type: Type::Date
     attribute :exchange_rate, type: Type::Float
@@ -16,6 +16,7 @@ module LedgerSync
     references_one :customer, to: Customer
     references_one :deposit_account, to: Account
     references_one :account, to: Account
+    references_one :currency, to: Currency
 
     references_many :line_items, to: PaymentLineItem
 

data/lib/ledger_sync/resources/transfer.rb

@@ -1,16 +1,17 @@
 # frozen_string_literal: true
 
 require_relative 'account'
+require_relative 'currency'
 
 module LedgerSync
   class Transfer < LedgerSync::Resource
-    attribute :currency, type: Type::String
     attribute :amount, type: Type::Integer
     attribute :memo, type: Type::String
     attribute :transaction_date, type: Type::Date
 
     references_one :from_account, to: Account
     references_one :to_account, to: Account
+    references_one :currency, to: Currency
 
     def name
       "Transaction: #{amount} #{currency}"

data/lib/ledger_sync/version.rb

@@ -1,3 +1,3 @@
 module LedgerSync
-  VERSION = '1.3.1'.freeze
+  VERSION = '1.3.2'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ledger_sync
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Ryan Jackson
@@ -413,6 +413,7 @@ files:
 - lib/ledger_sync/adaptors/ledger_serializer_attribute_set.rb
 - lib/ledger_sync/adaptors/ledger_serializer_type/mapping_type.rb
 - lib/ledger_sync/adaptors/ledger_serializer_type/references_many_type.rb
+- lib/ledger_sync/adaptors/ledger_serializer_type/references_one_type.rb
 - lib/ledger_sync/adaptors/ledger_serializer_type/value_type.rb
 - lib/ledger_sync/adaptors/mixins/infer_adaptor_class_mixin.rb
 - lib/ledger_sync/adaptors/mixins/infer_ledger_serializer_mixin.rb
@@ -481,6 +482,7 @@ files:
 - lib/ledger_sync/adaptors/quickbooks_online/bill/searcher.rb
 - lib/ledger_sync/adaptors/quickbooks_online/bill_line_item/ledger_serializer.rb
 - lib/ledger_sync/adaptors/quickbooks_online/config.rb
+- lib/ledger_sync/adaptors/quickbooks_online/currency/ledger_serializer.rb
 - lib/ledger_sync/adaptors/quickbooks_online/customer/ledger_serializer.rb
 - lib/ledger_sync/adaptors/quickbooks_online/customer/operations/create.rb
 - lib/ledger_sync/adaptors/quickbooks_online/customer/operations/find.rb