learn-open 1.2.26 → 1.2.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a5051e016deae305afb850fb1e2a9e0bc8cec075b99a061bf474eab8b91be57a
-  data.tar.gz: 7442920700a29f28b714220e6ad46975f3149af89851930630b9fa36abca1549
+  metadata.gz: eed604cd38477a398c08a0f865919e776f63db144f9e447af7af398c6b12f0f5
+  data.tar.gz: 80de4e7cc2e539d87e866eb7ab1c87fee136787d68387edd67fb092fdcaa377e
 SHA512:
-  metadata.gz: 437805ba9ef05fffb211425b034c9d99097e17e28b4bfb8b85fb134555805488ded5002a05926628f358232cf1e211d720720ddca31a183ca7e5b946b7a8e619
-  data.tar.gz: 431ac6bb126c11041caa15e7a663d0283439c7ad6db4ca69e241ebf847e7b40454e178fb94c929fc441799c9e4e2f8483382037a02e128a676750a01606f6186
+  metadata.gz: 364185f316c52cbf5f92e83806ec846a5a59ef701774c03613a4efd421fe80b3aef4d382dd22d9f36c4e57dbbdcdb9dddc0c21a2d422c45c930c1fcf9ea5b0b5
+  data.tar.gz: 14e9684582c1afe07b72e509280979e4e9c20dbe8d6d12bb368646ab391163ea137a67362345f6c0d67d8fb68bf81bb93f763d20fd4867b6f0dc353fb276262e

data/lib/learn_open/adapters/system_adapter.rb

@@ -11,10 +11,6 @@ module LearnOpen
         exec("#{shell} -l")
       end
 
-      def self.watch_dir(dir, action)
-        spawn("while inotifywait -qre create,delete,move,close_write --exclude \"#{excluded_dirs}\" #{dir}; do #{action}; done")
-      end
-
       def self.spawn(command, block: false)
         pid = Process.spawn(command, [:out, :err] => File::NULL)
         Process.waitpid(pid) if block

data/lib/learn_open/environments/base_environment.rb

@@ -65,16 +65,6 @@ module LearnOpen
         logger.log("Done.")
         io.puts "Done."
       end
-
-      def warn_if_necessary(lesson)
-        return unless lesson.later_lesson
-
-        io.puts 'WARNING: You are attempting to open a lesson that is beyond your current lesson.'
-        io.print 'Are you sure you want to continue? [Y/n]: '
-
-        warn_response = io.gets.chomp.downcase
-        exit if !['yes', 'y'].include?(warn_response)
-      end
     end
   end
 end

data/lib/learn_open/environments/ide_environment.rb

@@ -7,7 +7,6 @@ module LearnOpen
 
       def open_readme(lesson)
         when_valid(lesson) do
-          warn_if_necessary(lesson)
           io.puts "Opening readme..."
           run_custom_command(:browser_open, {url: lesson.to_url})
         end
@@ -15,7 +14,6 @@ module LearnOpen
 
       def open_jupyter_lab(lesson, location, editor, _clone_only)
         when_valid(lesson) do
-          warn_if_necessary(lesson)
           io.puts "Opening Jupyter Lesson..."
           run_custom_command(:browser_open, {url: lesson.to_url})
         end
@@ -23,7 +21,6 @@ module LearnOpen
 
       def open_lab(lesson, location, editor, clone_only)
         when_valid(lesson) do
-          warn_if_necessary(lesson)
           case lesson
           when LearnOpen::Lessons::IosLesson
             super

data/lib/learn_open/environments/linux_environment.rb

@@ -2,13 +2,11 @@ module LearnOpen
   module Environments
     class LinuxEnvironment < BaseEnvironment
       def open_readme(lesson)
-        warn_if_necessary(lesson)
         io.puts "Opening readme..."
         system_adapter.run_command("xdg-open #{lesson.to_url}")
       end
 
       def open_jupyter_lab(lesson, location, _editor, _clone_only)
-        warn_if_necessary(lesson)
         io.puts "Opening Jupyter Lesson..."
         system_adapter.run_command("xdg-open #{lesson.to_url}")
       end

data/lib/learn_open/environments/mac_environment.rb

@@ -14,13 +14,11 @@ module LearnOpen
       end
 
       def open_readme(lesson)
-        warn_if_necessary(lesson)
         io.puts "Opening readme..."
         system_adapter.run_command("open -a Safari #{lesson.to_url}")
       end
 
       def open_lab(lesson, location, editor, clone_only)
-        warn_if_necessary(lesson)
         case lesson
         when LearnOpen::Lessons::IosLesson
           download_lesson(lesson, location)
@@ -33,7 +31,6 @@ module LearnOpen
       end
 
       def open_jupyter_lab(lesson, location, editor, _clone_only)
-        warn_if_necessary(lesson)
         io.puts "Opening Jupyter Lesson..."
         system_adapter.run_command("open -a Safari #{lesson.to_url}")
       end
@@ -59,13 +56,11 @@ module LearnOpen
 
     class MacWithChromeEnvironment < MacEnvironment
       def open_readme(lesson)
-        warn_if_necessary(lesson)
         io.puts "Opening readme..."
         system_adapter.run_command("open -a 'Google Chrome' #{lesson.to_url}")
       end
 
       def open_jupyter_lab(lesson, location, _editor, _clone_only)
-        warn_if_necessary(lesson)
         io.puts "Opening Jupyter Lesson..."
         system_adapter.run_command("open -a 'Google Chrome' #{lesson.to_url}")
       end

data/lib/learn_open/services/file_backup_starter.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
 module LearnOpen
   class FileBackupStarter
+    BACKUP_LAB_PROCESS = "tail -f ~/inotify.log | while read change do; backup-lab; done"
+
     attr_reader :lesson, :location, :system_adapter
 
     def self.call(lesson, location, options)
@@ -14,7 +17,7 @@ module LearnOpen
 
     def call
       system_adapter.spawn("restore-lab", block: true)
-      system_adapter.watch_dir("#{lesson.to_path}", "backup-lab")
+      system_adapter.spawn(BACKUP_LAB_PROCESS)
     end
   end
 end

data/lib/learn_open/version.rb

@@ -1,3 +1,3 @@
 module LearnOpen
-  VERSION = '1.2.26'
+  VERSION = '1.2.27'
 end

data/spec/learn_open/environments/ide_environment_spec.rb

@@ -118,8 +118,8 @@ describe LearnOpen::Environments::IDEEnvironment do
         .to receive(:spawn)
         .with("restore-lab", {:block=>true})
       expect(system_adapter)
-        .to receive(:watch_dir)
-        .with("/home/bobby", "backup-lab")
+        .to receive(:spawn)
+        .with(LearnOpen::FileBackupStarter::BACKUP_LAB_PROCESS)
       expect(system_adapter)
         .to receive(:open_login_shell)
         .with("/usr/local/fish")

data/spec/learn_open/environments/jupyter_container_environment_spec.rb

@@ -83,8 +83,8 @@ describe LearnOpen::Environments::JupyterContainerEnvironment do
         .to receive(:spawn)
         .with("restore-lab", {:block=>true})
       expect(system_adapter)
-        .to receive(:watch_dir)
-        .with("/home/bobby", "backup-lab")
+        .to receive(:spawn)
+        .with(LearnOpen::FileBackupStarter::BACKUP_LAB_PROCESS)
       expect(system_adapter)
         .to receive(:open_login_shell)
         .with("/usr/local/fish")

data/spec/learn_open/opener_spec.rb

@@ -119,8 +119,8 @@ describe LearnOpen::Opener do
           .to receive(:spawn)
           .with('restore-lab', block: true)
         expect(system_adapter)
-          .to receive(:watch_dir)
-          .with("/home/bobby/Development/code/ruby_lab", "backup-lab")
+          .to receive(:spawn)
+          .with(LearnOpen::FileBackupStarter::BACKUP_LAB_PROCESS)
         expect(system_adapter)
           .to receive(:run_command)
           .with("bundle install")
@@ -142,7 +142,7 @@ describe LearnOpen::Opener do
           "IDE_CONTAINER" => "true",
           "IDE_VERSION" => "3"
         }
-        allow(system_adapter).to receive_messages([:spawn, :watch_dir])
+        allow(system_adapter).to receive_messages([:spawn, :spawn])
 
         home_dir = create_linux_home_dir("bobby")
         opener = LearnOpen::Opener.new(nil, "atom", true, false,
@@ -156,72 +156,6 @@ describe LearnOpen::Opener do
         expect(File.exist?("#{home_dir}/.custom_commands.log")).to eq(false)
       end
 
-      it "does not prompt if they want to skip lesson if the container is for a different lab" do
-        environment = {
-          "SHELL" => "/usr/local/bin/fish",
-          "LAB_NAME" => "Something wild",
-          "CREATED_USER" => "bobby",
-          "IDE_CONTAINER" => "true",
-          "IDE_VERSION" => "3"
-        }
-        io = instance_double(LearnOpen::Adapters::IOAdapter)
-        expect(io)
-          .to receive(:puts)
-          .with("Looking for lesson...")
-
-        expect(io)
-          .to receive(:puts)
-          .with("Opening new window")
-
-        create_linux_home_dir("bobby")
-        opener = LearnOpen::Opener.new("later_lesson", "atom", true, false,
-                                       learn_web_client: learn_web_client,
-                                       git_adapter: git_adapter,
-                                       environment_vars: environment,
-                                       system_adapter: system_adapter,
-                                       git_ssh_connector: git_ssh_connector,
-                                       io: io)
-        opener.run
-      end
-      it "prompts if they want to skip lesson" do
-        environment = {
-          "SHELL" => "/usr/local/bin/fish",
-          "LAB_NAME" => "later_lesson",
-          "CREATED_USER" => "bobby",
-          "IDE_CONTAINER" => "true",
-          "IDE_VERSION" => "3"
-        }
-        io = instance_double(LearnOpen::Adapters::IOAdapter)
-        expect(io)
-          .to receive(:puts)
-          .with("Looking for lesson...")
-
-        expect(io)
-          .to receive(:puts)
-          .with("WARNING: You are attempting to open a lesson that is beyond your current lesson.")
-
-        expect(io)
-          .to receive(:print)
-          .with("Are you sure you want to continue? [Y/n]: ")
-
-        expect(io)
-          .to receive(:gets)
-          .and_return("yes")
-
-        expect(io)
-          .to receive(:puts)
-          .with("Opening readme...")
-
-        create_linux_home_dir("bobby")
-        opener = LearnOpen::Opener.new("later_lesson", "atom", true, false,
-                                       learn_web_client: learn_web_client,
-                                       git_adapter: git_adapter,
-                                       environment_vars: environment,
-                                       system_adapter: system_adapter,
-                                       git_ssh_connector: git_ssh_connector,
-                                       io: io)
-        opener.run
-      end
       it "writes to custom_commands_log if lab name doesn't match env" do
         environment = {
           "SHELL" => "/usr/local/bin/fish",
@@ -230,7 +164,7 @@ describe LearnOpen::Opener do
           "IDE_CONTAINER" => "true",
           "IDE_VERSION" => "3"
         }
-        allow(system_adapter).to receive_messages([:spawn, :watch_dir])
+        allow(system_adapter).to receive_messages([:spawn, :spawn])
 
         home_dir = create_linux_home_dir("bobby")
         opener = LearnOpen::Opener.new(nil, "atom", true, false,
@@ -251,7 +185,7 @@ describe LearnOpen::Opener do
           "LAB_NAME" => "Something wild",
           "CREATED_USER" => "bobby"
         }
-        allow(system_adapter).to receive_messages([:spawn, :watch_dir])
+        allow(system_adapter).to receive_messages([:spawn, :spawn])
 
         home_dir = create_linux_home_dir("bobby")
         opener = LearnOpen::Opener.new(nil, "atom", true, false,
@@ -272,7 +206,7 @@ describe LearnOpen::Opener do
           "CREATED_USER" => "bobby",
           "IDE_CONTAINER" => "true",
         }
-        allow(system_adapter).to receive_messages([:spawn, :watch_dir])
+        allow(system_adapter).to receive_messages([:spawn, :spawn])
         expect(system_adapter)
           .to receive(:open_editor)
           .with("atom", path: ".")
@@ -309,7 +243,7 @@ describe LearnOpen::Opener do
       allow(system_adapter).to receive_messages(
         open_editor: :noop,
         spawn: :noop,
-        watch_dir: :noop,
+        spawn: :noop,
         open_login_shell: :noop,
         change_context_directory: :noop,
         run_command: :noop,
@@ -339,7 +273,7 @@ Failed to obtain an SSH connection!
       allow(system_adapter).to receive_messages(
         open_editor: :noop,
         spawn: :noop,
-        watch_dir: :noop,
+        spawn: :noop,
         open_login_shell: :noop,
         change_context_directory: :noop,
         run_command: :noop,
@@ -373,7 +307,7 @@ Done.
       allow(system_adapter).to receive_messages(
         open_editor: :noop,
         spawn: :noop,
-        watch_dir: :noop,
+        spawn: :noop,
         open_login_shell: :noop,
         change_context_directory: :noop,
         run_command: :noop,
@@ -408,8 +342,8 @@ Done.
           .to receive(:spawn)
           .with("restore-lab", block: true)
         expect(system_adapter)
-          .to receive(:watch_dir)
-          .with("/home/bobby/Development/code/jupyter_lab", "backup-lab")
+          .to receive(:spawn)
+          .with(LearnOpen::FileBackupStarter::BACKUP_LAB_PROCESS)
         expect(system_adapter)
           .to receive(:open_login_shell)
           .with("/usr/local/bin/fish")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: learn-open
 version: !ruby/object:Gem::Version
-  version: 1.2.26
+  version: 1.2.27
 platform: ruby
 authors:
 - Flatiron School
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-22 00:00:00.000000000 Z
+date: 2019-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler