leanplum_api 4.0.2 → 4.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 92bca9f613ba5eb8d2f4eebb6cc88fb29fc2a38b
-  data.tar.gz: 16979c3cae038e26c6873b6815ae7deefda268e7
+  metadata.gz: 43f7d678d33a30f6b8f4a3d50a875f3536328ad1
+  data.tar.gz: 7bb19cca732b8023d580d110423fa46f071c64a6
 SHA512:
-  metadata.gz: 34f75c8514a7e7b8811a0a80bc35f699834fe3054c5c545d6737e19346d1d02b10c8090c91336f8297ad87eb45ab04d0464f8f9df5fa2d9c967fe89ae8601894
-  data.tar.gz: 8ded87e06e2ed7b5dee4b24f9888eef4c116cdbc829df41b031706ce2d0cbecdc4de2b9f0550e13148860a2fb3f4821702432732862d79d32222305486eab649
+  metadata.gz: eb6851bf1dd347cc0f0e4b91a8d529ac91a38bb61898cc0172491e81d21da464e4c55b3a561750f2078249dcb52bf51ab065eb882c38ac4e729f4565910d74d5
+  data.tar.gz: 0bb6461320be68b9cdd09f5a03ff1ca73056cf06db7b7eb99a77d22d7d9fe6bffa0ad8052bfa416cc27e132e61da673f4b9eed6bc50cdf940068b8f2de28b45f

data/README.md

@@ -143,7 +143,7 @@ response = data_export_api.wait_for_export_job(job_id)
 **Note well that Leanplum now officially recommends use of the automated S3 export instead of API based export.**  According to a Leanplum engineer these two data export methodologies are completely independent data paths and in our experience we have found API based data export to be missing 10-15% of the data that is eventually returned by the automated export.
 
 ### Other Available Methods
-These are mostly simple wrappers around Leanplum's API methods.  See their documentation for details.
+These are mostly simple wrappers around Leanplum's API methods.  See [their documentation](https://www.leanplum.com/docs/api/) for details.
 
 * `api.export_user(user_id)`
 * `api.user_attributes(user_id)` (gives you the attributes section of `exportUser`)

data/lib/leanplum_api/api.rb

@@ -45,7 +45,9 @@ module LeanplumApi
 
     def user_attributes(user_id)
       # Leanplum returns strings instead of booleans
-      Hash[export_user(user_id)['userAttributes'].map { |k, v| [k, v.to_s =~ /\Atrue|false\z/i ? eval(v.downcase) : v] }]
+      export_user(user_id)['userAttributes']
+        .map { |k, v| [k, v.to_s =~ /\A(true|false)\z/i ? eval(v.downcase) : v] }
+        .to_h
     end
 
     def user_events(user_id)

data/lib/leanplum_api/version.rb

@@ -1,3 +1,3 @@
 module LeanplumApi
-  VERSION = '4.0.2'
+  VERSION = '4.0.3'
 end

data/spec/api_spec.rb

@@ -116,6 +116,10 @@ describe LeanplumApi::API do
     end
 
     context '#user_attributes' do
+      let(:true_key) { 'random_true_key' }
+      let(:false_key) { 'arbitrary_false_key' }
+      let(:test_hash) { { 'userAttributes' => { true_key => 'TrUe', false_key => 'fALSE' } } }
+
       it 'should get user attributes for this user' do
         VCR.use_cassette('export_user') do
           api.user_attributes(first_user_id).each do |k, v|
@@ -127,6 +131,28 @@ describe LeanplumApi::API do
           end
         end
       end
+
+      it 'should convert true / false strings into booleans' do
+        allow(api).to receive(:export_user).and_return(test_hash)
+        attributes = api.user_attributes(first_user_id)
+
+        expect(attributes[true_key]).to eq(true)
+        expect(attributes[false_key]).to eq(false)
+      end
+
+      context 'boolean looking strings' do
+        let(:true_like_value) { 'truegrit' }
+        let(:false_like_value) { 'whatever string ending in false' }
+        let(:test_hash) { { 'userAttributes' => { true_key => true_like_value, false_key => false_like_value } } }
+
+        it 'should not convert true / false like strings' do
+          allow(api).to receive(:export_user).and_return(test_hash)
+          attributes = api.user_attributes(first_user_id)
+
+          expect(attributes[true_key]).to eq(true_like_value)
+          expect(attributes[false_key]).to eq(false_like_value)
+        end
+      end
     end
 
     context '#reset_anomalous_users' do

data/spec/spec_helper.rb

@@ -5,7 +5,7 @@ require 'webmock'
 require 'vcr'
 require 'dotenv/load'
 
-DEFAULT_SPEC_KEY = 'JUNKTASTIC_SPASMASTIC'
+DEFAULT_SPEC_KEY = 'JUNKTASTIC_SPASMASTIC'.freeze
 
 RSpec.configure do |config|
   config.before(:all) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: leanplum_api
 version: !ruby/object:Gem::Version
-  version: 4.0.2
+  version: 4.0.3
 platform: ruby
 authors:
 - Lumos Labs, Inc.
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-21 00:00:00.000000000 Z
+date: 2017-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport