leanplum_api 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba21ebe73260c66ae36b3c901abfe6824d238b26
-  data.tar.gz: '009e58d6f0537a717bd1a66ddf6f39d5601ab328'
+  metadata.gz: d5a76aed3d020547e134ee3a112266a894ede780
+  data.tar.gz: 79ef59a1a63018388963bd3d71de1af95ac9cd72
 SHA512:
-  metadata.gz: 0e56f3fea79360b0820803e7edb1d153f19691d7adf644699feba9c7abe00edd58593852c8e62988dd202f3471ad7818ed8de9c55225adf6fb10b657c4e420c5
-  data.tar.gz: 9404b64c448032f32cde14db3082cdb4fc5fa4e2b4d7e27de1ede0ea5f4dc653fd4a8bdf8d3c01b9983df5a75687deb62c922c6d4d6fae05b2035f3f518e88ae
+  metadata.gz: 7878726aa0f68c2445c941e3e695ee341780836625f9022fe4a4efa80fbb89f6163fc11991f56781e36132b47b9a2e325bb7452a0bfcefd18892b8e1d2a7543e
+  data.tar.gz: 8c2cbb38fbc6f12b439f6f01512bdb94a952bb6fc895ed8f57853b5a57a01605ba73b88f4585db0f9991cc6a29f8ea4f3365412e92e692636b30689682ed8977

data/lib/leanplum_api/faraday_middleware/response_validation.rb

@@ -16,8 +16,10 @@ module LeanplumApi
 
       @app.call(environment).on_complete do |response|
         fail ResourceNotFoundError, response.inspect if response.status == 404
-        fail BadResponseError, response.inspect unless response.status == 200 && (responses = response.body['response']).is_a?(Array)
-        fail BadResponseError, "No :success key in #{responses.inspect}!" unless responses.all? { |r| r.key?(SUCCESS) }
+        fail BadResponseError, response.inspect unless response.status == 200
+
+        responses = response.body['response']
+        fail BadResponseError, "No response array: #{response.inspect}" unless responses.is_a?(Array)
 
         validate_request_success(responses, requests) if LeanplumApi.configuration.validate_response
       end
@@ -27,7 +29,7 @@ module LeanplumApi
 
     def validate_request_success(success_indicators, requests)
       if requests && success_indicators.size != requests.size
-        fail BadResponseError, "Attempted #{requests.size} operations but received confirmation for #{success_indicators.size}!"
+        fail BadResponseError, "Attempted #{requests.size} operations; responses for only #{success_indicators.size}!"
       end
 
       failures = success_indicators.map.with_index do |indicator, i|
@@ -37,7 +39,8 @@ module LeanplumApi
 
         next nil if indicator[SUCCESS].to_s == 'true'
 
-        requests ? { operation: requests[i], error: indicator } : { error: indicator }
+        failure = { message: indicator.key?(SUCCESS) ? indicator.to_s : "No :success key found in #{indicator}" }
+        requests ? failure.merge(operation: requests[i]) : failure
       end.compact
 
       unless failures.empty?

data/lib/leanplum_api/version.rb

@@ -1,3 +1,3 @@
 module LeanplumApi
-  VERSION = '4.0.0'
+  VERSION = '4.0.1'
 end

data/spec/api_spec.rb

@@ -302,17 +302,17 @@ describe LeanplumApi::API do
   end
 
   context 'hash utility methods' do
-    let(:hash_with_times) { { not_time: 'grippin', time: Time.now.utc, date: Time.now.utc.to_date } }
+    let(:hash_with_times) { { not_time: 'grippin', time: last_event_time, date: last_event_time.to_date } }
 
     it 'turns datetimes into seconds from the epoch' do
       expect(api.send(:fix_seconds_since_epoch, hash_with_times)).to eq(
-        hash_with_times.merge(time: Time.now.utc.strftime('%s').to_i, date: Time.now.utc.to_date.strftime('%s').to_i)
+        hash_with_times.merge(time: last_event_time.strftime('%s').to_i, date: last_event_time.to_date.strftime('%s').to_i)
       )
     end
 
     it 'turns datetimes into iso8601 format' do
       expect(api.send(:fix_iso8601, hash_with_times)).to eq(
-        hash_with_times.merge(time: Time.now.utc.iso8601, date: Time.now.utc.to_date.iso8601)
+        hash_with_times.merge(time: last_event_time.iso8601, date: last_event_time.to_date.iso8601)
       )
     end
   end

data/spec/data_export_api_spec.rb

@@ -10,17 +10,17 @@ describe LeanplumApi::DataExportAPI do
   context 'data export methods' do
     context 'export_data' do
       context 'regular export' do
-        it 'should request a data export job with a starttime' do
-          VCR.use_cassette('export_data') do
-            expect { api.export_data(Time.at(1438660800).utc) }.to raise_error LeanplumApi::BadResponseError
-          end
-        end
-
         it 'should request a data export job with start and end dates' do
           VCR.use_cassette('export_data_dates') do
             expect { api.export_data(Date.new(2017, 8, 5), Date.new(2017, 8, 6)) }.to_not raise_error
           end
         end
+
+        it 'should exception when requesting a data export job with an invalid starttime' do
+          VCR.use_cassette('export_data') do
+            expect { api.export_data(Time.at(1438660800).utc) }.to raise_error LeanplumApi::BadResponseError
+          end
+        end
       end
 
       context 's3 export' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: leanplum_api
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Lumos Labs, Inc.
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-14 00:00:00.000000000 Z
+date: 2017-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport