leankitkanban 0.0.2 → 0.0.3

data/README.md

@@ -12,8 +12,12 @@ Usage
     LeanKitKanban::Config.password = "mypassword"
     LeanKitKanban::Config.account  = "myaccount"
 
-    @boards = LeanKitKanban::Board.all # gets all boards and returns an array of hashes
-    @board  = LeanKitKanban::Board.find(board_id) # gets the board with specified id as a hash
+    # get all boards and returns an array of hashes
+    @boards      = LeanKitKanban::Board.all
+    # get the board with specified id as a hash
+    @board       = LeanKitKanban::Board.find(board_id)
+    # get all the identifiers for a board
+    @identifiers = LeanKitKanban::Board.get_identifiers(board_id)
 
 Board ID
 --------

data/Rakefile

@@ -2,7 +2,7 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('leankitkanban', '0.0.2') do |p|
+Echoe.new('leankitkanban', '0.0.3') do |p|
   p.description     = "Ruby Wrapper around LeanKitKanban Api"
   p.url             = "http://github.com/mlainez/leankitkanban"
   p.author          = "Marc Lainez"

data/leankitkanban.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{leankitkanban}
-  s.version = "0.0.2"
+  s.version = "0.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Marc Lainez}]

data/lib/leankitkanban/board.rb

@@ -2,34 +2,35 @@ module LeanKitKanban
   module Board
     include HTTParty
 
-    ALL_BOARDS  = "/Boards"
-    ONE_BOARD   = "/Boards/{boardID}"
-    IDENTIFIERS = "/Board/{boardID}/GetBoardIdentifiers"
+    ALL_BOARDS     = "/Boards"
+    ONE_BOARD      = "/Boards/{boardID}"
+    IDENTIFIERS    = "/Board/{boardID}/GetBoardIdentifiers"
+    REPLY_DATA_KEY = "ReplyData"
 
     def self.all
-      url      = "#{LeanKitKanban::Config.uri}#{ALL_BOARDS}"
-      response = get(url, LeanKitKanban::Config.basic_auth_hash)
-      parse_body(response.body)
+      get(ALL_BOARDS)
     end
 
     def self.find(board_id)
       api_call = ONE_BOARD.gsub("{boardID}", board_id.to_s)
-      url      = "#{LeanKitKanban::Config.uri}#{api_call}"
-      response = get(url, LeanKitKanban::Config.basic_auth_hash)
-      parse_body(response.body)
+      get(api_call)
     end
 
     def self.get_identifiers(board_id)
       api_call = IDENTIFIERS.gsub("{boardID}", board_id.to_s)
+      get(api_call)
+    end
+
+    private
+    def self.get(api_call)
       url      = "#{LeanKitKanban::Config.uri}#{api_call}"
-      response = get(url, LeanKitKanban::Config.basic_auth_hash)
+      response = super(url, LeanKitKanban::Config.basic_auth_hash)
       parse_body(response.body)
     end
 
-    private
     def self.parse_body(body)
-      json_data       = JSON.parse body
-      json_data["ReplyData"]
+      json_data = JSON.parse body
+      json_data[REPLY_DATA_KEY]
     end
   end
 end

data/lib/leankitkanban/config.rb

@@ -7,6 +7,7 @@ module LeanKitKanban
       attr_accessor :email, :password, :account
 
       LKK_DOMAIN = "leankitkanban.com"
+      API_SUFFIX = "/Kanban/API"
 
       def validate
         raise NoCredentials if email.nil? || password.nil?
@@ -15,7 +16,7 @@ module LeanKitKanban
 
       def uri
         validate
-        "http://#{account}.#{LKK_DOMAIN}/Kanban/API"
+        "http://#{account}.#{LKK_DOMAIN}#{API_SUFFIX}"
       end
 
       def basic_auth_hash

data/spec/leankitkanban/board_spec.rb

@@ -6,105 +6,33 @@ describe LeanKitKanban::Board do
   end
 
   describe :all do
-    before :each do
-      @response  = mock("Response")
-      @body      = mock("Body")
-      @auth_hash = mock("Auth hash")
-      LeanKitKanban::Config.stub(:uri)
-      LeanKitKanban::Config.stub(:basic_auth_hash => @auth_hash)
-      LeanKitKanban::Board.stub(:get => @response)
-      @response.stub(:body => @body)
-      LeanKitKanban::Board.stub(:parse_body)
-    end
-
-    it "gets the base uri" do
-      LeanKitKanban::Config.should_receive(:uri)
-      LeanKitKanban::Board.all
-    end
-
-    it "gets the basic authentication hash" do
-      LeanKitKanban::Config.should_receive(:basic_auth_hash)
-      LeanKitKanban::Board.all
-    end
-
     it "gets all boards for that account" do
-      url = "/Boards"
-      LeanKitKanban::Board.should_receive(:get).with(url, @auth_hash).and_return(@response)
-      LeanKitKanban::Board.all
-    end
-
-    it "gets the body from the response" do
-      @response.should_receive(:body).and_return(@body)
+      api_call = "/Boards"
+      LeanKitKanban::Board.should_receive(:get).with(api_call)
       LeanKitKanban::Board.all
     end
   end
 
   describe :find do
     before :each do
-      @board_id  = 123
-      @response  = mock("Response")
-      @body      = mock("Body")
-      @auth_hash = mock("Auth hash")
-      LeanKitKanban::Config.stub(:uri)
-      LeanKitKanban::Config.stub(:basic_auth_hash => @auth_hash)
-      LeanKitKanban::Board.stub(:get => @response)
-      @response.stub(:body => @body)
-      LeanKitKanban::Board.stub(:parse_body)
-    end
-
-    it "gets the base uri" do
-      LeanKitKanban::Config.should_receive(:uri)
-      LeanKitKanban::Board.find(@board_id)
-    end
-
-    it "gets the basic authentication hash" do
-      LeanKitKanban::Config.should_receive(:basic_auth_hash)
-      LeanKitKanban::Board.find(@board_id)
+      @board_id  = mock("boardID")
     end
 
     it "gets the board whose id is passed as parameter" do
-      url = "/Boards/#{@board_id}"
-      LeanKitKanban::Board.should_receive(:get).with(url, @auth_hash).and_return(@response)
-      LeanKitKanban::Board.find(@board_id)
-    end
-
-    it "gets the body from the response" do
-      @response.should_receive(:body).and_return(@body)
+      api_call = "/Boards/#{@board_id}"
+      LeanKitKanban::Board.should_receive(:get).with(api_call)
       LeanKitKanban::Board.find(@board_id)
     end
   end
 
   describe :get_identifiers do
     before :each do
-      @board_id  = 123
-      @response  = mock("Response")
-      @body      = mock("Body")
-      @auth_hash = mock("Auth hash")
-      LeanKitKanban::Config.stub(:uri)
-      LeanKitKanban::Config.stub(:basic_auth_hash => @auth_hash)
-      LeanKitKanban::Board.stub(:get => @response)
-      @response.stub(:body => @body)
-      LeanKitKanban::Board.stub(:parse_body)
-    end
-
-    it "gets the base uri" do
-      LeanKitKanban::Config.should_receive(:uri)
-      LeanKitKanban::Board.get_identifiers(@board_id)
-    end
-
-    it "gets the basic authentication hash" do
-      LeanKitKanban::Config.should_receive(:basic_auth_hash)
-      LeanKitKanban::Board.get_identifiers(@board_id)
-    end
-
-    it "gets the board whose id is passed as parameter" do
-      url = "/Board/#{@board_id}/GetBoardIdentifiers"
-      LeanKitKanban::Board.should_receive(:get).with(url, @auth_hash).and_return(@response)
-      LeanKitKanban::Board.get_identifiers(@board_id)
+      @board_id  = mock("boardID")
     end
 
-    it "gets the body from the response" do
-      @response.should_receive(:body).and_return(@body)
+    it "gets the identifiers of the board whose id is passed as parameter" do
+      api_call = "/Board/#{@board_id}/GetBoardIdentifiers"
+      LeanKitKanban::Board.should_receive(:get).with(api_call)
       LeanKitKanban::Board.get_identifiers(@board_id)
     end
   end

metadata

@@ -2,7 +2,7 @@
 name: leankitkanban
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Marc Lainez