leadsquared 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5cc7825ff72316806e703ea2a527c42ae33981f8
-  data.tar.gz: ae29b53d1c89677f131c77f67b18715cfda0baf7
+  metadata.gz: 2f6b501ce8ab4dd1adaabda63f2751574be73d7e
+  data.tar.gz: 27531c051ac257780361ed40225c0e2b35a4d21c
 SHA512:
-  metadata.gz: ada256d8dcd17eaf28349f6eb554f6d63410376b3a4527317ced93b8e0fb594702212ad75ba77954c294e4ba3da77ed2292561b309368f00c0ef0a53c8329ee9
-  data.tar.gz: a5df388a1d99efb212e3157a92fdfba293fc432d932201fe4cb832e72a8717b3aee9d7d568d726977843bf32cb058f0dfa0c1424202512878554ee0856739ead
+  metadata.gz: ceccfe9f88311e7137cc9a325eb111af74c09daab7a4a7101511d23f3028b196ee57671ac334bd877e42a06268517e1f225f8c124864481af5a7322eb5ad80e4
+  data.tar.gz: 69a6a08f3f3897f2f6f50b24e0d509e12f0d548076a50edcaed6de2ba4b89008b1972743b7924558e8aa606de0799174468782104f59890f0fbe884930a72616

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.4.0

data/leadsquared.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: leadsquared 0.3.1 ruby lib
+# stub: leadsquared 0.4.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "leadsquared"
-  s.version = "0.3.1"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["David Paluy"]
-  s.date = "2015-11-30"
+  s.date = "2015-12-04"
   s.description = "Ruby framework for integration with Leadsquared. Leadsquared API: http://apidocs.leadsquared.com/"
   s.email = "dpaluy@gmail.com"
   s.extra_rdoc_files = [

data/lib/leadsquared/lead.rb

@@ -35,22 +35,15 @@ module Leadsquared
       handle_response response
     end
 
-    def create_lead(email, first_name = nil, last_name = nil)
+    def create_lead(email, values_hash = {})
       url = url_with_service("Lead.Create")
       body = [
         {
           "Attribute": "EmailAddress",
           "Value": email
-        },
-        {
-          "Attribute": "FirstName",
-          "Value": first_name
-        },
-        {
-          "Attribute": "LastName",
-          "Value": last_name
         }
       ]
+      body += build_attributes values_hash
       response = connection.post(url, {}, body.to_json)
       parsed_response = handle_response response
       parsed_response["Message"]["Id"]
@@ -58,36 +51,25 @@ module Leadsquared
 
     def update_lead(lead_id, values_hash = {})
       url = url_with_service("Lead.Update")
-      body = values_hash.map {|key, val| {"Attribute" => key, "Value" => val} }
+      body = build_attributes values_hash
       response = connection.post(url, {leadId: lead_id}, body.to_json)
       parsed_response = handle_response response
       parsed_response["Status"]
     end
 
-    def create_or_update(email = nil, first_name = nil, last_name = nil, phone = nil, search_by = "EmailAddress")
+    def create_or_update(email, values_hash = {})
       url = url_with_service("Lead.CreateOrUpdate")
       body = [
         {
           "Attribute": "EmailAddress",
           "Value": email
         },
-        {
-          "Attribute": "FirstName",
-          "Value": first_name
-        },
-        {
-          "Attribute": "LastName",
-          "Value": last_name
-        },
-        {
-          "Attribute": "Phone",
-          "Value": phone
-        },
         {
           "Attribute": "SearchBy",
-          "Value": search_by
+          "Value": "EmailAddress"
         }
       ]
+      body += build_attributes(values_hash)
       response = connection.post(url, {}, body.to_json)
       parsed_response = handle_response response
       parsed_response["Message"]["Id"]
@@ -95,12 +77,17 @@ module Leadsquared
 
     def visitor_to_lead(prospect_id, values_hash = {})
       url = url_with_service("Lead.Convert")
-      body = values_hash.map {|key, val| {"Attribute" => key, "Value" => val} }
+      body = build_attributes(values_hash)
       response = connection.post(url, {leadId: prospect_id}, body.to_json)
       parsed_response = handle_response response
       parsed_response["Status"]
     end
 
+    private
+
+    def build_attributes(values_hash)
+      values_hash.map {|key, val| {"Attribute" => key, "Value" => val} }
+    end
   end
 
 end

data/spec/leadsquared/lead_spec.rb

@@ -6,6 +6,9 @@ describe Leadsquared::Lead do
   let(:email) { "test@example.com" }
   let(:first_name) { "Bob" }
   let(:last_name) { "Zeiger" }
+  let(:attributes) do
+    {"FirstName" => first_name, "LastName" => last_name}
+  end
 
   let(:invalid_response_body) do
     {
@@ -218,6 +221,10 @@ describe Leadsquared::Lead do
           "Attribute": "EmailAddress",
           "Value": email
         },
+        {
+          "Attribute": "SearchBy",
+          "Value": "EmailAddress"
+        },
         {
           "Attribute": "FirstName",
           "Value": first_name
@@ -225,27 +232,16 @@ describe Leadsquared::Lead do
         {
           "Attribute": "LastName",
           "Value": last_name
-        },
-        {
-          "Attribute": "Phone",
-          "Value": nil
-        },
-        {
-          "Attribute": "SearchBy",
-          "Value": "EmailAddress"
         }
       ]
       end
+
       it "valid request" do
         expect(mock_connection).to receive(:post).with(url, {}, body.to_json).and_return valid_response
-        response = subject.create_or_update(email, first_name, last_name)
+        response = subject.create_or_update(email, attributes)
         expect(response).to eq(success_response["Message"]["Id"])
       end
     end
-
-    describe "search by phone" do
-      pending "TODO"
-    end
   end
 
   describe "#create_lead" do
@@ -278,14 +274,14 @@ describe Leadsquared::Lead do
 
     it "valid request with given params" do
       expect(mock_connection).to receive(:post).with(url, {}, body.to_json).and_return valid_response
-      response = subject.create_lead(email, first_name, last_name)
+      response = subject.create_lead(email, attributes)
       expect(response).to eq(success_response["Message"]["Id"])
     end
 
     it "invalid request" do
       expect(mock_connection).to receive(:post).with(url, {}, body.to_json).and_return invalid_response
       expect {
-        subject.create_lead(email, first_name, last_name)
+        subject.create_lead(email, attributes)
       }.to raise_error(Leadsquared::InvalidRequestError)
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: leadsquared
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - David Paluy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-30 00:00:00.000000000 Z
+date: 2015-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport