leaderbrag 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f1f08cd9b911549a210572d128a7468a81ffc96e
-  data.tar.gz: 45530a9599ccdf9fb6254eba5aad905582e984fb
+  metadata.gz: 7579c259982dedf4121354fd0cdcdd697e2c76ff
+  data.tar.gz: 6c98eebdb490302afcde4ef45289516ad51421e4
 SHA512:
-  metadata.gz: 35747ec43c7fd29058e812f22f8774f5239f9e952ab9b89b07503800c7cc88e29347a8762b3c72a0b2c50a445f2099dbbc6c1291b1a0d96f6722ae9a2c52bada
-  data.tar.gz: d203f5e93b3f093ce69958097f70d431157c4603c12824bf3e06e45407581df0c0034ef0342c95c455751af59da3b4f54bd1ef73247b72dc87060d71e6e4caae
+  metadata.gz: 6d7b685b826f17d073c2c923e3790ef1f1ab66c552f50ee928ae1c4c43feec0377ea734063c80395b9b594b2a163d774c50ca7b8711b1f1cf4d7bcda0909daa9
+  data.tar.gz: b30eacd0ffd35c3540d24dd41e7702055405ab06c4c88c1e2ea83cecb860bee89445c5ebdaca81baba3d41a7adf7bdf377e65fb1d02f7c413f1db90e9c7a74dc

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-06-18 21:39:23 -0500 using RuboCop version 0.71.0.
+# on 2019-06-21 22:32:50 -0500 using RuboCop version 0.71.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,7 +14,7 @@ Lint/HandleExceptions:
 
 # Offense count: 2
 Metrics/AbcSize:
-  Max: 36
+  Max: 44
 
 # Offense count: 1
 Metrics/CyclomaticComplexity:
@@ -23,7 +23,7 @@ Metrics/CyclomaticComplexity:
 # Offense count: 1
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 30
+  Max: 38
 
 # Offense count: 1
 Metrics/PerceivedComplexity:

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+before_install:
+  - gem update --system
+  - gem install bundler

data/README.md

@@ -1,8 +1,8 @@
-# Leaderbrag
+# Leaderbrag [![Build Status](https://travis-ci.org/schlazor/leaderbrag.svg?branch=master)](https://travis-ci.org/schlazor/leaderbrag)
 
-Leaderbrag is a small gem that uses [xmlstats](https://erikberg.com/api) to find the leading team in baseball or determine if a given team is the best in baseball. 
+Leaderbrag is a small gem that uses [xmlstats](https://erikberg.com/api) via [xmlstats-ruby](https://github.com/alexmchale/xmlstats-ruby) to find the leading team in baseball or determine if a given team is the best in baseball.
 
-It includes the CLI executable `leader` which should be suitable for most scripting desires and also serves as a useful example for using the underlying library.
+It includes the CLI executable `leader` which should be suitable for most scripting desires.
 
 ## Installation
 
@@ -23,6 +23,17 @@ Or install it yourself as:
 ## Usage
 
 First, ensure you have $GEM_HOME/bin in your path.
+You'll need to set some environment variables to match your [xmlstats API key](https://erikberg.com/api#):
+```
+$ export XMLSTATS_API_KEY="xxxxx-xxxx-xxxx"
+$ export XMLSTATS_CONTACT_INFO="you@example.com"
+```
+To cut down on API calls, you can turn on caching by setting these environment variables:
+```
+export XMLSTATS_CACHER='redis'
+export XMLSTATS_REDIS_HOST='127.0.0.1'
+```
+where XMLSTATS_REDIS_HOST is the IP of a server running [redis](https://redis.io/) that you have access to. Most probably this is `127.0.0.1` and in fact if you don't specify this environment variable that value will be used.
 
 Using the CLI is pretty straightforward.
 
@@ -35,41 +46,43 @@ The Minnesota Twins are the leaders of the AL.
 The Minnesota Twins are the best team in baseball.
 ```
 
-To query about a specific team, you'll need that team's ID. Get the list with the `list` task:
+To query about a specific team, you'll need that team's ID. Get the full leaderboard with the `board` task, which includes each team's ID:
 ```
-$ leader list
-Minnesota Twins:       minnesota-twins
-Cleveland Indians:     cleveland-indians
-Chicago White Sox:     chicago-white-sox
-Detroit Tigers:        detroit-tigers
-Kansas City Royals:    kansas-city-royals
-New York Yankees:      new-york-yankees
-Tampa Bay Rays:        tampa-bay-rays
-Boston Red Sox:        boston-red-sox
-Toronto Blue Jays:     toronto-blue-jays
-Baltimore Orioles:     baltimore-orioles
-Houston Astros:        houston-astros
-Texas Rangers:         texas-rangers
-Oakland Athletics:     oakland-athletics
-Los Angeles Angels:    los-angeles-angels
-Seattle Mariners:      seattle-mariners
-Milwaukee Brewers:     milwaukee-brewers
-Chicago Cubs:          chicago-cubs
-St. Louis Cardinals:   st-louis-cardinals
-Cincinnati Reds:       cincinnati-reds
-Pittsburgh Pirates:    pittsburgh-pirates
-Atlanta Braves:        atlanta-braves
-Philadelphia Phillies: philadelphia-phillies
-New York Mets:         new-york-mets
-Washington Nationals:  washington-nationals
-Miami Marlins:         miami-marlins
-Los Angeles Dodgers:   los-angeles-dodgers
-Colorado Rockies:      colorado-rockies
-Arizona Diamondbacks:  arizona-diamondbacks
-San Diego Padres:      san-diego-padres
-San Francisco Giants:  san-francisco-giants
+$ leader board
+Team Name              Team ID               Rank  Win%  League  Div
+--------------------------------------------------------------------
+Los Angeles Dodgers:   los-angeles-dodgers   1     .671  NL      W
+Minnesota Twins:       minnesota-twins       2     .649  AL      C
+New York Yankees:      new-york-yankees      3     .635  AL      E
+Houston Astros:        houston-astros        4     .632  AL      W
+Atlanta Braves:        atlanta-braves        5     .587  NL      E
+Tampa Bay Rays:        tampa-bay-rays        6     .573  AL      E
+Chicago Cubs:          chicago-cubs          7     .547  NL      C
+Colorado Rockies:      colorado-rockies      8     .541  NL      W
+Boston Red Sox:        boston-red-sox        9     .539  AL      E
+Texas Rangers:         texas-rangers         10    .533  AL      W
+Milwaukee Brewers:     milwaukee-brewers     11    .533  NL      C
+Cleveland Indians:     cleveland-indians     12    .527  AL      C
+Philadelphia Phillies: philadelphia-phillies 13    .527  NL      E
+Oakland Athletics:     oakland-athletics     14    .526  AL      W
+St. Louis Cardinals:   st-louis-cardinals    15    .514  NL      C
+San Diego Padres:      san-diego-padres      16    .507  NL      W
+Arizona Diamondbacks:  arizona-diamondbacks  17    .500  NL      W
+Los Angeles Angels:    los-angeles-angels    18    .500  AL      W
+Chicago White Sox:     chicago-white-sox     19    .486  AL      C
+Washington Nationals:  washington-nationals  20    .486  NL      E
+Cincinnati Reds:       cincinnati-reds       21    .479  NL      C
+New York Mets:         new-york-mets         22    .474  NL      E
+Pittsburgh Pirates:    pittsburgh-pirates    23    .452  NL      C
+San Francisco Giants:  san-francisco-giants  24    .425  NL      W
+Seattle Mariners:      seattle-mariners      25    .418  AL      W
+Detroit Tigers:        detroit-tigers        26    .371  AL      C
+Miami Marlins:         miami-marlins         27    .370  NL      E
+Toronto Blue Jays:     toronto-blue-jays     28    .360  AL      E
+Kansas City Royals:    kansas-city-royals    29    .347  AL      C
+Baltimore Orioles:     baltimore-orioles     30    .280  AL      E
 ```
-When asking about a team, the exit code indicates whether the requested team is the best team in baseball - 0 of so, otherwise it is the rank of that team in their division.
+When asking about a team, the exit code is 0 when the requested team is the best team in baseball, otherwise it is the rank of that team in their division.
 ```
 $ leader is minnesota-twins
 The Minnesota Twins are the leaders of the AL C division.
@@ -77,51 +90,53 @@ The Minnesota Twins are the leaders of the AL.
 The Minnesota Twins are the best team in baseball.
 $ echo $?
 0
-
 $ leader is new-york-yankees
 The New York Yankees are the leaders of the AL E division.
-The New York Yankees are not the leaders of the AL.
-The New York Yankees are not the best team in baseball.
+The New York Yankees are not the leaders of the AL. They are #2.
+The New York Yankees are not the best team in baseball. They are #3.
 $ echo $?
 1
-
 $ leader is seattle-mariners
-The Seattle Mariners are not the leaders of the AL W division.
-The Seattle Mariners are not the leaders of the AL.
-The Seattle Mariners are not the best team in baseball.
+The Seattle Mariners are not the leaders of the AL W division. They are 5th.
+The Seattle Mariners are not the leaders of the AL. They are #11.
+The Seattle Mariners are not the best team in baseball. They are #25.
 $ echo $?
 5
 ```
-You can also get some extra stats about the team in the `is` and `find` tasks:
+You can also get some extra stats about the team in the `is` and `find` tasks with the `-s` option:
 ```
-$ leader is new-york-yankees -s
-Rank:                          1
-Won:                           44
-Lost:                          27
-Streak:                        W3
-Games back:                    0.0
-Points for:                    382
-Points against:                307
-Home won:                      23
-Home lost:                     13
-Away won:                      21
-Away lost:                     14
-Conference won:                38
-Conference lost:               23
-Division won:                  20
-Division lost:                 7
-Last five:                     3-2
-Last ten:                      5-5
-Conference:                    AL
-Division:                      E
-Points scored per game:        5.4
-Points allowed per game:       4.3
-Win percentage:                .620
-Point differential:            75
-Point differential per game:   1.1
-Streak type:                   win
-Streak total:                  3
-Games played:                  71
+$ leader is chicago-cubs -s
+The Chicago Cubs are the leaders of the NL C division.
+The Chicago Cubs are not the leaders of the NL. They are #3.
+The Chicago Cubs are not the best team in baseball. They are #7.
+Rank:                         1
+Won:                          41
+Lost:                         34
+Streak:                       L1
+Games back:                   0.0
+Points for:                   382
+Points against:               317
+Home won:                     26
+Home lost:                    13
+Away won:                     15
+Away lost:                    21
+Conference won:               34
+Conference lost:              28
+Division won:                 13
+Division lost:                11
+Last five:                    2-3
+Last ten:                     4-6
+Conference:                   NL
+Division:                     C
+Points scored per game:       5.1
+Points allowed per game:      4.2
+Win percentage:               .547
+Point differential:           65
+Point differential per game:  0.9
+Streak type:                  loss
+Streak total:                 1
+Games played:                 75
+Date:                         2019-06-21
 ```
 
 ## Development

data/Rakefile

@@ -2,11 +2,9 @@
 
 require 'bundler/gem_tasks'
 begin
-  require 'rspec/core/rake_task'
   require 'rubocop/rake_task'
   require 'cucumber'
   require 'cucumber/rake/task'
-  RSpec::Core::RakeTask.new(:spec)
   RuboCop::RakeTask.new(:style)
   Cucumber::Rake::Task.new(:features) do |t|
     t.cucumber_opts = '--format pretty'
@@ -14,7 +12,6 @@ begin
   desc 'run all checks'
   task :all do
     Rake::Task['style'].invoke
-    Rake::Task['spec'].invoke
     Rake::Task['features'].invoke
   end
 rescue LoadError

data/leaderbrag.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
 
   spec.summary       = 'Find out if your baseball team is best baseball team.'
   spec.description   = 'Tools to determine whether a baseball team is leading'\
-   'its division/league/all of baseball.'
+   ' its division/league/all of baseball.'
   spec.homepage      = 'https://github.com/schlazor/leaderbrag'
 
   if spec.respond_to?(:metadata)
@@ -33,7 +33,9 @@ Gem::Specification.new do |spec|
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
+  spec.add_dependency 'redis', '~> 4.1'
   spec.add_dependency 'thor', '~> 0.20'
+  spec.add_dependency 'xmlstats', '~> 1.7'
   spec.add_development_dependency 'aruba', '~> 0.14'
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'cucumber', '~> 3.1'

data/lib/leaderbrag/cli.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
 require 'thor'
-require 'leaderbrag/team'
+require 'leaderbrag/leader'
+require 'redis'
 module Leaderbrag
   # A CLI for Leaderbrag
   class CLI < Thor
@@ -9,13 +10,22 @@ module Leaderbrag
       true
     end
 
-    @standings = nil
-    desc 'list', 'Lists all baseball team IDs'
-    def list
-      standings = Leaderbrag::Standings.new.standings
-      standings['standing'].each do |team|
-        puts "#{team['first_name']} #{team['last_name']}:".ljust(23) +
-             team['team_id']
+    @leader = nil
+    def initialize(args = [], local_options = {}, config = {})
+      super
+      @leader = Leaderbrag::Leader.new
+    end
+
+    desc 'board', 'Lists all baseball teams with their standings'
+    def board
+      puts 'Team Name'.ljust(23) +
+           'Team ID               Rank  Win%  League  Div'
+      puts '-'.ljust(68, '-')
+      @leader.standings.each_with_index do |team, i|
+        puts "#{team.first_name} #{team.last_name}:".ljust(23) +
+             team.team_id.ljust(22) + (i + 1).to_s.ljust(6) +
+             team.win_percentage.ljust(6) +
+             team.conference.ljust(8) + team.division
       end
     end
 
@@ -26,13 +36,7 @@ module Leaderbrag
                           desc: 'Include team stats in output',
                           default: false)
     def find
-      @standings = Leaderbrag::Standings.new.standings
-      @standings['standing'].sort_by! do |team|
-        team['win_percentage'].to_f
-      end
-      i = @standings['standing'].length - 1
-      myteam = Leaderbrag::Team.new(@standings['standing'][i]['team_id'],
-                                    @standings)
+      myteam = @leader.standings[0]
       brag(myteam, options[:quiet], options[:stats])
     end
 
@@ -42,9 +46,9 @@ module Leaderbrag
     method_option(:stats, aliases: '-s',
                           desc: 'Include team stats in output',
                           default: false)
-    def is?(team)
-      myteam = Leaderbrag::Team.new(team)
-      if myteam.team_standings.nil?
+    def is?(team_id)
+      myteam = @leader.team(team_id)
+      if myteam.nil?
         warn "No such team with ID #{options['team']}"
         exit 50
       end
@@ -54,37 +58,45 @@ module Leaderbrag
     private
 
     def brag(myteam, quiet, stats)
-      name = "#{myteam.team_standings['first_name']}"\
-             " #{myteam.team_standings['last_name']}"
-      league = myteam.team_standings['conference']
-      division = myteam.team_standings['division']
+      name = "#{myteam.first_name}"\
+             " #{myteam.last_name}"
+      league = myteam.conference
+      division = myteam.division
       unless quiet
         print "The #{name} are "
-        print 'not ' unless myteam.division_leader?
-        puts "the leaders of the #{league} #{division} division."
-        print "The #{name} are "
-        print 'not ' unless myteam.league_leader?
-        puts "the leaders of the #{league}."
-        print "The #{name} are "
-        print 'not ' unless myteam.overall_leader?
-        puts 'the best team in baseball.'
+        print 'not ' unless @leader.division_leader?(myteam)
+        print "the leaders of the #{league} #{division} division."
+        unless @leader.division_leader?(myteam)
+          print " They are #{myteam.ordinal_rank}."
+        end
+        print "\nThe #{name} are "
+        print 'not ' unless @leader.league_leader?(myteam)
+        print "the leaders of the #{league}."
+        unless @leader.league_leader?(myteam)
+          print " They are ##{@leader.league_rank(myteam)}."
+        end
+        print "\nThe #{name} are "
+        print 'not ' unless @leader.overall_leader?(myteam)
+        print 'the best team in baseball.'
+        unless @leader.overall_leader?(myteam)
+          print " They are ##{@leader.overall_rank(myteam)}."
+        end
+        puts
       end
 
       if stats
-        myteam.team_standings.each do |k, v|
-          next if k == 'team_id'
-          next if k == 'first_name'
-          next if k == 'last_name'
-          next if k == 'ordinal_rank'
+        myteam.fields.each do |field|
+          k = field.to_s
+          next if %w[team_id first_name last_name ordinal_rank].include?(k)
 
-          label = k.gsub(/_/, ' ').capitalize + ':'
-          puts "#{label.ljust(30)} #{v}"
+          label = k.gsub(/_/, ' ').capitalize + ': '
+          puts label.ljust(30) + myteam.send(field).to_s
         end
       end
-      if myteam.overall_leader?
+      if @leader.overall_leader?(myteam)
         exit 0
       else
-        exit myteam.team_standings['rank']
+        exit myteam.rank
       end
     end
   end

data/lib/leaderbrag/leader.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+require 'xmlstats'
+module Leaderbrag
+  # Mostly wraps MLB standings adding some additional leadership checks
+  class Leader
+    attr_reader :standings
+    def initialize
+      Xmlstats.cacher = if ENV['XMLSTATS_CACHER'] == 'redis'
+                          host = '127.0.0.1'
+                          if ENV.key? 'XMLSTATS_REDIS_HOST'
+                            host = ENV['XMLSTATS_REDIS_HOST']
+                          end
+                          Xmlstats::Cachers::Redis.new(host: host)
+                        else
+                          Xmlstats::Cachers::Memory.new
+                        end
+      begin
+        @standings = Xmlstats.mlb_standing
+      rescue Redis::CannotConnectError
+        warn "WARN: Redis host #{ENV['XMLSTATS_REDIS_HOST']} "\
+        'not available. Falling back to memory cacher.'
+        Xmlstats.cacher = Xmlstats::Cachers::Memory.new
+        @standings = Xmlstats.mlb_standing
+      end
+      @standings.sort_by! do |team|
+        team.win_percentage.to_f
+      end
+      @standings.reverse!
+    end
+
+    def team(team_id)
+      @standings.detect do |team|
+        team.team_id == team_id
+      end
+    end
+
+    def division_leader?(team)
+      return true if team.rank == 1
+
+      false
+    end
+
+    def league_members(team)
+      @standings.select do |t|
+        team.conference == t.conference
+      end
+    end
+
+    def league_leader?(team)
+      return true if team.team_id == league_members(team)[0].team_id
+
+      false
+    end
+
+    def league_rank(team)
+      league_members(team).find_index(team) + 1
+    end
+
+    def overall_leader?(team)
+      return true if team.team_id == @standings[0].team_id
+
+      false
+    end
+
+    def overall_rank(team)
+      @standings.find_index(team) + 1
+    end
+  end
+end

data/lib/leaderbrag/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Leaderbrag
-  VERSION = '0.1.0'
+  VERSION = '1.0.0'
 end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: leaderbrag
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - David Schlenk
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-19 00:00:00.000000000 Z
+date: 2019-06-22 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: redis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.1'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -24,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.20'
+- !ruby/object:Gem::Dependency
+  name: xmlstats
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
@@ -122,7 +150,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.20'
-description: Tools to determine whether a baseball team is leadingits division/league/all
+description: Tools to determine whether a baseball team is leading its division/league/all
   of baseball.
 email:
 - david@schdav.org
@@ -135,6 +163,7 @@ files:
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - ".ruby-version"
+- ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -147,8 +176,7 @@ files:
 - leaderbrag.gemspec
 - lib/leaderbrag.rb
 - lib/leaderbrag/cli.rb
-- lib/leaderbrag/standings.rb
-- lib/leaderbrag/team.rb
+- lib/leaderbrag/leader.rb
 - lib/leaderbrag/version.rb
 homepage: https://github.com/schlazor/leaderbrag
 licenses: []

data/lib/leaderbrag/standings.rb

@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-require 'json'
-require 'net/http'
-
-module Leaderbrag
-  # holds the current baseball standings
-  class Standings
-    attr_reader :standings
-
-    def initialize
-      update
-    end
-
-    def update
-      url = 'https://erikberg.com/mlb/standings.json'
-      uri = URI(url)
-      user_agent = 'Leaderbrag/0.1.0 (david@schdav.org)'
-      Net::HTTP.start(uri.host, uri.port, use_ssl: true) do |http|
-        request = Net::HTTP::Get.new(uri, 'User-Agent' => user_agent)
-        response = http.request(request)
-        @standings = JSON.parse(response.body)
-      end
-    end
-  end
-end

data/lib/leaderbrag/team.rb

@@ -1,66 +0,0 @@
-# frozen_string_literal: true
-
-require 'leaderbrag/standings'
-module Leaderbrag
-  # a baseball team
-  class Team
-    attr_reader :name, :team_standings, :division_leader, :league_leader
-    attr_reader :overall_leader, :baseball_standings
-    alias division_leader? division_leader
-    alias league_leader? league_leader
-    alias overall_leader? overall_leader
-    def initialize(name, standings = nil)
-      @name = name
-      if standings.nil?
-        @baseball_standings = Leaderbrag::Standings.new.standings
-      end
-      @baseball_standings = standings unless standings.nil?
-      @team_standings = find_team
-      return if @team_standings.nil?
-
-      find_division_leader
-      find_league_leader
-      find_overall_leader
-    end
-
-    def find_team
-      myteams = @baseball_standings['standing'].select do |team|
-        team['team_id'] == name
-      end
-      myteams.length == 1 ? myteams[0] : nil
-    end
-
-    def find_division_leader
-      @division_leader = @team_standings['games_back'] == 0.0
-    end
-
-    def find_division_leaders
-      @baseball_standings['standing'].select do |team|
-        team['rank'] == 1
-      end
-    end
-
-    def find_overall_leader
-      division_leaders = find_division_leaders
-      division_leaders.sort_by! do |team|
-        team['win_percentage'].to_f
-      end
-      dl_id = division_leaders[division_leaders.length - 1]['team_id']
-      @overall_leader = false
-      @overall_leader = true if dl_id == @name
-    end
-
-    def find_league_leader
-      division_leaders = find_division_leaders
-      league_leaders = division_leaders.select do |team|
-        @team_standings['conference'] == team['conference']
-      end
-      league_leaders.sort_by! do |team|
-        team['win_percentage'].to_f
-      end
-      ll_id = league_leaders[league_leaders.length - 1]['team_id']
-      @league_leader = false
-      @league_leader = true if ll_id == name
-    end
-  end
-end