ldap_groups_lookup 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 204d6f964fd4220ed8043e376bd0d373d127968853b88559f66df7c9edf518ab
-  data.tar.gz: 9cdb88255825aba6bef3f71c78be2ed20edbac518a5cebda8535ec663497a51b
+  metadata.gz: 89497393dbd1cb8187e740a5867c0758a6a47eb79ae4719bf2e09ba0952011ac
+  data.tar.gz: e9e7db4530168f315c7b7463beeb395d94aa49411fc2a7d92cba6152136600ce
 SHA512:
-  metadata.gz: 8f079510a9a3c4349c3164d8abc8cd6f99e65c826dee864d31188e4379fd345cda75c70292a73f3b0d682f2611351da23bbe6d1381f22d00b022aee4a695fb8e
-  data.tar.gz: d2b11fe898402af8662feedd335f44bf7392213721ae5f98a9eb930085f44c5270613e24c89ba0b07448cad35b6c99ca7057f52d6b9c9b43069e45254c6a81d3
+  metadata.gz: be721599c153b22b93fc7769377610619d24d74973e3316f7ebd427341a1c5830cc71d45df67cb78671773347c865999b65e18e2cf349759e005d42c84b5b337
+  data.tar.gz: f5f4aa7a0d10008ee984cc495076fb669b6113bf8ac52012f8c6806f7b14cb8c1ac12bd340a98a1585168be8cb2101d29da1aa6aef154d04d8222e6f3e8c9f11

data/lib/ldap_groups_lookup/behavior.rb

@@ -6,14 +6,14 @@ module LDAPGroupsLookup
 
     # @return String object's mail attribute
     def ldap_mail
-      return '' unless respond_to? :ldap_lookup_key
+      return '' unless respond_to?(:ldap_lookup_key) && ldap_lookup_key.to_s.size.positive?
       LDAPGroupsLookup.lookup_mail(ldap_lookup_key)
     end
 
     # Searches object's nested LDAP groups by value of ldap_lookup_key
     # @return [Array] all of the object's LDAP groups, sorted
     def ldap_groups
-      return [] unless respond_to? :ldap_lookup_key
+      return [] unless respond_to?(:ldap_lookup_key) && ldap_lookup_key.to_s.size.positive?
       LDAPGroupsLookup.walk_ldap_groups(
           LDAPGroupsLookup.ldap_member_of(ldap_lookup_key)
       ).sort
@@ -23,10 +23,10 @@ module LDAPGroupsLookup
     # @param [Array] groups is a list of group CN strings to search within
     # @return [Boolean]
     def member_of_ldap_group?(groups)
-      return false unless respond_to? :ldap_lookup_key
+      return false unless respond_to?(:ldap_lookup_key) && ldap_lookup_key.to_s.size.positive?
       return false if LDAPGroupsLookup.service.nil?
       groups = [groups] if groups.is_a? String
-      dn = LDAPGroupsLookup.lookup_dn ldap_lookup_key
+      dn = LDAPGroupsLookup.lookup_dn(ldap_lookup_key)
       return LDAPGroupsLookup.walk_ldap_members(groups, dn)
     end
   end

data/lib/ldap_groups_lookup/version.rb

@@ -1,5 +1,5 @@
 # Gem version release tracking
 module LDAPGroupsLookup
   # Define release version
-  VERSION = '0.6.0'.freeze
+  VERSION = '0.6.1'.freeze
 end

data/spec/lib/ldap_groups_lookup_spec.rb

@@ -72,12 +72,18 @@ RSpec.describe LDAPGroupsLookup do
       allow_any_instance_of(Net::LDAP).to receive(:search).and_return([entry])
       allow_any_instance_of(Net::LDAP).to receive(:bind).and_return(true)
     end
-    context 'when subject does not provide ldap_lookup_key' do
+    context 'when subject does not provide ldap_lookup_key method' do
       before(:each) { user.class.send(:remove_method, :ldap_lookup_key) }
       it 'should return ''' do
         expect(user.ldap_mail).to eq('')
       end
     end
+    context 'when subject does not provide ldap_lookup_key value' do
+      before(:each) { allow(user).to receive(:ldap_lookup_key).and_return(nil) }
+      it 'should return ''' do
+        expect(user.ldap_mail).to eq('')
+      end
+    end
     context 'when subject provides ldap_lookup_key' do
       context 'when LDAP is not configured' do
         before(:each) do
@@ -103,12 +109,18 @@ RSpec.describe LDAPGroupsLookup do
       allow_any_instance_of(Net::LDAP).to receive(:search).and_return([entry])
       allow_any_instance_of(Net::LDAP).to receive(:bind).and_return(true)
     end
-    context 'when subject does not provide ldap_lookup_key' do
+    context 'when subject does not provide ldap_lookup_key method' do
       before(:each) { user.class.send(:remove_method, :ldap_lookup_key) }
       it 'should return []' do
         expect(user.ldap_groups).to eq([])
       end
     end
+    context 'when subject does not provide ldap_lookup_key value' do
+      before(:each) { allow(user).to receive(:ldap_lookup_key).and_return(nil) }
+      it 'should return []' do
+        expect(user.ldap_groups).to eq([])
+      end
+    end
     context 'when subject provides ldap_lookup_key' do
       context 'when LDAP is not configured' do
         before(:each) do
@@ -127,12 +139,18 @@ RSpec.describe LDAPGroupsLookup do
   end
 
   describe '#member_of_ldap_group?' do
-    context 'when subject does not provide ldap_lookup_key' do
+    context 'when subject does not provide ldap_lookup_key method' do
       before(:each) { user.class.send(:remove_method, :ldap_lookup_key) }
       it 'should return false' do
         expect(user.member_of_ldap_group?('Test-Group')).to eq(false)
       end
     end
+    context 'when subject does not provide ldap_lookup_key value' do
+      before(:each) { allow(user).to receive(:ldap_lookup_key).and_return(nil) }
+      it 'should return false' do
+        expect(user.member_of_ldap_group?('Test-Group')).to eq(false)
+      end
+    end
     context 'when subject provides ldap_lookup_key' do
       context 'when LDAP is not configured' do
         before(:each) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ldap_groups_lookup
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Adam Ploshay
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-14 00:00:00.000000000 Z
+date: 2019-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-ldap
@@ -112,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Provides easy access to the list of LDAP groups a username is a member of.