ld-eventsource 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a5949132cfd8b9aa8ce29c12de9b7eb37bb7b12f
-  data.tar.gz: db91678ed8ed19ef586c1acafbe926a3ad57d1ce
+  metadata.gz: 8af7db395f6a4a500ea56ff3f742aab25b8ca416
+  data.tar.gz: ee59c90efdf456e277a6f6ea7209a62941dbe96b
 SHA512:
-  metadata.gz: d8b525565f92caf2f15b692e06afd484da52cd82959d1d862e9ed994842a29fa0074e78be032ea81ec0bd4051540a38055fd1aa90a46599f95550ee75f41c0a2
-  data.tar.gz: 69605c60dabfebcddcde3fd23eb3f8f7962d69ff81a9f6975a2a2b9a93851bf78a8444c7f25ef41e3a0bc60ab13debd8347a8a8f6ed4a68fecb983f6ba6571a5
+  metadata.gz: 3c1c5e63d0f8bcff6c27a60f9a8cb04f5d1ffc3e4128bc5d9822f19663934b70ab3f90725ba747b4e13cc77c154c8d23605ed677c392dab980fd56c3d87d8cef
+  data.tar.gz: eec5bfce676d858bca4d8c687c043d45f2e200d3fb8819d693e81812e5504f597fcbed9bbe011d29f4aba967ee17de1e1302b3b673fbb5d2b9af03ba6558a823

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to the LaunchDarkly SSE Client for Ruby will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [1.0.2] - 2020-03-10
+### Removed:
+- Removed an unused dependency on `rake`. There are no other changes in this release.
+
+
 ## [1.0.1] - 2019-07-10
 ### Fixed:
 - Calling `close` on the client could cause a misleading warning message in the log, such as `Unexpected error from event source: #<IOError: stream closed in another thread>`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ld-eventsource (1.0.2)
+    ld-eventsource (1.0.3)
       concurrent-ruby (~> 1.0)
       http_tools (~> 0.4.5)
       socketry (~> 0.5.1)

data/lib/ld-eventsource/impl/backoff.rb

@@ -38,10 +38,6 @@ module SSE
           good_duration = Time.now.to_f - @last_good_time
           @attempts = 0 if good_duration >= @reconnect_reset_interval
         end
-        if @attempts == 0
-          @attempts += 1
-          return 0
-        end
         @last_good_time = nil
         target = ([@base_interval * (2 ** @attempts), @max_interval].min).to_f
         @attempts += 1

data/lib/ld-eventsource/version.rb

@@ -1,3 +1,3 @@
 module SSE
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/spec/backoff_spec.rb

@@ -0,0 +1,50 @@
+require "ld-eventsource"
+
+module SSE
+  module Impl
+    describe Backoff do
+      it "increases exponentially with jitter" do
+        initial = 1.5
+        max = 60
+        b = Backoff.new(initial, max)
+        previous = 0
+
+        for i in 1..6 do
+          interval = b.next_interval
+          expect(interval).to be > previous
+          target = initial * (2 ** (i - 1))
+          expect(interval).to be <= target
+          expect(interval).to be >= target / 2
+          previous = i
+        end
+
+        interval = b.next_interval
+        expect(interval).to be >= previous
+        expect(interval).to be <= max
+      end
+
+      it "resets to initial delay if reset threshold has elapsed" do
+        initial = 1.5
+        max = 60
+        threshold = 2
+        b = Backoff.new(initial, max, reconnect_reset_interval: threshold)
+
+        for i in 1..6 do
+          # just cause the backoff to increase quickly, don't actually do these delays
+          b.next_interval
+        end
+
+        b.mark_success
+        sleep(threshold + 0.001)
+
+        interval = b.next_interval
+        expect(interval).to be <= initial
+        expect(interval).to be >= initial / 2
+
+        interval = b.next_interval # make sure it continues increasing after that
+        expect(interval).to be <= (initial * 2)
+        expect(interval).to be >= initial
+      end
+    end
+  end
+end

data/spec/client_spec.rb

@@ -330,7 +330,7 @@ EOT
           expect(event_sink.pop).to eq(simple_event_1)
           if i > 0
             interval = request_times[i] - request_end_times[i - 1]
-            expect(interval).to be <= initial_interval
+            expect(interval).to be <= (initial_interval + 0.1)
           end
         end
       end
@@ -362,7 +362,7 @@ EOT
       with_client(client) do |client|
         expect(event_sink.pop).to eq(simple_event_1)
         interval = request_times[1] - request_times[0]
-        expect(interval).to be < ((retry_ms.to_f / 1000) + 0.1)
+        expect(interval).to be < 0.5
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ld-eventsource
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - LaunchDarkly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-10 00:00:00.000000000 Z
+date: 2020-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -120,6 +120,7 @@ files:
 - lib/ld-eventsource/version.rb
 - scripts/gendocs.sh
 - scripts/release.sh
+- spec/backoff_spec.rb
 - spec/client_spec.rb
 - spec/event_parser_spec.rb
 - spec/http_stub.rb
@@ -149,6 +150,7 @@ signing_key:
 specification_version: 4
 summary: LaunchDarkly SSE client
 test_files:
+- spec/backoff_spec.rb
 - spec/client_spec.rb
 - spec/event_parser_spec.rb
 - spec/http_stub.rb