lcgstyle 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cc02e8d9bc1bfc0c9ae1016e9b35ad4f7c9d36b8
-  data.tar.gz: 2097d7d115f520481145fbbe8082e5b0636059b9
+  metadata.gz: 0f433e407d8e15ab734fec19d0bb2fb70ddbe320
+  data.tar.gz: d9e4ed098c918cb53c3122dea4c600e794dde452
 SHA512:
-  metadata.gz: acb07cb3e984f30d999ccbb9bc7a2df94a72ef28a7ac645ac0a58cf26ac43c2bfbea3333a9b375dca70e2d3281e2ddc20df2086a0314363a38b56ee160a39d02
-  data.tar.gz: c6f1703ad11ba725f8213101c2c32d8494ead64c7e63b75336122a74ced529b61c34c7ac6532c413d32efe414ec1d88d9da427b2bd8f4193a725072c5620db6d
+  metadata.gz: 1c1d71af9a43253eaa1c06f785a1223ff442b83c59b92b5e58d345abb6bbf311ef7d3d1b4cf9c520410057d714f323581535d2927ee915c90bc115505fff3bf2
+  data.tar.gz: 466ed8e4eae19517174b0e2fe9c8334720661b9cd158f7e6b879587346de0884a9fe2f38d013479a557b5093f09dc0f19a48b09c18ef1c6266a53bcb2c97597d

data/config/chefstyle.yml

@@ -99,7 +99,7 @@ Lint/RescueException:
   Enabled: false
 
 # we have lots of not-insecure uses of eval
-Lint/Eval:
+Security/Eval:
   Enabled: false
 
 # disabling this will make it easier to stage chefstyle rollouts
@@ -522,3 +522,10 @@ Style/EmptyCaseCondition:
 Style/MultilineArrayBraceLayout:
   Enabled: false
 
+# This rule isn't smart enough to figure out accessors vs. things that set stuff on the system (e.g. set_member method in group providers)
+Style/AccessorMethodName:
+  Enabled: false
+
+# Perl backrefs are just fine and the alternative is a lot of typing.
+Style/PerlBackrefs:
+  Enabled: false

data/config/disable_all.yml

@@ -1,4 +1,8 @@
 ---
+Bundler/DuplicatedGem:
+  Enabled: false
+Bundler/OrderedGems:
+  Enabled: false
 Lint/AmbiguousOperator:
   Enabled: false
 Lint/AmbiguousRegexpLiteral:
@@ -41,8 +45,6 @@ Lint/EndInMethod:
   Enabled: false
 Lint/EnsureReturn:
   Enabled: false
-Lint/Eval:
-  Enabled: false
 Lint/FloatOutOfRange:
   Enabled: false
 Lint/FormatParameterMismatch:
@@ -63,6 +65,8 @@ Lint/LiteralInInterpolation:
   Enabled: false
 Lint/Loop:
   Enabled: false
+Lint/MultipleCompare:
+  Enabled: false
 Lint/NestedMethodDefinition:
   Enabled: false
 Lint/NextWithoutAccumulator:
@@ -81,6 +85,8 @@ Lint/RequireParentheses:
   Enabled: false
 Lint/RescueException:
   Enabled: false
+Lint/SafeNavigationChain:
+  Enabled: false
 Lint/ShadowedException:
   Enabled: false
 Lint/ShadowingOuterLocalVariable:
@@ -163,13 +169,15 @@ Performance/RedundantMerge:
   Enabled: false
 Performance/RedundantSortBy:
   Enabled: false
+Performance/RegexpMatch:
+  Enabled: false
 Performance/ReverseEach:
   Enabled: false
 Performance/Sample:
   Enabled: false
 Performance/Size:
   Enabled: false
-Performance/SortWithBlock:
+Performance/CompareWithBlock:
   Enabled: false
 Performance/StartWith:
   Enabled: false
@@ -285,6 +293,8 @@ Style/EmptyLinesAroundModuleBody:
   Enabled: false
 Style/EmptyLiteral:
   Enabled: false
+Style/EmptyMethod:
+  Enabled: false
 Style/Encoding:
   Enabled: false
 Style/EndBlock:
@@ -357,7 +367,9 @@ Style/LeadingCommentSpace:
   Enabled: false
 Style/LineEndConcatenation:
   Enabled: false
-Style/MethodCallParentheses:
+Style/MethodCallWithoutArgsParentheses:
+  Enabled: false
+Style/MethodCallWithArgsParentheses:
   Enabled: false
 Style/MethodCalledOnDoEndBlock:
   Enabled: false
@@ -593,8 +605,12 @@ Rails/Delegate:
   Enabled: false
 Rails/DelegateAllowBlank:
   Enabled: false
+Rails/EnumUniqueness:
+  Enabled: false
 Rails/Exit:
   Enabled: false
+Rails/FilePath:
+  Enabled: false
 Rails/FindBy:
   Enabled: false
 Rails/FindEach:
@@ -615,17 +631,27 @@ Rails/ReadWriteAttribute:
   Enabled: false
 Rails/RequestReferer:
   Enabled: false
+Rails/ReversibleMigration:
+  Enabled: false
 Rails/SafeNavigation:
   Enabled: false
 Rails/SaveBang:
   Enabled: false
 Rails/ScopeArgs:
   Enabled: false
+Rails/SkipsModelValidations:
+  Enabled: false
 Rails/TimeZone:
   Enabled: false
 Rails/UniqBeforePluck:
   Enabled: false
 Rails/Validation:
   Enabled: false
+Security/Eval:
+  Enabled: false
 Security/JSONLoad:
   Enabled: false
+Security/MarshalLoad:
+  Enabled: false
+Security/YAMLLoad:
+  Enabled: false

data/config/disabled.yml

@@ -69,6 +69,11 @@ Style/InlineComment:
   Description: 'Avoid trailing inline comments.'
   Enabled: false
 
+Style/MethodCallWithArgsParentheses:
+  Description: 'Use parentheses for method calls with arguments.'
+  StyleGuide: '#method-invocation-parens'
+  Enabled: false
+
 Style/MethodCalledOnDoEndBlock:
   Description: 'Avoid chaining a method call on a do...end block.'
   StyleGuide: '#single-line-blocks'
@@ -113,3 +118,7 @@ Style/SymbolArray:
   Description: 'Use %i or %I for arrays of symbols.'
   StyleGuide: '#percent-i'
   Enabled: false
+
+Style/SingleLineBlockParams:
+  Description: 'Enforces the names of some block params.'
+  Enabled: false

data/config/enabled.yml

@@ -244,6 +244,11 @@ Style/EmptyLiteral:
   StyleGuide: '#literal-array-hash'
   Enabled: true
 
+Style/EmptyMethod:
+  Description: 'Checks the formatting of empty method definitions.'
+  StyleGuide: '#no-single-line-methods'
+  Enabled: true
+
 Style/EndBlock:
   Description: 'Avoid the use of END blocks.'
   StyleGuide: '#no-END-blocks'
@@ -399,7 +404,7 @@ Style/LineEndConcatenation:
                  line end.
   Enabled: true
 
-Style/MethodCallParentheses:
+Style/MethodCallWithoutArgsParentheses:
   Description: 'Do not use parentheses for method calls with no arguments.'
   StyleGuide: '#method-invocation-parens'
   Enabled: true
@@ -602,7 +607,7 @@ Style/ParenthesesAroundCondition:
   Description: >-
                  Don't use parentheses around the condition of an
                  if/unless/while.
-  StyleGuide: '#no-parens-if'
+  StyleGuide: '#no-parens-around-condition'
   Enabled: true
 
 Style/PercentLiteralDelimiters:
@@ -705,10 +710,6 @@ Style/SignalException:
   StyleGuide: '#prefer-raise-over-fail'
   Enabled: true
 
-Style/SingleLineBlockParams:
-  Description: 'Enforces the names of some block params.'
-  Enabled: true
-
 Style/SingleLineMethods:
   Description: 'Avoid single-line methods.'
   StyleGuide: '#no-single-line-methods'
@@ -1115,10 +1116,6 @@ Lint/EnsureReturn:
   StyleGuide: '#no-return-ensure'
   Enabled: true
 
-Lint/Eval:
-  Description: 'The use of eval represents a serious security risk.'
-  Enabled: true
-
 Lint/FloatOutOfRange:
   Description: >-
                  Catches floating-point literals too large or small for Ruby to
@@ -1171,6 +1168,10 @@ Lint/Loop:
   StyleGuide: '#loop-with-break'
   Enabled: true
 
+Lint/MultipleCompare:
+  Description: "Use `&&` operator to compare multiple value."
+  Enabled: true
+
 Lint/NestedMethodDefinition:
   Description: 'Do not use nested method definitions.'
   StyleGuide: '#no-nested-methods'
@@ -1220,6 +1221,10 @@ Lint/RescueException:
   StyleGuide: '#no-blind-rescues'
   Enabled: true
 
+Lint/SafeNavigationChain:
+  Description: 'Do not chain ordinary method call after safe navigation operator.'
+  Enabled: true
+
 Lint/ShadowedException:
   Description: >-
                   Avoid rescuing a higher level exception
@@ -1274,6 +1279,7 @@ Lint/UselessAccessModifier:
   Description: 'Checks for useless access modifiers.'
   Enabled: true
   ContextCreatingMethods: []
+  MethodCreatingMethods: []
 
 Lint/UselessAssignment:
   Description: 'Checks for useless assignment to a local variable.'
@@ -1403,6 +1409,10 @@ Performance/RedundantSortBy:
   Description: 'Use `sort` instead of `sort_by { |x| x }`.'
   Enabled: true
 
+Performance/RegexpMatch:
+  Description: 'Use `match?` instead of `Regexp#match`, `String#match`, `Symbol#match`, `Regexp#===` or `=~` when `MatchData` is not used.'
+  Enabled: true
+
 Performance/ReverseEach:
   Description: 'Use `reverse_each` instead of `reverse.each`.'
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerablereverseeach-vs-enumerablereverse_each-code'
@@ -1422,7 +1432,7 @@ Performance/Size:
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#arraycount-vs-arraysize-code'
   Enabled: true
 
-Performance/SortWithBlock:
+Performance/CompareWithBlock:
   Description: 'Use `sort_by(&:foo)` instead of `sort_by { |a, b| a.foo <=> b.foo }`.'
   Enabled: true
 
@@ -1472,6 +1482,10 @@ Rails/DynamicFindBy:
   StyleGuide: 'https://github.com/bbatsov/rails-style-guide#find_by'
   Enabled: true
 
+Rails/EnumUniqueness:
+  Description: 'Avoid duplicate integers in hash-syntax `enum` declaration.'
+  Enabled: true
+
 Rails/Exit:
   Description: >-
                   Favor `fail`, `break`, `return`, etc. over `exit` in
@@ -1479,6 +1493,10 @@ Rails/Exit:
                   exits during unit testing or running in production.
   Enabled: true
 
+Rails/FilePath:
+  Description: 'Use `Rails.root.join` for file path joining.'
+  Enabled: true
+
 Rails/FindBy:
   Description: 'Prefer find_by over where.first.'
   StyleGuide: 'https://github.com/bbatsov/rails-style-guide#find_by'
@@ -1528,6 +1546,12 @@ Rails/RequestReferer:
   Description: 'Use consistent syntax for request.referer.'
   Enabled: true
 
+Rails/ReversibleMigration:
+  Description: 'Checks whether the change method of the migration file is reversible.'
+  StyleGuide: 'https://github.com/bbatsov/rails-style-guide#reversible-migration'
+  Reference: 'http://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html'
+  Enabled: true
+
 Rails/SafeNavigation:
   Description: "Use Ruby's safe navigation operator (`&.`) instead of `try!`"
   Enabled: true
@@ -1546,10 +1570,21 @@ Rails/UniqBeforePluck:
   Description: 'Prefer the use of uniq or distinct before pluck.'
   Enabled: true
 
+Rails/SkipsModelValidations:
+  Description: >-
+                 Use methods that skips model validations with caution.
+                 See reference for more information.
+  Reference: 'http://guides.rubyonrails.org/active_record_validations.html#skipping-validations'
+  Enabled: true
+
 Rails/Validation:
   Description: 'Use validates :attribute, hash of validations.'
   Enabled: true
 
+Security/Eval:
+  Description: 'The use of eval represents a serious security risk.'
+  Enabled: true
+
 Security/JSONLoad:
   Description: >-
                  Prefer usage of `JSON.parse` over `JSON.load` due to potential
@@ -1559,3 +1594,35 @@ Security/JSONLoad:
   # Autocorrect here will change to a method that may cause crashes depending
   # on the value of the argument.
   AutoCorrect: false
+
+Security/MarshalLoad:
+  Description: >-
+                 Avoid using of `Marshal.load` or `Marshal.restore` due to potential
+                 security issues. See reference for more information.
+  Reference: 'http://ruby-doc.org/core-2.3.3/Marshal.html#module-Marshal-label-Security+considerations'
+  Enabled: true
+
+Security/YAMLLoad:
+  Description: >-
+                 Prefer usage of `YAML.safe_load` over `YAML.load` due to potential
+                 security issues. See reference for more information.
+  Reference: 'https://ruby-doc.org/stdlib-2.3.3/libdoc/yaml/rdoc/YAML.html#module-YAML-label-Security'
+  Enabled: true
+
+##################### Bundler #############################
+
+Bundler/DuplicatedGem:
+  Description: 'Checks for duplicate gem entries in Gemfile.'
+  Enabled: true
+  Include:
+    - '**/Gemfile'
+    - '**/gems.rb'
+
+Bundler/OrderedGems:
+  Description: >-
+                 Sort alphabetically gems appearing within a contiguous set
+                 of lines in the Gemfile
+  Enabled: true
+  Include:
+    - '**/Gemfile'
+    - '**/gems.rb'

data/config/upstream.yml

@@ -29,35 +29,35 @@ AllCops:
     - '**/*Fastfile'
   Exclude:
     - 'vendor/**/*'
-  # Default formatter will be used if no -f/--format option is given.
+  # Default formatter will be used if no `-f/--format` option is given.
   DefaultFormatter: progress
   # Cop names are not displayed in offense messages by default. Change behavior
-  # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
+  # by overriding DisplayCopNames, or by giving the `-D/--display-cop-names`
   # option.
   DisplayCopNames: false
   # Style guide URLs are not displayed in offense messages by default. Change
-  # behavior by overriding DisplayStyleGuide, or by giving the
-  # -S/--display-style-guide option.
+  # behavior by overriding `DisplayStyleGuide`, or by giving the
+  # `-S/--display-style-guide` option.
   DisplayStyleGuide: false
   # When specifying style guide URLs, any paths and/or fragments will be
   # evaluated relative to the base URL.
   StyleGuideBaseURL: https://github.com/bbatsov/ruby-style-guide
   # Extra details are not displayed in offense messages by default. Change
   # behavior by overriding ExtraDetails, or by giving the
-  # -E/--extra-details option.
+  # `-E/--extra-details` option.
   ExtraDetails: false
   # Additional cops that do not reference a style guide rule may be enabled by
-  # default. Change behavior by overriding StyleGuideCopsOnly, or by giving
-  # the --only-guide-cops option.
+  # default. Change behavior by overriding `StyleGuideCopsOnly`, or by giving
+  # the `--only-guide-cops` option.
   StyleGuideCopsOnly: false
   # All cops except the ones in disabled.yml are enabled by default. Change
-  # this behavior by overriding DisabledByDefault. When DisabledByDefault is
-  # true, all cops in the default configuration are disabled, and and only cops
+  # this behavior by overriding `DisabledByDefault`. When `DisabledByDefault` is
+  # `true`, all cops in the default configuration are disabled, and only cops
   # in user configuration are enabled. This makes cops opt-in instead of
-  # opt-out. Note that when DisabledByDefault is true, cops in user
+  # opt-out. Note that when `DisabledByDefault` is `true`, cops in user
   # configuration will be enabled even if they don't set the Enabled parameter.
   DisabledByDefault: false
-  # Enables the result cache if true. Can be overridden by the --cache command
+  # Enables the result cache if `true`. Can be overridden by the `--cache` command
   # line option.
   UseCache: true
   # Threshold for how many files can be stored in the result cache before some
@@ -113,6 +113,10 @@ Style/AlignHash:
   #   'a'  => 2
   #   'bb' => 3
   EnforcedHashRocketStyle: key
+  SupportedHashRocketStyles:
+    - key
+    - separator
+    - table
   # Alignment of entries using colon as separator. Valid values are:
   #
   # key - left alignment of keys
@@ -125,6 +129,10 @@ Style/AlignHash:
   #   a:  0
   #   bb: 1
   EnforcedColonStyle: key
+  SupportedColonStyles:
+    - key
+    - separator
+    - table
   # Select whether hashes that are the last argument in a method call should be
   # inspected? Valid values are:
   #
@@ -194,7 +202,7 @@ Style/AndOr:
     - conditionals
 
 
-# Checks if usage of %() or %Q() matches configuration.
+# Checks if usage of `%()` or `%Q()` matches configuration.
 Style/BarePercentLiterals:
   EnforcedStyle: bare_percent
   SupportedStyles:
@@ -288,14 +296,14 @@ Style/BracesAroundHashParameters:
 
 # Indentation of `when`.
 Style/CaseIndentation:
-  IndentWhenRelativeTo: case
+  EnforcedStyle: case
   SupportedStyles:
     - case
     - end
   IndentOneStep: false
-  # By default, the indentation width from Style/IndentationWidth is used
-  # But it can be overridden by setting this parameter
-  # This only matters if IndentOneStep is true
+  # By default, the indentation width from `Style/IndentationWidth` is used.
+  # But it can be overridden by setting this parameter.
+  # This only matters if `IndentOneStep` is `true`
   IndentationWidth: ~
 
 Style/ClassAndModuleChildren:
@@ -313,7 +321,7 @@ Style/ClassAndModuleChildren:
   #   class Foo::Bar
   #   end
   #
-  # The compact style is only forced, for classes / modules with one child.
+  # The compact style is only forced, for classes or modules with one child.
   EnforcedStyle: nested
   SupportedStyles:
     - nested
@@ -340,17 +348,17 @@ Style/CollectionMethods:
     detect: 'find'
     find_all: 'select'
 
-# Use ` or %x around command literals.
+# Use '`' or '%x' around command literals.
 Style/CommandLiteral:
   EnforcedStyle: backticks
   # backticks: Always use backticks.
-  # percent_x: Always use %x.
-  # mixed: Use backticks on single-line commands, and %x on multi-line commands.
+  # percent_x: Always use `%x`.
+  # mixed: Use backticks on single-line commands, and `%x` on multi-line commands.
   SupportedStyles:
     - backticks
     - percent_x
     - mixed
-  # If false, the cop will always recommend using %x if one or more backticks
+  # If `false`, the cop will always recommend using `%x` if one or more backticks
   # are found in the command string.
   AllowInnerBackticks: false
 
@@ -375,14 +383,15 @@ Style/ConditionalAssignment:
   # will only register an offense for assignment to a condition that has
   # at least one multiline branch.
   SingleLineConditionsOnly: true
+  IncludeTernaryExpressions: true
 
 # Checks that you have put a copyright in a comment before any code.
 #
 # You can override the default Notice in your .rubocop.yml file.
 #
 # In order to use autocorrect, you must supply a value for the
-# AutocorrectNotice key that matches the regexp Notice.  A blank
-# AutocorrectNotice will cause an error during autocorrect.
+# `AutocorrectNotice` key that matches the regexp Notice.  A blank
+# `AutocorrectNotice` will cause an error during autocorrect.
 #
 # Autocorrect will add a copyright notice in a comment at the top
 # of the file immediately after any shebang or encoding comments.
@@ -409,9 +418,9 @@ Style/DotPosition:
     - trailing
 
 # Warn on empty else statements
-# empty - warn only on empty else
-# nil - warn on else with nil in it
-# both - warn on empty else and else with nil in it
+# empty - warn only on empty `else`
+# nil - warn on `else` with nil in it
+# both - warn on empty `else` and `else` with nil in it
 Style/EmptyElse:
   EnforcedStyle: both
   SupportedStyles:
@@ -421,7 +430,7 @@ Style/EmptyElse:
 
 # Use empty lines between defs.
 Style/EmptyLineBetweenDefs:
-  # If true, this parameter means that single line method definitions don't
+  # If `true`, this parameter means that single line method definitions don't
   # need an empty line between them.
   AllowAdjacentOneLineDefs: false
 
@@ -436,6 +445,7 @@ Style/EmptyLinesAroundClassBody:
   SupportedStyles:
     - empty_lines
     - empty_lines_except_namespace
+    - empty_lines_special
     - no_empty_lines
 
 Style/EmptyLinesAroundModuleBody:
@@ -443,8 +453,15 @@ Style/EmptyLinesAroundModuleBody:
   SupportedStyles:
     - empty_lines
     - empty_lines_except_namespace
+    - empty_lines_special
     - no_empty_lines
 
+Style/EmptyMethod:
+  EnforcedStyle: compact
+  SupportedStyles:
+    - compact
+    - expanded
+
 # Checks whether the source file has a utf-8 encoding comment or not
 # AutoCorrectEncodingComment must match the regex
 # /#.*coding\s?[:=]\s?(?:UTF|utf)-8/
@@ -461,19 +478,19 @@ Style/ExtraSpacing:
   # things with the previous or next line, not counting empty lines or comment
   # lines.
   AllowForAlignment: true
-  # When true, forces the alignment of = in assignments on consecutive lines.
+  # When true, forces the alignment of `=` in assignments on consecutive lines.
   ForceEqualSignAlignment: false
 
 Style/FileName:
-  # File names listed in AllCops:Include are excluded by default. Add extra
+  # File names listed in `AllCops:Include` are excluded by default. Add extra
   # excludes here.
   Exclude: []
-  # When true, requires that each source file should define a class or module
+  # When `true`, requires that each source file should define a class or module
   # with a name which matches the file name (converted to ... case).
   # It further expects it to be nested inside modules which match the names
   # of subdirectories in its path.
   ExpectMatchingDefinition: false
-  # If non-nil, expect all source file names to match the following regex.
+  # If non-`nil`, expect all source file names to match the following regex.
   # Only the file name itself is matched, not the entire file path.
   # Use anchors as necessary if you want to match the entire name rather than
   # just a part of it.
@@ -482,6 +499,47 @@ Style/FileName:
   # report offending filenames for executable scripts (i.e. source
   # files with a shebang in the first line).
   IgnoreExecutableScripts: true
+  AllowedAcronyms:
+    - CLI
+    - DSL
+    - ACL
+    - API
+    - ASCII
+    - CPU
+    - CSS
+    - DNS
+    - EOF
+    - GUID
+    - HTML
+    - HTTP
+    - HTTPS
+    - ID
+    - IP
+    - JSON
+    - LHS
+    - QPS
+    - RAM
+    - RHS
+    - RPC
+    - SLA
+    - SMTP
+    - SQL
+    - SSH
+    - TCP
+    - TLS
+    - TTL
+    - UDP
+    - UI
+    - UID
+    - UUID
+    - URI
+    - URL
+    - UTF8
+    - VM
+    - XML
+    - XMPP
+    - XSRF
+    - XSS
 
 Style/FirstParameterIndentation:
   EnforcedStyle: special_for_inner_method_call_in_parentheses
@@ -494,10 +552,10 @@ Style/FirstParameterIndentation:
     # a parameter in a method call, then the inner parameter should be indented
     # relative to the inner method.
     - special_for_inner_method_call
-    # Same as special_for_inner_method_call except that the special rule only
+    # Same as `special_for_inner_method_call` except that the special rule only
     # applies if the outer method call encloses its arguments in parentheses.
     - special_for_inner_method_call_in_parentheses
-  # By default, the indentation width from Style/IndentationWidth is used
+  # By default, the indentation width from `Style/IndentationWidth` is used
   # But it can be overridden by setting this parameter
   IndentationWidth: ~
 
@@ -527,12 +585,15 @@ Style/FrozenStringLiteralComment:
     # string literal. If you run code against multiple versions of Ruby, it is
     # possible that this will create errors in Ruby 2.3.0+.
     - always
+    # `never` will enforce that the frozen string literal comment does not
+    # exist in a file.
+    - never
 
 # Built-in global variables are allowed by default.
 Style/GlobalVars:
   AllowedVariables: []
 
-# `MinBodyLength` defines the number of lines of the a body of an if / unless
+# `MinBodyLength` defines the number of lines of the a body of an `if` or `unless`
 # needs to have to trigger this cop
 Style/GuardClause:
   MinBodyLength: 1
@@ -590,13 +651,13 @@ Style/IndentArray:
     - special_inside_parentheses
     - consistent
     - align_brackets
-  # By default, the indentation width from Style/IndentationWidth is used
+  # By default, the indentation width from `Style/IndentationWidth` is used
   # But it can be overridden by setting this parameter
   IndentationWidth: ~
 
 # Checks the indentation of assignment RHS, when on a different line from LHS
 Style/IndentAssignment:
-  # By default, the indentation width from Style/IndentationWidth is used
+  # By default, the indentation width from `Style/IndentationWidth` is used
   # But it can be overridden by setting this parameter
   IndentationWidth: ~
 
@@ -618,7 +679,7 @@ Style/IndentHash:
     - special_inside_parentheses
     - consistent
     - align_braces
-  # By default, the indentation width from Style/IndentationWidth is used
+  # By default, the indentation width from `Style/IndentationWidth` is used
   # But it can be overridden by setting this parameter
   IndentationWidth: ~
 
@@ -646,7 +707,7 @@ Style/Next:
   # replaced by next - with `skip_modifier_ifs` the modifier if like this one
   # are ignored: [1, 2].each { |a| return 'yes' if a == 1 }
   EnforcedStyle: skip_modifier_ifs
-  # `MinBodyLength` defines the number of lines of the a body of an if / unless
+  # `MinBodyLength` defines the number of lines of the a body of an `if` or `unless`
   # needs to have to trigger this cop
   MinBodyLength: 3
   SupportedStyles:
@@ -679,6 +740,9 @@ Style/MethodDefParentheses:
     - require_no_parentheses
     - require_no_parentheses_except_multiline
 
+Style/MethodCallWithArgsParentheses:
+  IgnoredMethods: []
+
 Style/MethodName:
   EnforcedStyle: snake_case
   SupportedStyles:
@@ -764,7 +828,7 @@ Style/MultilineOperationIndentation:
   SupportedStyles:
     - aligned
     - indented
-  # By default, the indentation width from Style/IndentationWidth is used
+  # By default, the indentation width from `Style/IndentationWidth` is used
   # But it can be overridden by setting this parameter
   IndentationWidth: ~
 
@@ -806,8 +870,8 @@ Style/PercentLiteralDelimiters:
 Style/PercentQLiterals:
   EnforcedStyle: lower_case_q
   SupportedStyles:
-    - lower_case_q # Use %q when possible, %Q when necessary
-    - upper_case_q # Always use %Q
+    - lower_case_q # Use `%q` when possible, `%Q` when necessary
+    - upper_case_q # Always use `%Q`
 
 Style/PredicateName:
   # Predicate name prefixes.
@@ -820,7 +884,7 @@ Style/PredicateName:
     - is_
     - has_
     - have_
-  # Predicate names which, despite having a blacklisted prefix, or no ?,
+  # Predicate names which, despite having a blacklisted prefix, or no `?`,
   # should still be accepted
   NameWhitelist:
     - is_a?
@@ -842,20 +906,20 @@ Style/RaiseArgs:
     - exploded # raise Exception, msg
 
 Style/RedundantReturn:
-  # When true allows code like `return x, y`.
+  # When `true` allows code like `return x, y`.
   AllowMultipleReturnValues: false
 
-# Use / or %r around regular expressions.
+# Use `/` or `%r` around regular expressions.
 Style/RegexpLiteral:
   EnforcedStyle: slashes
   # slashes: Always use slashes.
-  # percent_r: Always use %r.
-  # mixed: Use slashes on single-line regexes, and %r on multi-line regexes.
+  # percent_r: Always use `%r`.
+  # mixed: Use slashes on single-line regexes, and `%r` on multi-line regexes.
   SupportedStyles:
     - slashes
     - percent_r
     - mixed
-  # If false, the cop will always recommend using %r if one or more slashes
+  # If `false`, the cop will always recommend using `%r` if one or more slashes
   # are found in the regexp string.
   AllowInnerSlashes: false
 
@@ -865,7 +929,7 @@ Style/SafeNavigation:
   ConvertCodeThatCanStartToReturnNil: false
 
 Style/Semicolon:
-  # Allow ; to separate several expressions on the same line.
+  # Allow `;` to separate several expressions on the same line.
   AllowAsExpressionSeparator: false
 
 Style/SignalException:
@@ -888,7 +952,7 @@ Style/SingleLineMethods:
   AllowIfMethodIsEmpty: true
 
 Style/SpaceBeforeFirstArg:
-  # When true, allows most uses of extra spacing if the intent is to align
+  # When `true`, allows most uses of extra spacing if the intent is to align
   # things with the previous or next line, not counting empty lines or comment
   # lines.
   AllowForAlignment: true
@@ -910,7 +974,7 @@ Style/StringLiterals:
   SupportedStyles:
     - single_quotes
     - double_quotes
-  # If true, strings which span multiple lines using \ for continuation must
+  # If `true`, strings which span multiple lines using `\` for continuation must
   # use the same type of quotes on each line.
   ConsistentQuotesInMultiline: false
 
@@ -932,7 +996,7 @@ Style/StringMethods:
 
 Style/SpaceAroundBlockParameters:
   EnforcedStyleInsidePipes: no_space
-  SupportedStyles:
+  SupportedStylesInsidePipes:
     - space
     - no_space
 
@@ -943,7 +1007,7 @@ Style/SpaceAroundEqualsInParameterDefault:
     - no_space
 
 Style/SpaceAroundOperators:
-  # When true, allows most uses of extra spacing if the intent is to align
+  # When `true`, allows most uses of extra spacing if the intent is to align
   # with an operator on the previous or next line, not counting empty lines
   # or comment lines.
   AllowForAlignment: true
@@ -959,20 +1023,25 @@ Style/SpaceInsideBlockBraces:
   SupportedStyles:
     - space
     - no_space
-  # Valid values are: space, no_space
   EnforcedStyleForEmptyBraces: no_space
+  SupportedStylesForEmptyBraces:
+    - space
+    - no_space
   # Space between { and |. Overrides EnforcedStyle if there is a conflict.
   SpaceBeforeBlockParameters: true
 
 Style/SpaceInsideHashLiteralBraces:
   EnforcedStyle: space
-  EnforcedStyleForEmptyBraces: no_space
   SupportedStyles:
     - space
     - no_space
     # 'compact' normally requires a space inside hash braces, with the exception
     # that successive left braces or right braces are collapsed together
     - compact
+  EnforcedStyleForEmptyBraces: no_space
+  SupportedStylesForEmptyBraces:
+    - space
+    - no_space
 
 Style/SpaceInsideStringInterpolation:
   EnforcedStyle: no_space
@@ -998,6 +1067,7 @@ Style/TernaryParentheses:
   SupportedStyles:
     - require_parentheses
     - require_no_parentheses
+    - require_parentheses_when_complex
   AllowSafeAssignment: true
 
 Style/TrailingBlankLines:
@@ -1012,7 +1082,7 @@ Style/TrailingCommaInArguments:
   # If `consistent_comma`, the cop requires a comma after the last argument,
   # for all parenthesized method calls with arguments.
   EnforcedStyleForMultiline: no_comma
-  SupportedStyles:
+  SupportedStylesForMultiline:
     - comma
     - consistent_comma
     - no_comma
@@ -1023,7 +1093,7 @@ Style/TrailingCommaInLiteral:
   # If `consistent_comma`, the cop requires a comma after the last item of all
   # non-empty array and hash literals.
   EnforcedStyleForMultiline: no_comma
-  SupportedStyles:
+  SupportedStylesForMultiline:
     - comma
     - consistent_comma
     - no_comma
@@ -1031,7 +1101,7 @@ Style/TrailingCommaInLiteral:
 # TrivialAccessors requires exact name matches and doesn't allow
 # predicated methods by default.
 Style/TrivialAccessors:
-  # When set to false the cop will suggest the use of accessor methods
+  # When set to `false` the cop will suggest the use of accessor methods
   # in situations like:
   #
   # def name
@@ -1086,7 +1156,7 @@ Style/VariableNumber:
 Style/WhileUntilModifier:
   MaxLineLength: 80
 
-# WordArray enforces how array literals of word-like strings should be expressed.
+# `WordArray` enforces how array literals of word-like strings should be expressed.
 Style/WordArray:
   EnforcedStyle: percent
   SupportedStyles:
@@ -1094,11 +1164,11 @@ Style/WordArray:
     - percent
     # bracket style: ['word1', 'word2']
     - brackets
-  # The MinSize option causes the WordArray rule to be ignored for arrays
+  # The `MinSize` option causes the `WordArray` rule to be ignored for arrays
   # smaller than a certain size.  The rule is only applied to arrays
-  # whose element count is greater than or equal to MinSize.
+  # whose element count is greater than or equal to `MinSize`.
   MinSize: 0
-  # The regular expression WordRegex decides what is considered a word.
+  # The regular expression `WordRegex` decides what is considered a word.
   WordRegex: !ruby/regexp '/\A[\p{Word}\n\t]+\z/'
 
 ##################### Metrics ##################################
@@ -1109,6 +1179,7 @@ Metrics/AbcSize:
   Max: 15
 
 Metrics/BlockNesting:
+  CountBlocks: false
   Max: 3
 
 Metrics/ClassLength:
@@ -1135,6 +1206,10 @@ Metrics/LineLength:
   # The IgnoreCopDirectives option causes the LineLength rule to ignore cop
   # directives like '# rubocop: enable ...' when calculating a line's length.
   IgnoreCopDirectives: false
+  # The IgnoredPatterns option is a list of !ruby/regexp and/or string
+  # elements. Strings will be converted to Regexp objects. A line that matches
+  # any regular expression listed in this option will be ignored by LineLength.
+  IgnoredPatterns: []
 
 Metrics/MethodLength:
   CountComments: false  # count full line comments?
@@ -1143,10 +1218,7 @@ Metrics/MethodLength:
 Metrics/BlockLength:
   CountComments: false  # count full line comments?
   Max: 25
-  Exclude:
-    - 'Rakefile'
-    - '**/*.rake'
-    - 'spec/**/*.rb'
+  ExcludedMethods: []
 
 Metrics/ParameterLists:
   Max: 5
@@ -1168,8 +1240,8 @@ Lint/BlockAlignment:
   # The value `start_of_line` means it should be aligned with the whole
   # expression's starting line.
   # The value `either` means both are allowed.
-  AlignWith: either
-  SupportedStyles:
+  EnforcedStyleAlignWith: either
+  SupportedStylesAlignWith:
     - either
     - start_of_block
     - start_of_line
@@ -1177,14 +1249,14 @@ Lint/BlockAlignment:
 # Align ends correctly.
 Lint/EndAlignment:
   # The value `keyword` means that `end` should be aligned with the matching
-  # keyword (if, while, etc.).
+  # keyword (`if`, `while`, etc.).
   # The value `variable` means that in assignments, `end` should be aligned
   # with the start of the variable on the left hand side of `=`. In all other
   # situations, `end` should still be aligned with the keyword.
   # The value `start_of_line` means that `end` should be aligned with the start
   # of the line which the matching keyword appears on.
-  AlignWith: keyword
-  SupportedStyles:
+  EnforcedStyleAlignWith: keyword
+  SupportedStylesAlignWith:
     - keyword
     - variable
     - start_of_line
@@ -1195,8 +1267,8 @@ Lint/DefEndAlignment:
   # The value `start_of_line` means that `end` should be aligned with method
   # calls like `private`, `public`, etc, if present in front of the `def`
   # keyword on the same line.
-  AlignWith: start_of_line
-  SupportedStyles:
+  EnforcedStyleAlignWith: start_of_line
+  SupportedStylesAlignWith:
     - start_of_line
     - def
   AutoCorrect: false
@@ -1249,6 +1321,10 @@ Rails/DynamicFindBy:
   Whitelist:
     - find_by_sql
 
+Rails/EnumUniqueness:
+  Include:
+    - app/models/**/*.rb
+
 Rails/Exit:
   Include:
     - app/**/*.rb
@@ -1290,6 +1366,10 @@ Rails/RequestReferer:
     - referer
     - referrer
 
+Rails/ReversibleMigration:
+  Include:
+    - db/migrate/*.rb
+
 Rails/SafeNavigation:
   # This will convert usages of `try` to use safe navigation as well as `try!`.
   # `try` and `try!` work slighly differently. `try!` and safe navigation will
@@ -1310,12 +1390,26 @@ Rails/TimeZone:
     - flexible
 
 Rails/UniqBeforePluck:
-  EnforcedMode: conservative
-  SupportedModes:
+  EnforcedStyle: conservative
+  SupportedStyles:
     - conservative
     - aggressive
   AutoCorrect: false
 
+Rails/SkipsModelValidations:
+  Blacklist:
+    - decrement!
+    - decrement_counter
+    - increment!
+    - increment_counter
+    - toggle!
+    - touch
+    - update_all
+    - update_attribute
+    - update_column
+    - update_columns
+    - update_counters
+
 Rails/Validation:
   Include:
     - app/models/**/*.rb

data/lib/lcgstyle/version.rb

@@ -1,4 +1,4 @@
 module Lcgstyle
-  VERSION = "0.0.7".freeze
-  RUBOCOP_VERSION = "0.45.0".freeze
+  VERSION = "0.0.8".freeze
+  RUBOCOP_VERSION = "0.47.1".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lcgstyle
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Thom May
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-21 00:00:00.000000000 Z
+date: 2017-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.45.0
+        version: 0.47.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.45.0
+        version: 0.47.1
 description: 
 email:
 - thom@chef.io
@@ -112,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.9
 signing_key: 
 specification_version: 4
 summary: Rubocop configuration for Chef's ruby projects