lcbo 1.0.0 → 1.0.1

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+Version 1.0.1
+
+ * Fixed issue where `TagHelper` was not including words with apostrophes (')
+   or dashes (-).
+
 Version 1.0.0
 
  * Fixed issue that affected about 10 products in where if the name began

data/lib/lcbo/crawlkit/tag_helper.rb

@@ -1,7 +1,7 @@
 module LCBO
   module CrawlKit
     module TagHelper
-      DELETION_RE   = /\'|\"|\\|\/|\(|\)|\[|\]|\./
+      DELETION_RE   = /\"|\\|\/|\(|\)|\[|\]|\./
       WHITESPACE_RE = /\*|\+|\&|\_|\,|\s/
 
       def self.flatten(values)
@@ -21,14 +21,27 @@ module LCBO
       end
 
       def self.stem(word)
-        if word.include?('-')
-          parts = word.split('-')
-          a = parts.dup
-          a << parts.join
-          a
-        else
-          word
-        end
+        split = lambda { |word|
+          if word.include?('-')
+            words = word.split('-')
+            a = words.dup
+            a << word
+            a << words.join
+            a
+          else
+            [word]
+          end
+        }
+
+        tokenize = lambda { |words|
+          words.reduce([]) do |tokens, word|
+            tokens << word
+            tokens << word.gsub("'", '') if word.include?("'")
+            tokens
+          end
+        }
+
+        tokenize.(split.(word))
       end
 
       def self.[](*values)

data/lib/lcbo/version.rb

@@ -1,3 +1,3 @@
 module LCBO
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/spec/crawlkit/tag_helper_spec.rb

@@ -6,8 +6,9 @@ describe LCBO::CrawlKit::TagHelper do
     ['Hello World']         => %w[hello world],
     ['Éve Picard']          => %w[éve picard eve],
     ['Hello Hello World']   => %w[hello world],
+    ['É\'ve Picard-Rowe']   => %w[é've éve picard rowe picard-rowe picardrowe e've eve],
     ['Hello', 'Éve Picard'] => %w[hello éve picard eve],
-    ['Hello', 'Éve-Picard'] => %w[hello éve picard évepicard eve evepicard],
+    ['Hello', 'Éve-Picard'] => %w[hello éve picard éve-picard évepicard eve eve-picard evepicard],
     ['Hello', nil, 'World'] => %w[hello world]
   }
 

data/spec/pages/product_pages.yml

@@ -48,7 +48,7 @@
   :expectation:
     :id: 18
     :name: Heineken Lager
-    :tags: ["heineken", "lager", "beer", "netherlands", "heinekens", "brouwerijen", "nederland", "bv", "bottle"]
+    :tags: ["heineken", "lager", "beer", "netherlands", "heineken's", "heinekens", "brouwerijen", "nederland", "bv", "bottle"]
     :price_in_cents: 1250
     :regular_price_in_cents: 1350
     :limited_time_offer_savings_in_cents: 100
@@ -336,7 +336,7 @@
   :expectation:
     :id: 56796
     :name: Heineken Draught Keg
-    :tags: ["heineken", "draught", "keg", "beer", "lager", "netherlands", "heinekens", "brouwerijen", "nederland", "bv", "can"]
+    :tags: ["heineken", "draught", "keg", "beer", "lager", "netherlands", "heineken's", "heinekens", "brouwerijen", "nederland", "bv", "can"]
     :price_in_cents: 2995
     :regular_price_in_cents: 2995
     :limited_time_offer_savings_in_cents: 0

data/spec/pages/store_pages.yml

@@ -7,7 +7,7 @@
   :expectation:
     :id: 444
     :name: Kennedy & Sheppard
-    :tags: ["kennedy", "sheppard", "2356", "road", "agincourt", "mall", "toronto", "scarborough", "torontoscarborough", "m1t3h1"]
+    :tags: ["kennedy", "sheppard", "2356", "road", "agincourt", "mall", "toronto", "scarborough", "toronto-scarborough", "torontoscarborough", "m1t3h1"]
     :address_line_1: 2356 Kennedy Road
     :address_line_2: Agincourt Mall
     :city: Toronto-Scarborough

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 0
-  - 0
-  version: 1.0.0
+  - 1
+  version: 1.0.1
 platform: ruby
 authors: 
 - Carsten Nielsen
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-17 00:00:00 -05:00
+date: 2011-01-20 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency