lbfgsb 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3bd36b7d31d1cbc04ef90be26df3fcf67b73a1dbeba544a1c838f6b35786115
-  data.tar.gz: d09cc5f75361c4ec6c542ed7b663d87c8654e806cfdcd81415754f963074fbd1
+  metadata.gz: d3c9f07b919bd5a429225c6aa74e05b4c64ad9df9464388ffea2648560432573
+  data.tar.gz: 2f264cc51d1d7b3438ecdd0204b41cd7d1ad4c38e9b23c2f6fc0a2116e923cd0
 SHA512:
-  metadata.gz: ce048d758955f403e2d6c176f316e8f7e5db58dc142f91a0ee343fd0115a17b9b61c6a26a145eb1553dab6644f3f6cc5f6fa8ad04898287393247ef34de58fc0
-  data.tar.gz: 6d6e7dd5fbc941b37542de548385a6202322fbfebe5a6a77a9afbb169dcf9d421f7d79435dda881b5c3174948b47eb603a065c6726011f010c66e45b674c41d5
+  metadata.gz: 9ee089354c99d1eaa412f42f4e74e8b51124be569c4b56820a88e3e0dcaff79b8f23e24d4c12b49b89824ed5f6a4975024973a2d3be6fa0fe33a8f25b1fc5aaa
+  data.tar.gz: f6727155040cd9b36effa98056eabc826dbf7c4701973202238dea8145c0cd2cfa9b6cb55ffa9a01f01d4d1365438ed62cb2dca1b987b41e77a26661a1a5df28

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.2
+- Refactor native extension codes.
+- Update documentations.
+
 ## 0.3.1
 - Add GC guard to narray given to native extension method.
 

data/README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://github.com/yoshoku/lbfgsb.rb/workflows/build/badge.svg)](https://github.com/yoshoku/lbfgsb.rb/actions?query=workflow%3Abuild)
 [![Gem Version](https://badge.fury.io/rb/lbfgsb.svg)](https://badge.fury.io/rb/lbfgsb)
-[![BSD 3-Clause License](https://img.shields.io/badge/License-BSD%203--Clause-orange.svg)](https://github.com/yoshoku/suika/blob/master/LICENSE.txt)
+[![BSD 3-Clause License](https://img.shields.io/badge/License-BSD%203--Clause-orange.svg)](https://github.com/yoshoku/suika/blob/main/LICENSE.txt)
 [![Documentation](http://img.shields.io/badge/api-reference-blue.svg)](https://yoshoku.github.io/lbfgsb.rb/doc/)
 
 Lbfgsb.rb is a Ruby binding for [L-BFGS-B](http://users.iems.northwestern.edu/~nocedal/lbfgsb.html)

data/ext/lbfgsb/lbfgsbext.c

@@ -8,7 +8,6 @@ VALUE lbfgsb_min_l_bfgs_b(VALUE self,
   VALUE l_val, VALUE u_val, VALUE nbd_val,
   VALUE maxcor, VALUE ftol, VALUE gtol, VALUE maxiter, VALUE disp)
 {
-  long i;
   long n_iter;
   long n_fev;
   long n_jev;
@@ -19,12 +18,12 @@ VALUE lbfgsb_min_l_bfgs_b(VALUE self,
   narray_t* nbd_nary;
   long n;
   long m = NUM2LONG(maxcor);
-  double *x_ptr;
-  double *l_ptr;
-  double *u_ptr;
-  long *nbd_ptr;
+  double* x_ptr;
+  double* l_ptr;
+  double* u_ptr;
+  long* nbd_ptr;
   double f;
-  double *g;
+  double* g;
   double factr = NUM2DBL(ftol);
   double pgtol = NUM2DBL(gtol);
   double* wa;
@@ -35,7 +34,6 @@ VALUE lbfgsb_min_l_bfgs_b(VALUE self,
   long lsave[4];
   long isave[44];
   double dsave[29];
-  double* g_ptr;
   VALUE g_val;
   VALUE fg_arr;
   VALUE ret;
@@ -111,7 +109,7 @@ VALUE lbfgsb_min_l_bfgs_b(VALUE self,
 
   g_val = Qnil;
   f = 0.0;
-  for (i = 0; i < n; g[i++] = 0.0);
+  memset(g, 0, n * sizeof(*g));
   strcpy(task, "START");
   n_fev = 0;
   n_jev = 0;
@@ -130,15 +128,14 @@ VALUE lbfgsb_min_l_bfgs_b(VALUE self,
         f = NUM2DBL(rb_funcall(self, rb_intern("fnc"), 3, fnc, x_val, args));
         g_val = rb_funcall(self, rb_intern("jcb"), 3, jcb, x_val, args);
       }
-      n_fev += 1;
-      n_jev += 1;
+      n_fev++;
+      n_jev++;
       if (CLASS_OF(g_val) != numo_cDFloat) g_val = rb_funcall(numo_cDFloat, rb_intern("cast"), 1, g_val);
       if (!RTEST(nary_check_contiguous(g_val))) g_val = nary_dup(g_val);
-      g_ptr = (double*)na_get_pointer_for_read(g_val);
-      for (i = 0; i < n; i++) g[i] = g_ptr[i];
+      memcpy(g, na_get_pointer_for_read(g_val), n * sizeof(*g));
+      RB_GC_GUARD(g_val);
     } else if (strncmp(task, "NEW_X", 5) == 0) {
-      n_iter += 1;
-      continue;
+      n_iter++;
     } else {
       break;
     }

data/ext/lbfgsb/lbfgsbext.h

@@ -2,6 +2,7 @@
 #define LBFGSB_RB_H 1
 
 #include <float.h>
+#include <string.h>
 
 #include <ruby.h>
 #include <numo/narray.h>

data/lbfgsb.gemspec

@@ -6,14 +6,17 @@ Gem::Specification.new do |spec|
   spec.authors       = ['yoshoku']
   spec.email         = ['yoshoku@outlook.com']
 
-  spec.summary       = 'Lbfgsb.rb is a Ruby binding for L-BFGS-B'
-  spec.description   = 'Lbfgsb.rb is a Ruby binding for L-BFGS-B'
+  spec.summary       = 'Lbfgsb.rb is a Ruby binding for L-BFGS-B.'
+  spec.description   = <<~MSG
+    Lbfgsb.rb is a Ruby binding for L-BFGS-B that is a limited-memory algorithm for
+    solving large nonlinear optimization problems subject to simple bounds on the variables.
+  MSG
   spec.homepage      = 'https://github.com/yoshoku/lbfgsb.rb'
   spec.license       = 'BSD-3-Clause'
 
-  spec.metadata['homepage_uri'] = spec.homepage
-  spec.metadata['source_code_uri'] = 'https://github.com/yoshoku/lbfgsb.rb'
-  spec.metadata['changelog_uri'] = 'https://github.com/yoshoku/lbfgsb.rb/blob/main/CHANGELOG.md'
+  spec.metadata['homepage_uri']      = spec.homepage
+  spec.metadata['source_code_uri']   = 'https://github.com/yoshoku/lbfgsb.rb'
+  spec.metadata['changelog_uri']     = 'https://github.com/yoshoku/lbfgsb.rb/blob/main/CHANGELOG.md'
   spec.metadata['documentation_uri'] = 'https://yoshoku.github.io/lbfgsb.rb/doc/'
 
   # Specify which files should be added to the gem when it is released.

data/lib/lbfgsb/version.rb

@@ -3,5 +3,5 @@
 # Lbfgsb.rb is a Ruby binding for L-BFGS-B with Numo::NArray.
 module Lbfgsb
   # The version of Lbfgsb.rb you are using.
-  VERSION = '0.3.1'
+  VERSION = '0.3.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lbfgsb
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - yoshoku
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-16 00:00:00.000000000 Z
+date: 2021-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: numo-narray
@@ -24,7 +24,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.1
-description: Lbfgsb.rb is a Ruby binding for L-BFGS-B
+description: |
+  Lbfgsb.rb is a Ruby binding for L-BFGS-B that is a limited-memory algorithm for
+  solving large nonlinear optimization problems subject to simple bounds on the variables.
 email:
 - yoshoku@outlook.com
 executables: []
@@ -77,8 +79,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
-summary: Lbfgsb.rb is a Ruby binding for L-BFGS-B
+summary: Lbfgsb.rb is a Ruby binding for L-BFGS-B.
 test_files: []