lbank 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e97309035b55a0607c7e25877d7b93d47efd7798
-  data.tar.gz: 2f2ab7d5612edd9509d501dc0f15b308275dced4
+SHA256:
+  metadata.gz: e42cbb5d1055bb80343d70d081956c326c8c155f614a37a7d578d20312fd7331
+  data.tar.gz: d00fa3314b87dc16a75c4ea993088e0551e6f9bcc254c89e3ab7afc3895b1936
 SHA512:
-  metadata.gz: 47701d086875ab0ba6e85b98e942378ff2940f33c1f391ca6b4738294b897eb746be03616fa5a14c785ce399651e5c488b237b5fe6d4a029a347619ad5513cc2
-  data.tar.gz: 154a81cf41ab3b91b817ce3d92d66e349daeccd85ed7afa8325b93f33d6680dc8f8e2bf245e5364174c5bc36944108e9265e000da14cfb709dbacadaf179d9a2
+  metadata.gz: 7494eea07bb8049fb3ded4845d54176df58803f97458295483ba760c4ff0b74e1a6ec68266ceccaf3d14f96eabfcf2c55a44ba8faeb3b3504e75b73280c07485
+  data.tar.gz: 8702c03fe0f58083025262832af803d80331d2ea1fa131a134353fb683a4373d70a50be9e700c0813012e18c7e5382c54d04a4a6a9c3ada1dc3c572dc8533794

data/.github/workflows/main.yml

@@ -0,0 +1,18 @@
+name: Build
+on: [push,pull_request]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version:
+          - 3.0
+          - 3.4
+    name: Ruby ${{ matrix.ruby-version }} sample
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+      - run: bundle install
+      - run: bundle exec rake spec

data/.github/workflows/publish.yml

@@ -0,0 +1,21 @@
+name: Publish gem to rubygems
+on:
+  release:
+    types: [published]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+
+      # setup .gem/credentials
+      - run: mkdir -p ~/.gem
+      - env:
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
+        run: >-
+          echo -e "---\n:rubygems_api_key: ${RUBYGEMS_API_KEY}" > ~/.gem/credentials
+      - run: chmod 0600 ~/.gem/credentials
+
+      - run: gem build lbank.gemspec --output=release.gem
+      - run: gem push release.gem

data/.ruby-version

@@ -1 +1 @@
-2.3.1
+3.3.5

data/Gemfile

@@ -4,4 +4,5 @@ gemspec
 
 group :test do
   gem 'rake'
+  gem 'nokogiri'
 end

data/README.md

@@ -1,8 +1,10 @@
 # Lbank
 
-[![Build Status](https://secure.travis-ci.org/laurynas/lbank.png)](http://travis-ci.org/laurynas/lbank)
+[![Gem](https://img.shields.io/gem/v/lbank.svg)](https://rubygems.org/gems/lbank)
+[![Build Status](https://github.com/laurynas/lbank/actions/workflows/main.yml/badge.svg)](https://github.com/laurynas/lbank/actions)
+[![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](https://opensource.org/licenses/MIT)
 
-Fetches currency rates from Lithuanian Central Bank website http://lbank.lt.
+Fetches currency rates from Lithuanian Central Bank website https://lb.lt.
 Does currency conversion.
 Supports historic currency rates.
 

data/lib/lbank/errors.rb

@@ -0,0 +1,4 @@
+module Lbank
+  class Error < StandardError; end
+  class ResponseError < Error; end
+end

data/lib/lbank/version.rb

@@ -1,3 +1,3 @@
 module Lbank
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/lib/lbank.rb

@@ -1,5 +1,6 @@
 require 'lbank/version'
 require 'lbank/memory_cache'
+require 'lbank/errors'
 require 'active_support/time'
 require 'faraday'
 require 'faraday_middleware'
@@ -29,6 +30,10 @@ module Lbank
 
     cache.fetch(cache_key(date)) do
       response = connection.post(URL, tp: RATE_TYPE, dt: date)
+      error = response.body['FxRates']['OprlErr']
+
+      raise ResponseError.new(error['Desc']) if error
+
       fx_rates = response.body['FxRates']['FxRate']
 
       rates = { fx_rates[0]['CcyAmt'][0]['Ccy'] => 1 }
@@ -41,8 +46,8 @@ module Lbank
     end
   end
 
-  def convert_currency(amount, from_currency, to_currency, date = nil)
-    rates = currency_rates(date)
+  def convert_currency(amount, from_currency, to_currency, time = nil)
+    rates = currency_rates(time)
     from_rate = rates[from_currency.to_s]
     to_rate = rates[to_currency.to_s]
 

data/spec/lbank_spec.rb

@@ -1,28 +1,27 @@
 require 'spec_helper'
 
 describe Lbank do
+  let(:date) { Date.new(2012, 8, 4) }
+
   describe '#currency_rates' do
-    subject { described_class.currency_rates }
+    subject { described_class.currency_rates(date) }
 
     its(['USD']) { is_expected.to be > 0 }
-  end
-
-  describe '#convert_currency' do
-    it 'converts currency' do
-      expect(subject.convert_currency(10, 'USD', 'EUR')).to be > 0
-      expect(subject.convert_currency(10, 'EUR', 'LTL')).to eq 34.528
 
-      date = Date.new(2012, 8, 4)
+    context 'when invalid time' do
+      let(:date) { Time.now + 1.week }
 
-      expect(subject.convert_currency(10, 'EUR', 'LTL')).to eq 34.528
-      expect(round(subject.convert_currency(1, 'USD', 'EUR', date))).to eq 0.82
-      expect(round(subject.convert_currency(100, 'RUB', 'USD', date))).to eq 3.08
+      it 'raises error' do
+        expect { subject }.to raise_error(Lbank::ResponseError, /No data/)
+      end
     end
   end
 
-  private
-
-  def round(number, precision = 2)
-    ("%.#{precision}f" % number).to_f
+  describe '#convert_currency' do
+    it 'converts currency' do
+      expect(subject.convert_currency(10, 'EUR', 'LTL', date).round(2)).to eq 34.53
+      expect(subject.convert_currency(1, 'USD', 'EUR', date).round(2)).to eq 0.82
+      expect(subject.convert_currency(100, 'RUB', 'USD', date).round(2)).to eq 3.08
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lbank
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Laurynas Butkus
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-09-24 00:00:00.000000000 Z
+date: 2025-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -101,6 +101,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
+- ".github/workflows/publish.yml"
 - ".gitignore"
 - ".rspec"
 - ".ruby-version"
@@ -111,6 +113,7 @@ files:
 - Rakefile
 - lbank.gemspec
 - lib/lbank.rb
+- lib/lbank/errors.rb
 - lib/lbank/memory_cache.rb
 - lib/lbank/version.rb
 - spec/lbank_spec.rb
@@ -118,7 +121,7 @@ files:
 homepage: https://github.com/laurynas/lbank
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -133,9 +136,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.5.16
+signing_key:
 specification_version: 4
 summary: Fetches currency rates from Lithuanian Central Bank website. Does currency
   conversion. Supports historic currency rates.