lbank 0.0.3 → 1.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: e97309035b55a0607c7e25877d7b93d47efd7798
+  data.tar.gz: 2f2ab7d5612edd9509d501dc0f15b308275dced4
+SHA512:
+  metadata.gz: 47701d086875ab0ba6e85b98e942378ff2940f33c1f391ca6b4738294b897eb746be03616fa5a14c785ce399651e5c488b237b5fe6d4a029a347619ad5513cc2
+  data.tar.gz: 154a81cf41ab3b91b817ce3d92d66e349daeccd85ed7afa8325b93f33d6680dc8f8e2bf245e5364174c5bc36944108e9265e000da14cfb709dbacadaf179d9a2

data/.ruby-version

@@ -0,0 +1 @@
+2.3.1

data/.travis.yml

@@ -1,7 +1,5 @@
 rvm:
-  - 1.9.3
-  - 1.9.2
-  - jruby
-  - rbx
+  - ruby-head
+  - 2.2.2
 script: "bundle exec rake spec"
 

data/Gemfile

@@ -2,10 +2,6 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'rake'
-gem 'tzinfo'
-gem 'activesupport'
-
 group :test do
-  gem "rspec"
-end
+  gem 'rake'
+end

data/README.md

@@ -1,6 +1,6 @@
 # Lbank
 
-[![Build Status](http://travis-ci.org/laurynas/lbank.png)](http://travis-ci.org/laurynas/lbank)
+[![Build Status](https://secure.travis-ci.org/laurynas/lbank.png)](http://travis-ci.org/laurynas/lbank)
 
 Fetches currency rates from Lithuanian Central Bank website http://lbank.lt.
 Does currency conversion.

data/lbank.gemspec

@@ -2,16 +2,24 @@
 require File.expand_path('../lib/lbank/version', __FILE__)
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["Laurynas Butkus"]
-  gem.email         = ["laurynas.butkus@gmail.com"]
+  gem.authors       = ['Laurynas Butkus']
+  gem.email         = ['laurynas.butkus@gmail.com']
   gem.description   = %q{lbank.lt currency rates fetcher and converter}
   gem.summary       = %q{Fetches currency rates from Lithuanian Central Bank website. Does currency conversion. Supports historic currency rates.}
-  gem.homepage      = "https://github.com/laurynas/lbank"
+  gem.homepage      = 'https://github.com/laurynas/lbank'
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.name          = "lbank"
-  gem.require_paths = ["lib"]
+  gem.name          = 'lbank'
+  gem.require_paths = ['lib']
   gem.version       = Lbank::VERSION
+
+  gem.add_dependency 'faraday'
+  gem.add_dependency 'faraday_middleware'
+  gem.add_dependency 'activesupport'
+  gem.add_dependency 'multi_xml'
+
+  gem.add_development_dependency 'rspec', '~> 3.5'
+  gem.add_development_dependency 'rspec-its', '~> 1.2'
 end

data/lib/lbank.rb

@@ -1,46 +1,64 @@
-require "lbank/version"
-require 'open-uri'
-require 'csv'
+require 'lbank/version'
+require 'lbank/memory_cache'
 require 'active_support/time'
+require 'faraday'
+require 'faraday_middleware'
+require 'bigdecimal'
 
 module Lbank
+  RATE_TYPE = 'LT'
+  TIMEZONE = 'Europe/Vilnius'
+  URL = 'http://www.lb.lt/webservices/FxRates/FxRates.asmx/getFxRates'
+  LTL = 'LTL'
+  LTL_RATE = BigDecimal('3.45280')
 
-  BASE_CURRENCY = 'LTL'
-  TIMEZONE      = 'Europe/Vilnius'
-  SOURCE        = 'http://lbank.lt/exchange/Results.asp'
+  module_function
 
-  @@cache       = {}
+  def cache
+    @cache ||= MemoryCache.new
+  end
+
+  def cache=(store)
+    @cache = store
+  end
 
-  def self.currency_rates(time = nil)
-    time      ||= Time.now
+  def currency_rates(time = nil)
+    time ||= Time.now
     bank_time = time.to_time.in_time_zone(TIMEZONE)
-    date      = [ bank_time.year, bank_time.month, bank_time.day ]
+    date = bank_time.strftime('%Y-%m-%d')
 
-    if @@cache[date].nil?
-      url   = "#{SOURCE}?Y=%i&M=%i&D=%i&S=csv" % date
-      rates = {}
+    cache.fetch(cache_key(date)) do
+      response = connection.post(URL, tp: RATE_TYPE, dt: date)
+      fx_rates = response.body['FxRates']['FxRate']
 
-      data  = open(url).read
+      rates = { fx_rates[0]['CcyAmt'][0]['Ccy'] => 1 }
+      rates[LTL] ||= LTL_RATE
 
-      CSV.parse(data).each do |row|
-        rates[row[1]] = row[2].to_i / row[3].to_f
+      fx_rates.each_with_object(rates) do |rate, result|
+        base, foreign = rate['CcyAmt']
+        result[foreign['Ccy']] = BigDecimal(foreign['Amt']) / BigDecimal(base['Amt'])
       end
-
-      rates[BASE_CURRENCY] = 1.0
-
-      @@cache[date] = rates
     end
-
-    @@cache[date]
   end
 
-  def self.convert_currency(amount, from_currency, to_currency,  date = nil)
-    rates     = self.currency_rates(date)
-
+  def convert_currency(amount, from_currency, to_currency, date = nil)
+    rates = currency_rates(date)
     from_rate = rates[from_currency.to_s]
-    to_rate   = rates[to_currency.to_s]
+    to_rate = rates[to_currency.to_s]
 
     amount / from_rate * to_rate
   end
 
+  def cache_key(date)
+    "lbank-#{date}"
+  end
+
+  def connection
+    @connection ||= Faraday.new do |builder|
+      builder.request :url_encoded
+      builder.response :raise_error
+      builder.response :xml, content_type: /\bxml$/
+      builder.adapter Faraday.default_adapter
+    end
+  end
 end

data/lib/lbank/memory_cache.rb

@@ -0,0 +1,21 @@
+class Lbank::MemoryCache
+  def initialize
+    @store = {}
+  end
+
+  def store(key, value)
+    @store[key] = value
+  end
+
+  def read(key)
+    @store[key]
+  end
+
+  def fetch(key, &block)
+    return self[key] if self[key]
+    self[key] = block.call
+  end
+
+  alias :[]= :store
+  alias :[] :read
+end

data/lib/lbank/version.rb

@@ -1,3 +1,3 @@
 module Lbank
-  VERSION = "0.0.3"
+  VERSION = '1.0.0'
 end

data/spec/lbank_spec.rb

@@ -1,22 +1,23 @@
 require 'spec_helper'
 
 describe Lbank do
+  describe '#currency_rates' do
+    subject { described_class.currency_rates }
 
-  it "should return currency rates" do
-    currency_rates = subject.currency_rates
-
-    currency_rates['USD'].should be > 0
+    its(['USD']) { is_expected.to be > 0 }
   end
 
-  it "should convert currency" do
-    subject.convert_currency(10, 'LTL', 'EUR').should be > 0
+  describe '#convert_currency' do
+    it 'converts currency' do
+      expect(subject.convert_currency(10, 'USD', 'EUR')).to be > 0
+      expect(subject.convert_currency(10, 'EUR', 'LTL')).to eq 34.528
 
-    date = Date.new(2012, 8, 4)
+      date = Date.new(2012, 8, 4)
 
-    round(subject.convert_currency(10, 'LTL', 'EUR', date)).should == 2.90
-    round(subject.convert_currency(10, 'LTL', 'USD', date)).should == 3.55
-    round(subject.convert_currency(100, 'RUB', 'LTL', date)).should == 8.68
-    round(subject.convert_currency(100, 'RUB', 'USD', date)).should == 3.08
+      expect(subject.convert_currency(10, 'EUR', 'LTL')).to eq 34.528
+      expect(round(subject.convert_currency(1, 'USD', 'EUR', date))).to eq 0.82
+      expect(round(subject.convert_currency(100, 'RUB', 'USD', date))).to eq 3.08
+    end
   end
 
   private
@@ -24,5 +25,4 @@ describe Lbank do
   def round(number, precision = 2)
     ("%.#{precision}f" % number).to_f
   end
-
-end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require 'rubygems'
 require 'bundler/setup'
+require 'rspec/its'
 require 'lbank'
 
 RSpec.configure do |config|

metadata

@@ -1,16 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: lbank
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 1.0.0
 platform: ruby
 authors:
 - Laurynas Butkus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-04 00:00:00.000000000 Z
-dependencies: []
+date: 2016-09-24 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: faraday_middleware
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: multi_xml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.5'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
 description: lbank.lt currency rates fetcher and converter
 email:
 - laurynas.butkus@gmail.com
@@ -18,44 +101,44 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - lbank.gemspec
 - lib/lbank.rb
+- lib/lbank/memory_cache.rb
 - lib/lbank/version.rb
 - spec/lbank_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/laurynas/lbank
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.5.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Fetches currency rates from Lithuanian Central Bank website. Does currency
   conversion. Supports historic currency rates.
 test_files:
 - spec/lbank_spec.rb
 - spec/spec_helper.rb
-has_rdoc: