lazylead 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3406ba1a6961d5be8547e8c8b9791bfacdeac1fd8f886964469baf4508a5129
-  data.tar.gz: c3401bf20c25f5496a3a2f99ddac4dd64cef7a7249e2ad488cd32d67d0d021b1
+  metadata.gz: dc28e9d71a966a27880ceac0418cf722b6994e57e60301dc53808cb6bb57e3f2
+  data.tar.gz: 48724243edda1c24e01e75ea50a63a0775869493696f116485125a90097c7877
 SHA512:
-  metadata.gz: 5c1c52b3ac90af6227419af7599ef576eafaade4f1d9cbdace293d1a7c9f6f17bce5e09f6ffafcfae4dc3ab12cc819d9106060c271e49248bf1eeb2687123a34
-  data.tar.gz: b13c9f451e782e248096f0bbfc65882e61eb6118fcf87a34309be4bcba9d25cf55eec177f04605047c898fb6161629ca35b387af208d9675371bb4fb502d4555
+  metadata.gz: 1748fbb1289cefc4f893d4353544bc635f8942a9df33a0375f57ea14bafa135197ff328e9af4ae7d38fe7fcbc8a9cec6398c10aebd5a1a96a65f6047742ca0f7
+  data.tar.gz: 9646375b7bcfc1ae3e61ee6075c8eb26055953a423ab6b9c9ccd04311c672dcbcd4310cf9bd7b1a0b06bbdb57c8a186ac7352cdba894972204bb64cee3a7fdac

data/lazylead.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = "2.2"
   s.required_ruby_version = ">=2.6.5"
   s.name = "lazylead"
-  s.version = "0.1.2"
+  s.version = "0.2.0"
   s.license = "MIT"
   s.summary = "Eliminate the annoying work within bug-trackers."
   s.description = "Ticketing systems (Github, Jira, etc.) are strongly
@@ -45,7 +45,7 @@ tasks instead of solving technical problems."
   s.authors = ["Yurii Dubinka"]
   s.email = "yurii.dubinka@gmail.com"
   s.homepage = "http://github.com/dgroup/lazylead"
-  s.post_install_message = "Thanks for installing Lazylead v0.1.2!
+  s.post_install_message = "Thanks for installing Lazylead v0.2.0!
   Read our blog posts: https://lazylead.org
   Stay in touch with the community in Telegram: https://t.me/lazylead
   Follow us on Twitter: https://twitter.com/lazylead

data/lib/lazylead/model.rb

@@ -92,13 +92,19 @@ module Lazylead
         log.debug("Task ##{id} '#{name}' is started")
         action.constantize
               .new(log)
-              .run(system.connect(log), postman(log), props)
+              .run(system.connect(log), postman(log), props(log))
         log.debug("Task ##{id} '#{name}' is completed")
       end
 
-      def props
-        return @prop if defined? @prop
-        @prop = team.to_hash.merge(to_hash)
+      def props(log = Log::NOTHING)
+        @props ||= begin
+                    if team.nil?
+                      log.warn("Team for task #{id} isn't defined.")
+                      to_hash
+                    else
+                      team.to_hash.merge(to_hash)
+                    end
+                  end
       end
 
       def postman(log = Log::NOTHING)

data/lib/lazylead/system/jira.rb

@@ -193,6 +193,10 @@ module Lazylead
     def inspect
       to_s
     end
+
+    def status
+      @issue.status.attrs["name"]
+    end
   end
 
   # The jira issue comments

data/lib/lazylead/version.rb

@@ -23,5 +23,5 @@
 # OR OTHER DEALINGS IN THE SOFTWARE.
 
 module Lazylead
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/readme.md

@@ -26,7 +26,7 @@ The idea of automatic management is not new, for example [Zerocracy](https://www
 I like this idea, but large companies/projects are not ready yet for such a decisive breakthrough and need step-by-step solutions such as [lazylead](https://github.com/dgroup/lazylead). 
 I think you remember how [static code analysis](https://en.wikipedia.org/wiki/Static_program_analysis) treated at in the past; today we have a huge toolkit (pmd, checkstyle, qulice, rubocop, peon, etc) for each language that allows you to avoid routine issues and remove from the code reviewer the unnecessary load.
  
-Join our [telegram group](https://t.me/lazyleads) for discussions.
+Join our telegram group [lazylead.org](https://t.me/lazyleads) for discussions.
 
 | Daily annoying task                                                    | Jira  | Github | Trello |
 | :--------------------------------------------------------------------- | :---: | :----: | :----: |
@@ -127,7 +127,7 @@ For simplicity, we are using [docker-compose](https://docs.docker.com/compose/):
     Modify you [sqlite](https://sqlite.com/index.html) file(`ll.db`) using [DB Browser](https://sqlitebrowser.org/) or any similar tool.
     Please change the `<youremail.com>` to your email address in order to be in CC when developer get the notification:
     ```sql
-    insert into teams  (id, name, properties) 
+    insert into teams (id, name, properties) 
                values (1, 'Dream team with lazylead', '{}');
     insert into systems(id, properties)    
                values (1,'{"type":"Lazylead::Jira", "username":"${jira_user}", "password":"${jira_password}", "site":"${jira_url}", "context_path":""}');

data/test/lazylead/system/jira_test.rb

@@ -106,5 +106,13 @@ module Lazylead
                              .first
                              .history[2]["id"]
     end
+
+    test "issue has expected status" do
+      assert_equal "Closed",
+                   NoAuthJira.new("https://jira.spring.io")
+                             .issues("key='DATAJDBC-480'")
+                             .first
+                             .status
+    end
   end
 end

data/test/lazylead/task/assignee_alert_test.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+# The MIT License
+#
+# Copyright (c) 2019-2020 Yurii Dubinka
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom
+# the Software is  furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included
+# in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
+# OR OTHER DEALINGS IN THE SOFTWARE.
+
+require_relative "../../test"
+require_relative "../../../lib/lazylead/log"
+require_relative "../../../lib/lazylead/smtp"
+require_relative "../../../lib/lazylead/postman"
+require_relative "../../../lib/lazylead/schedule"
+require_relative "../../../lib/lazylead/model"
+require_relative "../../../lib/lazylead/cli/app"
+require_relative "../../../lib/lazylead/system/jira"
+require_relative "../../../lib/lazylead/task/alert"
+
+module Lazylead
+  class AssigneeAlertTest < Lazylead::Test
+    test "issue #154: undefined method to_hash for nil object" do
+      CLI::App.new(Log::NOTHING, NoSchedule.new).run(
+        home: ".",
+        sqlite: "test/resources/#{no_ext(__FILE__)}.#{__method__}.db",
+        vcs4sql: "upgrades/sqlite",
+        testdata: true
+      )
+      assert_equal "lead@fake.com", ORM::Task.find(154).props["cc"]
+    end
+  end
+end

data/test/lazylead/task/duedate_test.rb

@@ -80,10 +80,8 @@ module Lazylead
         "subject" => "[DD] HMCHT!",
         "template" => "lib/messages/due_date_expired.erb"
       )
-      assert_words %w[STS-3599 2013-11-08 Major Miles\ Parker Use JavaFX WebView],
-                   Mail::TestMailer.deliveries
-                                   .filter { |m| m.subject.eql? "[DD] HMCHT!" }
-                                   .first.body.parts.first.body
+      assert_email "[DD] HMCHT!",
+                   %w[STS-3599 2013-11-08 Major Miles\ Parker Use JavaFX WebView]
     end
 
     test "send notification about bunch of tickets" do
@@ -98,10 +96,8 @@ module Lazylead
         "to" => "big.boss@example.com",
         "addressee" => "Boss"
       )
-      assert_words %w[Hi Boss STS-3599 2013-11-08 Major Miles\ Parker Use JavaFX WebView],
-                   Mail::TestMailer.deliveries
-                                   .filter { |m| m.subject.eql? "ALRT: Frozen" }
-                                   .first.body.parts.first.body
+      assert_email "ALRT: Frozen",
+                   %w[Hi Boss STS-3599 2013-11-08 Major Miles\ Parker Use JavaFX WebView]
     end
 
     test "cc got notification" do

data/test/lazylead/task/fix_version_test.rb

@@ -43,10 +43,8 @@ module Lazylead
         "subject" => "FixVersion: How dare you?",
         "template" => "lib/messages/illegal_fixversion_change.erb"
       )
-      assert_words %w[DATAJDBC-480 01-Apr-2020 Minor Mark\ Paluch tom,mike,bob EntityInstantiators],
-                   Mail::TestMailer.deliveries
-                                   .filter { |m| m.subject.eql? "FixVersion: How dare you?" }
-                                   .first.body.parts.first.body
+      assert_email "FixVersion: How dare you?",
+                   %w[DATAJDBC-480 01-Apr-2020 Minor Mark\ Paluch tom,mike,bob EntityInstantiators]
     end
   end
 end

data/test/lazylead/task/missing_comment_test.rb

@@ -47,10 +47,8 @@ module Lazylead
         "template" => "lib/messages/missing_comment.erb",
         "template_details" => "reference to <a href='file://ftp/path'>ftp</a>"
       )
-      assert_words %w[DATAJDBC-523 Major Mark\ Paluch https://github.com/spring-projects/spring-data-jdbc/commit/aadbb667ed1d61139d5ac51a06eb3dd1b39316db#diff-510a5041bb8a0575e97fedf105606b83R130],
-                   Mail::TestMailer.deliveries
-                                   .filter { |m| m.subject.eql? "Expected ftp link is missing" }
-                                   .first.body.parts.first.body
+      assert_email "Expected ftp link is missing",
+                   %w[DATAJDBC-523 Major Mark\ Paluch https://github.com/spring-projects/spring-data-jdbc/commit/aadbb667ed1d61139d5ac51a06eb3dd1b39316db#diff-510a5041bb8a0575e97fedf105606b83R130]
     end
   end
 end

data/test/test.rb

@@ -37,6 +37,7 @@ require "minitest/reporters"
 require "concurrent"
 require "timeout"
 require "active_support"
+require "mail"
 
 STDOUT.sync = true
 Minitest::Reporters.use! [Minitest::Reporters::SpecReporter.new]
@@ -99,5 +100,15 @@ module Lazylead
         !ENV[keys].blank?
       end
     end
+
+    # Assert that email sent using 'mail' gem in test mode
+    #  has expected subject and words
+    def assert_email(subject, words)
+      assert_words words,
+                   Mail::TestMailer.deliveries
+                                   .filter { |m| m.subject.eql? subject }
+                                   .first
+                                   .body.parts.first.body.raw_source
+    end
   end
 end

data/upgrades/sqlite/999.testdata.sql

@@ -27,7 +27,8 @@ values (1,
        (2,
         '{"type":"Lazylead::Jira", "username":"${jsi_usr}", "password":"${jsi_psw}", "site":"https://jira.spring.io", "context_path":""}');
 insert into teams(id, name, properties)
-values (1, 'BA squad', '{"from":"basquad@fake.com", "usr":"${usr}"}');
+values (1, 'BA squad', '{"from":"basquad@fake.com", "usr":"${usr}"}'),
+       (154, 'Team for issue #154', '{"cc":"lead@fake.com"}');
 insert into tasks(name, cron, enabled, id, system, team_id, action, properties)
 values ('echo', '* * * * *', 'false', 1, 1, 1, 'Lazylead::Task::Echo', '{}'),
        ('expired due date', '* * * * *', 'false', 2, 1, 1,
@@ -36,4 +37,5 @@ values ('echo', '* * * * *', 'false', 1, 1, 1, 'Lazylead::Task::Echo', '{}'),
        ('task with cc', '* * * * *', 'false', 3, 1, 1, 'Lazylead::Task::Echo',
         '{"cc":"leelakenny@mail.com,maciecrane@mail.com"}'),
        ('task', '* * * * *', 'false', 4, 2, 1, 'Lazylead::Task::Echo', '{}'),
-       ('pman', '', '', 5, 2, 1, '', '{"postman":"Lazylead::Postman"}');
+       ('pman', '', '', 5, 2, 1, '', '{"postman":"Lazylead::Postman"}'),
+       ('issue 154', '* * * * *', 'false', 154, 1, 154, 'Lazylead::Task::AssigneeAlert', '{}');

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lazylead
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Yurii Dubinka
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-15 00:00:00.000000000 Z
+date: 2020-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -769,6 +769,7 @@ files:
 - test/lazylead/smoke_test.rb
 - test/lazylead/smtp_test.rb
 - test/lazylead/system/jira_test.rb
+- test/lazylead/task/assignee_alert_test.rb
 - test/lazylead/task/confluence_ref_test.rb
 - test/lazylead/task/duedate_test.rb
 - test/lazylead/task/echo_test.rb
@@ -785,7 +786,7 @@ licenses:
 - MIT
 metadata: {}
 post_install_message: |-
-  Thanks for installing Lazylead v0.1.2!
+  Thanks for installing Lazylead v0.2.0!
     Read our blog posts: https://lazylead.org
     Stay in touch with the community in Telegram: https://t.me/lazylead
     Follow us on Twitter: https://twitter.com/lazylead
@@ -819,6 +820,7 @@ test_files:
 - test/lazylead/smoke_test.rb
 - test/lazylead/smtp_test.rb
 - test/lazylead/system/jira_test.rb
+- test/lazylead/task/assignee_alert_test.rb
 - test/lazylead/task/confluence_ref_test.rb
 - test/lazylead/task/duedate_test.rb
 - test/lazylead/task/echo_test.rb