lazy_observers 0.0.4 → 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 9368b4489ad2f76e6ecbdd5bf386200f3145ac1b
+  data.tar.gz: 911a834c8160fd2b27cc23062b783a260d34b2c1
+SHA512:
+  metadata.gz: 90f41cb278d45021ad2ba6e98eb02c580bd817909ae23535199f4d1e11dfdcb69ba50d12fed7cef9193a60c680e6d0e5e8a8296f75b33d2ca77ba8e68fcbabc7
+  data.tar.gz: 82cacd550131dc729285201634ce87d4d3ec6587515631f6f0ebbc06ba9ae257b27f099f1ef926ae5e4e096cbc4fc8f33a9c74841330b616030b3224be24bd88

data/.travis.yml

@@ -1,4 +1,8 @@
+script: "bundle exec rake spec"
 rvm:
-  - ree
-  - 1.9.2
+  - 1.8.7
   - 1.9.3
+gemfile:
+  - gemfiles/rails-2.3.gemfile
+  - gemfiles/rails-3.0.gemfile
+  - gemfiles/rails-3.2.gemfile

data/Gemfile

@@ -5,3 +5,4 @@ gem 'rake'
 gem 'rspec', '~>2'
 gem 'sqlite3'
 gem 'appraisal'
+gem 'bump'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lazy_observers (0.0.4)
+    lazy_observers (0.1.0)
       activerecord
 
 GEM
@@ -23,6 +23,7 @@ GEM
       rake
     arel (3.0.2)
     builder (3.0.0)
+    bump (0.5.2)
     diff-lcs (1.1.3)
     i18n (0.6.0)
     multi_json (1.3.6)
@@ -43,7 +44,11 @@ PLATFORMS
 
 DEPENDENCIES
   appraisal
+  bump
   lazy_observers!
   rake
   rspec (~> 2)
   sqlite3
+
+BUNDLED WITH
+   1.10.6

data/Rakefile

@@ -1,27 +1,11 @@
 require 'bundler/gem_tasks'
 require 'appraisal'
+require 'bump/tasks'
 
 task :spec do
   sh "rspec spec/"
 end
 
-# extracted from https://github.com/grosser/project_template
-rule /^version:bump:.*/ do |t|
-  sh "git status | grep 'nothing to commit'" # ensure we are not dirty
-  index = ['major', 'minor','patch'].index(t.name.split(':').last)
-  file = 'lib/lazy_observers/version.rb'
-
-  version_file = File.read(file)
-  old_version, *version_parts = version_file.match(/(\d+)\.(\d+)\.(\d+)/).to_a
-  version_parts[index] = version_parts[index].to_i + 1
-  version_parts[2] = 0 if index < 2 # remove patch for minor
-  version_parts[1] = 0 if index < 1 # remove minor for major
-  new_version = version_parts * '.'
-  File.open(file,'w'){|f| f.write(version_file.sub(old_version, new_version)) }
-
-  sh "bundle && git add #{file} Gemfile.lock && git commit -m 'bump version to #{new_version}'"
-end
-
 task :default do
   sh "bundle exec rake appraisal:install && bundle exec rake appraisal spec"
 end

data/Readme.md

@@ -2,6 +2,22 @@ Make Activerecord Observers not load observed models -> faster/safer environment
  - faster tests + console
  - able to boot environment without/with empty/with old database
 
+Recommended: turn your observers into modules
+
+```Ruby
+module CachingObserver
+  def self.included(base)
+    this = self
+    base.after_save { |record| this.do_something(record); true }
+  end
+
+  def self.do_something(record)
+     ... do something ...
+  end
+end
+```
+
+
 Install
 =======
 
@@ -19,7 +35,7 @@ Usage
 ### Extend models from gems after they are loaded
 
     LazyObservers.on_load("Arturo::Feature") do |klass|
-      Arturo::Feature.class_eval do
+      klass.class_eval do
         ... funky hacks ...
       end
     end
@@ -39,6 +55,7 @@ Loads all classes registered via observers, to make sure you did not misspell</b
 
 TIPS
 ====
+ - .on_load is called before all methods are defined on the baseclass, so they might not be defined
  - do not use observe and lazy_observe in the same observer (and if you have to, use observe after lay_observe)
  - do not use Model classes with class-methods of the observer e.g. class FooObserver; Foo.something{}; def after_update; end; end
 

data/gemfiles/rails-2.3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/lazy_observers
   specs:
-    lazy_observers (0.0.3)
+    lazy_observers (0.0.4)
       activerecord
 
 GEM

data/gemfiles/rails-3.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/lazy_observers
   specs:
-    lazy_observers (0.0.3)
+    lazy_observers (0.0.4)
       activerecord
 
 GEM

data/gemfiles/rails-3.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/lazy_observers
   specs:
-    lazy_observers (0.0.3)
+    lazy_observers (0.0.4)
       activerecord
 
 GEM

data/lib/lazy_observers.rb

@@ -1,6 +1,7 @@
 require 'lazy_observers/version'
 require 'active_record'
 require 'active_record/observer'
+require 'lazy_observers/railtie' if defined?(Rails)
 
 module LazyObservers
   def self.observed_loaded(klass)
@@ -36,6 +37,11 @@ module LazyObservers
     ActiveRecord::Base.send(:extend, LazyObservers::InheritedDebugger)
   end
 
+  def self.clear
+    @observers = {}
+    @loaded = []
+  end
+
   private
 
   def self.on_load_callbacks

data/lib/lazy_observers/railtie.rb

@@ -0,0 +1,7 @@
+module LazyObservers
+  class Railtie < Rails::Railtie
+    config.to_prepare do
+      LazyObservers.clear
+    end
+  end
+end

data/lib/lazy_observers/version.rb

@@ -1,3 +1,3 @@
 module LazyObservers
-  VERSION = '0.0.4'
+  VERSION = '0.1.0'
 end

data/spec/app/t1.rb

@@ -0,0 +1,5 @@
+class T1 < ActiveRecord::Base
+  def self.xxx
+    111
+  end
+end

data/spec/app/t2.rb

@@ -0,0 +1,5 @@
+class T2 < ActiveRecord::Base
+end
+
+class InheritedT2 < T2
+end

data/spec/app/t3.rb

@@ -0,0 +1,2 @@
+class T3 < ActiveRecord::Base
+end

data/spec/lazy_observers_spec.rb

@@ -68,12 +68,34 @@ describe LazyObservers do
     NonLazyMovieObserver.instance.called.should == [[:after_create, [movie]], [:after_update, [movie]]]
   end
 
-  it "calls callback when matching class is loaded" do
-    loaded = []
-    LazyObservers.on_load("Group") do |klass|
-      loaded << klass
+  context "#on_load" do
+    it "calls callback when matching class is loaded after block is defined" do
+      loaded = []
+      LazyObservers.on_load("T3") do |klass|
+        loaded << klass
+      end
+      require File.expand_path("../app/t3", __FILE__)
+      loaded.should == [T3]
+    end
+
+    it "calls callback when matching class is loaded before block is defined" do
+      loaded = []
+      LazyObservers.on_load("T2") do |klass|
+        loaded << klass
+      end
+      require File.expand_path("../app/t2", __FILE__)
+      loaded.should == [T2]
+    end
+
+    it "can use classmethods when on_load is called" do
+      pending do
+        loaded = []
+        LazyObservers.on_load("T1") do |klass|
+          loaded << klass.xxx
+        end
+        require File.expand_path("../app/t1", __FILE__)
+        loaded.should == [111]
+      end
     end
-    require File.expand_path("../app/groups", __FILE__)
-    loaded.should == [Group]
   end
 end

metadata

@@ -1,30 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: lazy_observers
 version: !ruby/object:Gem::Version
-  version: 0.0.4
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-08 00:00:00.000000000 Z
+date: 2015-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -33,7 +30,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .travis.yml
+- ".travis.yml"
 - Appraisals
 - Gemfile
 - Gemfile.lock
@@ -47,8 +44,8 @@ files:
 - gemfiles/rails-3.2.gemfile.lock
 - lazy_observers.gemspec
 - lib/lazy_observers.rb
+- lib/lazy_observers/railtie.rb
 - lib/lazy_observers/version.rb
-- spec/app/groups.rb
 - spec/app/inherited_movie.rb
 - spec/app/movie.rb
 - spec/app/movie_observer.rb
@@ -58,6 +55,9 @@ files:
 - spec/app/product_observer.rb
 - spec/app/products.rb
 - spec/app/stupid_observer.rb
+- spec/app/t1.rb
+- spec/app/t2.rb
+- spec/app/t3.rb
 - spec/app/user_observer.rb
 - spec/database.rb
 - spec/lazy_observers_spec.rb
@@ -65,33 +65,26 @@ files:
 homepage: http://github.com/grosser/lazy_observers
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -521166920063735374
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -521166920063735374
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Makes Activerecord Observers lazy, do not load model on startup and only
   listen once a model got loaded.
 test_files: []

data/spec/app/groups.rb

@@ -1,5 +0,0 @@
-class Group < ActiveRecord::Base
-end
-
-class InheritedGroup < Group
-end