lazy_high_charts 1.3.3.beta.2 → 1.3.3

data/CHANGELOG.md

@@ -1,11 +1,13 @@
 # VERSION 1.3.3
-  * Dec 17, 2012
+  * Fri Jan 18, 2013
   1. rails 4 feature turbolinks supported.
   [#95](https://github.com/michelson/lazy_high_charts/isues/95)
   2. Can be used without rails, such as sinatra web framework.
   [#94](https://github.com/michelson/lazy_high_charts/isues/96)
   3. You shouldn't be forced to override the default chart text
   [#93](https://github.com/michelson/lazy_high_charts/issues/93)
+  4. Add chart to window scope for dynamic series addition
+  [#99](https://github.com/michelson/lazy_high_charts/pull/99)
 
 # VERSION 1.3.2
   * Nov 22, 2012

data/GEM_VERSION

@@ -1 +1 @@
-1.3.3.beta.2
+1.3.3

data/README.md

@@ -8,13 +8,13 @@ Current
 [VERSION](https://github.com/xiaods/lazy_high_charts/blob/master/GEM_VERSION)
 [ChangeLog](https://github.com/xiaods/lazy_high_charts/blob/master/CHANGELOG.md)
 
-### Installation instructions for Rails 3
+## Installation
 
 ### Installing it by rubygems
 To install it, you just need to add it to your Gemfile:
     gem 'lazy_high_charts'
 
-And then run this to install the javascript files:
+You do not need to run this unless you are using the older rails versions 3.0 or 3.1:
     rails g lazy_high_charts:install
 
 ### Installing it as a plugin for rails 2.3.x

data/lib/lazy_high_charts/layout_helper.rb

@@ -28,10 +28,9 @@ module LazyHighCharts
       options_collection << %|"series": [#{generate_json_from_array(object.data)}]|
 
       core_js =<<-EOJS
-        var options, chart;
-        options = { #{options_collection.join(',')} };
+        var options = { #{options_collection.join(',')} };
         #{capture(&block) if block_given?}
-        chart = new Highcharts.#{type}(options);
+        window.chart_#{placeholder} = new Highcharts.#{type}(options);
       EOJS
 
       if defined?(request) && request.respond_to?(:xhr?) && request.xhr?
@@ -52,6 +51,16 @@ module LazyHighCharts
         })()
         </script>
         EOJS
+      elsif defined?(Turbolinks) && request.headers["X-XHR-Referer"]
+        graph =<<-EOJS
+        <script type="text/javascript">
+        (function() {
+          $(window).bind('page:load', function() {
+            #{core_js}
+          });
+        })()
+        </script>
+        EOJS
       else
         graph =<<-EOJS
         <script type="text/javascript">

data/spec/lazy_high_charts_spec.rb

@@ -40,10 +40,11 @@ describe HighChartsHelper do
     end
     describe "initialize HighChart" do
       it "should set variables `chart` `options`" do
-        high_chart(@placeholder, @chart).should include('var options, chart;')
+        high_chart(@placeholder, @chart).should match(/var\s+options\s+=/)
+        high_chart(@placeholder, @chart).should match(/window.chart_placeholder\s=/)
       end
       it "should set Chart data" do
-        high_chart(@placeholder, @chart).should match(/chart\s+=\s+new\s+Highcharts.Chart/)
+        high_chart(@placeholder, @chart).should match(/window\.chart_placeholder\s=\snew\sHighcharts.Chart/)
       end
 
       it "should set chart renderTo" do
@@ -51,7 +52,7 @@ describe HighChartsHelper do
       end
 
       it "should set Chart Stock" do
-        high_stock(@placeholder, @chart).should match(/chart\s+=\s+new\s+Highcharts.StockChart/)
+        high_stock(@placeholder, @chart).should match(/window\.chart_placeholder\s+=\s+new\s+Highcharts.StockChart/)
       end
     end
 

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: lazy_high_charts
 version: !ruby/object:Gem::Version
-  version: 1.3.3.beta.2
-  prerelease: 6
+  version: 1.3.3
+  prerelease: 
 platform: ruby
 authors:
 - Miguel Michelson Martinez
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-17 00:00:00.000000000 Z
+date: 2013-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler