lazy_crud 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68a5f9373bcd358d5a51afb4ea77fd025d57b066
-  data.tar.gz: 65844983213a6fa73b3c40c32733c757e34da598
+  metadata.gz: 32871f8c7fcf29804cba0f25c3ab1fa585cf0516
+  data.tar.gz: af379a9727d4b46fe0451da95a133512f04ff925
 SHA512:
-  metadata.gz: 39b140a3db495ed4bc554aa70c63741ff9da385b70c9eef002ef012b4814f51e0e6b2dfe2ac04c2c5c9c11131b3180188d312389e9c548e19fdb68392cacdce6
-  data.tar.gz: 218ab0667505bb0e5af2ef91711fc23b91f7bd314552b55593689bfb13cc54a90c84ef790a7ba79c4589256199177a493caaf13453fc5348f330cda7307dc8aa
+  metadata.gz: d23a9e140f80b25061906919c41bb190927b29d7658e3b619545baf2fade1958d0b36c6ec3f297d184591d7aff33bc369992b7959dd5cbf33ef19e0e760a2a37
+  data.tar.gz: 556c8e9fe7e60af0ade37b871e2bca0b783e14252821a6bb8a0c21dcb498fdc4bd223b026485428b5c9e280e250872d1f914c277bad95a1c5dce4ef042713705

data/lib/lazy_crud/version.rb

@@ -1,3 +1,3 @@
 module LazyCrud
-  VERSION = "0.9.2"
+  VERSION = "0.9.3"
 end

data/lib/lazy_crud.rb

@@ -54,7 +54,7 @@ module LazyCrud
   end
 
   def create
-    @resource = resource_proxy.build(resource_params)
+    @resource = resource_proxy.send(build_method, resource_params)
 
     # ensure we can still use model name-based instance variables
     set_resource_instance
@@ -105,8 +105,10 @@ module LazyCrud
     @resource = resource_proxy.find(params[:id])
   end
 
+  # use .try() on the params hash, in case the user forgot to provide
+  # the attributes
   def resource_params
-    params[resource_singular_name].permit(self.class.param_whitelist)
+    params[resource_singular_name].try(:permit, self.class.param_whitelist)
   end
 
   # determines if we want to use the parent class if available or
@@ -125,6 +127,13 @@ module LazyCrud
     proxy
   end
 
+  # if the resource_proxy has a parent, we can use the
+  # build method. Otherwise, resource_proxy, is just the
+  # resource's class - in which case we'll use new
+  def build_method
+    resource_proxy.respond_to?(:build) ? :build : :new
+  end
+
   # allows all of our views to still use things like
   # @level, @event, @whatever
   # rather than just @resource
@@ -138,7 +147,7 @@ module LazyCrud
   end
 
   def parent_instance
-    unless @parent
+    if (not @parent) and self.class.parent_class.present?
       # e.g.: Event => 'event'
       parent_instance_name = self.class.parent_class.name.underscore
       @parent = instance_variable_get("@#{parent_instance_name}")

data/spec/integration/discounts_controller_spec.rb

@@ -1,5 +1,6 @@
 require 'rails_helper'
 
+# this is a nested resource
 describe DiscountsController, type: :controller do
 
   before(:each) do

data/spec/integration/users_controller_spec.rb

@@ -0,0 +1,89 @@
+require 'rails_helper'
+
+# standard, non-nested resource
+describe UsersController, type: :controller do
+
+    describe '#index' do
+      it 'sets the collection' do
+        create(:user)
+        get :index
+
+        expect(assigns(:users)).to be_present
+      end
+    end
+
+    describe '#show' do
+
+      it 'gets the resource' do
+        user = create(:user)
+        get :show, id: user.id
+
+        expect(assigns(:user)).to eq user
+      end
+    end
+
+    describe '#new' do
+      it 'creates an instance of the object' do
+        get :new
+        expect(assigns(:user)).to be_new_record
+      end
+    end
+
+    describe '#edit' do
+
+
+      it 'sets the instance of the object' do
+        user = create(:user)
+        get :edit, id: user.id
+        expect(assigns(:user)).to eq user
+      end
+    end
+
+    describe '#create' do
+      it 'creates and persists a new object' do
+        expect{
+          post :create, user: build(:user).attributes
+        }.to change(User, :count).by 1
+
+        expect(assigns(:user)).to be_present
+      end
+
+      it 'does not create' do
+        expect{
+          post :create
+        }.to change(User, :count).by 0
+      end
+    end
+
+    describe '#update' do
+      it 'updates and persists changes' do
+        user = create(:user)
+        put :update, id: user.id,
+          user: { name: "updated" }
+
+        updated_user = assigns(:user)
+        expect(updated_user.name).to eq "updated"
+      end
+
+      it 'does not update' do
+        user = create(:user)
+        put :update, id: user.id, user: { name: "" }
+
+        updated_user = assigns(:user)
+        expect(updated_user.errors.full_messages.count).to eq 1
+      end
+    end
+
+
+    describe '#destroy' do
+      it 'destroys the object' do
+        user = create(:user)
+
+        expect{
+          delete :destroy, id: user.id
+        }.to change(User.all, :count).by -1
+      end
+    end
+
+
+end

data/spec/support/factories.rb

@@ -1,7 +1,7 @@
 FactoryGirl.define do
 
   factory :user do
-
+    name "a user"
   end
 
   factory :event do

data/spec/support/rails_app/app/models/user.rb

@@ -1,9 +1,6 @@
 class User < ActiveRecord::Base
   has_many :events
 
-  has_many :collaborated_events,
-    through: :collaborations,
-    source: :user
-  has_many :collaborations
+  validates :name, presence: true, allow_blank: false
 
 end

data/spec/unit/lazy_crud_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe LazyCrud do
+
+  class Example < ActionController::Base
+    include LazyCrud
+  end
+
+
+  describe '#build_method' do
+
+    it 'uses build when the resource_proxy is a class' do
+      example = Example.new
+      allow(example).to receive(:resource_proxy){ Example }
+
+      expect(example.send(:build_method)).to eq :new
+    end
+
+  end
+
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lazy_crud
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - L. Preston Sego III
@@ -197,6 +197,7 @@ files:
 - lib/lazy_crud.rb
 - lib/lazy_crud/version.rb
 - spec/integration/discounts_controller_spec.rb
+- spec/integration/users_controller_spec.rb
 - spec/rails_helper.rb
 - spec/spec_helper.rb
 - spec/support/factories.rb
@@ -296,9 +297,10 @@ rubyforge_project:
 rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
-summary: LazyCrud-0.9.2
+summary: LazyCrud-0.9.3
 test_files:
 - spec/integration/discounts_controller_spec.rb
+- spec/integration/users_controller_spec.rb
 - spec/rails_helper.rb
 - spec/spec_helper.rb
 - spec/support/factories.rb