lazy_attributes 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91e3b39b32b2e21093801b5c92dee0757adb35b9
-  data.tar.gz: f8a6109bb4345cb03fcb7f924a15fb39159508ee
+  metadata.gz: 8a557716460804140b468ad2933d0d06a72ab5dd
+  data.tar.gz: 85981d9020b694164288aac797a6dcdb90fe8e8f
 SHA512:
-  metadata.gz: ee23f503f47d864ccf4a8df06841e8c19931a5d47d565f2a8ff2c2787c4b600e95d66af3f419e387f293a457da8dee7eb1783b382b7ed9614e8bb46ca49988a3
-  data.tar.gz: c8848b82eac334456d31cd997a00135377ba6b304f54cdfa9af7c25afc8dfa63329cd6095f4cf5260d4c3afb4be3ce02482f36714abf9bef1a18da9d59f215cf
+  metadata.gz: c9e3f5a61a9ab12e12bcd1efe857fecef62b7195153ef10601cb772c7ffa9f8d3e2b48e5acffb28decf843e869873c84c13276231a469e8c405cb613f7b1fcc0
+  data.tar.gz: 8568c0a4e5be842cb397a24eeb7e5ec6539df3491cd81824fda866e8f42533ce2a502bfe4299f6c0cb02a127c4eb7891001cdbca2cebb8d4f260f0811a978368

data/gemfiles/activerecord_3.2.18.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    lazy_attributes (0.0.2)
+    lazy_attributes (0.0.3)
       activerecord (>= 3.2, < 5)
 
 GEM

data/gemfiles/activerecord_4.0.5.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    lazy_attributes (0.0.2)
+    lazy_attributes (0.0.3)
       activerecord (>= 3.2, < 5)
 
 GEM

data/gemfiles/activerecord_4.1.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    lazy_attributes (0.0.2)
+    lazy_attributes (0.0.3)
       activerecord (>= 3.2, < 5)
 
 GEM

data/lazy_attributes.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "lazy_attributes"
-  spec.version       = '0.0.3'
+  spec.version       = '0.0.4'
   spec.authors       = ["Eito Katagiri"]
   spec.email         = ["eitoball@gmail.com"]
   spec.summary       = %q{ActiveRecord plugin to load specified attributes lazyly}

data/lib/lazy_attributes.rb

@@ -7,15 +7,6 @@ module LazyAttributes
       self._lazy_attributes = []
     end
 
-    def reload_but_keep_changes
-      return unless persisted?
-      changes_before_reload = changes.clone
-      reload
-      changes_before_reload.each do |attr_name, values|
-        send("#{attr_name}=", values[1])
-      end
-    end
-
     module ClassMethods
       def lazy_attributes(*attrs)
         if self._lazy_attributes.empty?
@@ -29,11 +20,17 @@ module LazyAttributes
         attrs.each do |attr|
           attr = attr.to_sym
           define_method(attr) do
-            reload_but_keep_changes unless has_attribute?(attr)
+            unless has_attribute?(attr)
+              self.class.define_attribute_method(attr)
+              write_attribute(attr, self.class.where(id: self.id).pluck(attr).first)
+            end
             read_attribute(attr)
           end
           define_method(:"#{attr}=") do |val|
-            reload_but_keep_changes unless has_attribute?(attr)
+            unless has_attribute?(attr)
+              self.class.define_attribute_method(attr)
+              write_attribute(attr, self.class.where(id: self.id).pluck(attr).first)
+            end
             write_attribute(attr, val)
           end
         end

data/spec/lazy_attributes_spec.rb

@@ -4,11 +4,6 @@ require 'spec_helper'
 
 describe LazyAttributes do
   it '' do
-    expect do
-      User.send(:lazy_attributes, :profile)
-      User.send(:lazy_attributes, :address)
-    end.to_not raise_error
-
     User.create!(
       name: 'John',
       profile: 'This attribute is suppose to be very long',
@@ -22,6 +17,22 @@ describe LazyAttributes do
     expect(user.address).to eq('Somewhere over the rainbow')
   end
 
+  describe '#<lazy_attribute>' do
+    let!(:user) { User.create!(name: 'John', profile: 'My profile...') }
+
+    it { expect(User.find(user.id).profile).to eq('My profile...') }
+
+    context 'association' do
+      before { user.groups.create!(name: 'Group A') }
+
+      it 'should not reload association' do
+        u = User.find(user.id)
+        u.groups.build(name: 'Group B')
+        expect { u.profile }.to_not change { u.groups.size }
+      end
+    end
+  end
+
   describe '.count' do
     context 'when no user exists' do
       subject { User.count }

data/spec/spec_helper.rb

@@ -12,11 +12,24 @@ ActiveRecord::Base.establish_connection(
 )
 ActiveRecord::Base.logger = Logger.new(STDOUT)
 
+class Group < ActiveRecord::Base
+  belongs_to :user
+end
+
 class User < ActiveRecord::Base
+  lazy_attributes :profile
+  lazy_attributes :address
+
+  has_many :groups
 end
 
 class CreateTables < ActiveRecord::Migration
   def up
+    create_table :groups do |t|
+      t.references :user
+      t.string :name
+    end
+
     create_table :users do |t|
       t.string :name
       t.text :profile

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lazy_attributes
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Eito Katagiri