lapine 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6ee36980b342bf290005bfe32c3645b60637fd29
-  data.tar.gz: 4c45b563a43f1ba82017801c257304779bc87a10
+  metadata.gz: d72d9ebaaaca0995cdf88aa8a2741f95b17d7514
+  data.tar.gz: 113b59cf6d8f411b983cd1202da0c8b557b78d94
 SHA512:
-  metadata.gz: d6b9b11710eef507aff965297bd94d35fbbaec1ea61d6c49068762c47c362d901b2fdca982217510acc6dcff18ddd140ea1a156f05fe77d7dc2cfdd6d472ae92
-  data.tar.gz: 77230701216a54be3410548a282c67e1aa05a33a085001aef88f9d98fb8df26dfd1a24ec505e1b9072be27fa39c096fe1d8195df865a7963097cba2f9d4a00be
+  metadata.gz: 6fb7291e77fb106921cbd0c9036de7fee053cb6ed396d614e2d0f88d6be9bc2f9cc804f4eca77896563288708bf8da344890f28fb052a5b7a9bad9f7868d2ffc
+  data.tar.gz: 347b60824f615d3329b210bd7d83d2b7eeb97c86ad21d159ac6fe18464df2e35a93b045fdb49d9ad16220b34d6b36d248267de45939b6cf24d8895cc3f8e7b45

data/lib/lapine/consumer/config.rb

@@ -17,7 +17,7 @@ module Lapine
       option :logfile,
         short: '-l LOGFILE',
         long: '--logfile LOGFILE',
-        description: 'where to log consumer info',
+        description: 'where to log consumer info (default to STDOUT)',
         required: false
 
       option :host,

data/lib/lapine/consumer/dispatcher.rb

@@ -5,8 +5,9 @@ module Lapine
   module Consumer
     class Dispatcher
       class DefaultErrorHandler
+
         def call(e, data)
-          logger.info "Lapine::Dispatcher unable to dispatch, #{e.message}, data: #{data}"
+          $stderr.puts "Lapine::Dispatcher unable to dispatch, #{e.message}, data: #{data}"
         end
       end
 
@@ -47,7 +48,7 @@ module Lapine
         ret = yield
         time_end = Time.now
         duration = (time_end - time) * 1000
-        logger.info  "Processing rabbit message handler:#{delegate_class.name} duration(ms):#{duration} payload:#{json.inspect}"
+        logger.info "Processing rabbit message handler:#{delegate_class.name} duration(ms):#{duration} payload:#{json.inspect}"
         ret
       end
 

data/lib/lapine/version.rb

@@ -1,3 +1,3 @@
 module Lapine
-  VERSION = '0.2.2'
+  VERSION = '0.2.3'
 end

data/spec/lib/lapine/consumer/dispatcher_spec.rb

@@ -12,10 +12,8 @@ RSpec.describe Lapine::Consumer::Dispatcher do
 
   let(:caught_errors) { [] }
 
-  before do
-    Lapine::Consumer::Dispatcher.error_handler = ->(error, data) {
-      caught_errors << [error, data]
-    }
+  after do
+    Lapine::Consumer::Dispatcher.error_handler = nil
   end
 
   describe "#delegation" do
@@ -43,23 +41,42 @@ RSpec.describe Lapine::Consumer::Dispatcher do
     end
 
     describe 'error cases' do
-      context 'with invalid json' do
-        let(:json) { 'oh boy I am not actually JSON' }
 
-        it 'notifies the error handler with the raw payload' do
-          dispatcher.dispatch
-          expect(caught_errors).to include([an_instance_of(Oj::ParseError), json])
+      context 'custom error handler' do
+        before do
+          Lapine::Consumer::Dispatcher.error_handler = ->(error, data) {
+            caught_errors << [error, data]
+          }
+        end
+        context 'with invalid json' do
+          let(:json) { 'oh boy I am not actually JSON' }
+
+          it 'notifies the error handler with the raw payload' do
+            dispatcher.dispatch
+            expect(caught_errors).to include([an_instance_of(Oj::ParseError), json])
+          end
+        end
+
+        context 'with any other error' do
+          before { allow(dispatcher).to receive(:do_dispatch).and_raise(ArgumentError) }
+
+          it 'notifies error handler with the parsed json' do
+            dispatcher.dispatch
+            expect(caught_errors).to include([an_instance_of(ArgumentError), hash])
+          end
         end
       end
 
-      context 'with any other error' do
+      context 'default error handler' do
         before { allow(dispatcher).to receive(:do_dispatch).and_raise(ArgumentError) }
 
-        it 'notifies error handler with the parsed json' do
+        it 'notifies default error handler' do
+          expect($stderr).to receive(:puts)
           dispatcher.dispatch
-          expect(caught_errors).to include([an_instance_of(ArgumentError), hash])
         end
       end
+
+
     end
   end
 end

data/spec/spec_helper.rb

@@ -21,5 +21,6 @@ RSpec.configure do |config|
 
   config.before :each do
     Lapine.instance_variable_set(:@config, nil)
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lapine
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Eric Saxby
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-02 00:00:00.000000000 Z
+date: 2014-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: amqp