langue-japanese 0.0.2 → 0.0.3

data/lib/langue/japanese/shaper.rb

@@ -13,32 +13,31 @@ module Langue
       end
 
       def shape_person_name(morphemes, person_name)
-        new_morphemes = Morphemes.new
-        name_morphemes = []
-        start_index = 0
-        person_name_size = person_name.size
+        Morphemes.new.tap do |new_morphemes|
+          person_name_morphemes = []
+          start_index = 0
+          person_name_size = person_name.size
 
-        morphemes.each do |morpheme|
-          text = morpheme.text
-          index = person_name.index(text, start_index)
+          morphemes.each do |morpheme|
+            text = morpheme.text
+            index = person_name.index(text, start_index)
 
-          if index == start_index
-            name_morphemes << morpheme
-            start_index += text.size
+            if index == start_index
+              person_name_morphemes << morpheme
+              start_index += text.size
 
-            if start_index == person_name_size
-              new_morphemes << join_as_person_name(name_morphemes)
-              name_morphemes.clear
+              if start_index == person_name_size
+                new_morphemes << join_as_person_name(person_name_morphemes)
+                person_name_morphemes.clear
+                start_index = 0
+              end
+            else
+              new_morphemes.concat(person_name_morphemes) << morpheme
+              person_name_morphemes.clear
               start_index = 0
             end
-          else
-            new_morphemes += name_morphemes + [morpheme]
-            name_morphemes.clear
-            start_index = 0
           end
         end
-
-        new_morphemes
       end
 
       private

data/lib/langue/japanese/version.rb

@@ -1,5 +1,5 @@
 module Langue
   module Japanese
-    VERSION = '0.0.2'
+    VERSION = '0.0.3'
   end
 end

data/spec/langue/japanese/shaper_spec.rb

@@ -19,15 +19,18 @@ describe Langue::Japanese::Shaper, '#initialize' do
 end
 
 describe Langue::Japanese::Shaper, '#shape_person_name' do
-  it 'forms the morphemes to a person name' do
+  it 'shapes the morphemes as person name' do
     shaper = described_class.new
 
     {
-      'あたしの名前は天道あかねよ' => '天道あかね',
-      'オレの名前は早乙女乱馬だ'   => '早乙女乱馬'
-    }.each do |text, name|
+      'あたしの名前は天道あかねよ' => ['天道あかね', 6],
+      'オレの名前は早乙女乱馬だ'   => ['早乙女乱馬', 6]
+    }.each do |text, params|
+      name, size = params
       morphemes = parser.parse(text)
-      morpheme = shaper.shape_person_name(morphemes, name).find { |m| m.classified?(*%w(名詞 固有名詞 人名)) }
+      shaped_morphemes = shaper.shape_person_name(morphemes, name)
+      shaped_morphemes.should have(size).items
+      morpheme = shaped_morphemes.find { |m| m.classified?(*%w(名詞 固有名詞 人名)) }
       morpheme.text.should == name
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: langue-japanese
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors: