landslider 0.2.0 → 0.2.1

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
 :major: 0
 :minor: 2
-:patch: 0
+:patch: 1
 :build: 

data/lib/landslider.rb

@@ -67,31 +67,17 @@ class Landslider < Handsoap::Service
 		node = response.document.xpath('//ns:getAccountsResponse', ns)
 		parse_get_accounts_result(node)
 	end
-	
-	def get_account_opportunities(session_id, account_id)
-		self.session_id = session_id
-		response = invoke("getAccountOpportunities", :soap_action => :none) do |message|
-			message.add 'accountId', account_id
-		end
-		puts response.document.inspect
-		
-		node = response.document.xpath('//ns:getAccountOpportunitiesResponse', ns)
-		parse_get_account_opportunities_result(node)	
-	end
-	
 
-	
 	def get_account_contacts(session_id, account_id)
 		self.session_id = session_id
 		response = invoke("getAccountContacts", :soap_action => :none) do |message|
 			message.add 'accountId', account_id
 		end
-		puts response.document.inspect
 		
 		node = response.document.xpath('//ns:getAccountContactsResponse', ns)
 		parse_get_account_contacts_result(node) 
 	end
-	
+		
 	def get_account_notes(session_id, account_id)
 		self.session_id = session_id
 
@@ -101,20 +87,22 @@ class Landslider < Handsoap::Service
 				ans.add 'accountId', account_id
 				ans.add 'firstResultPosition', 1
 				ans.add 'totalResultsRequested', 10
-
-				# search criteria doesn't seem to work
-				# ans.add('searchCriteria') { |sc|
-				#	sc.add 'fieldId', 'note'
-				#	sc.add 'operator', 'Contains'
-				#	sc.add 'queryValue', 'BLAH'
-				# }
 			}
 		end
-		puts response.document.inspect
-	
+		node = response.document.xpath('//ns:getAccountNotesResponse', ns)
+		parse_get_account_notes_result(node)
 	end
 	
-	
+	def get_account_opportunities(session_id, account_id)
+		self.session_id = session_id
+		response = invoke("getAccountOpportunities", :soap_action => :none) do |message|
+			message.add 'accountId', account_id
+		end
+		
+		node = response.document.xpath('//ns:getAccountOpportunitiesResponse', ns)
+		parse_get_account_opportunities_result(node)	
+	end
+
 	def get_contact_notes(session_id, contact_id)
 		self.session_id = session_id
 		
@@ -129,7 +117,6 @@ class Landslider < Handsoap::Service
 	
 	end
 	
-	
 	def get_opportunity_notes(session_id, opportunity_id)
 		self.session_id = session_id
 	
@@ -160,7 +147,6 @@ class Landslider < Handsoap::Service
 	
 	end
 	
-
 	private
 
 	def ns
@@ -199,6 +185,16 @@ class Landslider < Handsoap::Service
 		}
 	end
 	
+	def parse_get_account_notes_result(node) 
+		{
+		:error => xml_to_bool(node, './*/error/text()'),
+		:error_code => xml_to_int(node, './*/errorCode/text()'),
+		:result_msg => xml_to_str(node, './*/resultMsg/text()'),
+		:status_code => xml_to_int(node, './*/statusCode/text()'),
+		:results_returned => xml_to_int(node, './*/resultsReturned/text()')
+		}
+	end
+	
 	def parse_get_account_opportunities_result(node)
 		{
 		:opportunities => node.xpath('./*/opportunityList', ns).map { |child| parse_opportunity(child) },

data/test/landslider_test.rb

@@ -21,7 +21,7 @@ class LandsliderTest < Test::Unit::TestCase
 		assert_operator result[:revision_version], :>=, 0
 	end
 	
-	def test_get_accounts
+	def test_landslider_get_accounts
 		result = Landslider.login('LOGINTOKEN=' + LS_INSTANCE_NAME)
 		result = Landslider.get_accounts(result[:session_id])
 		assert_equal false, result[:error]
@@ -32,9 +32,54 @@ class LandsliderTest < Test::Unit::TestCase
 		assert_not_nil result[:result_msg]
 	end
 	
+	def test_landslider_get_account_contacts
+		result = Landslider.login('LOGINTOKEN=' + LS_INSTANCE_NAME)
+		
+		# exists on jaytest
+		result = Landslider.get_account_contacts(result[:session_id], 51857822)		
+		
+		assert_equal false, result[:error]
+		assert_operator result[:results_returned], :>=, 1
+		assert result[:contacts].all? { |con| !con[:last_name].nil? }, "last name required"
+	end
+	
+	def test_landslider_get_account_notes
+		result = Landslider.login('LOGINTOKEN=' + LS_INSTANCE_NAME)
+
+		# exists on jaytest
+		result = Landslider.get_account_notes(result[:session_id], 55647822)
+		
+		validate_standard_api_result result
+		assert_operator result[:results_returned], :>=, 1
+
+	end
+	
+	
+	def test_landslider_get_account_opportunities
+		result = Landslider.login('LOGINTOKEN=' + LS_INSTANCE_NAME)
+
+		# exists on jaytest
+		result = Landslider.get_account_opportunities(result[:session_id], 51858821)
+	  
+		assert_equal false, result[:error]
+		assert result[:opportunities].all? { |opp| 
+			!opp[:account_name].nil? && 
+			!opp[:name].nil? && 
+			!opp[:deal_value].nil? && 
+			!opp[:selling_process].nil?
+		}, "opportunities require a name, account, deal value and selling process"
+  
+  end
+	
 
 	private
 
+	def validate_standard_api_result(result) 
+		assert_equal Hash, result.class, "api method should return a hash"
+		assert_operator result[:results_returned], :>=, 0
+		assert_equal false, result[:error], "error should be false"
+	end
+
 	def login(session_id)
 		Landslider.login(session_id)
 	end

metadata

@@ -2,7 +2,7 @@
 name: landslider
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Jay Prall