landable 1.10.0.rc2 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18ff721aa14c6fb5bde399c92457e4f074e6a226
-  data.tar.gz: 0603e1abfdf22f19fa4ae7a5011014e29b1a4993
+  metadata.gz: 33e0d69e6891c96f2d1a009ef58a5a82ddc5f3a6
+  data.tar.gz: d5007db85e84798a12c6abf7e6d1c43548264556
 SHA512:
-  metadata.gz: d70d1b346cc558a6692949556b11b44befe6ab2a8d2c62c447a86cd1b21ac457f64c8c703a51673350ddc6f2f778897cb7160f97ea5c680131194429b2d1772b
-  data.tar.gz: d5afd864aa0cda1356c82fe5c0faf65105110ab418dae7e3db75a4ecdc7eb906d8b806b22fe66e8c64d4ded6bdbca256dc9d2f6a14248f8e69b70001a141a445
+  metadata.gz: 8e1199458a3de14521df62769d390e8fbc4fccac423a58903be15af167b99ca9855c2ab7765183d95e7c2b09ae7e0d98fac0aa879c8d7a09dc125eb8438d6594
+  data.tar.gz: f569cbfb3c711e2f2c2453eff742d1b8c4ca7498c9d5bf2ed0fc1b453fdcd5455fc193f9c0eeeb22f5a45bfa8577bcccb8978b4a10239c4e7fa3e3824137d8ff

data/.hound.yml

@@ -0,0 +1,4 @@
+# Hound Configuration File -> https://houndci.com/configuration
+ruby:
+  enabled: true
+  config_file: .ruby.yml

data/.ruby.yml

@@ -0,0 +1,10 @@
+AllCops:
+  Exclude:
+    - "spec/**/*"
+    - "db/**/*"
+
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+    - single_quotes
+    - double_quotes

data/.travis.yml

@@ -28,3 +28,4 @@ script:
 notifications:
   # let enova know about the build
   slack: enova:xzPNLg3AxkbkUcUlfn7sqHW5
+  email: trogdor@enova.com

data/CHANGELOG.md

@@ -2,10 +2,17 @@
 
 See README.md before updating this file.
 
-## Unreleased [#](https://github.com/enova/landable/compare/v1.10.0.rc1...master)
+## Unreleased [#](https://github.com/enova/landable/compare/v1.11.0...master)
+
+## 1.11.0 [#](https://github.com/enova/landable/compare/v1.10.0.rc1...v1.11.0)
+* Make the tracker.user_agent accessible [#33]
+* Add missing functions/triggers to schema_move task.  Make it a little better in other ways [#24]
+* Lock Liquid Dependency to Version as above versions will break tests [#30]
+* Turn DNT into a config option [#31]
+* Make Themes Import From App More Accepting [#35]
 
 ## 1.10.0.rc2 [#](https://github.com/enova/landable/compare/v1.10.0.rc1...v1.10.0.rc2)
-* Set up configurable paths that are not visit tracked
+* Set up configurable paths that are not visit tracked [#27]
 
 ## 1.10.0.rc1 [#](https://github.com/enova/landable/compare/v1.9.2...v1.10.0.rc1)
 * Handle blank UserAgent [#25]

data/landable.gemspec

@@ -29,13 +29,14 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency 'rails',     '~> 4.0'
   gem.add_dependency 'rack-cors', '>= 0.2.7'
-  gem.add_dependency 'active_model_serializers', '~> 0.8'
+  gem.add_dependency 'active_model_serializers', '0.8.3'
   gem.add_dependency 'carrierwave'
-  gem.add_dependency 'liquid'
+  gem.add_dependency 'liquid',    '~> 2.6.1'
   gem.add_dependency 'fog'
   gem.add_dependency 'rest-client'
   gem.add_dependency 'builder'
   gem.add_dependency 'lookup_by', '> 0.4.0'
+  gem.add_dependency 'highline'
 
   gem.add_development_dependency 'pg'
   gem.add_development_dependency 'rspec-rails',        '~> 2.14.2'

data/lib/generators/templates/landable.rb

@@ -26,6 +26,23 @@ Landable.configure do |config|
   # Set to :html to track only HTML requests.
   # config.traffic_enabled = true
 
+  # Set up paths that are never tracked by Landable visit tracking
+  # config.untracked_paths = %w(/status)
+
+  # DNT header (http://en.wikipedia.org/wiki/Do_Not_Track)
+  #
+  # DNT is a proposed HTTP header field that accepts three values:
+  #    "1": (opt-out) user does not want to be tracked
+  #    "0": (opt-in)  user consents to being tracked
+  #   null: (no header, empty, or other) user has not expressed a preference
+  #
+  # Note: It is unsettled if the DNT header should apply to first-party tracking.
+  #
+  # Default: Skip tracking if request.headers["DNT"] == "1"
+  #
+  # Uncomment to change the default
+  # config.dnt_enabled = true
+
   # If you're using Landable with Publicist, add its url here. (required for screenshots)
   # config.publicist_url = 'http://publicist.dev/'
 
@@ -34,9 +51,6 @@ Landable.configure do |config|
 
   # If you want to save a different UserAgent if the request.user_agent is blank, set it here
   # config.blank_user_agent_string = 'blank'
-
-  # Set up paths that are never tracked by Landable visit tracking
-  # config.untracked_paths %w(/status)
 end
 
 # Configure asset uploads. Assets will be uploaded to public/uploads by default.

data/lib/landable/configuration.rb

@@ -10,6 +10,7 @@ module Landable
     attr_writer :reserved_paths, :partials_to_templates, :database_schema_prefix
     attr_writer :publicist_url, :audit_flags
     attr_writer :blank_user_agent_string, :untracked_paths
+    attr_writer :dnt_enabled
 
     def authenticators
       @authenticators || raise("No Landable authenticator configured.")
@@ -149,6 +150,13 @@ module Landable
       @untracked_paths ||= []
     end
 
+    def dnt_enabled
+      return true if @dnt_enabled.nil?
+
+      @dnt_enabled
+    end
+
+
     class Screenshots
       attr_accessor :autorun
       attr_accessor :browserstack_username, :browserstack_password

data/lib/landable/layout.rb

@@ -49,7 +49,14 @@ module Landable
       end
 
       def files
-        paths.map { |path| Dir[path + "/**/[^_]*.html.*"] }.flatten
+        files = []
+
+        paths.map do |path|
+          files << Dir[path + "/**/[^_]*.html.*"]
+          files << Dir[path + "/**/application*"]
+        end
+
+        files.flatten.uniq
       end
 
       def paths

data/lib/landable/traffic.rb

@@ -9,7 +9,8 @@ require 'landable/traffic/noop_tracker'
 module Landable
   module Traffic
     def track_with_landable!
-      yield and return if (request.headers["DNT"] || untracked_path)
+      yield and return if untracked?
+
       begin
         @tracker = Tracker.for self
         @tracker.track
@@ -32,7 +33,15 @@ module Landable
       end
     end
 
-    def untracked_path
+    def untracked?
+      untracked_user? || untracked_path?
+    end
+
+    def untracked_user?
+      Landable.configuration.dnt_enabled && request.headers["DNT"] == "1"
+    end
+
+    def untracked_path?
       Landable.configuration.untracked_paths.include? request.fullpath
     end
   end

data/lib/landable/traffic/tracker.rb

@@ -121,6 +121,10 @@ module Landable
         @visit_id and PageView.where(visit_id: @visit_id).order(:page_view_id).first.try(:path)
       end
 
+      def get_user_agent
+        user_agent
+      end
+
     protected
       def cookies
         request.cookie_jar

data/lib/landable/version.rb

@@ -1,10 +1,9 @@
 module Landable
   module VERSION
     MAJOR = 1
-    MINOR = 10
+    MINOR = 11
     PATCH = 0
-    PRE   = 'rc2'
 
-    STRING = [MAJOR, MINOR, PATCH, PRE].compact.join('.')
+    STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end
 end

data/lib/schema_moves.rb

@@ -0,0 +1,208 @@
+module SchemaMoves
+  module Helpers
+    def create_schema(schema)
+      connection = ActiveRecord::Base.connection
+
+      sql = %{
+        CREATE SCHEMA #{schema};
+      }
+      puts "Creating #{schema} schema"
+      connection.execute sql
+    end
+
+    def drop_schema(schema)
+      connection = ActiveRecord::Base.connection
+
+      sql = %{
+        DROP SCHEMA #{schema};
+      }
+      puts "Dropping #{schema} schema"
+      connection.execute sql
+    end
+
+    def move_objects(from_schema, to_schema, relkind, object_type)
+      connection = ActiveRecord::Base.connection
+
+      # move objects from public to new schema
+      objects = connection.select_all("
+        SELECT o.relname
+          FROM pg_class o
+          JOIN pg_namespace n
+          ON n.oid=o.relnamespace
+          AND n.nspname = '#{from_schema}'
+          AND o.relkind = '#{relkind}'
+          ORDER BY o.relname
+      ")
+
+      objects.each do |object|
+        sql = %{
+          ALTER #{object_type} #{from_schema}.#{object['relname']}
+            SET SCHEMA #{to_schema}
+        }
+        puts "Moving #{from_schema}.#{object['relname']} TO #{to_schema}"
+        connection.execute sql
+      end
+    end
+
+    def create_new_triggers(new_schema)
+      connection = ActiveRecord::Base.connection
+      sql = %{
+        CREATE FUNCTION #{new_schema}.tg_disallow()
+          RETURNS TRIGGER
+          AS
+          $TRIGGER$
+            BEGIN
+
+            IF TG_LEVEL <> 'STATEMENT' THEN
+              RAISE EXCEPTION $$You should use a statement-level trigger (trigger %, table %)$$, TG_NAME, TG_RELID::regclass;
+            END IF;
+
+            RAISE EXCEPTION $$%s are not allowed on table %$$, TG_OP, TG_RELNAME;
+
+            RETURN NULL;
+
+            END
+           $TRIGGER$
+           LANGUAGE plpgsql;
+
+        CREATE FUNCTION #{new_schema}.template_revision_ordinal()
+          RETURNS TRIGGER
+          AS
+          $TRIGGER$
+            BEGIN
+
+            IF NEW.ordinal IS NOT NULL THEN
+              RAISE EXCEPTION $$Must not supply ordinal value manually.$$;
+            END IF;
+
+            NEW.ordinal = (SELECT COALESCE(MAX(ordinal)+1,1)
+                            FROM #{new_schema}.template_revisions
+                            WHERE template_id = NEW.template_id);
+
+            RETURN NEW;
+
+            END
+           $TRIGGER$
+           LANGUAGE plpgsql;
+
+        CREATE TRIGGER #{new_schema}_template_revisions__bfr_insert
+                  BEFORE INSERT ON #{new_schema}.template_revisions
+                  FOR EACH ROW EXECUTE PROCEDURE #{new_schema}.template_revision_ordinal();
+
+        CREATE TRIGGER #{new_schema}_template_revisions__no_delete
+                BEFORE DELETE ON #{new_schema}.template_revisions
+                FOR EACH STATEMENT EXECUTE PROCEDURE #{new_schema}.tg_disallow();
+
+        CREATE TRIGGER #{new_schema}_template_revisions__no_update
+                BEFORE UPDATE OF notes, is_minor, template_id, author_id, created_at, ordinal ON #{new_schema}.template_revisions
+                FOR EACH STATEMENT EXECUTE PROCEDURE #{new_schema}.tg_disallow();
+
+        CREATE FUNCTION #{new_schema}.pages_revision_ordinal()
+          RETURNS TRIGGER
+          AS
+          $TRIGGER$
+            BEGIN
+
+            IF NEW.ordinal IS NOT NULL THEN
+              RAISE EXCEPTION $$Must not supply ordinal value manually.$$;
+            END IF;
+
+            NEW.ordinal = (SELECT COALESCE(MAX(ordinal)+1,1)
+                            FROM #{new_schema}.page_revisions
+                            WHERE page_id = NEW.page_id);
+
+            RETURN NEW;
+
+            END
+           $TRIGGER$
+           LANGUAGE plpgsql;
+
+        CREATE TRIGGER #{new_schema}_page_revisions__bfr_insert
+          BEFORE INSERT ON #{new_schema}.page_revisions
+          FOR EACH ROW EXECUTE PROCEDURE #{new_schema}.pages_revision_ordinal();
+
+        CREATE TRIGGER #{new_schema}_page_revisions__no_delete
+          BEFORE DELETE ON #{new_schema}.page_revisions
+          FOR EACH STATEMENT EXECUTE PROCEDURE #{new_schema}.tg_disallow();
+
+        CREATE TRIGGER #{new_schema}_page_revisions__no_update
+          BEFORE UPDATE OF notes, is_minor, page_id, author_id, created_at, ordinal ON #{new_schema}.page_revisions
+          FOR EACH STATEMENT EXECUTE PROCEDURE #{new_schema}.tg_disallow();
+      }
+      puts "Creating new triggers..."
+      connection.execute sql
+    end
+
+    def drop_old_triggers(old_schema, new_schema)
+      connection = ActiveRecord::Base.connection
+      sql = %{
+        DROP TRIGGER IF EXISTS #{old_schema}_page_revisions__bfr_insert ON #{new_schema}.page_revisions;
+        DROP TRIGGER IF EXISTS #{old_schema}_page_revisions__no_delete  ON #{new_schema}.page_revisions;
+        DROP TRIGGER IF EXISTS #{old_schema}_page_revisions__no_update  ON #{new_schema}.page_revisions;
+
+        DROP TRIGGER IF EXISTS #{old_schema}_template_revisions__bfr_insert ON #{new_schema}.template_revisions;
+        DROP TRIGGER IF EXISTS #{old_schema}_template_revisions__no_delete  ON #{new_schema}.template_revisions;
+        DROP TRIGGER IF EXISTS #{old_schema}_template_revisions__no_update  ON #{new_schema}.template_revisions;
+
+        DROP FUNCTION IF EXISTS #{old_schema}.pages_revision_ordinal();
+        DROP FUNCTION IF EXISTS #{old_schema}.template_revision_ordinal();
+        DROP FUNCTION IF EXISTS #{old_schema}.tg_disallow();
+      }
+      puts "Dropping old triggers..."
+      connection.execute sql
+    end
+
+    def ask(*args, &block)
+      HighLine.new.ask(*args, &block)
+    end
+
+    def get_schema_names(new = true)
+      # Always get old schemas
+      @old_landable = ask("Enter the OLD main landable schema: ") { |q| q.default = 'landable' }
+      @old_traffic = ask("Enter the OLD traffic schema: ") { |q| q.default = 'landable_traffic' }
+
+      # Only ask for new names if new == true
+      if new
+        @new_landable = ask("Enter the NEW main landable schema: ") { |q| q.default = "#{appname}_landable" }
+        @new_traffic = ask("Enter the NEW traffic schema: ") { |q| q.default = "#{appname}_landable_traffic" }
+      end
+    end
+
+    def create_schemas
+      create_schema @new_landable
+      create_schema @new_traffic
+    end
+
+    def migrate_objects
+      # move_tables
+      move_objects(@old_landable, @new_landable, 'r', 'TABLE')
+      move_objects(@old_traffic, @new_traffic, 'r', 'TABLE')
+      # move_sequences
+      move_objects(@old_landable, @new_landable, 's', 'SEQUENCE')
+      move_objects(@old_traffic, @new_traffic, 's', 'SEQUENCE')
+      # move_views
+      move_objects(@old_landable, @new_landable, 'v', 'TABLE')
+      move_objects(@old_traffic, @new_traffic, 'v', 'TABLE')
+      # move_triggers
+      create_new_triggers(@new_landable)
+      drop_old_triggers(@old_landable, @new_landable)
+    end
+
+    def drop_old_schemas
+      drop_schema @old_landable
+      drop_schema @old_traffic
+    end
+
+    def want_to_drop_old_schemas?
+      drop = nil
+      until ['yes', 'no'].include?(drop.to_s.downcase)
+        drop = ask("Would you like to drop the old schemas? (Yes or No)") { |q| q.default = 'no' }
+      end
+      drop.to_s.downcase == 'yes'
+    end
+
+    def appname
+      Rails.application.class.parent_name.underscore
+    end
+  end
+end

data/lib/tasks/landable/data.rake

@@ -1,3 +1,8 @@
+require 'highline'
+
+require_dependency 'schema_moves'
+include SchemaMoves::Helpers
+
 namespace :landable do
   namespace :data do
     desc "Clean & restore database from specified source"
@@ -20,147 +25,18 @@ namespace :landable do
     end
 
     desc "Migrates all to new schema"
-    task :move_schemas, :old_landable, :new_landable, :old_traffic, :new_traffic do |t, args|
-      @old_landable = "#{args[:old_landable]}"
-      @new_landable = "#{args[:new_landable]}"
-      @old_traffic = "#{args[:old_traffic]}"
-      @new_traffic = "#{args[:new_traffic]}"
-
-      Rake.application.invoke_task("landable:data:create_schemas")
-      Rake.application.invoke_task("landable:data:move_tables")
-      Rake.application.invoke_task("landable:data:move_sequences")
-      Rake.application.invoke_task("landable:data:move_triggers")
-    end
-
-    desc "Creates the new schemas"
-    task create_schemas: :environment do
-      create_schema("#{@new_landable}")
-      create_schema("#{@new_traffic}")
-    end
-
-    desc "Move tables to new db schema"
-    task move_tables: :environment do
-      move_objects("#{@old_landable}", "#{@new_landable}", 'r', 'TABLE')
-      move_objects("#{@old_traffic}", "#{@new_traffic}", 'r', 'TABLE')
-    end
-
-    desc "Move sequences to new db schema"
-    task move_sequences: :environment do
-      move_objects("#{@old_landable}", "#{@new_landable}", 'S', 'SEQUENCE')
-      move_objects("#{@old_traffic}", "#{@new_traffic}", 'S', 'SEQUENCE')
+    task move_schemas: :environment do
+      get_schema_names
+      create_schemas
+      migrate_objects
+      drop_old_schemas if want_to_drop_old_schemas?
     end
 
-    desc "Move triggers to new db schema"
-    task move_triggers: :environment do
-      create_new_triggers("#{@new_landable}")
-      drop_old_triggers("#{@old_landable}", "#{@new_landable}")
-    end
-
-  end
-
-  def create_schema(schema)
-    connection = ActiveRecord::Base.connection
-
-    sql = %{
-      CREATE SCHEMA #{schema};
-    }
-    puts "Creating #{schema} schema"
-    connection.execute sql
-  end
-
-  def move_objects(from_schema, to_schema, relkind, object_type)
-    connection = ActiveRecord::Base.connection
-
-    # move objects from public to new schema
-    objects = connection.select_all("
-      SELECT o.relname
-        FROM pg_class o
-        JOIN pg_namespace n
-        ON n.oid=o.relnamespace
-        AND n.nspname = '#{from_schema}'
-        AND o.relkind = '#{relkind}'
-        ORDER BY o.relname
-    ")
-
-    objects.each do |object|
-      sql = %{
-        ALTER #{object_type} #{from_schema}.#{object['relname']}
-          SET SCHEMA #{to_schema}
-      }
-      puts "Moving #{from_schema}.#{object['relname']} TO #{to_schema}"
-      connection.execute sql
+    desc "Drop the old schemas"
+    task drop_schemas: :environment do
+      get_schema_names false
+      drop_old_schemas if want_to_drop_old_schemas?
     end
-  end
-
-  def create_new_triggers(new_schema)
-    puts "#{new_schema}"
-    connection = ActiveRecord::Base.connection
-    sql = %{
-      CREATE FUNCTION #{new_schema}.pages_revision_ordinal()
-        RETURNS TRIGGER
-        AS
-        $TRIGGER$
-          BEGIN
-
-          IF NEW.ordinal IS NOT NULL THEN
-            RAISE EXCEPTION $$Must not supply ordinal value manually.$$;
-          END IF;
-
-          NEW.ordinal = (SELECT COALESCE(MAX(ordinal)+1,1)
-                          FROM #{new_schema}.page_revisions
-                          WHERE page_id = NEW.page_id);
-
-          RETURN NEW;
-
-          END
-         $TRIGGER$
-         LANGUAGE plpgsql;
-
-      CREATE TRIGGER #{new_schema}_page_revisions__bfr_insert
-        BEFORE INSERT ON #{new_schema}.page_revisions
-        FOR EACH ROW EXECUTE PROCEDURE #{new_schema}.pages_revision_ordinal();
-
-      CREATE FUNCTION #{new_schema}.tg_disallow()
-        RETURNS TRIGGER
-        AS
-        $TRIGGER$
-          BEGIN
-
-          IF TG_LEVEL <> 'STATEMENT' THEN
-            RAISE EXCEPTION $$You should use a statement-level trigger (trigger %, table %)$$, TG_NAME, TG_RELID::regclass;
-          END IF;
-
-          RAISE EXCEPTION $$%s are not allowed on table %$$, TG_OP, TG_RELNAME;
-
-          RETURN NULL;
-
-          END
-         $TRIGGER$
-         LANGUAGE plpgsql;
-
-      CREATE TRIGGER #{new_schema}_page_revisions__no_delete
-        BEFORE DELETE ON #{new_schema}.page_revisions
-        FOR EACH STATEMENT EXECUTE PROCEDURE #{new_schema}.tg_disallow();
-
-      CREATE TRIGGER #{new_schema}_page_revisions__no_update
-        BEFORE UPDATE OF notes, is_minor, page_id, author_id, created_at, ordinal ON #{new_schema}.page_revisions
-        FOR EACH STATEMENT EXECUTE PROCEDURE #{new_schema}.tg_disallow();
-    }
-    puts "Creating new triggers..."
-    connection.execute sql
-  end
-
-  def drop_old_triggers(old_schema, new_schema)
-    connection = ActiveRecord::Base.connection
-    sql = %{
-      DROP TRIGGER IF EXISTS #{old_schema}_page_revisions__bfr_insert ON #{new_schema}.page_revisions;
-      DROP TRIGGER IF EXISTS #{old_schema}_page_revisions__no_delete  ON #{new_schema}.page_revisions;
-      DROP TRIGGER IF EXISTS #{old_schema}_page_revisions__no_update  ON #{new_schema}.page_revisions;
 
-      DROP FUNCTION IF EXISTS #{old_schema}.pages_revision_ordinal();
-      DROP FUNCTION IF EXISTS #{old_schema}.tg_disallow();
-    }
-    puts "Dropping old triggers..."
-    connection.execute sql
   end
-end
+end

data/spec/dummy/app/views/layouts/_partial.html.haml

@@ -0,0 +1 @@
+I am a partial, hear me roar!

data/spec/dummy/app/views/layouts/application.haml

@@ -0,0 +1,4 @@
+!!!
+%html{lang: 'en'}
+  %body
+    I am an awesome Theme :)

data/spec/lib/landable/layout_spec.rb

@@ -6,7 +6,7 @@ module Landable
   describe Layout do
     it "creates themes" do
       Theme.destroy_all
-      expect { described_class.all.each(&:to_theme) }.to change { Theme.count }.by(2)
+      expect { described_class.all.each(&:to_theme) }.to change { Theme.count }.by(3)
     end
 
     it "defaults attributes" do
@@ -21,5 +21,15 @@ module Landable
 
       theme.body.should == File.read(Rails.root.join('app/views/layouts/application.html.erb'))
     end
+
+    context 'File Finding' do
+      it 'will find the correct application files' do
+        Layout.files.any? { |f| f.end_with?('application.haml') }.should be_true
+        Layout.files.any? { |f| f.end_with?('application.html.erb') }.should be_true
+        Layout.files.any? { |f| f.end_with?('priority.html.erb') }.should be_true
+        Layout.files.any? { |f| f.end_with?('_partial.html.haml') }.should be_false
+        Layout.files.any? { |f| f.end_with?('partial.html.haml') }.should be_false
+      end
+    end
   end
 end

data/spec/lib/landable/tracking_spec.rb

@@ -89,6 +89,30 @@ module Landable
       end
     end
 
+    context 'user_agent' do
+      describe '#get_user_agent' do
+        context 'user agent provided' do
+          let(:user_agent) { Landable::Traffic::UserAgent.new(user_agent: 'dummy_user_agent') }
+
+          it 'should return the user agent' do
+            tracker = Landable::Traffic::UserTracker.new controller
+            tracker.stub(:user_agent) { user_agent }
+
+            tracker.send(:get_user_agent).should == user_agent
+          end
+        end
+
+        context 'user agent not provided' do
+          it 'should return the user agent' do
+            tracker = Landable::Traffic::UserTracker.new controller
+            tracker.stub(:user_agent) { nil }
+
+            tracker.send(:get_user_agent).should be_nil
+          end
+        end
+      end
+    end
+
     context 'no referer' do
       let(:visit) { double('visit', { referer: nil }) }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: landable
 version: !ruby/object:Gem::Version
-  version: 1.10.0.rc2
+  version: 1.11.0
 platform: ruby
 authors:
 - Team Trogdor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-04 00:00:00.000000000 Z
+date: 2014-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -42,16 +42,16 @@ dependencies:
   name: active_model_serializers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.8.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.8.3
 - !ruby/object:Gem::Dependency
   name: carrierwave
   requirement: !ruby/object:Gem::Requirement
@@ -70,16 +70,16 @@ dependencies:
   name: liquid
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.6.1
 - !ruby/object:Gem::Dependency
   name: fog
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +136,20 @@ dependencies:
     - - '>'
       - !ruby/object:Gem::Version
         version: 0.4.0
+- !ruby/object:Gem::Dependency
+  name: highline
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -298,8 +312,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .hound.yml
 - .rbenv-gemsets
 - .rspec
+- .ruby.yml
 - .travis.yml
 - CHANGELOG.md
 - Gemfile
@@ -526,6 +542,7 @@ files:
 - lib/landable/traffic/tracker.rb
 - lib/landable/traffic/user_tracker.rb
 - lib/landable/version.rb
+- lib/schema_moves.rb
 - lib/tasks/landable/cucumber.rake
 - lib/tasks/landable/data.rake
 - lib/tasks/landable/pgtap.rake
@@ -568,6 +585,8 @@ files:
 - spec/dummy/app/mailers/.keep
 - spec/dummy/app/models/.keep
 - spec/dummy/app/models/concerns/.keep
+- spec/dummy/app/views/layouts/_partial.html.haml
+- spec/dummy/app/views/layouts/application.haml
 - spec/dummy/app/views/layouts/application.html.erb
 - spec/dummy/app/views/layouts/priority.html.erb
 - spec/dummy/app/views/partials/_foobazz.html
@@ -659,12 +678,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>'
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Mountable CMS engine for Rails
@@ -724,6 +743,8 @@ test_files:
 - spec/dummy/app/mailers/.keep
 - spec/dummy/app/models/.keep
 - spec/dummy/app/models/concerns/.keep
+- spec/dummy/app/views/layouts/_partial.html.haml
+- spec/dummy/app/views/layouts/application.haml
 - spec/dummy/app/views/layouts/application.html.erb
 - spec/dummy/app/views/layouts/priority.html.erb
 - spec/dummy/app/views/partials/_foobazz.html