lagunitas 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5a194c09db06f502a74285d90164859150f76845
-  data.tar.gz: 8985a301c8dc5fb2e74d8318029b68e754923e7d
+SHA256:
+  metadata.gz: 56fa97a715dde896b508360808a0bb4b11b668df2a8a8b486905151760456415
+  data.tar.gz: '0895bc28b55d105f46de7725e5d9a8e1415ddb4d716f25093573e57a9bec645e'
 SHA512:
-  metadata.gz: 0dae877a69f5d5786c9e66830bdd002728114f2d926fcbec0b976ccfb6d9dc4dad0024641d7cf96ac54fd1e3c6884cd48542196ea73f5da1e221580521aa193f
-  data.tar.gz: b2efd099fb4465c1b8f92aa9119a12e540c258c9fc14ab3b8a124dbd7086c02006094ce085ae1a99e373ac39f014f38f5aba04d3ad6c48ff1611622569817eea
+  metadata.gz: 362150ea3ba7b5ace28c31d6181af1bb89422fe1cb9ee8a84a6fd970e849f2716465c3975ffdea1d82769933ceca558cfbed6d143159fd06072e0e73b9097a8c
+  data.tar.gz: 880dd41275ac06a631a6029762ee777e0621f4bda82e5c9d758839e227d99a51505dbece10db87db34a4d8ed274cdddf85f1ee68b5805680cbe3a0d4399d9a46

data/.github/workflows/ruby.yml

@@ -0,0 +1,34 @@
+name: Ruby
+on:
+  pull_request:
+    paths:
+      - '**/*.rb'
+      - Gemfile
+      - Rakefile
+  push:
+    branches:
+      - main
+jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    env:
+      RAILS_ENV: test
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7.2
+      - name: Cache gems
+        uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
+      - name: Install dependencies
+        run: |
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+      - name: Run Rubocop
+        run: bundle exec rake lint:ruby

data/.github/workflows/test.yml

@@ -0,0 +1,28 @@
+name: Test
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+jobs:
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7.2
+      - name: Cache gems
+        uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
+      - name: Install dependencies
+        run: |
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+      - name: Run tests
+        run: bundle exec rake test

data/.github/workflows/yaml.yml

@@ -0,0 +1,26 @@
+name: YAML
+on:
+  pull_request:
+    paths:
+      - '**/*.yml'
+      - '**/*.yaml'
+  push:
+    branches:
+      - main
+jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Setup Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: '3.x'
+      - name: Install dependencies
+        run: python -m pip install --upgrade pip setuptools wheel yamllint
+      - name: Lint
+        run: |
+          yamllint --version >/dev/null 2>&1 || pip3 install yamllint
+          yamllint -c .yamllint.yml .

data/.rubocop.yml

@@ -0,0 +1,2 @@
+AllCops:
+  TargetRubyVersion: 2.4

data/.yamllint.yml

@@ -0,0 +1,10 @@
+extends: default
+yaml-files:
+  - '*.yaml'
+  - '*.yml'
+ignore: |
+  /vendor/
+rules:
+  document-start: disable
+  line-length: disable
+  truthy: disable

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2013-2014 Sam Soffes, http://soff.es
+Copyright (c) 2013-2020 Sam Soffes, https://soff.es
 
 MIT License
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler'
 Bundler::GemHelper.install_tasks
 
@@ -7,3 +9,20 @@ Rake::TestTask.new(:test) do |t|
   t.pattern = 'test/**/*_test.rb'
 end
 task default: :test
+
+namespace :lint do
+  desc 'Lint Ruby'
+  task :ruby do
+    system 'bundle exec rubocop --parallel --config .rubocop.yml'
+  end
+
+  desc 'Lint YAML'
+  task :yaml do
+    abort 'yamllint is not installed. Install it with `pip3 install yamllint`.' if `which yamllint`.chomp.empty?
+
+    system 'yamllint -c .yamllint.yml .'
+  end
+end
+
+desc 'Run all linters'
+task lint: %i[lint:ruby lint:yaml]

data/lagunitas.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'lagunitas/version'
 
@@ -12,18 +13,20 @@ Gem::Specification.new do |spec|
   spec.summary       = spec.description
   spec.homepage      = 'https://github.com/soffes/lagunitas'
   spec.license       = 'MIT'
+  spec.required_ruby_version = '>= 2.4'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'bundler', '>= 1.3'
 
-  spec.add_dependency 'rubyzip', '>= 1.0.0'
   spec.add_dependency 'CFPropertyList'
   spec.add_dependency 'pngdefry', '>= 0.1.0'
+  spec.add_dependency 'rubocop', '>= 0.92.0'
+  spec.add_dependency 'rubyzip', '>= 1.0.0'
 
-  spec.add_development_dependency 'rake'
   spec.add_development_dependency 'minitest', '>= 5.0'
+  spec.add_development_dependency 'rake'
 end

data/lib/lagunitas.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 require 'lagunitas/version'
 
+# Lagunitas module
 module Lagunitas
 end
 

data/lib/lagunitas/app.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 require 'cfpropertylist'
 require 'pngdefry'
 
 module Lagunitas
+  # Representation of an app inside an IPA
   class App
     def initialize(path)
       @path = path
@@ -15,6 +18,10 @@ module Lagunitas
       info['CFBundleIdentifier']
     end
 
+    def bundle_name
+      info['CFBundleName']
+    end
+
     def display_name
       info['CFBundleDisplayName']
     end
@@ -41,7 +48,9 @@ module Lagunitas
           icons << get_image(name)
           icons << get_image("#{name}@2x")
         end
-        icons.delete_if { |i| !i }
+        icons.delete_if(&:!)
+      rescue NoMethodError # fix a ipa without icons
+        []
       end
     end
 

data/lib/lagunitas/ipa.rb

@@ -1,10 +1,15 @@
+# frozen_string_literal: true
+
 require 'zip'
 require 'fileutils'
+require 'securerandom'
 
 module Lagunitas
+  # Representation of an IPA file
   class IPA
     def initialize(path)
       @path = path
+      @contents = nil
     end
 
     def app
@@ -17,6 +22,7 @@ module Lagunitas
 
     def cleanup
       return unless @contents
+
       FileUtils.rm_rf(@contents)
       @contents = nil
     end
@@ -25,7 +31,8 @@ module Lagunitas
 
     def contents
       return if @contents
-      @contents = "tmp/lagunitas-#{SecureRandom.hex}"
+
+      @contents = "tmp/lagunitas-#{::SecureRandom.hex}"
 
       Zip::File.open(@path) do |zip_file|
         zip_file.each do |f|

data/lib/lagunitas/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Lagunitas
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/test/lagunitas/app_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module Lagunitas
@@ -29,7 +31,7 @@ module Lagunitas
     end
 
     def teardown
-      @ipa.cleanup if @ipa
+      @ipa&.cleanup
     end
   end
 end

data/test/lagunitas/ipa_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module Lagunitas
@@ -11,7 +13,7 @@ module Lagunitas
     end
 
     def teardown
-      @ipa.cleanup if @ipa
+      @ipa&.cleanup
     end
   end
 end

data/test/lagunitas_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module Lagunitas

data/test/test_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'bundler'
 Bundler.require :test
@@ -6,10 +8,12 @@ require 'minitest/autorun'
 require 'lagunitas'
 
 # Support files
-Dir["#{File.expand_path(File.dirname(__FILE__))}/support/*.rb"].each do |file|
+Dir["#{__dir__}/support/*.rb"].sort.each do |file|
   require file
 end
 
-class Lagunitas::TestCase < MiniTest::Test
-  include Lagunitas
+module Lagunitas
+  class TestCase < MiniTest::Test
+    include Lagunitas
+  end
 end

metadata

@@ -1,85 +1,85 @@
 --- !ruby/object:Gem::Specification
 name: lagunitas
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Sam Soffes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-13 00:00:00.000000000 Z
+date: 2020-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: rubyzip
+  name: CFPropertyList
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: CFPropertyList
+  name: pngdefry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.1.0
 - !ruby/object:Gem::Dependency
-  name: pngdefry
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.92.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.92.0
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rubyzip
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: 1.0.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Easy iOS IPAs inspection.
 email:
 - sam@soff.es
@@ -101,7 +115,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
+- ".github/workflows/test.yml"
+- ".github/workflows/yaml.yml"
 - ".gitignore"
+- ".rubocop.yml"
+- ".yamllint.yml"
 - Gemfile
 - LICENSE
 - Rakefile
@@ -128,15 +147,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Easy iOS IPAs inspection.