ladybug 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b73479c1e9523e9a0f5798daed1707ed24baf74c
-  data.tar.gz: d046e7c87d246a2e3a156ad1bf71c23fc256789c
+  metadata.gz: e754a38c616bafe8c321316d63c69761918f2a78
+  data.tar.gz: 504e0c72215d472c93a17d3d5c780ef16d1bc7d4
 SHA512:
-  metadata.gz: c79d7443d7cebedbb3174fe5a340aa21d2c23d201df2fab87aa6294326c839b3371e187f46eb7d351f4c7c8ad8bf103197882ded9dfb588284f1ae3422eca4ed
-  data.tar.gz: 58f696d4d5dc454c68215c0a3780f9ea2c45d070db1e168f915f2be26bf7ec5e567a02c110439291962f8db88f4e481a4d70978e669f0d7f01c0129c8f8893b4
+  metadata.gz: 1c4a8090f910deb746e64a1e292f2dd95f857932e714ed0525a6db00672d9d1890cfc4246911c6eec2b0472969bd17e24cc76eb9c3d43e207e1f1973ca3a0f40
+  data.tar.gz: 7cec420eae32d21ed0cc51713fe49f8b414205615806beb41ef7750034317b1f84f9bbdcc2fb1b41da08ca7a7cb3131a8d1e4dec5bd4a94ed605956b668a781e

data/README.md

@@ -6,11 +6,11 @@ Chrome Devtools as a user interface.
 It aims to provide a rich backend debugging experience in a UI that many
 web developers are already familiar with for debugging frontend Javascript.
 
-**This project is currently in an early experimental phase.** Expect many limitations and bugs. If you try it out, please file
+**This project is currently in an experimental phase.** Expect many limitations and bugs. If you try it out, please file
 Github issues or [email me](mailto:gklitt@gmail.com) to help make this a
 more useful tool.
 
-![screenshot](screenshots/demo.png)
+![screenshot](screenshots/ladybug-demo.gif)
 
 ## Get started
 
@@ -53,7 +53,7 @@ execute code on your server without authenticating.
 
 ## Development status
 
-* So far, ladybug has only been tested with simple Rails applications running on
+* So far, ladybug has been tested with simple Rails applications running on
 Rails 5 with the puma web server. Eventually it aims to support more Rack
 applications and web servers (and perhaps even non-Rack applications).
 * inspecting primtive objects like strings and numbers works okay; support for more complex objects is in development.

data/lib/ladybug/debugger.rb

@@ -82,6 +82,8 @@ module Ladybug
     end
 
     def evaluate(expression)
+      raise InvalidExpressionError if !parseable?(expression)
+
       @to_main_thread.push({
         command: 'eval',
         arguments: {
@@ -144,6 +146,17 @@ module Ladybug
 
     private
 
+    # Try parsing an expression to see if we can safely eval it
+    def parseable?(expression)
+      begin
+        Parser::CurrentRuby.parse(expression)
+      rescue Parser::SyntaxError
+        return false
+      end
+
+      return true
+    end
+
     # remove ladybug code from a callstack and prepare it for comparison
     # this is a hack implemenetation for now, can be made better
     def clean(callstack)
@@ -317,5 +330,6 @@ module Ladybug
     memoize :deep_child_node_types
 
     class InvalidBreakpointLocationError < StandardError; end
+    class InvalidExpressionError < StandardError; end
   end
 end

data/lib/ladybug/middleware.rb

@@ -39,6 +39,13 @@ module Ladybug
 
     private
 
+    # Avoid eval'ing weird expressions that Chrome sends us,
+    # like Javascript functions and other things.
+    # This is an initial hack implementation, could be better.
+    def sanitize_expression(expression)
+      expression
+    end
+
     def create_websocket(env)
       ws = Faye::WebSocket.new(env)
 
@@ -155,7 +162,17 @@ module Ladybug
             @debugger.step_out
             result = {}
           elsif data["method"] == "Debugger.evaluateOnCallFrame"
-            evaluated = @debugger.evaluate(data["params"]["expression"])
+            expression = data["params"]["expression"]
+
+            begin
+              evaluated = @debugger.evaluate(expression)
+            rescue Debugger::InvalidExpressionError
+              # A better thing to do would be to throw the syntax error
+              # back to the user, but for now we just return nil if
+              # given invalid input
+              evaluated = nil
+            end
+
             result = {
               result: @object_manager.serialize(evaluated)
             }
@@ -197,6 +214,26 @@ module Ladybug
 
               ws.send(message)
             end
+
+            # Create a runtime context so Chrome can
+            # accept user input in the console
+
+            message = {
+              method: "Runtime.executionContextCreated",
+              params: {
+                context: {
+                  id: 12, # random number for now
+                  name: "",
+                  origin: "http://localhost:3000" ,
+                  auxData: {
+                    isDefault: true,
+                    frameId: SecureRandom.uuid
+                  }
+                }
+              }
+            }.to_json
+
+            ws.send(message)
           end
         rescue => e
           puts e.message

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ladybug
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Geoffrey Litt
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.7
+        version: '0.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.7
+        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0.2
+        version: '2.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0.2
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: memoist
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: '0.14'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: '0.14'
 description: Debug Ruby code using Chrome Devtools
 email: gklitt@gmail.com
 executables: []