lacerda 0.3.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9e353a73a35769ada04cc9efa1a32dfbedc1fee
-  data.tar.gz: a18205aa09824893c34a3c861dff1995f92fd28a
+  metadata.gz: f22605d51fec41e57a8bb76e38621ef3fba87847
+  data.tar.gz: 186995c3c701f0a3ffaf6783eed3cbb85ee2b940
 SHA512:
-  metadata.gz: 605e8d8df037122645b4a113180ab043cb7472ca35792696e570c9398510b2c4f2703600cce3c3fdceee6f3fe473bbba44c1d259b7dfe9842cac85b31cb4ab0b
-  data.tar.gz: 4e9ad371ccb84ba3667c973011d216d0bddae5454a85a4aadfc638053d71c83ddb537cd1ae300561384b6e51c94e2929359c583dac46618b55d2a253f1f6b367
+  metadata.gz: f9527eab7980d2770748ce1382678111e992ab125e5918f0843ddc28d4d56071972d770082908630491836922eadef2a66cca8645b0643b145c1957cf98581d9
+  data.tar.gz: 6e76e0f5edc802737bcb0099b1886e5397fbcf8f7ed6835ad76d332279b4f1f014c349c80e1c110d5a8c613255ccb5fb1f16d417a6942f277f82d3d48c8d0cd6

data/.ruby-gemset

@@ -1 +1 @@
-minimum-term
+lacerda

data/CHANGELOG.markdown

@@ -1,3 +1,10 @@
+# 0.3.2 (28-Oct-15)
+- fix wrongly named rake task
+- fix case where an infrastructure with a missing publishing service was reported as valid
+
+# 0.3.0 (28-Oct-15)
+- rename to Lacerda
+
 # 0.2.4 (23-Oct-15)
 - fix deep clone bug for schema scoping
 

data/README.md

@@ -1,7 +1,7 @@
-# Lacerda [![Circle CI](https://circleci.com/gh/moviepilot/minimum-term/tree/master.svg?style=svg)](https://circleci.com/gh/moviepilot/minimum-term/tree/master) [![Coverage Status](https://coveralls.io/repos/moviepilot/minimum-term/badge.svg?branch=master&service=github)](https://coveralls.io/github/moviepilot/minimum-term?branch=master) [![Code Climate](https://codeclimate.com/github/moviepilot/minimum-term/badges/gpa.svg)](https://codeclimate.com/github/moviepilot/minimum-term) [![Dependency Status](https://gemnasium.com/moviepilot/minimum-term.svg)](https://gemnasium.com/moviepilot/minimum-term)
+# Lacerda [![Circle CI](https://circleci.com/gh/moviepilot/lacerda/tree/master.svg?style=svg)](https://circleci.com/gh/moviepilot/lacerda/tree/master) [![Coverage Status](https://coveralls.io/repos/moviepilot/lacerda/badge.svg?branch=master&service=github)](https://coveralls.io/github/moviepilot/lacerda?branch=master) [![Code Climate](https://codeclimate.com/github/moviepilot/lacerda/badges/gpa.svg)](https://codeclimate.com/github/moviepilot/lacerda) [![Dependency Status](https://gemnasium.com/moviepilot/lacerda.svg)](https://gemnasium.com/moviepilot/lacerda)
 
 ![](https://dl.dropboxusercontent.com/u/1953503/lacerda.jpg)
-> «We need total coverage»<sup>[1](http://www.dailyscript.com/scripts/fearandloathing.html)</sup>
+> «No, no -- we have to go on. We need total coverage.»<sup>[1](#references)</sup>
 
 This gem can:
 
@@ -63,3 +63,7 @@ By converting all files in a directory this gem will build up the following rela
         - PublishedObjects
       - Consume contract
         - ConsumedObjects
+
+# References
+
+[1] This quote in French quotation marks is from "Fear and Loathing in Las Vegas". Since I can't link to the book, a link to the [movie script](http://www.dailyscript.com/scripts/fearandloathing.html) shall suffice. 

data/lib/lacerda/compare/json_schema.rb

@@ -18,8 +18,9 @@ module Lacerda
         @containing_schema = containing_schema
       end
 
-      def contains?(contained_schema, pry = false)
+      def contains?(contained_schema, initial_location = nil)
         @errors = []
+        @initial_location = initial_location
         @contained_schema = contained_schema
         definitions_contained?
       end
@@ -29,7 +30,7 @@ module Lacerda
       def definitions_contained?
         @contained_schema['definitions'].each do |property, contained_property|
           containing_property = @containing_schema['definitions'][property]
-          return _e(:ERR_MISSING_DEFINITION, [property]) unless containing_property
+          return _e(:ERR_MISSING_DEFINITION, [@initial_location, property]) unless containing_property
           return false unless schema_contains?(containing_property, contained_property, [property])
         end
         true
@@ -37,7 +38,7 @@ module Lacerda
 
       def _e(error, location, extra = nil)
         message = [ERRORS[error], extra].compact.join(": ")
-        @errors.push(error: error, message: message, location: location.join("/"))
+        @errors.push(error: error, message: message, location: location.compact.join("/"))
         false
       end
 

data/lib/lacerda/consumed_object.rb

@@ -4,9 +4,14 @@ module Lacerda
   class ConsumedObject < Lacerda::ObjectDescription
 
     def publisher
+      return unless publisher_name
+      @defined_in_service.infrastructure.services[publisher_name]
+    end
+
+    def publisher_name
       i = @scoped_name.index(Lacerda::SCOPE_SEPARATOR)
-      return @defined_in_service unless i
-      @defined_in_service.infrastructure.services[@scoped_name[0...i].underscore.to_sym]
+      return unless i
+      @scoped_name[0...i].underscore
     end
 
     def consumer

data/lib/lacerda/infrastructure.rb

@@ -18,11 +18,33 @@ module Lacerda
     def contracts_fulfilled?
       @mutex1.synchronize do
         @errors = {}
+
+        # Check for incompatibility in published objects
         publishers.each do |publisher|
           publisher.satisfies_consumers?(verbose: @verbose)
           next if publisher.errors.empty?
           @errors.merge! publisher.errors
         end
+
+        # Check for missing publishers
+        missing_publishers = {}
+        consumers.each do |consumer|
+          consumer.consumed_objects.each do |object|
+            next if object.publisher
+            missing_publishers[object.publisher_name.camelize] ||= []
+            missing_publishers[object.publisher_name.camelize] << consumer.name.camelize
+          end
+        end
+
+        # Report missing publishers
+        unless missing_publishers.empty?
+          missing = []
+          missing_publishers.each do |publisher, consumers|
+            missing << "#{publisher} (consumed by #{consumers.join(', ')})"
+          end
+          errors["Missing publishers: "] = missing
+        end
+
         @errors.empty?
       end
     end

data/lib/lacerda/publish_contract.rb

@@ -10,7 +10,7 @@ module Lacerda
 
     def satisfies?(consumer)
       @comparator = Compare::JsonSchema.new(@schema)
-      @comparator.contains?(consumer.consume.scoped_schema(service))
+      @comparator.contains?(consumer.consume.scoped_schema(service), consumer.name)
     end
 
     private

data/lib/lacerda/service.rb

@@ -43,10 +43,10 @@ module Lacerda
       consumers.each do |consumer|
         @publish.satisfies?(consumer)
         if @publish.errors.empty?
-          print "#{consumer.name.camelize}".green if verbose
+          print "#{consumer.name.camelize.green} "if verbose
           next
         end
-          print "#{consumer.name.camelize}".red if verbose
+          print "#{consumer.name.camelize.red} "if verbose
         @errors["#{name} -> #{consumer.name}"] = @publish.errors
       end
       print "\n" if verbose

data/lib/lacerda/tasks.rb

@@ -5,7 +5,7 @@ module Lacerda
     include Rake::DSL if defined? Rake::DSL
 
     def install_tasks
-      namespace :minimum_term do
+      namespace :lacerda do
         desc "Clean up intermediary json files"
         task :cleanup do
           path = File.expand_path("../contracts")

data/lib/lacerda/version.rb

@@ -1,3 +1,3 @@
 module Lacerda
-  VERSION = '0.3.0'
+  VERSION = '0.3.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lacerda
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors:
 - Jannis Hermanns