kumo_keisei 3.0.4.pre.alpha1 → 3.0.4.pre.alpha2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a9f9da6e952e7fb49df49d4c9e401dd56ec2615c
-  data.tar.gz: 13863deea165af416cea1e65b9d0e8b09cb39669
+  metadata.gz: 6d20310dc355e8295f37c2613f3e4c9c27109716
+  data.tar.gz: 073d42960ee1118df16dd1841757c93c551a021d
 SHA512:
-  metadata.gz: f8c7eb06e6a431a2089a79ee94554a2d6c610362f6506de26353fb436e6350b0bc4a3cc4ecfbb80238a878fba0d858f58aaf9746a5cda505d85e69f7b4ed79b7
-  data.tar.gz: b503f7296fdbb83ee35ef401afe75a1e4a52a226b345cf6e926e8cea84a18a90b9182fd970b258a0518d4c36de651a3166c226af0eeda10ebc0fc5d175c6ffb1
+  metadata.gz: 6ae2f7c6d66e22c8eaae52044954b1d6f539a0ca96ab5b5b84dc87694cfe4802ce49679f52cde32d9ce49f8accfe23ebdd973715844bbd1d003145242366d787
+  data.tar.gz: de1ce351850616e9ff96fcb5a5175d27add17fbeae051d49e1a185a47f3f9eaed94086d40371471868932b3e3fc210000aa8b0e30313dcd0e057cc23aef90719

data/VERSION

@@ -1 +1 @@
-3.0.4-alpha1
+3.0.4-alpha2

data/lib/kumo_keisei/environment_config.rb

@@ -8,6 +8,8 @@ require_relative 'parameter_builder'
 module KumoKeisei
   # Environment Configuration for a cloud formation stack
   class EnvironmentConfig
+    class ConfigurationError < StandardError; end
+
     LOGGER = Logger.new(STDOUT)
 
     attr_reader :app_name, :env_name
@@ -16,9 +18,18 @@ module KumoKeisei
       @env_name = options[:env_name]
       @params_template_file_path = options[:params_template_file_path]
       @injected_config = options[:injected_config] || {}
-      @config_file_loader = KumoKeisei::FileLoader.new(config_dir_path: options[:config_path])
-
       @log = logger
+
+      if options[:config_path]
+          @config_file_loader = KumoKeisei::FileLoader.new(config_dir_path: options[:config_path])
+      elsif options[:config_dir_path]
+          warn "[DEPRECATION] `:config_dir_path` is deprecated, please pass in `:config_path` instead"
+          @config_file_loader = KumoKeisei::FileLoader.new(config_dir_path: options[:config_dir_path])
+      else
+          @log.error "Please provide a :config_path"
+          raise ConfigurationError.new("Please provide a :config_path")
+      end
+
     end
 
     def production?

data/spec/lib/kumo_keisei/environment_config_spec.rb

@@ -26,6 +26,58 @@ describe KumoKeisei::EnvironmentConfig do
     allow(File).to receive(:dirname).and_return('/tmp')
   end
 
+  context 'backward compatibility' do
+      context 'config_path' do
+        let(:options) do
+          {
+            env_name: env_name,
+            config_path: config_dir_path
+          }
+        end
+        it 'will be used without complaint' do
+            expect(KumoKeisei::FileLoader).to receive(:new).with(config_dir_path: config_dir_path).and_return(nil)
+            described_class.new(options)
+        end
+      end
+
+      context 'config_dir_path' do
+        let(:options) do
+          {
+            env_name: env_name,
+            config_dir_path: config_dir_path
+          }
+        end
+
+        before do
+          @orig_stderr = $stderr
+          $stderr = StringIO.new
+        end
+
+        after do
+          $stderr = @orig_stderr
+        end
+
+        it 'will be used if given and raise a deprecation warning' do
+            expect(KumoKeisei::FileLoader).to receive(:new).with(config_dir_path: config_dir_path).and_return(nil)
+            described_class.new(options)
+            $stderr.rewind
+            expect($stderr.string.chomp).to eq("[DEPRECATION] `:config_dir_path` is deprecated, please pass in `:config_path` instead")
+        end
+      end
+
+      context 'neither config_path nor config_dir_path' do
+        let(:options) do
+          {
+            env_name: env_name
+          }
+        end
+
+        it 'will raise an error' do
+          expect { described_class.new(options)}.to raise_error(KumoKeisei::EnvironmentConfig::ConfigurationError)
+        end
+      end
+  end
+
   context 'unit tests' do
     let(:fake_environment_binding) { binding }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kumo_keisei
 version: !ruby/object:Gem::Version
-  version: 3.0.4.pre.alpha1
+  version: 3.0.4.pre.alpha2
 platform: ruby
 authors:
 - Redbubble