kudu_adapter 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a16fccf807f95dbd8a16bf90c03314fda9564a6d
-  data.tar.gz: 3f10e1d226527b8550e4950c03632d9d9a2060cb
+SHA256:
+  metadata.gz: 6acdd82cf235759fbc882d260802e0b7cbf8b5cdb3b7896512b273bd4fb58d71
+  data.tar.gz: 1f60bcf02fef433dc80643caebaa9707ed4da6c8c77524706baeb64ea2ae333a
 SHA512:
-  metadata.gz: 05f9b3a9ac337b3b93bf6ad3f2df444bacf8982ca67fcc61d9c071783732a8a6e2e89d74d3944a7cb1fd18a3768ad830734ece62dcdfbe191deb677450943869
-  data.tar.gz: ce8a364831494992b183ba50af1b2cb922ca154c44b657b688bd69a62e7417c1c57a6e10d5bbb0368c89b47739901069d37d4cced164cfc80281f3caa5bea24c
+  metadata.gz: 72c9c188026556de099d4ab25cf48473070983b888ea9e8e3921e573a47fc1cce09799c74137d75f82ea05e9e1df4fd64f5411c2b535506aee8ac83693d57b88
+  data.tar.gz: 2af2c26170a6b017db20660a911ed0a3b1e428f7d182c9f529e5b6fd86171a125b0801f73c8537da91d16977d37d9b091a7969cc2f23a33c90aff809d029f9bb

data/.rubocop.yml

@@ -5,4 +5,4 @@ AllCops:
 
 Metrics/LineLength:
   Enabled: true
-  Max: 120
+  Max: 120

data/lib/active_record/connection_adapters/kudu/database_statements.rb

@@ -10,14 +10,14 @@ module ActiveRecord
         # :nodoc:
         def exec_query(sql, _ = 'SQL', binds = [], prepare: false)
           ::Rails.logger.warn 'Prepared statements are not supported' if prepare
-
+          # Important because of replacing ? marks and if we have replaced string with ? inside...
+          sql = sql.gsub('?', '@@?')
           unless without_prepared_statement? binds
             type_casted_binds(binds).each do |bind|
-              bind = quote(bind)
-              sql = sql.sub('?', bind.to_s)
+              sql = sql.sub('@@?', quote(bind).to_s)
             end
           end
-          #::Rails.logger.info 'QUERY : ' + sql.to_s
+          ::Rails.logger.info 'QUERY : ' + sql.to_s
           result = connection.query sql
           columns = result.first&.keys.to_a
           rows = result.map { |row| row.fetch_values(*columns) }

data/lib/active_record/connection_adapters/kudu/quoting.rb

@@ -18,6 +18,11 @@ module ActiveRecord
           quote_column_name table_name
         end
 
+        def quote_string(s)
+          # This will make proper single quote in text
+          s.gsub('\\', '\&\&').gsub("'", "\\\\\\\\'")
+        end
+
         def quote_default_expression(value, column) # :nodoc:
           if value.is_a?(Proc)
             value.call

data/lib/active_record/connection_adapters/kudu/schema_statements.rb

@@ -72,7 +72,7 @@ module ActiveRecord
           table_structure(table_name).map do |col_def|
             type = if col_def[:type] == 'int'
                      :integer
-                   elsif col_def[:type] == 'bigint' && /_at$/ =~ col_def[:name]
+                   elsif col_def[:type] == 'bigint' && /(_at|_date|_time)$/ =~ col_def[:name]
                      :datetime
                    else
                      col_def[:type].to_sym
@@ -372,8 +372,8 @@ module ActiveRecord
 
         def add_timestamps(table_name, options = {})
           options[:null] = false if options[:null].nil?
-          add_column table_name, :created_at, :bigint, options
-          add_column table_name, :updated_at, :bigint, options
+          add_column table_name, :created_at, :datetime, options
+          add_column table_name, :updated_at, :datetime, options
         end
 
         def remove_timestamps(table_name, options = {})

data/lib/active_record/connection_adapters/kudu_adapter.rb

@@ -92,7 +92,7 @@ module ActiveRecord
       end
 
       def disconnect!
-        @connection.close
+        @connection.close if @connection.open?
         @connection = nil
       end
 

data/lib/kudu_adapter/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KuduAdapter
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kudu_adapter
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Paweł Smoliński
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-14 00:00:00.000000000 Z
+date: 2018-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: arel
@@ -196,7 +196,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: ActiveRecord adapter for Cloudera's Kudu over Impala database