kucoin_ruby 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7093c1d401923d5deeb7111db6667a17477cd6d5
-  data.tar.gz: d800824977fbe1a591cc3b2cfb482c05ecfe0932
+  metadata.gz: 0aa51631734d147b3f984554ada24a022a8335e0
+  data.tar.gz: 8c2879a026e145796e9a87a11bcafd349c163900
 SHA512:
-  metadata.gz: c2d9b1e2c16be588a59cae9535d56b3cfd4797f72bca4f6f4e8f05d43eb40e3481d0b6090d7d6cb42f724853a19cd74c892c099ec0323bc876e1060f0c8df4bd
-  data.tar.gz: 950f3bf435e53e8ca7960ac9d97c52272ddda5de9b773742627cfd1fdd13d642f646e7ce219dead23e08408aa02620a482b7edf3ac9b12d4d553f816d8c07ccb
+  metadata.gz: 4d032f9ecf36485febf7f2218d0ecb38ff92b04ec625b2556023fb3d8b13c1187c2b488398ebfe47ea9fbc0a17f59c2a87c48fdabbb3797984c03f932fa76e2f
+  data.tar.gz: 18e992c7e9069af0ea63e6961a6fd98d985cf1235507c030bfcf721351c7566a4282d9e5a2e229164f30954602a09a63217ef24a634b062ff35fbc4e8a8e6426

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.1.4
+
+### Changed
+
+- Fix error with to_param ruby compatibility
+- Add Exceptions
+- Handel Kucoin API response
+
 ## 0.1.3
 
 ### Changed

data/Gemfile.lock

@@ -1,17 +1,26 @@
 PATH
   remote: .
   specs:
-    kucoin_ruby (0.1.3)
+    kucoin_ruby (0.1.4)
+      addressable
       httparty
 
 GEM
   remote: https://rubygems.org/
   specs:
+    addressable (2.5.2)
+      public_suffix (>= 2.0.2, < 4.0)
+    coderay (1.1.2)
     diff-lcs (1.3)
     httparty (0.15.6)
       multi_xml (>= 0.5.2)
+    method_source (0.9.0)
     multi_xml (0.6.0)
     openssl (2.0.6)
+    pry (0.11.3)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
+    public_suffix (3.0.1)
     rake (10.5.0)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
@@ -34,6 +43,7 @@ DEPENDENCIES
   bundler (~> 1.16)
   kucoin_ruby!
   openssl
+  pry
   rake (~> 10.0)
   rspec
 

data/kucoin_ruby.gemspec

@@ -25,6 +25,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "openssl"
+  spec.add_development_dependency "pry"
 
   spec.add_dependency "httparty"
+  spec.add_dependency "addressable"
 end

data/lib/kucoin_ruby/exceptions/base.rb

@@ -0,0 +1,6 @@
+module KucoinRuby
+  module Exceptions
+    class Base < StandardError
+    end
+  end
+end

data/lib/kucoin_ruby/exceptions/response_error.rb

@@ -0,0 +1,30 @@
+module KucoinRuby
+  module Exceptions
+    class ResponseError < Base
+      attr_reader :response
+
+      def initialize(response)
+        @response = response
+      end
+
+      def to_s
+        super +
+          format(' (%s)', data.map { |k, v| %(#{k}: "#{v}") }.join(', '))
+      end
+
+      def error_code
+        data[:error_code] || data['error_code']
+      end
+
+      private
+
+      def data
+        @data ||= begin
+          JSON.parse(response.body)
+        rescue JSON::ParserError
+          { error_code: response.status, uri: response.env.url.to_s }
+        end
+      end
+    end
+  end
+end

data/lib/kucoin_ruby/net.rb

@@ -5,11 +5,11 @@ module KucoinRuby
     API_HOST   = 'https://api.kucoin.com'
 
     def self.key
-      ENV['KUCOIN_KEY']
+      ENV['KUCOIN_KEY'] || 'fake_key'
     end
 
     def self.secret
-      ENV['KUCOIN_SECRET']
+      ENV['KUCOIN_SECRET'] || 'fake_secret'
     end
 
     def self.headers(nonce, signature)
@@ -24,26 +24,35 @@ module KucoinRuby
 
     def self.get(endpoint)
       uri = "#{API_HOST}#{endpoint}"
-      HTTParty.get(uri)
+      handle_response(HTTParty.get(uri))
     end
 
     def self.signed_get(endpoint, query_string = nil)
       nonce, signature = KucoinRuby::Util.sign_message(endpoint, query_string)
       uri = "#{API_HOST}#{endpoint}?#{query_string}"
-      HTTParty.get(
+      response = HTTParty.get(
         uri,
         headers: headers(nonce, signature)
       )
+      handle_response(response)
     end
 
     def self.signed_post(endpoint, payload = nil)
       nonce, signature = KucoinRuby::Util.sign_message(endpoint)
       uri = "#{API_HOST}#{endpoint}"
-      HTTParty.post(
+      response = HTTParty.post(
         uri,
         headers: headers(nonce, signature),
         body: payload
       )
+      handle_response(response)
+    end
+
+    def self.handle_response(response)
+      if response.code != 200
+        raise KucoinRuby::Exceptions::ResponseError.new(response)
+      end
+      JSON.parse(response.body)
     end
   end
 end

data/lib/kucoin_ruby/util.rb

@@ -4,8 +4,8 @@ module KucoinRuby
       (Time.now.to_f * 1000).to_i.to_s
     end
 
-    def self.build_message(endpoint, nonce, queryString = '')
-      "#{endpoint}/#{nonce}/#{queryString.to_param}"
+    def self.build_message(endpoint, nonce, query_string = '')
+      "#{endpoint}/#{nonce}/#{query_string}"
     end
 
     def self.sign(string)
@@ -13,15 +13,23 @@ module KucoinRuby
       sign_hmac(base)
     end
 
-    def self.sign_message(endpoint, queryString = '')
+    def self.sign_message(endpoint, query_string = nil)
       nc = nonce
-      [nc, sign(build_message(endpoint, nc, queryString.to_param))]
+      query_string = compose_query_string(query_string)
+      [nc, sign(build_message(endpoint, nc, query_string))]
     end
 
     private
 
     def self.sign_hmac(string)
-      OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new('sha256'), KucoinRuby::NetConfig.secret, string)
+      OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new('sha256'), KucoinRuby::Net.secret, string)
+    end
+
+    def self.compose_query_string(query_string)
+      return query_string unless query_string.is_a? Hash
+      uri = Addressable::URI.new
+      uri.query_values = query_string
+      uri.query
     end
   end
 end

data/lib/kucoin_ruby/version.rb

@@ -1,3 +1,3 @@
 module KucoinRuby
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/lib/kucoin_ruby.rb

@@ -9,8 +9,12 @@ require "kucoin_ruby/operations"
 require "kucoin_ruby/trading"
 require "kucoin_ruby/market"
 
+require "kucoin_ruby/exceptions/base"
+require "kucoin_ruby/exceptions/response_error"
+
 require "openssl"
 require "httparty"
+require "addressable/uri"
 
 module KucoinRuby
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kucoin_ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - lalo
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: KuCoin Ruby API Gem
 email:
 - abelardogilm@gmail.com
@@ -100,6 +128,8 @@ files:
 - kucoin_ruby.gemspec
 - lib/kucoin_ruby.rb
 - lib/kucoin_ruby/currency.rb
+- lib/kucoin_ruby/exceptions/base.rb
+- lib/kucoin_ruby/exceptions/response_error.rb
 - lib/kucoin_ruby/inviting.rb
 - lib/kucoin_ruby/language.rb
 - lib/kucoin_ruby/market.rb