kubernetes-deploy 0.31.1 → 1.0.0.pre.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5ea371b75bdbb77ee7c54096800b71ee671e7103ef91d845200b0964bcb10ce
-  data.tar.gz: 4b5c4a6ce792a15bdb18f748d99f9a06b7cf6b323d3692c22a6498ff0601117b
+  metadata.gz: adeeeeb19772ea87237a9c1e3a9333ec3621227ef6fbb8f0106996d4919e860c
+  data.tar.gz: 1959eeadd28a63461b1c044918ec0209d9fbfe4d5aadeb51183b97f3889507c7
 SHA512:
-  metadata.gz: 6882484623314efdac211e9af8d2f1752491ec215ff5181742cc9bb54e96f2b7d85f4e29d01477d1d0be25d90fd9cbdd47bbc3318660a6b8bca74af7e5b3c75e
-  data.tar.gz: 7636c573ee277a64202e1705ecabf14098b457499fa3ddca6cf64ad590ec82d93d1f7ccf874ea638f32039dfd5073b1809251602faec87d7ab805ef856f112d3
+  metadata.gz: 1a82ba6d6de049f378811a2c9aab6e2ffad869ee1c44f2e417a38bb310471cd404880fddf20a4e9eef40de45173a24640c2a18ec5ff8e08d15a5e8141f4be8ee
+  data.tar.gz: 5e79e0ac53ee91514d8d514f84688322dcc6d4b661c9f80380e87a35f2317838ed60fbc9b91c56d66566adb8b9a31239fb6ce10fb8896ed1f2f62a9daf9df385

data/.buildkite/pipeline.nightly.yml

@@ -1,4 +1,11 @@
 steps:
+  - name: 'Run Test Suite (:kubernetes: 1.16-latest)'
+    command: bin/ci
+    agents:
+      queue: k8s-ci
+    env:
+      LOGGING_LEVEL: 4
+      KUBERNETES_VERSION: v1.16-latest
   - name: 'Run Test Suite (:kubernetes: 1.15-latest)'
     command: bin/ci
     agents:

data/.shopify-build/kubernetes-deploy.yml

@@ -9,6 +9,13 @@ steps:
       - bundle exec rubocop
     dependencies:
       - bundler
+  - label: 'Run Test Suite (:kubernetes: 1.16-latest)'
+    command: bin/ci
+    agents:
+      queue: k8s-ci
+    env:
+      LOGGING_LEVEL: "4"
+      KUBERNETES_VERSION: v1.16-latest
   - label: 'Run Test Suite (:kubernetes: 1.15-latest)'
     command: bin/ci
     agents:

data/1.0-Upgrade.md

@@ -0,0 +1,109 @@
+# kubernetes-deploy 0.31.1 -> krane 1.0.0 migration guide
+
+**THIS MIGRATION GUIDE IS A WORK IN PROGRESS. THINGS CAN STILL CHANGE BEFORE 1.0.0**
+
+`kubernetes-deploy` was renamed `krane` when version 1.0.0 was released. Version 1.0.0 introduced [new features and breaking changes](CHANGELOG.md). This guide will help you transition to version 1.0.0 as smoothly as possible.
+
+**TL;DR**:
+* The command-line interface was redesigned; alongside the name change there are breaking changes in several flags.
+* There are breaking changes in the public API (such as the renaming of the `KubernetesDeploy` namespace to `Krane`, and the change in default values for different arguments of the public interface).
+* StatsD metrics will now be generated with the `krane` prefix.
+* `krane deploy` now considers all namespaced resources eligible for pruning, including
+custom resources. See [blacklist](https://github.com/Shopify/kubernetes-deploy/blob/master/lib/krane/cluster_resource_discovery.rb#L20) for exceptions.
+* `kubernetes-deploy` (now `krane deploy`) / `DeployTask` can no longer deploy global (non-namespaced) resources. A new command called `krane global-deploy` and a related class called `GlobalDeployTask` were added to replace that feature.
+* If you attempt to install two gems that have conflicting executables, `gem install` will warn you but the most recently installed one will win.
+
+## Public API changes
+
+The only breaking change in the public API (so far) is the renaming of the `KubernetesDeploy` namespace to `Krane`. Otherwise, the APIs of the major public classes (`DeployTask`, `RenderTask`, `RunnerTask`, and `RestartTask`) have not changed between 0.31.1 and 1.0.0. If you're curious about this API, check the comment-based docs on these classes or the [rendered documentation at RubyGems.org](https://www.rubydoc.info/gems/kubernetes-deploy/1.0.0/KubernetesDeploy/DeployTask).
+
+## Command-line interface changes
+
+Old command | New command
+--- | ---
+`kubernetes-deploy` | `krane deploy`
+`kubernetes-deploy -v` | `krane version`
+`kubernetes-render` | `krane render`
+`kubernetes-run` | `krane run`
+`kubernetes-restart` | `krane restart`
+`[kubernetes-deploy with global resources in templates]` | `krane global-deploy`
+
+### Flag changes
+
+The following tables provide a mapping of the flags previously supported in `kubernetes-deploy` and their new version in `krane` (if applicable).
+
+Important: you can't repeat flags. If you need to provide multiple arguments for a flag, use a space-separated list (e.g. `-f file1.yml file2.yml`) unless specified otherwise.
+
+#### krane deploy
+
+Old flag | New flag | Comments
+--- | --- | ---
+--bindings=BINDINGS | --bindings=BINDINGS |
+--skip-wait | --verify-result=true |
+--allow-protected-ns | --protected-namespaces=default,kube-system,kube-public | Added the ability to specify which namespaces are protected
+--no-prune | --prune=true |
+--template-dir | -f, --filename | Makes all krane commands accept this argument, which is now required for the deploy task
+--verbose-log-prefix | --verbose-log-prefix |
+--max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value to be a duration (expressed using strings like "300s" or "1h")
+--selector | --selector |
+-h, --help | -h, --help |
+-v, --version | [none] | Replaced with `krane version`
+$ENVIRONMENT | [none] | Dropped in favour of `-f`
+$REVISION | --current-sha | The environment variable REVISION was dropped in favour of an explicit flag
+[none] | --render-erb | **Important:** the new CLI doesn't render ERB by default
+[none] | --stdin | Allow template filenames given from stdin stream
+
+#### krane restart
+
+Old flag | New flag | Comments
+--- | --- | ---
+--deployments=LIST | --deployments=LIST |
+--max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value to be a duration (expressed using strings like "300s" or "1h")
+[none] | --verify-result=true | Defines whether it should wait for results or exit immediately after validation
+
+#### krane run
+
+Old flag | New flag | Comments
+--- | --- | ---
+--skip-wait | --verify-result=true |
+--max-watch-seconds=seconds | --global-timeout=300s | Changed flag name and default value to be a duration (expressed using strings like "300s" or "1h")
+--entrypoint | --command | Changed flag name to make its purpose clearer
+--template | --template | Changed to be required
+[it is positional now] | --arguments | Optional flag, as `command` or the template might already specify the required arguments
+--env-vars=ENV_VARS | --env-vars=ENV_VARS |
+
+#### krane render
+
+Old flag | New flag | Comments
+--- | --- | ---
+--bindings=BINDINGS | --bindings=BINDINGS |
+--template-dir | -f, --filename | Changed to be more aligned with `kubectl apply` and other krane tasks
+$REVISION | --current-sha | The environment variable REVISION was dropped in favour of an explicit flag
+[none] | --stdin | Allow template filenames given from stdin stream
+
+## Running `kubernetes-deploy` and `krane` side by side
+
+If you attempt to install two gems that have conflicting executables (as is the case here), `gem install` will warn you but the most recently installed one will win. This means that you can run both `kubernetes-deploy` 0.31.1 and `krane` 1.0.0 side by side by doing:
+
+```bash
+gem install kubernetes-deploy -v 0.31.1
+gem install -f krane -v 1.0.0
+```
+
+This can help you incrementally port scripts that use the old CLI to the new one.
+
+## New task: `krane global-deploy`
+
+`krane global-deploy` (accessible through the Ruby API as `Krane::GlobalDeployTask`) can deploy global (non-namespaced) resources such as `PersistentVolume`, `Namespace`, and `CustomResourceDefinition`. Its interface is very similar to `krane deploy`. Example usage:
+
+```bash
+$ cat my-template.yml
+    apiVersion: storage.k8s.io/v1
+    kind: StorageClass
+    metadata:
+      name: testing-storage-class
+      labels:
+        app: krane
+    provisioner: kubernetes.io/no-provisioner
+$ krane global-deploy my-k8s-context -f my-template.yml --selector app=krane
+```

data/CHANGELOG.md

@@ -3,6 +3,22 @@
 *Important!*
 - The next release will be 1.0.0, which means that master will contain breaking changes.
 
+## 1.0.0.pre.1
+
+*Important!*
+
+- This is the final release of KubernetesDeploy. Version 1.0.0 will be released
+under the name `Krane`. We've added a migration guide to help make it easier to migrate.
+([#607](https://github.com/Shopify/kubernetes-deploy/pull/607))
+
+*Enhancements*
+- (beta) `krane deploy` will now consider all namespaced resources eligible for pruning
+and does not respect the `krane.shopify.io/prunable` annotation. This adds 5 additional
+types: Endpoints, Event, LimitRange, ReplicationController, and Lease.
+ ([#616](https://github.com/Shopify/kubernetes-deploy/pull/616)
+
+- (beta) Added the `--stdin` flag to `krane deploy|global-deploy|render` to read resources from stdin. ([#630](https://github.com/Shopify/kubernetes-deploy/pull/630))
+
 ## 0.31.1
 
 *Bug Fixes*

data/README.md

@@ -524,7 +524,7 @@ The following command will restart all pods in the `web` and `jobs` deployments:
 Add the annotation `shipit.shopify.io/restart` to all the deployments you want to target, like this:
 
 ```yaml
-apiVersion: apps/v1beta1
+apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: web

data/lib/krane/cli/deploy_command.rb

@@ -14,8 +14,10 @@ module Krane
                         desc: "Expose additional variables to ERB templates (format: k1=v1 k2=v2, JSON string or file "\
                           "(JSON or YAML) path prefixed by '@')" },
         "filenames" => { type: :array, banner: 'config/deploy/production config/deploy/my-extra-resource.yml',
-                         aliases: :f, required: true,
+                         aliases: :f, required: false, default: [],
                          desc: "Directories and files that contains the configuration to apply" },
+        "stdin" => { type: :boolean, default: false,
+                     desc: "Read resources from stdin" },
         "global-timeout" => { type: :string, banner: "duration", default: DEFAULT_DEPLOY_TIMEOUT,
                               desc: "Max duration to monitor workloads correctly deployed" },
         "protected-namespaces" => { type: :array, banner: "namespace1 namespace2 namespaceN",
@@ -54,7 +56,14 @@ module Krane
           protected_namespaces = []
         end
 
-        ::Krane::OptionsHelper.with_processed_template_paths(options[:filenames],
+        # never mutate options directly
+        filenames = options[:filenames].dup
+        filenames << "-" if options[:stdin]
+        if filenames.empty?
+          raise Thor::RequiredArgumentMissingError, 'At least one of --filenames or --stdin must be set'
+        end
+
+        ::Krane::OptionsHelper.with_processed_template_paths(filenames,
           require_explicit_path: true) do |paths|
           deploy = ::Krane::DeployTask.new(
             namespace: namespace,

data/lib/krane/cli/global_deploy_command.rb

@@ -6,8 +6,9 @@ module Krane
       DEFAULT_DEPLOY_TIMEOUT = '300s'
       OPTIONS = {
         "filenames" => { type: :array, banner: 'config/deploy/production config/deploy/my-extra-resource.yml',
-                         aliases: :f, required: true,
+                         aliases: :f, required: false, default: [],
                          desc: "Directories and files that contains the configuration to apply" },
+        "stdin" => { type: :boolean, default: false, desc: "Read resources from stdin" },
         "global-timeout" => { type: :string, banner: "duration", default: DEFAULT_DEPLOY_TIMEOUT,
                               desc: "Max duration to monitor workloads correctly deployed" },
         "verify-result" => { type: :boolean, default: true,
@@ -27,7 +28,14 @@ module Krane
 
         selector = ::Krane::LabelSelector.parse(options[:selector])
 
-        ::Krane::OptionsHelper.with_processed_template_paths(options[:filenames],
+        # never mutate options directly
+        filenames = options[:filenames].dup
+        filenames << "-" if options[:stdin]
+        if filenames.empty?
+          raise Thor::RequiredArgumentMissingError, 'At least one of --filenames or --stdin must be set'
+        end
+
+        ::Krane::OptionsHelper.with_processed_template_paths(filenames,
           require_explicit_path: true) do |paths|
           deploy = ::Krane::GlobalDeployTask.new(
             context: context,

data/lib/krane/cli/render_command.rb

@@ -4,10 +4,11 @@ module Krane
   module CLI
     class RenderCommand
       OPTIONS = {
-        bindings: { type: :array, banner: "foo=bar abc=def", desc: 'Bindings for erb' },
-        filenames: { type: :array, banner: 'config/deploy/production config/deploy/my-extra-resource.yml',
-                     required: true, aliases: 'f', desc: 'Directories and files to render' },
-        'current-sha': { type: :string, banner: "SHA", desc: "Expose SHA `current_sha` in ERB bindings" },
+        "bindings" => { type: :array, banner: "foo=bar abc=def", desc: 'Bindings for erb' },
+        "filenames" => { type: :array, banner: 'config/deploy/production config/deploy/my-extra-resource.yml',
+                         required: false, default: [], aliases: 'f', desc: 'Directories and files to render' },
+        "stdin" => { type: :boolean, desc: "Read resources from stdin", default: false },
+        "current-sha" => { type: :string, banner: "SHA", desc: "Expose SHA `current_sha` in ERB bindings" },
       }
 
       def self.from_options(options)
@@ -18,7 +19,14 @@ module Krane
         bindings_parser = ::Krane::BindingsParser.new
         options[:bindings]&.each { |b| bindings_parser.add(b) }
 
-        ::Krane::OptionsHelper.with_processed_template_paths(options[:filenames]) do |paths|
+        # never mutate options directly
+        filenames = options[:filenames].dup
+        filenames << "-" if options[:stdin]
+        if filenames.empty?
+          raise Thor::RequiredArgumentMissingError, 'At least one of --filenames or --stdin must be set'
+        end
+
+        ::Krane::OptionsHelper.with_processed_template_paths(filenames) do |paths|
           runner = ::Krane::RenderTask.new(
             current_sha: options['current-sha'],
             template_paths: paths,

data/lib/krane/cluster_resource_discovery.rb

@@ -16,41 +16,19 @@ module Krane
       end
     end
 
-    def global_resource_kinds
-      @globals ||= fetch_resources(namespaced: false).map { |g| g["kind"] }
-    end
-
     def prunable_resources(namespaced:)
-      black_list = %w(Namespace Node)
+      black_list = %w(Namespace Node ControllerRevision)
       api_versions = fetch_api_versions
 
       fetch_resources(namespaced: namespaced).map do |resource|
         next unless resource['verbs'].one? { |v| v == "delete" }
         next if black_list.include?(resource['kind'])
-        version = api_versions[resource['apigroup'].to_s].last
+        group_versions = api_versions[resource['apigroup'].to_s]
+        version = version_for_kind(group_versions, resource['kind'])
         [resource['apigroup'], version, resource['kind']].compact.join("/")
       end.compact
     end
 
-    private
-
-    # kubectl api-versions returns a list of group/version strings e.g. autoscaling/v2beta2
-    # A kind may not exist in all versions of the group.
-    def fetch_api_versions
-      raw, _, st = kubectl.run("api-versions", attempts: 5, use_namespace: false)
-      # The "core" group is represented by an empty string
-      versions = { "" => %w(v1) }
-      if st.success?
-        rows = raw.split("\n")
-        rows.each do |group_version|
-          group, version = group_version.split("/")
-          versions[group] ||= []
-          versions[group] << version
-        end
-      end
-      versions
-    end
-
     # kubectl api-resources -o wide returns 5 columns
     # NAME SHORTNAMES APIGROUP NAMESPACED KIND VERBS
     # SHORTNAMES and APIGROUP may be blank
@@ -85,6 +63,39 @@ module Krane
       end
     end
 
+    private
+
+    # kubectl api-versions returns a list of group/version strings e.g. autoscaling/v2beta2
+    # A kind may not exist in all versions of the group.
+    def fetch_api_versions
+      raw, _, st = kubectl.run("api-versions", attempts: 5, use_namespace: false)
+      # The "core" group is represented by an empty string
+      versions = { "" => %w(v1) }
+      if st.success?
+        rows = raw.split("\n")
+        rows.each do |group_version|
+          group, version = group_version.split("/")
+          versions[group] ||= []
+          versions[group] << version
+        end
+      end
+      versions
+    end
+
+    def version_for_kind(versions, kind)
+      # Override list for kinds that don't appear in the lastest version of a group
+      version_override = { "CronJob" => "v1beta1", "VolumeAttachment" => "v1beta1",
+                           "CSIDriver" => "v1beta1", "Ingress" => "v1beta1", "CSINode" => "v1beta1" }
+
+      pattern = /v(?<major>\d+)(?<pre>alpha|beta)?(?<minor>\d+)?/
+      latest = versions.sort_by do |version|
+        match = version.match(pattern)
+        pre = { "alpha" => 0, "beta" => 1, nil => 2 }.fetch(match[:pre])
+        [match[:major].to_i, pre, match[:minor].to_i]
+      end.last
+      version_override.fetch(kind, latest)
+    end
+
     def fetch_crds
       raw_json, _, st = kubectl.run("get", "CustomResourceDefinition", output: "json", attempts: 5,
         use_namespace: false)

data/lib/krane/deploy_task.rb

@@ -8,5 +8,9 @@ module Krane
       raise "Use Krane::DeployGlobalTask to deploy global resources" if args[:allow_globals]
       super(args.merge(allow_globals: false))
     end
+
+    def prune_whitelist
+      cluster_resource_discoverer.prunable_resources(namespaced: true)
+    end
   end
 end

data/lib/krane/kubeclient_builder.rb

@@ -55,9 +55,9 @@ module Krane
       )
     end
 
-    def build_apps_v1beta1_kubeclient(context)
+    def build_apps_v1_kubeclient(context)
       build_kubeclient(
-        api_version: "v1beta1",
+        api_version: "v1",
         context: context,
         endpoint_path: "/apis/apps"
       )

data/lib/krane/kubernetes_resource.rb

@@ -388,7 +388,12 @@ module Krane
         .lastTimestamp
         .reason
         .message
+        .eventTime
+        .deprecatedCount
+        .deprecatedLastTimestamp
+        .series
       )
+      FIELD_EMPTY_VALUE = '<no value>'
 
       def self.go_template_for(kind, name)
         and_conditions = [
@@ -409,17 +414,61 @@ module Krane
       def self.extract_all_from_go_template_blob(blob)
         blob.split(EVENT_SEPARATOR).map do |event_blob|
           pieces = event_blob.split(FIELD_SEPARATOR, FIELDS.length)
+          count = extract_event_count(pieces)
+          timestamp = extract_event_timestamp(pieces)
+
           new(
             subject_kind: pieces[FIELDS.index(".involvedObject.kind")],
             subject_name: pieces[FIELDS.index(".involvedObject.name")],
-            count: pieces[FIELDS.index(".count")],
-            last_timestamp: pieces[FIELDS.index(".lastTimestamp")],
+            count: count,
+            last_timestamp: timestamp,
             reason: pieces[FIELDS.index(".reason")],
             message: pieces[FIELDS.index(".message")]
           )
         end
       end
 
+      def self.extract_event_count(pieces)
+        series = pieces[FIELDS.index(".series")]
+        count = pieces[FIELDS.index(".count")]
+        deprecated_count = pieces[FIELDS.index(".deprecatedCount")]
+
+        # Find the right event count according to Kubernetes API and kubectl version
+        if count.present? && count != FIELD_EMPTY_VALUE
+          count # This is the default field, so let's try to use it first
+        elsif series.present? && series != FIELD_EMPTY_VALUE
+          # kubectl 1.16 uses Events/v1, which has the .series/.count field
+          count_regex = /count:(?<value>\S+?(?=\s))/
+          count_regex.match(series)['value']
+        elsif deprecated_count.present? && deprecated_count != FIELD_EMPTY_VALUE
+          # kubectl < 1.16 uses events.k8s.io/v1beta1, which has .deprecatedCount
+          deprecated_count
+        else
+          "1" # Fallback to 1 when all count fields are null
+        end
+      end
+
+      def self.extract_event_timestamp(pieces)
+        series = pieces[FIELDS.index(".series")]
+        last_timestamp = pieces[FIELDS.index(".lastTimestamp")]
+        deprecated_timestamp = pieces[FIELDS.index(".deprecatedLastTimestamp")]
+
+        # Find the right event timestamp according to Kubernetes API and kubectl version
+        if last_timestamp.present? && last_timestamp != FIELD_EMPTY_VALUE
+          last_timestamp # kubernetes 1.16 also exposes .last_timestamp field, so let's support it
+        elsif series.present? && series != FIELD_EMPTY_VALUE
+          # kubectl 1.16 uses Events/v1, which has the .series/.lastObservedTime field
+          timestamp_regex = /lastObservedTime:(?<value>\S+?(?=\]))/
+          timestamp_regex.match(series)['value']
+        elsif deprecated_timestamp.present? && deprecated_timestamp != FIELD_EMPTY_VALUE
+          # kubectl < 1.16 uses events.k8s.io/v1beta1, which has .deprecatedLastTimestamp
+          deprecated_timestamp
+        else
+          pieces[FIELDS.index(".eventTime")] # Fallback to eventTime when other timestamp fields are null
+        end
+      end
+      private_class_method :extract_event_timestamp, :extract_event_count
+
       def initialize(subject_kind:, last_timestamp:, reason:, message:, count:, subject_name:)
         @subject_kind = subject_kind
         @subject_name = subject_name

data/lib/krane/kubernetes_resource/daemon_set.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-require 'krane/kubernetes_resource/pod_set_base'
+require "krane/kubernetes_resource/pod_set_base"
 module Krane
   class DaemonSet < PodSetBase
     TIMEOUT = 5.minutes
@@ -78,9 +78,13 @@ module Krane
 
     def parent_of_pod?(pod_data)
       return false unless pod_data.dig("metadata", "ownerReferences")
+
+      template_generation = @instance_data.dig("spec", "templateGeneration") ||
+        @instance_data.dig("metadata", "annotations", "deprecated.daemonset.template.generation")
+      return false unless template_generation.present?
+
       pod_data["metadata"]["ownerReferences"].any? { |ref| ref["uid"] == @instance_data["metadata"]["uid"] } &&
-      pod_data["metadata"]["labels"]["pod-template-generation"].to_i ==
-        @instance_data["spec"]["templateGeneration"].to_i
+      pod_data["metadata"]["labels"]["pod-template-generation"].to_i == template_generation.to_i
     end
   end
 end

data/lib/krane/restart_task.rb

@@ -97,13 +97,13 @@ module Krane
       if deployment_names.nil?
         deployments = if selector.nil?
           @logger.info("Configured to restart all deployments with the `#{ANNOTATION}` annotation")
-          v1beta1_kubeclient.get_deployments(namespace: @namespace)
+          apps_v1_kubeclient.get_deployments(namespace: @namespace)
         else
           selector_string = selector.to_s
           @logger.info(
             "Configured to restart all deployments with the `#{ANNOTATION}` annotation and #{selector_string} selector"
           )
-          v1beta1_kubeclient.get_deployments(namespace: @namespace, label_selector: selector_string)
+          apps_v1_kubeclient.get_deployments(namespace: @namespace, label_selector: selector_string)
         end
         deployments.select! { |d| d.metadata.annotations[ANNOTATION] }
 
@@ -137,7 +137,7 @@ module Krane
     end
 
     def patch_deployment_with_restart(record)
-      v1beta1_kubeclient.patch_deployment(
+      apps_v1_kubeclient.patch_deployment(
         record.metadata.name,
         build_patch_payload(record),
         @namespace
@@ -159,7 +159,7 @@ module Krane
       list.map do |name|
         record = nil
         begin
-          record = v1beta1_kubeclient.get_deployment(name, @namespace)
+          record = apps_v1_kubeclient.get_deployment(name, @namespace)
         rescue Kubeclient::ResourceNotFoundError
           raise FatalRestartError, "Deployment `#{name}` not found in namespace `#{@namespace}`"
         end
@@ -205,6 +205,10 @@ module Krane
       end
     end
 
+    def apps_v1_kubeclient
+      @apps_v1_kubeclient ||= kubeclient_builder.build_apps_v1_kubeclient(@context)
+    end
+
     def kubeclient
       @kubeclient ||= kubeclient_builder.build_v1_kubeclient(@context)
     end

data/lib/krane/task_config.rb

@@ -15,7 +15,7 @@ module Krane
     def global_kinds
       @global_kinds ||= begin
         cluster_resource_discoverer = ClusterResourceDiscovery.new(task_config: self)
-        cluster_resource_discoverer.global_resource_kinds
+        cluster_resource_discoverer.fetch_resources(namespaced: false).map { |g| g["kind"] }
       end
     end
   end

data/lib/krane/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Krane
-  VERSION = "0.31.1"
+  VERSION = "1.0.0.pre.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kubernetes-deploy
 version: !ruby/object:Gem::Version
-  version: 0.31.1
+  version: 1.0.0.pre.1
 platform: ruby
 authors:
 - Katrina Verey
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-13 00:00:00.000000000 Z
+date: 2019-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -259,6 +259,7 @@ files:
 - ".rubocop.yml"
 - ".shopify-build/VERSION"
 - ".shopify-build/kubernetes-deploy.yml"
+- 1.0-Upgrade.md
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
@@ -377,9 +378,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: