kubeclient 3.1.1 → 3.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7a3f5bd1265e7901b0107badc19f6519919674d
-  data.tar.gz: 89a0f99ce7194c998a3a0f18888fcc0496adf2b8
+  metadata.gz: c9d152d80d40134d2ae7eecd9a319cde84983452
+  data.tar.gz: 29d56b44b8e7cae1cd12a8161063de21398094dd
 SHA512:
-  metadata.gz: 0ea1aec07c2dd2e121b9648fb1e18a3c23993af2bf9efd460992ec8a983c5d1ee38102c1b013a20e09c766d1f7e1474561494bd77e28be190f3a85ec23ec5fd6
-  data.tar.gz: b002550b4e4144802f20e21262f082ce228bc196e643e0f9c4446f1cbe49f0710584d5cdab865a544cc557b4e27a6661ce9350423075a34a700fbc01b18ebdb2
+  metadata.gz: 829939040059e56d8a023da659c2e60d646622e263a5273b79fa3793a6b3f93e3739abbe35c02df1da004bc958778741567829b15e0537f0c5c517f6d207c91b
+  data.tar.gz: 3ecc6f28154591bef665ce2699ecff835bf5b30384338c69dfc8c4b9234792b2f3563f8e9225e7fa76a5b3425135c5c51e16f150d5e37e94c767a3f851197650

data/CHANGELOG.md

@@ -4,10 +4,17 @@ Notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 Kubeclient release versioning follows [SemVer](https://semver.org/).
 
-## 3.1.1 - 2018-06-01
+## 3.1.2 — 2018-06-11
+
+### Fixed
+- Fixed `Kubeclient::Config.read` regression, no longer crashes on YAML timestamps (#338).
+
+## 3.1.1 - 2018-06-01 — REGRESSION
+
+In this version `Kubeclient::Config.read` raises Psych::DisallowedClass on legal yaml configs containing a timestamp, for example gcp access-token expiry (#337).
 
 ### Security
-- Fixed `Kubeclient::Config.read` to use `YAML.safe_load` (#334).
+- Changed `Kubeclient::Config.read` to use `YAML.safe_load` (#334).
 
   Previously, could deserialize arbitrary ruby classes.  The risk depends on ruby classes available in the application; sometimes a class may have side effects - up to arbitrary code execution - when instantiated and/or built up with `x[key] = value` during YAML parsing.
 

data/lib/kubeclient/config.rb

@@ -25,7 +25,8 @@ module Kubeclient
     end
 
     def self.read(filename)
-      Config.new(YAML.safe_load(File.read(filename)), File.dirname(filename))
+      parsed = YAML.safe_load(File.read(filename), [Date, Time])
+      Config.new(parsed, File.dirname(filename))
     end
 
     def contexts

data/lib/kubeclient/version.rb

@@ -1,4 +1,4 @@
 # Kubernetes REST-API Client
 module Kubeclient
-  VERSION = '3.1.1'.freeze
+  VERSION = '3.1.2'.freeze
 end

data/test/config/timestamps.kubeconfig

@@ -0,0 +1,25 @@
+apiVersion: v1
+users:
+- name: gke_username
+  user:
+    auth-provider:
+      config:
+        access-token: REDACTED
+        cmd-args: config config-helper --format=json
+        cmd-path: /Users/tannerbruce/opt/google-cloud-sdk/bin/gcloud
+        expiry: 2018-07-07T18:25:36Z
+        expiry-key: '{.credential.token_expiry}'
+        token-key: '{.credential.access_token}'
+      name: gcp
+
+# More syntaxes from go-yaml tests, hopefully covering all types possible in kubeconfig
+IPv4: 1.2.3.4
+Duration: 3s
+date_only: 2015-01-01
+rfc3339: 2015-02-24T18:19:39Z
+longer: 2015-02-24T18:19:39.123456789-03:00
+shorter: 2015-2-3T3:4:5Z
+iso_lower_t: 2015-02-24t18:19:39Z
+space_no_tz: 2015-02-24 18:19:39
+space_tz: 2001-12-14 21:59:43.10 -5
+timestamp_like_string: "2015-02-24T18:19:39Z"

data/test/test_config.rb

@@ -68,6 +68,11 @@ class KubeclientConfigTest < MiniTest::Test
     assert_equal('pAssw0rd123', context.auth_options[:password])
   end
 
+  def test_timestamps
+    # Test YAML parsing doesn't crash on YAML timestamp syntax.
+    Kubeclient::Config.read(config_file('timestamps.kubeconfig'))
+  end
+
   private
 
   def check_context(context, ssl: true)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kubeclient
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.1.2
 platform: ruby
 authors:
 - Alissa Bonas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-01 00:00:00.000000000 Z
+date: 2018-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -204,6 +204,7 @@ files:
 - test/config/external-key.rsa
 - test/config/external.kubeconfig
 - test/config/nouser.kubeconfig
+- test/config/timestamps.kubeconfig
 - test/config/userauth.kubeconfig
 - test/json/bindings_list.json
 - test/json/component_status.json
@@ -309,6 +310,7 @@ test_files:
 - test/config/external-key.rsa
 - test/config/external.kubeconfig
 - test/config/nouser.kubeconfig
+- test/config/timestamps.kubeconfig
 - test/config/userauth.kubeconfig
 - test/json/bindings_list.json
 - test/json/component_status.json