kronos-ruby 0.2.1.alpha.9 → 0.2.1.alpha.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e8c9e7b6c282c258f653df363494cafc1055c846
-  data.tar.gz: 185bd729886a57bc22bb0d80e9f7d06f892fb2f9
+  metadata.gz: 94065dd5befb97c9a910ef8beb81af2986b63f1b
+  data.tar.gz: bc29df98662ec85c9830b9db4e2e3cee12a5e8c3
 SHA512:
-  metadata.gz: 3d6bacf3bedb5e0d10f69daf22efdfd267c8ad79d27dd74ef02f030b0f41f972b4ae31d073bb9e374855bdb342b6243d51e0a64644ad7e2ee1b649db6a615e29
-  data.tar.gz: 147b6a29ee3aa307de7880003da6a34fbd807c909e830e62d1b7b1f01f1959307c72559bf690289d056ddf62f0ac5ddaabf9aba4d5635205d379e5b531447812
+  metadata.gz: 5f49278e16b63184f277d3c7636ae47c7d6c0fedb2a948a48c4509fd2addd881eb2a8082df0fa094209180b477aaf75e7d9218f3cc710fe0978d9a272b917422
+  data.tar.gz: aa21e234ea82b1c543c939afc1ca81a85f96e7fb80aef542b78414ef50185ffa23af99edfd710c7b17adac8f79fd2f1cbd013867030fc74d6f2d500ec4bf38a1

data/README.md

@@ -12,7 +12,7 @@ This project allows you to use a scheduler with well defined concepts of runners
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'kronos-ruby'
+gem 'kronos-ruby', require: ['kronos']
 ```
 
 And then execute:
@@ -47,6 +47,15 @@ To view Krono's web dashboard, simply mount it into your Rack stack:
 mount Kronos::Web::App, at: '/kronos-dashboard'
 ```
 
+If you want to protect Kronos dashboard, try using `Rack::Auth::Basic`:
+```ruby
+protected_kronos = Rack::Auth::Basic.new(Kronos::Web::App) do |username, password|
+  # Check if username/password tuple is valid
+end
+
+mount protected_kronos, at: '/kronos-dashboard'
+```
+
 ## Developing
 - Clone this repository
 - Run `bin/setup` to install dependencies

data/lib/kronos.rb

@@ -4,6 +4,7 @@ require 'concurrent'
 require 'chronic'
 require 'erb'
 require 'ostruct'
+require 'forwardable'
 
 require 'kronos/config_agent'
 require 'kronos/dependencies'

data/lib/kronos/runner/synchronous.rb

@@ -24,6 +24,7 @@ module Kronos
       def initialize(tasks, dependencies)
         @tasks = tasks
         @dependencies = dependencies
+        @lock_manager = LockManager.new(dependencies.storage)
       end
 
       def start
@@ -66,9 +67,10 @@ module Kronos
 
       # rubocop:disable RescueException
       def run_task(task)
-        raw_execute_task(task)
+        task_id = task.id
+        @lock_manager.lock_and_execute(task_id) { raw_execute_task(task) }
       rescue ::Exception => error
-        register_task_failure(task.id, error)
+        register_task_failure(task_id, error)
       end
       # rubocop:enable
 
@@ -109,3 +111,5 @@ module Kronos
     end
   end
 end
+
+require 'kronos/runner/synchronous/lock_manager'

data/lib/kronos/runner/synchronous/lock_manager.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module Kronos
+  module Runner
+    class Synchronous
+      class LockManager
+        extend Forwardable
+
+        def initialize(storage)
+          @storage = storage
+        end
+
+        def lock_and_execute(task_id)
+          return if locked_task?(task_id)
+          lock_id = lock_task(task_id)
+          return unless check_lock(task_id, lock_id)
+          yield
+        ensure
+          release_lock(task_id)
+        end
+
+        def_delegator :@storage, :locked_task?, :locked_task?
+        def_delegator :@storage, :lock_task,    :lock_task
+        def_delegator :@storage, :check_lock,   :check_lock
+        def_delegator :@storage, :release_lock, :release_lock
+      end
+    end
+  end
+end

data/lib/kronos/storage/in_memory.rb

@@ -9,6 +9,7 @@ module Kronos
       def initialize
         @scheduled_tasks = []
         @reports = []
+        @locks = {}
       end
 
       def schedule(scheduled_task)
@@ -48,6 +49,24 @@ module Kronos
       def remove_reports_for(id)
         @reports.reject! { |report| report.task_id == id }
       end
+
+      def locked_task?(task_id)
+        @locks.key?(task_id)
+      end
+
+      def lock_task(task_id)
+        SecureRandom.uuid.tap do |lock_id|
+          @locks[task_id] = lock_id
+        end
+      end
+
+      def check_lock(task_id, lock_id)
+        @locks[task_id] == lock_id
+      end
+
+      def release_lock(task_id)
+        @locks.delete(task_id)
+      end
     end
   end
 end

data/lib/kronos/storage/mongo/model/lock_model.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'mongoid'
+
+module Kronos
+  module Storage
+    module Mongo
+      module Model
+        class LockModel
+          include Mongoid::Document
+          store_in collection: :kronos_locks
+
+          field :task_id, type: Symbol
+          field :value, type: String
+        end
+      end
+    end
+  end
+end

data/lib/kronos/storage/mongo_db.rb

@@ -2,13 +2,16 @@
 
 require 'kronos/storage/mongo/model/scheduled_task_model'
 require 'kronos/storage/mongo/model/report_model'
+require 'kronos/storage/mongo/model/lock_model'
 
 module Kronos
   module Storage
     # :reek:UtilityFunction:
+    # :reek:TooManyMethods:
     class MongoDb
       SHEDULED_TASK_MODEL = Mongo::Model::ScheduledTaskModel
       REPORT_MODEL = Mongo::Model::ReportModel
+      LOCK_MODEL = Mongo::Model::LockModel
 
       def scheduled_tasks
         # Returns all current Kronos::ScheduledTask, resolved or pending
@@ -53,13 +56,31 @@ module Kronos
         query.exists? && query.first.next_run > Time.now
       end
 
+      def locked_task?(task_id)
+        LOCK_MODEL.where(task_id: task_id).exists?
+      end
+
+      def lock_task(task_id)
+        SecureRandom.uuid.tap do |lock_id|
+          LOCK_MODEL.create(task_id: task_id, value: lock_id)
+        end
+      end
+
+      def check_lock(task_id, lock_id)
+        LOCK_MODEL.where(task_id: task_id, value: lock_id).exists?
+      end
+
+      def release_lock(task_id)
+        LOCK_MODEL.where(task_id: task_id).destroy_all
+      end
+
       private
 
       def mount_report(report_model)
         case report_model.status
-        when 0
+        when Kronos::Report::STATUSES[:success]
           mount_success_report(report_model)
-        when 1
+        when Kronos::Report::STATUSES[:failure]
           mount_failure_report(report_model)
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kronos-ruby
 version: !ruby/object:Gem::Version
-  version: 0.2.1.alpha.9
+  version: 0.2.1.alpha.10
 platform: ruby
 authors:
 - Gabriel Teles
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-25 00:00:00.000000000 Z
+date: 2017-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -255,9 +255,11 @@ files:
 - lib/kronos/runner.rb
 - lib/kronos/runner/asynchronous.rb
 - lib/kronos/runner/synchronous.rb
+- lib/kronos/runner/synchronous/lock_manager.rb
 - lib/kronos/scheduled_task.rb
 - lib/kronos/storage.rb
 - lib/kronos/storage/in_memory.rb
+- lib/kronos/storage/mongo/model/lock_model.rb
 - lib/kronos/storage/mongo/model/report_model.rb
 - lib/kronos/storage/mongo/model/scheduled_task_model.rb
 - lib/kronos/storage/mongo_db.rb
@@ -286,7 +288,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Persistent cron jobs manager